GNU bug report logs - #11935
XINT etc. should be functions

Previous Next

Package: emacs;

Reported by: Paul Eggert <eggert <at> cs.ucla.edu>

Date: Fri, 13 Jul 2012 15:15:02 UTC

Severity: wishlist

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 11935 <at> debbugs.gnu.org
Subject: bug#11935: XINT etc. should be functions
Date: Thu, 13 Jun 2013 16:08:08 -0400

> +   the operation's implementation.  That way, OP can be implementated
                                                           ^^^^^^^^^^^^^
                                                           implemented

> +LISP_INLINE bool
> +(LISP_INT_TAG_P) (int x)
> +{
> +  return lisp_h_LISP_INT_TAG_P (x);
> +}

Can't we use something like

#define FUNCTION_OF_MACRO(fun, type_in, type_out) \
  LISP_INLINE type_out (fun) (type_in x) { return lisp_h_##fun (x); }

[ I guess it depends on whether the args to FUNCTION_OF_MACRO get
  macro-expanded before or after expanding the macro. ]

Other than that, it looks OK for me,


        Stefan
This bug report was last modified 5 years and 119 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.