GNU bug report logs - #11922
df doesn't handle \n in mount entries appropriately

Previous Next

Full log

Message #31 received at 11922-done <at> debbugs.gnu.org (full text, mbox):

From: Pádraig Brady <P <at> draigBrady.com>
To: Jim Meyering <jim <at> meyering.net>
Cc: 11922-done <at> debbugs.gnu.org, Paul Eggert <eggert <at> cs.ucla.edu>
Subject: Re: bug#11922: df doesn't handle \n in mount entries appropriately
Date: Mon, 16 Jul 2012 02:46:19 +0100

[Message part 1 (text/plain, inline)]

On 07/13/2012 04:05 PM, Pádraig Brady wrote:
> On 07/13/2012 04:03 PM, Jim Meyering wrote:
>> Pádraig Brady wrote:
>>> On 07/12/2012 05:11 PM, Pádraig Brady wrote:
> 
>>> * src/df.c (hide_problematic_chars): Replace '\n' with '\?'.
>>
>> Thanks.  That looks fine, but shouldn't the '\?' above be just '?'
> 
> oops thanks.

I adjusted a bit and now replace all control chars (< 0x20) with '?'.
They're easy to handle in all encodings and can only be problematic.
I added a test too.

I've pushed the attached, so I'm marking this done.

cheers,
Pádraig.

[df-newlines.diff (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.