GNU bug report logs - #11914
Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11914: closed (Unnecessary '#define HAVE_LIBKSTAT' in
 src/s/sol2-6.h)
Date: Wed, 11 Jul 2012 20:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 11 Jul 2012 13:41:40 -0700
with message-id <4FFDE504.9050705 <at> cs.ucla.edu>
and subject line Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
has caused the debbugs.gnu.org bug report #11914,
regarding Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11914: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11914
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
Date: Wed, 11 Jul 2012 15:14:18 -0400

Package: emacs
Version: 24.1.50
Severity: minor

(Very similar to bug#11905)

src/s/sol2-6.h does this:
    
    /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root.
       ghazi <at> caip.rutgers.edu, 7/21/97.  Don't redefine if already defined
       (e.g., by config.h). */
    #ifndef HAVE_LIBKSTAT
    #define HAVE_LIBKSTAT
    #endif

The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is
lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling
this properly via configure checks (?), so there is no need for Emacs's
src/s/sol2-6.h to define HAVE_LIBKSTAT.

[Message part 3 (message/rfc822, inline)]

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 11914-done <at> debbugs.gnu.org
Subject: Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
Date: Wed, 11 Jul 2012 13:41:40 -0700

On 07/11/2012 12:14 PM, Glenn Morris wrote:
> there is no need for Emacs's
> src/s/sol2-6.h to define HAVE_LIBKSTAT.

Yes, thanks, I made that change in trunk bzr 109034.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.