GNU bug report logs - #11914
Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h

Previous Next

Package: emacs;

Reported by: Glenn Morris <rgm <at> gnu.org>

Date: Wed, 11 Jul 2012 19:20:01 UTC

Severity: minor

Found in version 24.1.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
Date: Wed, 11 Jul 2012 15:14:18 -0400

Package: emacs
Version: 24.1.50
Severity: minor

(Very similar to bug#11905)

src/s/sol2-6.h does this:
    
    /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root.
       ghazi <at> caip.rutgers.edu, 7/21/97.  Don't redefine if already defined
       (e.g., by config.h). */
    #ifndef HAVE_LIBKSTAT
    #define HAVE_LIBKSTAT
    #endif

The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is
lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling
this properly via configure checks (?), so there is no need for Emacs's
src/s/sol2-6.h to define HAVE_LIBKSTAT.
This bug report was last modified 12 years and 313 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.