Subject: bug#11914: closed (Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 11 Jul 2012 20:48:02 +0000

Your bug report

#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
11914: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11914
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
From: Paul Eggert <[email-masked]>
To: Glenn Morris <[email-masked]>
Cc: [email-masked]
Date: Wed, 11 Jul 2012 13:41:40 -0700
List-Id: <debbugs-submit.debbugs.gnu.org>

On 07/11/2012 12:14 PM, Glenn Morris wrote:
> there is no need for Emacs's
> src/s/sol2-6.h to define HAVE_LIBKSTAT.

Yes, thanks, I made that change in trunk bzr 109034.

Subject: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h
From: Glenn Morris <[email-masked]>
To: [email-masked]
Date: Wed, 11 Jul 2012 15:14:18 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Package: emacs
Version: 24.1.50
Severity: minor

(Very similar to bug#11905)

src/s/sol2-6.h does this:
    
    /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root.
       [email-masked], 7/21/97.  Don't redefine if already defined
       (e.g., by config.h). */
    #ifndef HAVE_LIBKSTAT
    #define HAVE_LIBKSTAT
    #endif

The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is
lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling
this properly via configure checks (?), so there is no need for Emacs's
src/s/sol2-6.h to define HAVE_LIBKSTAT.