From unknown Sun Jun 15 08:52:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: eggert@cs.ucla.edu, bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Jul 2012 19:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11914 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11914@debbugs.gnu.org Cc: Paul Eggert X-Debbugs-Original-To: submit@debbugs.gnu.org X-Debbugs-Original-Xcc: Paul Eggert Received: via spool by submit@debbugs.gnu.org id=B.134203439127728 (code B ref -1); Wed, 11 Jul 2012 19:20:01 +0000 Received: (at submit) by debbugs.gnu.org; 11 Jul 2012 19:19:51 +0000 Received: from localhost ([127.0.0.1]:33894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp2Ry-0007DA-Pn for submit@debbugs.gnu.org; Wed, 11 Jul 2012 15:19:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37588) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp2Rv-0007D1-GL for submit@debbugs.gnu.org; Wed, 11 Jul 2012 15:19:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sp2Mc-0000dZ-U1; Wed, 11 Jul 2012 15:14:18 -0400 From: Glenn Morris X-Spook: Maple FBI Craig Livingstone [Hello to all my friends and X-Ran: \Cc0~bVBCN$XLGA<- User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Package: emacs Version: 24.1.50 Severity: minor (Very similar to bug#11905) src/s/sol2-6.h does this: /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root. ghazi@caip.rutgers.edu, 7/21/97. Don't redefine if already defined (e.g., by config.h). */ #ifndef HAVE_LIBKSTAT #define HAVE_LIBKSTAT #endif The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling this properly via configure checks (?), so there is no need for Emacs's src/s/sol2-6.h to define HAVE_LIBKSTAT. From unknown Sun Jun 15 08:52:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Glenn Morris Subject: bug#11914: closed (Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h) Message-ID: References: <4FFDE504.9050705@cs.ucla.edu> X-Gnu-PR-Message: they-closed 11914 X-Gnu-PR-Package: emacs Reply-To: 11914@debbugs.gnu.org Date: Wed, 11 Jul 2012 20:48:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1342039682-2974-1" This is a multi-part message in MIME format... ------------=_1342039682-2974-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11914@debbugs.gnu.org. --=20 11914: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11914 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1342039682-2974-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11914-done) by debbugs.gnu.org; 11 Jul 2012 20:47:21 +0000 Received: from localhost ([127.0.0.1]:34004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp3oe-0000l6-M5 for submit@debbugs.gnu.org; Wed, 11 Jul 2012 16:47:21 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:41500) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp3ob-0000ky-9B for 11914-done@debbugs.gnu.org; Wed, 11 Jul 2012 16:47:18 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 76E81A60001; Wed, 11 Jul 2012 13:41:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id PQQqTAFHOMoa; Wed, 11 Jul 2012 13:41:48 -0700 (PDT) Received: from [192.168.1.4] (pool-108-23-119-2.lsanca.fios.verizon.net [108.23.119.2]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 1947D39E80E0; Wed, 11 Jul 2012 13:41:48 -0700 (PDT) Message-ID: <4FFDE504.9050705@cs.ucla.edu> Date: Wed, 11 Jul 2012 13:41:40 -0700 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux i686; rv:13.0) Gecko/20120615 Thunderbird/13.0.1 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#11914: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11914-done Cc: 11914-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 07/11/2012 12:14 PM, Glenn Morris wrote: > there is no need for Emacs's > src/s/sol2-6.h to define HAVE_LIBKSTAT. Yes, thanks, I made that change in trunk bzr 109034. ------------=_1342039682-2974-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Jul 2012 19:19:51 +0000 Received: from localhost ([127.0.0.1]:33894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp2Ry-0007DA-Pn for submit@debbugs.gnu.org; Wed, 11 Jul 2012 15:19:51 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37588) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sp2Rv-0007D1-GL for submit@debbugs.gnu.org; Wed, 11 Jul 2012 15:19:48 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sp2Mc-0000dZ-U1; Wed, 11 Jul 2012 15:14:18 -0400 From: Glenn Morris To: submit@debbugs.gnu.org Subject: Unnecessary '#define HAVE_LIBKSTAT' in src/s/sol2-6.h X-Debbugs-CC: Paul Eggert X-Spook: Maple FBI Craig Livingstone [Hello to all my friends and X-Ran: \Cc0~bVBCN$XLGA<- User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Package: emacs Version: 24.1.50 Severity: minor (Very similar to bug#11905) src/s/sol2-6.h does this: /* Prefer kstat over kvm in getloadavg.c, kstat doesn't require root. ghazi@caip.rutgers.edu, 7/21/97. Don't redefine if already defined (e.g., by config.h). */ #ifndef HAVE_LIBKSTAT #define HAVE_LIBKSTAT #endif The only place in Emacs that references '#ifdef HAVE_LIBKSTAT' is lib/getloadavg.c, from Gnulib. It looks like Gnulib is already handling this properly via configure checks (?), so there is no need for Emacs's src/s/sol2-6.h to define HAVE_LIBKSTAT. ------------=_1342039682-2974-1--