From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 19:22:27 2012 Received: (at submit) by debbugs.gnu.org; 10 Jul 2012 23:22:27 +0000 Received: from localhost ([127.0.0.1]:60905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SojlD-0004Cp-C2 for submit@debbugs.gnu.org; Tue, 10 Jul 2012 19:22:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45607) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sojl9-0004Cg-HF for submit@debbugs.gnu.org; Tue, 10 Jul 2012 19:22:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sojfu-0002ID-OP for submit@debbugs.gnu.org; Tue, 10 Jul 2012 19:16:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57208) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sojfu-0002I2-J3 for submit@debbugs.gnu.org; Tue, 10 Jul 2012 19:16:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sojfs-0001G1-VS for bug-gnu-emacs@gnu.org; Tue, 10 Jul 2012 19:16:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sojfq-0002Hn-Vq for bug-gnu-emacs@gnu.org; Tue, 10 Jul 2012 19:16:56 -0400 Received: from md5i.com ([75.151.244.229]:59583 helo=maru.md5i.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sojfq-0002H1-Ka for bug-gnu-emacs@gnu.org; Tue, 10 Jul 2012 19:16:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=md5i.com; s=dkim; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=k/GEDXSPlj52G8SwZH/jSYUey0ogwA4oSRBKok41R8k=; b=uO8zuF8hUmlJBW30MrDdG2vRm6ONn2O4SMkdhOLjW3JK0scnqV6n0hFmFr/UxDttdDM0eI7zpLwyTWWdUjFhH0M6WHAfBHuzp6oGzcdGePZi5DomsisHHn1q8RR+3qpA; Received: from md5i by maru.md5i.com with local (Exim 4.80) (envelope-from ) id 1Sojfj-0000TC-Sm for bug-gnu-emacs@gnu.org; Tue, 10 Jul 2012 19:16:47 -0400 From: Michael Welsh Duggan To: bug-gnu-emacs@gnu.org Subject: 24.1.50; error byte compiling (defvar :foo ':foo), regression from 23.4 Date: Tue, 10 Jul 2012 19:16:47 -0400 Message-ID: <87liirw6jk.fsf@maru.md5i.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Create a new directory and within this directory create the following two files: File foo.el: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline; filename=foo.el Content-Transfer-Encoding: quoted-printable (defvar :foo ':foo) (provide 'foo) --=-=-= Content-Type: text/plain File bar.el: --=-=-= Content-Type: application/emacs-lisp Content-Disposition: inline; filename=bar.el Content-Transfer-Encoding: quoted-printable (require 'foo) --=-=-= Content-Type: text/plain >From within that directory, run the following command: emacs --no-site-file --no-init-file --batch --eval='(setq load-path (cons "." load-path) )' -f batch-byte-compile *.el Then, again run the same command: emacs --no-site-file --no-init-file --batch --eval='(setq load-path (cons "." load-path) )' -f batch-byte-compile *.el This first time around, both files complain without error. The second time I get the following error: In toplevel form: bar.el:1:1:Error: Constant symbol `:foo' specified in defvar Wrote /tmp/baz/foo.elc I have verified that this is a regression from emacs 23.4. In GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, X toolkit) of 2012-07-09 on maru Bzr revision: 108966 rgm@gnu.org-20120709101737-t80gis1iw52odbif Windowing system distributor `The X.Org Foundation', version 11.0.11201902 Configured using: `configure '--without-gconf' '--without-gsettings' '--without-toolkit-scroll-bars' '--with-x-toolkit=lucid' 'CFLAGS=-O0 -ggdb' '--enable-asserts' '--with-wide-int' '--enable-maintainer-mode'' Important settings: value of $LANG: en_US.utf8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t -- Michael Welsh Duggan (md5i@md5i.com) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 11 03:44:31 2012 Received: (at 11904) by debbugs.gnu.org; 11 Jul 2012 07:44:31 +0000 Received: from localhost ([127.0.0.1]:33013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sorb5-0007H1-3V for submit@debbugs.gnu.org; Wed, 11 Jul 2012 03:44:31 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:49886) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sorb2-0007Gs-Tm for 11904@debbugs.gnu.org; Wed, 11 Jul 2012 03:44:30 -0400 Received: from frontend4.mail.m-online.net (unknown [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3WXBy51pwzz4KKH2; Wed, 11 Jul 2012 09:39:37 +0200 (CEST) Received: from igel.home (ppp-93-104-136-236.dynamic.mnet-online.de [93.104.136.236]) by mail.mnet-online.de (Postfix) with ESMTPA id 3WXBwV0n4CzbbtQ; Wed, 11 Jul 2012 09:38:34 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 8B8BACA2A4; Wed, 11 Jul 2012 09:38:33 +0200 (CEST) From: Andreas Schwab To: Michael Welsh Duggan Subject: Re: bug#11904: 24.1.50; error byte compiling (defvar :foo ':foo), regression from 23.4 References: <87liirw6jk.fsf@maru.md5i.com> X-Yow: Am I elected yet? Date: Wed, 11 Jul 2012 09:38:33 +0200 In-Reply-To: <87liirw6jk.fsf@maru.md5i.com> (Michael Welsh Duggan's message of "Tue, 10 Jul 2012 19:16:47 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11904 Cc: 11904@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) That's because (defvar :foo ':foo) is written as (defvar :foo :foo) in the elc file, which defvar doesn't allow. byte-compile-file-form-defvar no longer calls byte-compile-form via byte-compile-keep-pending which would handle it correctly (and emit a warning). When adding a doc string the bug also happens in emacs < 24. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 12 09:48:55 2012 Received: (at 11904) by debbugs.gnu.org; 12 Jul 2012 13:48:55 +0000 Received: from localhost ([127.0.0.1]:35629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpJlH-0003VW-At for submit@debbugs.gnu.org; Thu, 12 Jul 2012 09:48:55 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:59561) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpJlF-0003VO-Nx for 11904@debbugs.gnu.org; Thu, 12 Jul 2012 09:48:54 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6CDhJeY018040; Thu, 12 Jul 2012 09:43:19 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 2EB76AE3BA; Thu, 12 Jul 2012 09:43:18 -0400 (EDT) From: Stefan Monnier To: Michael Welsh Duggan Subject: Re: bug#11904: 24.1.50; error byte compiling (defvar :foo ':foo), regression from 23.4 Message-ID: References: <87liirw6jk.fsf@maru.md5i.com> Date: Thu, 12 Jul 2012 09:43:18 -0400 In-Reply-To: <87liirw6jk.fsf@maru.md5i.com> (Michael Welsh Duggan's message of "Tue, 10 Jul 2012 19:16:47 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4276=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4276> : streams <783339> : uri <1163388> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 11904 Cc: 11904@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > (defvar :foo ':foo) I'm curious: where did you find such code? Such code used to be added "implicitly" back in Emacs-19 days because Emacs-19 did not have keywords. Some packages kept such code a bit longer in the hope that the resulting code would still work under Emacs-19, but nowadays this seems very outdated. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 12 09:57:54 2012 Received: (at 11904) by debbugs.gnu.org; 12 Jul 2012 13:57:54 +0000 Received: from localhost ([127.0.0.1]:35987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpJtv-0003ly-Jz for submit@debbugs.gnu.org; Thu, 12 Jul 2012 09:57:53 -0400 Received: from euclid.red.cert.org ([192.88.209.48]:57690) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpJts-0003lp-Et for 11904@debbugs.gnu.org; Thu, 12 Jul 2012 09:57:50 -0400 Received: from bucknell.indigo.cert.org (bucknell.indigo.cert.org [10.60.10.121]) by euclid.red.cert.org (8.14.4/8.14.4) with ESMTP id q6CDkhIH024565; Thu, 12 Jul 2012 09:46:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cert.org; s=jthatj15xw2j; t=1342100803; bh=oWgUPGvyHDHhLZw3hB536p3Em3/DOZrEOG+Bk9hhDXM=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type:Sender:Reply-To; b=BywMerOCX4l06ollJ4+gELFd25m+/UPGDeRELICEsM+4uOAtB6ybNGejzqCV1fzEm n0xBSOniVnaclJt0rhUajKYOARFpTdM4HhFm+pEFCWIoc13Uopbo2UfAzP4DUpEUb7 jkdsV614l4Fg04wAFmkFvohjh/d21xg1Q10AyV3w= Received: from waterbuck.yellow.cert.org (waterbuck.yellow.cert.org [10.20.128.84]) by bucknell.indigo.cert.org (8.14.4/8.14.4/2.81) with ESMTP id q6CDqFRp000769; Thu, 12 Jul 2012 09:52:15 -0400 Received: (from mwd@localhost) by waterbuck.yellow.cert.org (8.14.4/8.14.4/Submit/1.6) id q6CDqFYJ006404; Thu, 12 Jul 2012 09:52:15 -0400 X-Authentication-Warning: waterbuck.yellow.cert.org: mwd set sender to mwd@cert.org using -f From: Michael Welsh Duggan To: Stefan Monnier Subject: Re: bug#11904: 24.1.50; error byte compiling (defvar :foo ':foo), regression from 23.4 References: <87liirw6jk.fsf@maru.md5i.com> Date: Thu, 12 Jul 2012 09:52:15 -0400 In-Reply-To: (Stefan Monnier's message of "Thu, 12 Jul 2012 09:43:18 -0400") Message-ID: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11904 Cc: Michael Welsh Duggan , 11904@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Stefan Monnier writes: >> (defvar :foo ':foo) > > I'm curious: where did you find such code? > Such code used to be added "implicitly" back in Emacs-19 days because > Emacs-19 did not have keywords. Some packages kept such code a bit > longer in the hope that the resulting code would still work under > Emacs-19, but nowadays this seems very outdated. sml-mode package from Debian unstable. -- Michael Welsh Duggan (mwd@cert.org) From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 11:27:45 2012 Received: (at 11904) by debbugs.gnu.org; 18 Jul 2012 15:27:45 +0000 Received: from localhost ([127.0.0.1]:48677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrWAB-0007aW-LK for submit@debbugs.gnu.org; Wed, 18 Jul 2012 11:27:45 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34476) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrWA8-0007aN-AC for 11904@debbugs.gnu.org; Wed, 18 Jul 2012 11:27:41 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6IFLH5G028460; Wed, 18 Jul 2012 11:21:18 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id E1E47AECB1; Wed, 18 Jul 2012 11:21:15 -0400 (EDT) From: Stefan Monnier To: Michael Welsh Duggan Subject: Re: bug#11904: 24.1.50; error byte compiling (defvar :foo ':foo), regression from 23.4 Message-ID: References: <87liirw6jk.fsf@maru.md5i.com> Date: Wed, 18 Jul 2012 11:21:15 -0400 In-Reply-To: (Michael Welsh Duggan's message of "Thu, 12 Jul 2012 09:52:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4283=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4283> : streams <786735> : uri <1168550> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 11904 Cc: Michael Welsh Duggan , 11904@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >>> (defvar :foo ':foo) >> I'm curious: where did you find such code? >> Such code used to be added "implicitly" back in Emacs-19 days because >> Emacs-19 did not have keywords. Some packages kept such code a bit >> longer in the hope that the resulting code would still work under >> Emacs-19, but nowadays this seems very outdated. > sml-mode package from Debian unstable. Duh! I guess it's time to re-label the 5.0beta1 into 5.0, where sml-compat.el has been removed (it only provided compatibility for ancient Emacsen)... OK, done! This said, I installed the patch below which simply removes the "defvar of a constant" check. Stefan === modified file 'src/ChangeLog' --- src/ChangeLog 2012-07-18 13:20:59 +0000 +++ src/ChangeLog 2012-07-18 15:19:50 +0000 @@ -1,5 +1,8 @@ 2012-07-18 Stefan Monnier + * eval.c (Fdefvar): Don't check constants since we only set the var if + it's not yet defined anyway (bug#11904). + * lisp.h (last_undo_boundary): Declare new var. * keyboard.c (command_loop_1): Set it. * cmds.c (Fself_insert_command): Use it to only remove boundaries that === modified file 'src/eval.c' --- src/eval.c 2012-07-10 16:53:26 +0000 +++ src/eval.c 2012-07-18 15:18:14 +0000 @@ -691,18 +691,6 @@ /* Do it before evaluating the initial value, for self-references. */ XSYMBOL (sym)->declared_special = 1; - if (SYMBOL_CONSTANT_P (sym)) - { - /* For upward compatibility, allow (defvar :foo (quote :foo)). */ - Lisp_Object tem1 = Fcar (tail); - if (! (CONSP (tem1) - && EQ (XCAR (tem1), Qquote) - && CONSP (XCDR (tem1)) - && EQ (XCAR (XCDR (tem1)), sym))) - error ("Constant symbol `%s' specified in defvar", - SDATA (SYMBOL_NAME (sym))); - } - if (NILP (tem)) Fset_default (sym, eval_sub (Fcar (tail))); else From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 19 04:18:14 2012 Received: (at control) by debbugs.gnu.org; 19 Jul 2012 08:18:14 +0000 Received: from localhost ([127.0.0.1]:49488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Srlw6-0002JL-GX for submit@debbugs.gnu.org; Thu, 19 Jul 2012 04:18:14 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:59463) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Srlw5-0002JB-1U for control@debbugs.gnu.org; Thu, 19 Jul 2012 04:18:13 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6J89mXs008964 for ; Thu, 19 Jul 2012 04:11:34 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6BB9FAECBE; Thu, 19 Jul 2012 04:08:50 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#11904: 24.1.50; error byte compiling (defvar :foo ':foo), regression from 23.4 Message-ID: References: <87liirw6jk.fsf@maru.md5i.com> Date: Thu, 19 Jul 2012 04:08:50 -0400 In-Reply-To: (Stefan Monnier's message of "Wed, 18 Jul 2012 11:21:15 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: * X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 1.3 X-NAI-Spam-Rules: 4 Rules triggered TO_2SPC_W_GEN_SPAM_FEATRE=1, GEN_SPAM_FEATRE=0.2, TO_2SPC=0.1, RV4283=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4283> : streams <787092> : uri <1169141> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) close 11904 thanks From unknown Sat Jun 14 19:02:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Aug 2012 11:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator