From unknown Mon Aug 18 19:30:06 2025 X-Loop: don@donarmstrong.com Subject: bug#1190: patch - fix crash in ftfont rendering Reply-To: Kenichi Handa , 1190@debbugs.gnu.org Resent-From: Kenichi Handa Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 17 Oct 2008 01:45:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1190 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122420758027123 (code B ref -1); Fri, 17 Oct 2008 01:45:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-6.0 required=4.0 tests=AWL,BAYES_00,IMPRONONCABLE_1, MURPHY_DRUGS_REL8,MURPHY_WRONG_WORD2,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Oct 2008 01:39:40 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9H1dZDS027117 for ; Thu, 16 Oct 2008 18:39:37 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqeJS-0001xk-Ro for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2008 21:39:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqeJR-0001xY-Th for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2008 21:39:34 -0400 Received: from [199.232.76.173] (port=49184 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqeJR-0001xV-OC for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2008 21:39:33 -0400 Received: from mx1.aist.go.jp ([150.29.246.133]:41774) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KqeJR-0002B6-1j for bug-gnu-emacs@gnu.org; Thu, 16 Oct 2008 21:39:33 -0400 Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id m9H1dFNF024159; Fri, 17 Oct 2008 10:39:15 +0900 (JST) env-from (handa@m17n.org) Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id m9H1dFYH016951; Fri, 17 Oct 2008 10:39:15 +0900 (JST) env-from (handa@m17n.org) Received: by smtp3.aist.go.jp with ESMTP id m9H1dDWL016730; Fri, 17 Oct 2008 10:39:13 +0900 (JST) env-from (handa@m17n.org) Received: from handa by etlken.m17n.org with local (Exim 4.69) (envelope-from ) id 1KqeJ7-0002ZG-SF; Fri, 17 Oct 2008 10:39:13 +0900 From: Kenichi Handa To: klchxbec@freenet.de CC: bug-gnu-emacs@gnu.org In-reply-to: (klchxbec@freenet.de) References: User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/23.0.60 (i686-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII Message-Id: Date: Fri, 17 Oct 2008 10:39:13 +0900 X-detected-operating-system: by monty-python.gnu.org: Solaris 9 I'm very sorry for the late response. In article , klchxbec@freenet.de writes: > This is a fix for a crash in otf font rendering. Emacs crashed for me when gsub_gpos->FeatureList.FeatureCount > was zero and otf_langsys->FeatureCount was 2377. [...] > - for (features = Qnil, k = otf_langsys->FeatureCount - 1; k >= 0; k--) > + for (features = Qnil, k = gsub_gpos->FeatureList.FeatureCount - 1; k >= 0; k--) As this part is collecting features for a specific language, the above change is not good. I'll fix the code so that invalid otf_langsys->FeatureCount doesn't lead to crash. Could you tell me which font causes this problem? --- Kenichi Handa handa@ni.aist.go.jp