From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 07:49:39 2012 Received: (at submit) by debbugs.gnu.org; 10 Jul 2012 11:49:39 +0000 Received: from localhost ([127.0.0.1]:59559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SoYwl-0001t2-EL for submit@debbugs.gnu.org; Tue, 10 Jul 2012 07:49:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60189) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SoYwj-0001su-Fp for submit@debbugs.gnu.org; Tue, 10 Jul 2012 07:49:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoYrX-0001fm-JI for submit@debbugs.gnu.org; Tue, 10 Jul 2012 07:44:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:45016) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoYrX-0001fg-FK for submit@debbugs.gnu.org; Tue, 10 Jul 2012 07:44:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoYrV-0002SW-Ig for bug-automake@gnu.org; Tue, 10 Jul 2012 07:44:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SoYrR-0001e0-1v for bug-automake@gnu.org; Tue, 10 Jul 2012 07:44:12 -0400 Received: from wp256.webpack.hosteurope.de ([80.237.133.25]:36065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SoYrQ-0001di-Rg for bug-automake@gnu.org; Tue, 10 Jul 2012 07:44:08 -0400 Received: from dhcp181.math.nat.tu-bs.de ([134.169.53.181]); authenticated by wp256.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) id 1SoYrP-0006Ms-32; Tue, 10 Jul 2012 13:44:07 +0200 From: Max Horn Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: automake 1.12.2 test failure on Mac OS X 10.7 Date: Tue, 10 Jul 2012 13:44:06 +0200 Message-Id: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> To: bug-automake@gnu.org Mime-Version: 1.0 (Apple Message framework v1280) X-Mailer: Apple Mail (2.1280) X-bounce-key: webpack.hosteurope.de;max@quendi.de;1341920648;3b907b3b; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Hi there, here is another test failure I am seeing on Mac OS X 10.7.4 with = automake 1.12.2. Specifically, two tap test fail with errors. So when I = execute make check TESTS=3D"t/suffix8.tap t/suffix10.tap" then I get this (after removing some fluff): PASS: t/suffix8.tap 1 - libtoolize PASS: t/suffix8.tap 2 - aclocal PASS: t/suffix8.tap 3 - autoconf PASS: t/suffix8.tap 4 - automake PASS: t/suffix8.tap 5 ERROR: t/suffix8.tap 5 - configure # OUT-OF-ORDER (expecting 6) ERROR: t/suffix8.tap 6 - make test0 # OUT-OF-ORDER (expecting 7) ERROR: t/suffix8.tap 7 - make test1 # OUT-OF-ORDER (expecting 8) ERROR: t/suffix8.tap 8 - make test2 # OUT-OF-ORDER (expecting 9) ERROR: t/suffix8.tap 9 - make all # OUT-OF-ORDER (expecting 10) ERROR: t/suffix8.tap 11 # UNPLANNED ERROR: t/suffix8.tap 10 - make distcheck # UNPLANNED ERROR: t/suffix8.tap - too many tests run (expected 10, got 12) PASS: t/suffix10.tap 1 - libtoolize PASS: t/suffix10.tap 2 - aclocal PASS: t/suffix10.tap 3 - autoconf PASS: t/suffix10.tap 4 - automake PASS: t/suffix10.tap 5 ERROR: t/suffix10.tap 5 - configure # OUT-OF-ORDER (expecting 6) ERROR: t/suffix10.tap 6 - make test # OUT-OF-ORDER (expecting 7) ERROR: t/suffix10.tap 7 - make all # UNPLANNED ERROR: t/suffix10.tap - too many tests run (expected 7, got 8) I think the problem is caused by the "configure" script spitting out = these messages: checking for archiver @FILE support... rm: cannot remove = `conftest.dSYM': Is a directory no checking for strip... strip checking for ranlib... ranlib checking command to parse /usr/bin/nm output from cc object... rm: = cannot remove `conftest.dSYM': Is a directory ok Note the isolated "ok" on a line of its own; apparently this makes the = test think that an unplanned test step occurred. This in turn is caused by a "bug" in libtool -- or rather, there is a = peculiar behavior of the Mac OS X compilers (namely to create = conftest.dSYM directories under certain circumstances), and libtool = hence needs to replace "rm -f conftest*" by "rm -rf conftest*". This was = done some years ago, but apparently was forgotten in three cases. I already reported this to libtool: = But since it directly affects the test suite of automake, I thought it = best to report this here, too. Perhaps you would like to workaround it = by making the test a bit more strict about how it detects a completed = test step? Cheers, Max From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 09:37:19 2012 Received: (at 11897) by debbugs.gnu.org; 10 Jul 2012 13:37:19 +0000 Received: from localhost ([127.0.0.1]:59708 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Soacw-0004Kq-FK for submit@debbugs.gnu.org; Tue, 10 Jul 2012 09:37:19 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:51180) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Soacs-0004Kc-7K; Tue, 10 Jul 2012 09:37:16 -0400 Received: by bkty7 with SMTP id y7so3498531bkt.3 for ; Tue, 10 Jul 2012 06:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=hIW/gaKkTrMoGtRbwB4ARBGB0qbBNLKe9vNLN+r8a7Q=; b=e7SH07hcRBGS6C+Eoi0eNZg1x5//DxWcfeoiUWkX/sItErYrqUJpjtJAITTQi88vKi b5RqhpjvNzO4ZK0zNYE0FPbGc4OR5niJtstnMQB4EPBuxqdt8hiG+HXiHYbxfw61EDlW k8A/xZdZ1g2jr4uNtWDXrDlq8Phouq6yDb+VQNgDKtEvl8sKopczbA+AQ/o06jEIrm/x C0pZD9Tj+J7YbVEc5GnugbmkwSoe3mMMEtpXysu/OAAL6fZWHssg5bzuHoRnzVpiW2cN Rn7ulY/0A5X4yZrZ9p77T9QKyz4OqdBLfLhkTfagbBXXyLm1hlahWDVICQbQlzB7J1N7 YZMw== Received: by 10.204.157.18 with SMTP id z18mr21239165bkw.16.1341927112561; Tue, 10 Jul 2012 06:31:52 -0700 (PDT) Received: from [87.2.97.124] (host124-97-dynamic.2-87-r.retail.telecomitalia.it. [87.2.97.124]) by mx.google.com with ESMTPS id t23sm20550560bks.4.2012.07.10.06.31.50 (version=SSLv3 cipher=OTHER); Tue, 10 Jul 2012 06:31:51 -0700 (PDT) Message-ID: <4FFC2EC3.4020507@gmail.com> Date: Tue, 10 Jul 2012 15:31:47 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Max Horn Subject: Re: bug#11897: automake 1.12.2 test failure on Mac OS X 10.7 References: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> In-Reply-To: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> Content-Type: multipart/mixed; boundary="------------050401050202020200090501" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11897 Cc: 11897@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------050401050202020200090501 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit tags 11897 + patch severity 11897 minor thanks On 07/10/2012 01:44 PM, Max Horn wrote: > Hi there, > Hi Max, thanks for the report. > here is another test failure I am seeing on Mac OS X 10.7.4 with > automake 1.12.2. Specifically, two tap test fail with errors. > So when I execute > > make check TESTS="t/suffix8.tap t/suffix10.tap" > > then I get this (after removing some fluff): > > > PASS: t/suffix8.tap 1 - libtoolize > PASS: t/suffix8.tap 2 - aclocal > PASS: t/suffix8.tap 3 - autoconf > PASS: t/suffix8.tap 4 - automake > PASS: t/suffix8.tap 5 > ERROR: t/suffix8.tap 5 - configure # OUT-OF-ORDER (expecting 6) > ERROR: t/suffix8.tap 6 - make test0 # OUT-OF-ORDER (expecting 7) > ERROR: t/suffix8.tap 7 - make test1 # OUT-OF-ORDER (expecting 8) > ERROR: t/suffix8.tap 8 - make test2 # OUT-OF-ORDER (expecting 9) > ERROR: t/suffix8.tap 9 - make all # OUT-OF-ORDER (expecting 10) > ERROR: t/suffix8.tap 11 # UNPLANNED > ERROR: t/suffix8.tap 10 - make distcheck # UNPLANNED > ERROR: t/suffix8.tap - too many tests run (expected 10, got 12) > PASS: t/suffix10.tap 1 - libtoolize > PASS: t/suffix10.tap 2 - aclocal > PASS: t/suffix10.tap 3 - autoconf > PASS: t/suffix10.tap 4 - automake > PASS: t/suffix10.tap 5 > ERROR: t/suffix10.tap 5 - configure # OUT-OF-ORDER (expecting 6) > ERROR: t/suffix10.tap 6 - make test # OUT-OF-ORDER (expecting 7) > ERROR: t/suffix10.tap 7 - make all # UNPLANNED > ERROR: t/suffix10.tap - too many tests run (expected 7, got 8) > > > I think the problem is caused by the "configure" script spitting > out these messages: > > checking for archiver @FILE support... rm: cannot remove `conftest.dSYM': Is a directory > no > checking for strip... strip > checking for ranlib... ranlib > checking command to parse /usr/bin/nm output from cc object... rm: cannot remove `conftest.dSYM': Is a directory > ok > > Note the isolated "ok" on a line of its own; apparently this > makes the test think that an unplanned test step occurred. > Your interpretation is absolutely correct. The attached patch should take care of the issue. Could you give it a try? > This in turn is caused by a "bug" in libtool -- or rather, there is > a peculiar behavior of the Mac OS X compilers (namely to create > conftest.dSYM directories under certain circumstances), and libtool > hence needs to replace "rm -f conftest*" by "rm -rf conftest*". This > was done some years ago, but apparently was forgotten in three cases. > > I already reported this to libtool: > > > But since it directly affects the test suite of automake, I thought > it best to report this here, too. > Well done. This is a spurious failure that shouldn't interfere with our test results. > Perhaps you would like to workaround it by making the test a bit > more strict about how it detects a completed test step? > This is not possible; the '*.tap' tests in the Automake testsuite use the TAP protocol, and that mandates which output lines must be interpreted as declaration of test results. I think the workaround implemented in the attached patch is the simplest and best fix. Thanks, Stefano --------------050401050202020200090501 Content-Type: text/x-diff; name="0001-tests-avoid-spurious-TAP-errors-on-Mac-OS-X-10.7.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-tests-avoid-spurious-TAP-errors-on-Mac-OS-X-10.7.patch" >From f2c18ffe38212751434b246d84c245e16c4dfd3d Mon Sep 17 00:00:00 2001 Message-Id: From: Stefano Lattarini Date: Tue, 10 Jul 2012 15:29:57 +0200 Subject: [PATCH] tests: avoid spurious TAP errors on Mac OS X 10.7 Fixes automake bug#1897. Reported by Max Horn. * t/suffix8.tap: The libtool bug#11895 was causing the ./configure script to output a stray "ok" string on a line of its own, confusing the TAP driver into thinking this was an extra test result (which resulted in the next, real test results being flagged as "OUT-OF-ORDER"). Fix this by protecting configure output. * t/suffix10.tap: Likewise. * THANKS: Update. Signed-off-by: Stefano Lattarini --- THANKS | 1 + t/suffix10.tap | 13 ++++++++++++- t/suffix8.tap | 14 +++++++++++++- 3 files changed, 26 insertions(+), 2 deletions(-) diff --git a/THANKS b/THANKS index 01b78c1..afdd33a 100644 --- a/THANKS +++ b/THANKS @@ -245,6 +245,7 @@ Matthew D. Langston langston@SLAC.Stanford.EDU Matthias Andree matthias.andree@gmx.de Matthias Clasen clasen@mathematik.uni-freiburg.de Matthias Klose doko@ubuntu.com +Max Horn max@quendi.de Maxim Sinev good@goods.ru Maynard Johnson maynardj@us.ibm.com Merijn de Jonge M.de.Jonge@cwi.nl diff --git a/t/suffix10.tap b/t/suffix10.tap index a650924..7e19e04 100755 --- a/t/suffix10.tap +++ b/t/suffix10.tap @@ -57,11 +57,22 @@ cat > foo.x_ << 'END' int foo (void) { return yyparse(); } END +# We must protect the TAP driver from the output of configure, since +# that might output a stray "ok" on a line of its own (due to a +# libtool bug on Mac OS X), thus causing a spurious test result to +# be seen. See automake bug#11897. +run_configure () +{ + st=0; ./configure >output 2>&1 || st=1 + sed 's/^/ /' output + test $st -eq 0 +} + command_ok_ "libtoolize" libtoolize --force command_ok_ "aclocal" $ACLOCAL command_ok_ "autoconf" $AUTOCONF command_ok_ "automake" $AUTOMAKE --add-missing -command_ok_ "configure" ./configure +command_ok_ "configure" run_configure command_ok_ "make test" $MAKE test directive=''; make_can_chain_suffix_rules || directive=TODO diff --git a/t/suffix8.tap b/t/suffix8.tap index fdaf087..87d6530 100755 --- a/t/suffix8.tap +++ b/t/suffix8.tap @@ -75,11 +75,23 @@ END echo 'int main (void) { return 0; }' > foo.x_ echo 'int bar (void) { return 0; }' > bar.x_ + +# We must protect the TAP driver from the output of configure, since +# that might output a stray "ok" on a line of its own (due to a +# libtool bug on Mac OS X), thus causing a spurious test result to +# be seen. See automake bug#11897. +run_configure () +{ + st=0; ./configure >output 2>&1 || st=1 + sed 's/^/ /' output + test $st -eq 0 +} + command_ok_ "libtoolize" libtoolize command_ok_ "aclocal" $ACLOCAL command_ok_ "autoconf" $AUTOCONF command_ok_ "automake" $AUTOMAKE -a -command_ok_ "configure" ./configure +command_ok_ "configure" run_configure command_ok_ "make test0" env OBJEXT=foo $MAKE -e test0 command_ok_ "make test1" $MAKE test1 -- 1.7.9.5 --------------050401050202020200090501-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 10:12:09 2012 Received: (at 11897) by debbugs.gnu.org; 10 Jul 2012 14:12:09 +0000 Received: from localhost ([127.0.0.1]:60112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SobAe-00062B-Qs for submit@debbugs.gnu.org; Tue, 10 Jul 2012 10:12:09 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:46069) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SobAb-000622-SU for 11897@debbugs.gnu.org; Tue, 10 Jul 2012 10:12:07 -0400 Received: by bkty7 with SMTP id y7so9964bkt.3 for <11897@debbugs.gnu.org>; Tue, 10 Jul 2012 07:06:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=+o++GnOdL/EKvu3gtf4oN6NV4Rhbo7JuW3unEMKQrKw=; b=x9qGpKa/b00SlKxtzZEY3XTc5W7DOcvdYACLMiloF2UP0zIqE1EwkAekNnqn7A7+BV QAMwHS7C8i5XG5fmgBILEQKpDA0gFFncyQea+dXvhiHEMFbrE3nx3EjpUvBuSO31KjL6 yqCt2dc+yW5jPucbiAJbOsBD2we9WWLGwsKRLa1czrvMO6TlCIZgUAjB6SJmN6cx8Y9q GpznJwllIgcPsU/giS+SwRy3eGBesLSLlzI5Amh4wWSKs/xgb2OwJdA7DIVj6SFtNaBR Wps+8so62Jzgzsgi7gYUSt2VXDWnRu3yhzOycsxQsI8YZWtdDH1enOO3DyL9WyiPWwwQ cHNA== Received: by 10.205.125.4 with SMTP id gq4mr9631687bkc.109.1341929202884; Tue, 10 Jul 2012 07:06:42 -0700 (PDT) Received: from [87.2.97.124] (host124-97-dynamic.2-87-r.retail.telecomitalia.it. [87.2.97.124]) by mx.google.com with ESMTPS id he8sm6831028bkc.3.2012.07.10.07.06.40 (version=SSLv3 cipher=OTHER); Tue, 10 Jul 2012 07:06:41 -0700 (PDT) Message-ID: <4FFC36ED.2090602@gmail.com> Date: Tue, 10 Jul 2012 16:06:37 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Max Horn Subject: Re: bug#11897: automake 1.12.2 test failure on Mac OS X 10.7 References: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> <4FFC2EC3.4020507@gmail.com> <8F5E210B-F0CA-4705-BA34-B2BC4DB3E366@quendi.de> In-Reply-To: <8F5E210B-F0CA-4705-BA34-B2BC4DB3E366@quendi.de> Content-Type: multipart/mixed; boundary="------------090901020905000503000700" X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11897 Cc: 11897@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------090901020905000503000700 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 07/10/2012 03:56 PM, Max Horn wrote: > > This fixes most of the errors, except for > > PASS: t/suffix8.tap 10 > ERROR: t/suffix8.tap 10 - make distcheck # UNPLANNED > ERROR: t/suffix8.tap - too many tests run (expected 10, got 11) > > I looked at the log, this is again the same issue, configure > is run once again > Of course, by "make distcheck"! *faceplam* I should have been more careful. > and once again suffers from the same problem. > Does the attached patch fares better? Thanks, Stefano --------------090901020905000503000700 Content-Type: text/x-diff; name="0001-tests-avoid-spurious-TAP-errors-on-Mac-OS-X-10.7.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-tests-avoid-spurious-TAP-errors-on-Mac-OS-X-10.7.patch" >From 65e7ac8c3556d1895ee597811856710143cfc4ac Mon Sep 17 00:00:00 2001 Message-Id: <65e7ac8c3556d1895ee597811856710143cfc4ac.1341929183.git.stefano.lattarini@gmail.com> From: Stefano Lattarini Date: Tue, 10 Jul 2012 15:29:57 +0200 Subject: [PATCH] tests: avoid spurious TAP errors on Mac OS X 10.7 Fixes automake bug#1897. Reported by Max Horn. * t/suffix8.tap: The libtool bug#11895 was causing the ./configure script to output a stray "ok" string on a line of its own, confusing the TAP driver into thinking this was an extra test result (which resulted in the next, real test results being flagged as "OUT-OF-ORDER"). Fix this by protecting configure output. * t/suffix10.tap: Likewise, and for the "make distcheck" output as well. * THANKS: Update. Signed-off-by: Stefano Lattarini --- THANKS | 1 + t/suffix10.tap | 13 ++++++++++++- t/suffix8.tap | 15 +++++++++++++-- 3 files changed, 26 insertions(+), 3 deletions(-) diff --git a/THANKS b/THANKS index 01b78c1..afdd33a 100644 --- a/THANKS +++ b/THANKS @@ -245,6 +245,7 @@ Matthew D. Langston langston@SLAC.Stanford.EDU Matthias Andree matthias.andree@gmx.de Matthias Clasen clasen@mathematik.uni-freiburg.de Matthias Klose doko@ubuntu.com +Max Horn max@quendi.de Maxim Sinev good@goods.ru Maynard Johnson maynardj@us.ibm.com Merijn de Jonge M.de.Jonge@cwi.nl diff --git a/t/suffix10.tap b/t/suffix10.tap index a650924..7e19e04 100755 --- a/t/suffix10.tap +++ b/t/suffix10.tap @@ -57,11 +57,22 @@ cat > foo.x_ << 'END' int foo (void) { return yyparse(); } END +# We must protect the TAP driver from the output of configure, since +# that might output a stray "ok" on a line of its own (due to a +# libtool bug on Mac OS X), thus causing a spurious test result to +# be seen. See automake bug#11897. +run_configure () +{ + st=0; ./configure >output 2>&1 || st=1 + sed 's/^/ /' output + test $st -eq 0 +} + command_ok_ "libtoolize" libtoolize --force command_ok_ "aclocal" $ACLOCAL command_ok_ "autoconf" $AUTOCONF command_ok_ "automake" $AUTOMAKE --add-missing -command_ok_ "configure" ./configure +command_ok_ "configure" run_configure command_ok_ "make test" $MAKE test directive=''; make_can_chain_suffix_rules || directive=TODO diff --git a/t/suffix8.tap b/t/suffix8.tap index fdaf087..516c9b2 100755 --- a/t/suffix8.tap +++ b/t/suffix8.tap @@ -75,11 +75,22 @@ END echo 'int main (void) { return 0; }' > foo.x_ echo 'int bar (void) { return 0; }' > bar.x_ +# We must protect the TAP driver from the output of configure, since +# that might output a stray "ok" on a line of its own (due to a +# libtool bug on Mac OS X), thus causing a spurious test result to +# be seen. See automake bug#11897. +protect_output () +{ + st=0; "$@" >output 2>&1 || st=1 + sed 's/^/ /' output + test $st -eq 0 +} + command_ok_ "libtoolize" libtoolize command_ok_ "aclocal" $ACLOCAL command_ok_ "autoconf" $AUTOCONF command_ok_ "automake" $AUTOMAKE -a -command_ok_ "configure" ./configure +command_ok_ "configure" protect_output ./configure command_ok_ "make test0" env OBJEXT=foo $MAKE -e test0 command_ok_ "make test1" $MAKE test1 @@ -88,7 +99,7 @@ directive=''; make_can_chain_suffix_rules || directive=TODO for target in test2 all distcheck; do command_ok_ "make $target" \ -D "$directive" -r "suffix rules not chained" \ - $MAKE $target + protect_output $MAKE $target done : -- 1.7.9.5 --------------090901020905000503000700-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 10:38:16 2012 Received: (at 11897-done) by debbugs.gnu.org; 10 Jul 2012 14:38:16 +0000 Received: from localhost ([127.0.0.1]:60180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SobZv-0006dO-8o for submit@debbugs.gnu.org; Tue, 10 Jul 2012 10:38:16 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:46979) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SobZt-0006dF-2M for 11897-done@debbugs.gnu.org; Tue, 10 Jul 2012 10:38:14 -0400 Received: by bkty7 with SMTP id y7so38789bkt.3 for <11897-done@debbugs.gnu.org>; Tue, 10 Jul 2012 07:32:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=v2w/RxCeyzmGwfiOE2gc1sRDksqVhiBchO43HIcqSak=; b=lAOOcChlVKTam+/MuMhBwexFnBrBZ+tOFBDmmnqSwvEoTzc0gvVLZ2IAW6r1P0+Idv qx1gMBF8PcnVlofP7GyvNYFdoxLUD2tDSe7woJp5bzxNMhhoqFzddFbEAoLbBFMewMVV ThZoWeb7k2kRZ39g/XFAf0aKIwWArvmdlMNUdwkA/2DEh4CgaquG70fajnnq9Px9W6mo S4hWY+AcuxaQifwehv9qcINZkdL0wBmZzytUcvRCc9QgrB6d7moBXcu+Py/fJ+dx+78M 9m4qBxZVYyMGXFq+1XBTnONo1loV8doanQSAlweCBSeQ6fcOJA5XChXffjvJ972/iz5J Dpfg== Received: by 10.205.123.10 with SMTP id gi10mr22571417bkc.9.1341930771048; Tue, 10 Jul 2012 07:32:51 -0700 (PDT) Received: from [87.2.97.124] (host124-97-dynamic.2-87-r.retail.telecomitalia.it. [87.2.97.124]) by mx.google.com with ESMTPS id hg13sm28399756bkc.7.2012.07.10.07.32.48 (version=SSLv3 cipher=OTHER); Tue, 10 Jul 2012 07:32:49 -0700 (PDT) Message-ID: <4FFC3D07.8090604@gmail.com> Date: Tue, 10 Jul 2012 16:32:39 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Max Horn Subject: Re: bug#11897: automake 1.12.2 test failure on Mac OS X 10.7 References: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> <4FFC2EC3.4020507@gmail.com> <8F5E210B-F0CA-4705-BA34-B2BC4DB3E366@quendi.de> <4FFC36ED.2090602@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11897-done Cc: 11897-done@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 07/10/2012 04:30 PM, Max Horn wrote: > > On 10.07.2012, at 16:06, Stefano Lattarini wrote: > >> On 07/10/2012 03:56 PM, Max Horn wrote: >>> >>> This fixes most of the errors, except for >>> >>> PASS: t/suffix8.tap 10 >>> ERROR: t/suffix8.tap 10 - make distcheck # UNPLANNED >>> ERROR: t/suffix8.tap - too many tests run (expected 10, got 11) >>> >>> I looked at the log, this is again the same issue, configure >>> is run once again >>> >> Of course, by "make distcheck"! *faceplam* I should have been more >> careful. >> >>> and once again suffers from the same problem. >>> >> Does the attached patch fares better? > > Works perfectly, thanks! > Thanks for confirming. I've pushed it, and I'm closing this bug report. Best regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 12:07:31 2012 Received: (at 11897) by debbugs.gnu.org; 10 Jul 2012 16:07:31 +0000 Received: from localhost ([127.0.0.1]:60359 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SocyG-00013S-2N for submit@debbugs.gnu.org; Tue, 10 Jul 2012 12:07:31 -0400 Received: from wp256.webpack.hosteurope.de ([80.237.133.25]:42768) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sob0w-0005o5-J2 for 11897@debbugs.gnu.org; Tue, 10 Jul 2012 10:02:07 -0400 Received: from dhcp181.math.nat.tu-bs.de ([134.169.53.181]); authenticated by wp256.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) id 1Soavk-0001IZ-He; Tue, 10 Jul 2012 15:56:44 +0200 Subject: Re: bug#11897: automake 1.12.2 test failure on Mac OS X 10.7 Mime-Version: 1.0 (Apple Message framework v1280) Content-Type: text/plain; charset=iso-8859-1 From: Max Horn In-Reply-To: <4FFC2EC3.4020507@gmail.com> Date: Tue, 10 Jul 2012 15:56:44 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <8F5E210B-F0CA-4705-BA34-B2BC4DB3E366@quendi.de> References: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> <4FFC2EC3.4020507@gmail.com> To: Stefano Lattarini X-Mailer: Apple Mail (2.1280) X-bounce-key: webpack.hosteurope.de;postbox@quendi.de;1341928605;8babb1db; X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11897 X-Mailman-Approved-At: Tue, 10 Jul 2012 12:07:26 -0400 Cc: 11897@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Dear Stefano, On 10.07.2012, at 15:31, Stefano Lattarini wrote: > tags 11897 + patch > severity 11897 minor > thanks >=20 > On 07/10/2012 01:44 PM, Max Horn wrote: >> Hi there, >>=20 > Hi Max, thanks for the report. Sure, thank you for your prompt reply and patch! [...] >> I think the problem is caused by the "configure" script spitting >> out these messages: >>=20 >> checking for archiver @FILE support... rm: cannot remove = `conftest.dSYM': Is a directory >> no >> checking for strip... strip >> checking for ranlib... ranlib >> checking command to parse /usr/bin/nm output from cc object... rm: = cannot remove `conftest.dSYM': Is a directory >> ok >>=20 >> Note the isolated "ok" on a line of its own; apparently this >> makes the test think that an unplanned test step occurred. >>=20 > Your interpretation is absolutely correct. The attached patch should > take care of the issue. Could you give it a try? This fixes most of the errors, except for PASS: t/suffix8.tap 10 ERROR: t/suffix8.tap 10 - make distcheck # UNPLANNED ERROR: t/suffix8.tap - too many tests run (expected 10, got 11) I looked at the log, this is again the same issue, configure is run once = again and once again suffers from the same problem. Cheers, Max= From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 10 12:07:32 2012 Received: (at 11897) by debbugs.gnu.org; 10 Jul 2012 16:07:32 +0000 Received: from localhost ([127.0.0.1]:60361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SocyJ-00013b-Ac for submit@debbugs.gnu.org; Tue, 10 Jul 2012 12:07:32 -0400 Received: from wp256.webpack.hosteurope.de ([80.237.133.25]:34717) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SobXP-0006ZL-5L for 11897@debbugs.gnu.org; Tue, 10 Jul 2012 10:35:40 -0400 Received: from dhcp181.math.nat.tu-bs.de ([134.169.53.181]); authenticated by wp256.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) id 1SobSD-0007Ju-3v; Tue, 10 Jul 2012 16:30:17 +0200 Subject: Re: bug#11897: automake 1.12.2 test failure on Mac OS X 10.7 Mime-Version: 1.0 (Apple Message framework v1280) Content-Type: text/plain; charset=iso-8859-1 From: Max Horn In-Reply-To: <4FFC36ED.2090602@gmail.com> Date: Tue, 10 Jul 2012 16:30:16 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <8BCA502F-931E-41A3-9D28-91512D69A15F@quendi.de> <4FFC2EC3.4020507@gmail.com> <8F5E210B-F0CA-4705-BA34-B2BC4DB3E366@quendi.de> <4FFC36ED.2090602@gmail.com> To: Stefano Lattarini X-Mailer: Apple Mail (2.1280) X-bounce-key: webpack.hosteurope.de;postbox@quendi.de;1341930618;5ec794c5; X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11897 X-Mailman-Approved-At: Tue, 10 Jul 2012 12:07:26 -0400 Cc: 11897@debbugs.gnu.org, "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 10.07.2012, at 16:06, Stefano Lattarini wrote: > On 07/10/2012 03:56 PM, Max Horn wrote: >> >> This fixes most of the errors, except for >> >> PASS: t/suffix8.tap 10 >> ERROR: t/suffix8.tap 10 - make distcheck # UNPLANNED >> ERROR: t/suffix8.tap - too many tests run (expected 10, got 11) >> >> I looked at the log, this is again the same issue, configure >> is run once again >> > Of course, by "make distcheck"! *faceplam* I should have been more > careful. > >> and once again suffers from the same problem. >> > Does the attached patch fares better? Works perfectly, thanks! Max From unknown Sun Jun 22 02:51:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 08 Aug 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator