GNU bug report logs - #11896
aclocal7.sh test fails sometimes with automake-1.12.2

Previous Next

Full log

Message #14 received at control <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Adam Sampson <ats <at> offog.org>
Cc: 11896 <at> debbugs.gnu.org
Subject: Re: bug#11896: aclocal7.sh test fails sometimes with automake-1.12.2
Date: Tue, 10 Jul 2012 15:26:13 +0200

[Message part 1 (text/plain, inline)]

tags 11896 + patch
severity 11896 minor
close 11896
thanks

On 07/10/2012 01:18 PM, Adam Sampson wrote:
> Hi,
>
Hi Adam, thanks for the report and the patch.

> I've just built automake-1.12.2 and had the aclocal7.sh test fail. After
> a bit of investigation, it's because the test:
> 
> - creates a .m4 file;
> - calls aclocal;
> - calls automake;
> - sleeps for a bit;
> - calls aclocal again;
> - calls automake again;
> - checks that those two calls didn't actually write any files.
>   [then goes on to test some other stuff that works fine]
> 
> The problem is that aclocal decides whether to rewrite its output file
> by checking that all of the input files it's read are older than the
> existing output file. If aclocal takes less than a second to run in the
> sequence above, it's possible for its output file to have the same
> timestamp as the .m4 file -- and then the second call to aclocal will
> decide the output file needs rewriting, and the test fails.
>
Oops, I introduced this error in a previous commit (v1.12.1-46-g13dd512).

> The attached patch adds a $sleep after creating the .m4 file, so it'll
> definitely be older than the first aclocal's output.
>
I've applied the fix in your name (see attached patch), and pushed.

I'm thus closing this bug report.

Thanks,
  Stefano

[0001-tests-fix-spurious-failure-in-aclocal7.sh-on-fast-ma.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.