GNU bug report logs - #11894
24.1.50; [PATCH] diff-apply-hunk can be off by 1 line when the hunk is 0-context pure removal

Previous Next

Full log

Message #17 received at 11894 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: 11894 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#11894: 24.1.50;
	[PATCH] diff-apply-hunk can be off by 1 line when the hunk is
	0-context pure removal
Date: Thu, 19 Jul 2012 03:58:55 -0400

>> This looks like a bug in those versions of diff (not that I know
>> a non-buggy version, tho).
> Maybe, but that's how POSIX wants it:

>     The ending line number of an empty range shall be the number of the
>     preceding line, or 0 if the range is at the start of the file.

Hmm... but the number we're talking about is the starting-line-number,
isn't it?

In any case I think that we're OK in the sense that we're not doing
much worse than `patch'.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.