GNU bug report logs - #11883
24.1.50; shell-mode doesn't colorize the prompt

Previous Next

Package: emacs;

Reported by: Dima Kogan <dima <at> secretsauce.net>

Date: Mon, 9 Jul 2012 06:52:02 UTC

Severity: wishlist

Tags: moreinfo, patch

Found in version 24.1.50

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Dima Kogan <dima <at> secretsauce.net>
To: 11883 <at> debbugs.gnu.org
Subject: bug#11883: Hints
Date: Tue, 6 Nov 2012 11:12:43 -0800
Looking around, I discovered that this regression was introduced in

http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/ansi-color.el?id=cd49cea06bb1c492d4d024889f3f320bf4c9b507

Furthermore, starting from the recent sources, this regression can be fixed by
making the following changes to comint.el:

1. Not inheriting the comint-highlight-prompt face from minibuffer-prompt
2. In comint-output-filter, changing

		    ;; Just move an existing overlay
                    (move-overlay comint-last-prompt-overlay
				  prompt-start (point))

to

		    (move-overlay (copy-overlay comint-last-prompt-overlay)
				  prompt-start (point))


Note that I don't understand this code sufficiently well to claim this as a fix,
but hopefully this will be helpful for the maintainer to make the final fix.

dima




This bug report was last modified 3 years and 235 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.