From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 08 12:23:19 2012 Received: (at submit) by debbugs.gnu.org; 8 Jul 2012 16:23:19 +0000 Received: from localhost ([127.0.0.1]:56889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnuGV-0004uR-0C for submit@debbugs.gnu.org; Sun, 08 Jul 2012 12:23:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59954) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Snm7F-0006gn-OP for submit@debbugs.gnu.org; Sun, 08 Jul 2012 03:41:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Snm2F-0007pG-Ol for submit@debbugs.gnu.org; Sun, 08 Jul 2012 03:36:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Snm2F-0007pC-In for submit@debbugs.gnu.org; Sun, 08 Jul 2012 03:36:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Snm2D-0002KC-Lq for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2012 03:36:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Snm2B-0007ob-5Z for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2012 03:36:01 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:57466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Snm2A-0007nt-Q2 for bug-gnu-emacs@gnu.org; Sun, 08 Jul 2012 03:35:59 -0400 Received: by pbbrp2 with SMTP id rp2so19564159pbb.0 for ; Sun, 08 Jul 2012 00:35:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:content-type:content-transfer-encoding:subject:date :message-id:to:mime-version:x-mailer; bh=JGK9JlvzbJATuU7IMzjujFh9rH+L64IA/9cJAMPTFQk=; b=TrkprPCGUUPq3VwkkIoQy19JtJBHYaUfbAt9hLHbZCt28hLcn14dFA1NL22oiAq8R3 dNfgA/3zpfEf2uZnMTw6+mIgmliLsPfNZAc80WZmMkN6Q2JUEyJFw8DtRIeJXFPGLavy q8+C4cYqGmEorQWYihV/ejOyX9YD7LMPnQ8jNYqXrUjSlwvWVyUc3pDGg7bN7k+o6amK 5bNGwMRUXE5gLnES2l5LYJfIn6DFM1pdF2eezyLiNhPAf2tmdmstbaC4Gtybct7+I04p O5umpx0/Vm4/zlMQDyHMYLBqwwk8VvtDAOKFEXniegs7Z79cU/XoYqUe4Pg45cdVIzYs FzFw== Received: by 10.68.136.229 with SMTP id qd5mr50597155pbb.2.1341732954331; Sun, 08 Jul 2012 00:35:54 -0700 (PDT) Received: from [192.168.1.13] (c-76-102-117-203.hsd1.ca.comcast.net. [76.102.117.203]) by mx.google.com with ESMTPS id ms1sm25287009pbb.63.2012.07.08.00.35.53 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 08 Jul 2012 00:35:53 -0700 (PDT) From: Matt Arsenault Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file Date: Sun, 8 Jul 2012 00:35:52 -0700 Message-Id: To: bug-gnu-emacs@gnu.org Mime-Version: 1.0 (Apple Message framework v1278) X-Mailer: Apple Mail (2.1278) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -5.9 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 08 Jul 2012 12:23:18 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.9 (-----) This is a regression from emacs 23. In emacs 24, delete-trailing-whitespace remove blank lines at the end of = a buffer. Previously this function would remove trailing whitespace on a = line, but not change the number of lines. Steps to reproduce:=20 1. Open a new buffer 2. Enter a few lines of text 3. Enter a few blank lines after the text 4. Run M-x delete-trailing-whitespace Expected behavior:=20 Number of lines to be unchanged. Blank lines at end of text should be = there which was the behavior in emacs 23 and previous versions. Observed behavior: Blank lines after the text are removed. If the buffer is only blank = lines, the first one survives the delete-trailing-whitespace. The report may appear in public locations. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Applications/Aquamacs.app/Contents/Resources/etc/DEBUG. In GNU Emacs 24.1.50.3 (i386-apple-darwin9.8.0, NS apple-appkit-949.54) of 2012-07-07 on braeburn.aquamacs.org - Aquamacs Distribution 3.xdev Windowing system distributor `Apple', version 10.3.1138 Configured using: `configure '--with-ns' '--without-x' 'CFLAGS=3D-arch i386 -g -O0 ' 'LDFLAGS=3D-arch i386 -g -O0 '' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default enable-multibyte-characters: t Major mode: Emacs-Lisp Minor modes in effect: shell-dirtrack-mode: t global-linum-mode: t linum-mode: t savehist-mode: t smart-frame-positioning-mode: t aquamacs-autoface-mode: t recentf-mode: t osx-key-mode: t tabbar-mwheel-mode: t tabbar-mode: t show-paren-mode: t cua-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t abbrev-mode: t Recent input: Features: (shadow sort mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader dired-aux cua-rect rect help-mode novice js json moz imenu dired etags multi-isearch desktop vc-git network-stream starttls url-http tls url-auth mail-parse rfc2231 url-gw url-cache url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse auth-source eieio gnus-util password-cache url-vars mailcap windmove protobuf-mode cc-langs cc-mode cc-fonts cc-guess cc-menus cc-cmds cmake-mode flymake camelCase gtk2hs haskell-ghci inf-haskell haskell-mode derived pp compile shell pcomplete comint ring goto-last-change cc-styles cc-align cc-engine cc-vars cc-defs edmacro kmacro ansi-color linum auto-complete-clang load-emacs-plugins aquamacs-mode-defaults auctex-config server preview-latex tex-site auto-loads aquamacs-aux savehist mouse-sel one-buffer-one-frame smart-frame-positioning drews_init color-theme-autoloads view saveplace visual-line aquamacs-bug aquamacs-autoface-mode aquamacs-editing sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils recentf tree-widget cus-edit osxkeys emulate-mac-keyboard-mode frame-cmds strings misc-fns thingatpt+ thingatpt frame-fns avoid aquamacs-mac-fontsets fit-frame aquamacs-frame-setup aquamacs-tabbar tabbar-window cl cus-start cus-load tabbar warnings load-emacs-pre-plugins aquamacs-site-start cocoa-compatibility matlab-load smart-dnd revive filladapt aquamacs-redo check-for-updates aquamacs-menu osx_defaults aquamacs aquamacs-tool-bar time-date mac-extra-functions aquamacs-tools aquamacs-macros parse-time timezone paren delsel cua-base wid-edit advice advice-preload byte-opt bytecomp byte-compile debug help-fns macroexp cconv image-file disp-table easymenu easy-mmode tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 13 16:36:35 2012 Received: (at 11879) by debbugs.gnu.org; 13 Jul 2012 20:36:35 +0000 Received: from localhost ([127.0.0.1]:39830 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpmbK-0002hz-Iv for submit@debbugs.gnu.org; Fri, 13 Jul 2012 16:36:35 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:48898) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpmbI-0002hr-LN for 11879@debbugs.gnu.org; Fri, 13 Jul 2012 16:36:33 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SpmVo-0006nC-ME; Fri, 13 Jul 2012 16:30:52 -0400 From: Glenn Morris To: Matt Arsenault Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file References: X-Spook: brigand Serbian Osama Operation Iraqi Freedom morse X-Ran: sw@>:9-l]_x>=YMCydqs0AHrYWy'kip[H&DF(ptV7!%Hg*@E($D~1zTS`{\UW}F_lx-]hC X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 13 Jul 2012 16:30:52 -0400 In-Reply-To: (Matt Arsenault's message of "Sun, 8 Jul 2012 00:35:52 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11879 Cc: 11879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Matt Arsenault wrote: > In emacs 24, delete-trailing-whitespace remove blank lines at the end > of a buffer. This appeared during the Emacs 24 feature freeze, I don't see why. I suggest using an optional prefix argument to control this. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 13 17:15:18 2012 Received: (at 11879) by debbugs.gnu.org; 13 Jul 2012 21:15:18 +0000 Received: from localhost ([127.0.0.1]:39856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpnCo-0003ck-BJ for submit@debbugs.gnu.org; Fri, 13 Jul 2012 17:15:18 -0400 Received: from mail-yw0-f44.google.com ([209.85.213.44]:51667) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SpnCn-0003ce-09 for 11879@debbugs.gnu.org; Fri, 13 Jul 2012 17:15:17 -0400 Received: by yhq56 with SMTP id 56so4211572yhq.3 for <11879@debbugs.gnu.org>; Fri, 13 Jul 2012 14:09:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=06vneTplpUsWGgPVGCGe5q14kG2a7cmPOIjPPQ2LrYI=; b=FH1F2iN0fTCecetza8V7qPX126EN1mp8Hs87S6OGKnDCTbDSrYy2sxRU8HM5HJGXBq vTAr9co87Koq2kZ8+m/u0s81Y3X2iI0JR7CjeURIYNtP/tSWXf5OtAgJpG3JRjWmYz6V Pc8IiuFdNOEgGqWWLfOIxs/SDcHBjy+tJx6d/ajct0hB1xM8Kp21c+PZuKZHjcUeR62l 4KWfYMG/v/bZcEUWHh+Ym8rUfzoLKTSYHXxYFr5DLl9gIsks0ksiUhjPyF9LevCn4fGb 8hspbvQhZJ3H3e/aWC3JDtUo//WLXIqMJ83E6ToKmLOxU5qe0fsQTaVYRnuloaegRErk 4Jtw== Received: by 10.66.84.130 with SMTP id z2mr4701739pay.77.1342213776554; Fri, 13 Jul 2012 14:09:36 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.162.16 with HTTP; Fri, 13 Jul 2012 14:08:56 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Fri, 13 Jul 2012 23:08:56 +0200 Message-ID: Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file To: Glenn Morris Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11879 Cc: 11879@debbugs.gnu.org, Matt Arsenault X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Fri, Jul 13, 2012 at 10:30 PM, Glenn Morris wrote: > This appeared during the Emacs 24 feature freeze, I don't see why. > I suggest using an optional prefix argument to control this. Why not treat it as an annoying regression, which it is? Juanma From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 15 18:37:43 2012 Received: (at 11879) by debbugs.gnu.org; 15 Jul 2012 22:37:43 +0000 Received: from localhost ([127.0.0.1]:43220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqXRf-0008E3-Fr for submit@debbugs.gnu.org; Sun, 15 Jul 2012 18:37:43 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:50995) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqXRe-0008Dw-0k for 11879@debbugs.gnu.org; Sun, 15 Jul 2012 18:37:42 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6FMVl7Y021570; Sun, 15 Jul 2012 18:31:48 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 42F99AE323; Sun, 15 Jul 2012 18:31:46 -0400 (EDT) From: Stefan Monnier To: Juanma Barranquero Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file Message-ID: References: Date: Sun, 15 Jul 2012 18:31:46 -0400 In-Reply-To: (Juanma Barranquero's message of "Fri, 13 Jul 2012 23:08:56 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4280=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4280> : streams <785155> : uri <1166211> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 11879 Cc: Glenn Morris , Matt Arsenault , 11879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >> This appeared during the Emacs 24 feature freeze, I don't see why. >> I suggest using an optional prefix argument to control this. > Why not treat it as an annoying regression, which it is? I can't remember the exact details, but I do remember it being introduced on purpose (tho the purpose might not have justified it). I think it was judged that a new custom var for it or a new function was not needed. And, while there is a change, I haven't yet seen a clear argument that this change is a problem. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 15 19:12:39 2012 Received: (at 11879) by debbugs.gnu.org; 15 Jul 2012 23:12:39 +0000 Received: from localhost ([127.0.0.1]:43249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqXzQ-0000bE-NE for submit@debbugs.gnu.org; Sun, 15 Jul 2012 19:12:38 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:41554) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqXzM-0000b5-NI for 11879@debbugs.gnu.org; Sun, 15 Jul 2012 19:12:34 -0400 Received: by pbcwy7 with SMTP id wy7so8888535pbc.3 for <11879@debbugs.gnu.org>; Sun, 15 Jul 2012 16:06:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=q4WsNKDhu4uCINOdyyuU6ywt4o0bBwl6R8WphNs8Bp8=; b=WznI8F+7UDHBPFAD+1OOqYJTcKlEeSgjYk472ZO+9bIIvQ1dQfGBQVVntON3EmTv6Y 9eE5jkZTLR0q+Arvv7FdKDIISnWqII9HufuczwpCOYP4Z6eAu+14oDzyz955xvIPvIW5 sePYRcjh0E0tJhDgbJInh3SkFVNrObLQQQdhXcvdsJZb4fAM0T6qUzF2r7D3czhi1Lky FLUsPdHoyve7L7yKWUqzkR0zI1tlFKQTJ2OsinFdTTR0MjVoe4tv9MZ4HO3q6A/sLLEg 72IAl8hD0szl/Db0haYWxG+vVlzBb1xttifGiYztUWqwvjV+DX00bXhHdUxd5A5LfiWa 7hnw== Received: by 10.68.193.195 with SMTP id hq3mr22317897pbc.30.1342393600783; Sun, 15 Jul 2012 16:06:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.162.16 with HTTP; Sun, 15 Jul 2012 16:06:00 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Mon, 16 Jul 2012 01:06:00 +0200 Message-ID: Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file To: Stefan Monnier Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11879 Cc: Glenn Morris , Matt Arsenault , 11879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Mon, Jul 16, 2012 at 12:31 AM, Stefan Monnier wrote: > And, while there is a change, I haven't yet seen a clear argument that > this change is a problem. I don't think it's a matter of argument, just taste. I dislike delete-trailing-whitespace removing lines. I have a checkout of Emacs with a lot of changed files, and editing some of them creates spurious differences. Hardly a catastrophe, more of a nuisance. Juanma From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 15 19:15:48 2012 Received: (at 11879) by debbugs.gnu.org; 15 Jul 2012 23:15:48 +0000 Received: from localhost ([127.0.0.1]:43260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqY2W-0000gL-1f for submit@debbugs.gnu.org; Sun, 15 Jul 2012 19:15:48 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37317) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SqY2T-0000gC-Nn for 11879@debbugs.gnu.org; Sun, 15 Jul 2012 19:15:46 -0400 Received: by wibhm6 with SMTP id hm6so1855409wib.15 for <11879@debbugs.gnu.org>; Sun, 15 Jul 2012 16:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:date:message-id:mime-version:content-type; bh=n4/kfIS+oxjfR4FPvIpKdsZJz+GsNccyG7NCGXlkecA=; b=EoV7NwFyRGxfBPzaw9sbvSqNUML0e8vB0PR8tccZc6NDwbuTQ9C94X1/HEdmD5RBFV klauyus9XbHtg3zFQEtSe6OwD91BfcqqmpLF83iEqchqRu/QuvUxJ3l/wN5H+dBKJ9cr 9aIRVCBHa62SPHKjJNPzapDBmr8Vq1FPQ212xl7dO/4A1+xe6xAK8WKDFoGVAnw3ybQ6 3hzMmMATfIXgbxku7w2p/9SKGsINFyXSeH3+skSeDnFVowSzJScWSQ+b35sjv43LvDp0 bVfmD9kRz7ZQTashyZ2kRLZHNGwCQAbf+tbeWGNLgQw3ZQel8riL8reloJzQsf51KZxQ U+cg== Received: by 10.180.98.69 with SMTP id eg5mr13606197wib.3.1342393793598; Sun, 15 Jul 2012 16:09:53 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id t8sm18469515wiy.3.2012.07.15.16.09.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 15 Jul 2012 16:09:52 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 49B598207; Mon, 16 Jul 2012 01:10:26 +0200 (CEST) From: Bastien To: Juanma Barranquero Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file In-Reply-To: (Juanma Barranquero's message of "Mon, 16 Jul 2012 01:06:00 +0200") Organization: GNU References: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Date: Mon, 16 Jul 2012 01:10:26 +0200 Message-ID: <87mx30mxi5.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11879 Cc: 11879@debbugs.gnu.org, Stefan Monnier , Matt Arsenault X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Juanma Barranquero writes: > On Mon, Jul 16, 2012 at 12:31 AM, Stefan Monnier > wrote: > >> And, while there is a change, I haven't yet seen a clear argument that >> this change is a problem. > > I don't think it's a matter of argument, just taste. I dislike > delete-trailing-whitespace removing lines. I have a checkout of Emacs > with a lot of changed files, and editing some of them creates spurious > differences. Hardly a catastrophe, more of a nuisance. FWIW I agree with Juanma here. Also the name of the function suggests this. -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 16 17:42:20 2012 Received: (at 11879) by debbugs.gnu.org; 16 Jul 2012 21:42:20 +0000 Received: from localhost ([127.0.0.1]:44753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sqt3c-0006jU-8N for submit@debbugs.gnu.org; Mon, 16 Jul 2012 17:42:20 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:49053) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1Sqt3Z-0006jJ-PW for 11879@debbugs.gnu.org; Mon, 16 Jul 2012 17:42:18 -0400 Received: (qmail invoked by alias); 16 Jul 2012 21:36:20 -0000 Received: from p4FC763F3.dip.t-dialin.net (EHLO turtle.gmx.de) [79.199.99.243] by mail.gmx.net (mp033) with SMTP; 16 Jul 2012 23:36:20 +0200 X-Authenticated: #28250155 X-Provags-ID: V01U2FsdGVkX18W8e1rQ/AWnYC5G8/N2gpni2OslBye0p4jVzqE4j dnMNJ0/dPqntgJ Received: by turtle.gmx.de (Postfix, from userid 1000) id 960283F48E; Mon, 16 Jul 2012 23:36:23 +0200 (CEST) From: Sven Joachim To: Stefan Monnier Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file References: Date: Mon, 16 Jul 2012 23:36:23 +0200 In-Reply-To: (Stefan Monnier's message of "Sun, 15 Jul 2012 18:31:46 -0400") Message-ID: <87hat78k2w.fsf@turtle.gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Y-GMX-Trusted: 0 X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11879 Cc: Juanma Barranquero , Matt Arsenault , 11879@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 2012-07-16 00:31 +0200, Stefan Monnier wrote: >>> This appeared during the Emacs 24 feature freeze, I don't see why. >>> I suggest using an optional prefix argument to control this. >> Why not treat it as an annoying regression, which it is? > > I can't remember the exact details, but I do remember it being > introduced on purpose (tho the purpose might not have justified it). > I think it was judged that a new custom var for it or a new function was > not needed. > > And, while there is a change, I haven't yet seen a clear argument that > this change is a problem. There may be cases where an empty line at the end is actually necessary. For instance, I occasionally edit chess game files in PGNš format, and removing the trailing empty line breaks the nice feature that several of such files can be combined with cat(1) to produce a larger one. Cheers, Sven 1. http://en.wikipedia.org/wiki/Portable_Game_Notation From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 28 06:48:10 2012 Received: (at 11879) by debbugs.gnu.org; 28 Jul 2012 10:48:10 +0000 Received: from localhost ([127.0.0.1]:45924 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sv4Z7-0004LV-Q1 for submit@debbugs.gnu.org; Sat, 28 Jul 2012 06:48:10 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:43264) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sv4Z6-0004LO-2h for 11879@debbugs.gnu.org; Sat, 28 Jul 2012 06:48:09 -0400 Received: by pbcwy7 with SMTP id wy7so6572196pbc.3 for <11879@debbugs.gnu.org>; Sat, 28 Jul 2012 03:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type:content-transfer-encoding; bh=595xRjzBf1PYqwqwGIOMtpxFubrrEQ4t8QQxSppksus=; b=w0D4YZjY4EjIqXRh5/d5YgCpZ93KwFWaOiQGjZzHYngI3X1OijgISK+B6gfCMoYZEW 3cdt4S8fOkTDssEoRUoqw4sqK0flEEvvNfCAGoMgW6qYBcgofKUFjZB+Y+VxTzpx+rLc 5i4c/bAAvCr/731aNDOLN7DCungKJPhd+HMmTYhcf/K3zL3VDux+J3hUGR+qwQQoCj8n 9cvWziYF9pmWpo/yBK4JaCVtM7AsO+RJ7Dm2st1Lp5kLizOXm6PZ9nYvrMA1ztQJQrcJ e2y1aAWeaf6Ba7TnZ6Rxr8Ayi/oePvJ5N8Ci9PDPkeMfW9hVMg6NT9vyoKMFqxQeggyC TgKQ== Received: by 10.68.235.68 with SMTP id uk4mr19874054pbc.52.1343472066012; Sat, 28 Jul 2012 03:41:06 -0700 (PDT) Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id sk5sm3771390pbc.7.2012.07.28.03.41.03 (version=SSLv3 cipher=OTHER); Sat, 28 Jul 2012 03:41:05 -0700 (PDT) From: Chong Yidong To: Sven Joachim Subject: Re: bug#11879: 24.1.50; delete-trailing-whitespace now removes empty lines at end of file References: <87hat78k2w.fsf@turtle.gmx.de> Date: Sat, 28 Jul 2012 18:41:00 +0800 In-Reply-To: <87hat78k2w.fsf@turtle.gmx.de> (Sven Joachim's message of "Mon, 16 Jul 2012 23:36:23 +0200") Message-ID: <87d33ggocj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11879 Cc: 11879@debbugs.gnu.org, Stefan Monnier , Matt Arsenault , Juanma Barranquero X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Sven Joachim writes: >> And, while there is a change, I haven't yet seen a clear argument that >> this change is a problem. > > There may be cases where an empty line at the end is actually necessary. > For instance, I occasionally edit chess game files in PGN=C3=82=C2=B9 for= mat, and > removing the trailing empty line breaks the nice feature that several of > such files can be combined with cat(1) to produce a larger one. I think this is a fair point, so I added `delete-trailing-lines' as an option defaulting to t. Major modes which need to preserve trailing newlines can now set that to nil, (I don't think there are any such modes in Emacs), or users can customize it. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 28 06:48:29 2012 Received: (at control) by debbugs.gnu.org; 28 Jul 2012 10:48:29 +0000 Received: from localhost ([127.0.0.1]:45927 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sv4ZR-0004Ly-2O for submit@debbugs.gnu.org; Sat, 28 Jul 2012 06:48:29 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:43264) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sv4ZK-0004LO-2X for control@debbugs.gnu.org; Sat, 28 Jul 2012 06:48:22 -0400 Received: by mail-pb0-f44.google.com with SMTP id wy7so6572196pbc.3 for ; Sat, 28 Jul 2012 03:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=u7ojgCCzk3zkE3RiZ5L7raGjIdJfhLmGsNcwaH/6KbM=; b=unOUoIfRCqnLYvBM0rtPxI0ww0lXqc50UIsjVED03/jITMQ2ruToO0PC5I3WRSBWsr B+dv8o9kaqBy6i+XgHZwkgboeggwJ5LdXP2LGyKh4ptlWDpAlIuPgJcQt+j6mXAt7McL 1UQfRM291mAknmjcTkfYQo/DYIseyxp3SwsN9xXTPxsB/xUScp7BpgE8PkjUOacGZasv pfMb9LdB9dKaxBpxjUkgWr2MKEp0I8hpz2WbRAyGhg0um3tHasNsJPhzJ5AcWDOK8HWA eSF2p2LKfv4cEBFi16Y1lqCXYvHqZw1da8YGhkNXbFFCbupFaxvpckFQnlRMzL0ltRTU 9Hdg== Received: by 10.68.237.103 with SMTP id vb7mr20785194pbc.38.1343472080352; Sat, 28 Jul 2012 03:41:20 -0700 (PDT) Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id gh9sm3769288pbc.20.2012.07.28.03.41.18 (version=SSLv3 cipher=OTHER); Sat, 28 Jul 2012 03:41:19 -0700 (PDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11879 Date: Sat, 28 Jul 2012 18:41:15 +0800 Message-ID: <87vch8yxpw.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 11879 thanks From unknown Sat Sep 06 05:55:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Aug 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator