From unknown Sat Jun 21 05:17:19 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11856 <11856@debbugs.gnu.org> To: bug#11856 <11856@debbugs.gnu.org> Subject: Status: 24.0.97; Improve imenu expression of sh-script mode to handle "function FOO" Reply-To: bug#11856 <11856@debbugs.gnu.org> Date: Sat, 21 Jun 2025 12:17:19 +0000 retitle 11856 24.0.97; Improve imenu expression of sh-script mode to handle= "function FOO" reassign 11856 emacs submitter 11856 Masatake YAMATO severity 11856 minor tag 11856 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 04 13:52:48 2012 Received: (at submit) by debbugs.gnu.org; 4 Jul 2012 17:52:48 +0000 Received: from localhost ([127.0.0.1]:48330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmTku-0001nd-D6 for submit@debbugs.gnu.org; Wed, 04 Jul 2012 13:52:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44863) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmTkr-0001nW-T4 for submit@debbugs.gnu.org; Wed, 04 Jul 2012 13:52:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmTgC-0002ho-D3 for submit@debbugs.gnu.org; Wed, 04 Jul 2012 13:47:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmTgC-0002hk-AM for submit@debbugs.gnu.org; Wed, 04 Jul 2012 13:47:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmTgA-0006TR-KM for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 13:47:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SmTg7-0002hD-Fm for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 13:47:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:21278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SmTg7-0002gn-7A for bug-gnu-emacs@gnu.org; Wed, 04 Jul 2012 13:47:51 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q64HlmC3015871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 4 Jul 2012 13:47:48 -0400 Received: from localhost (vpn-235-4.phx2.redhat.com [10.3.235.4]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q64HllWS015135 for ; Wed, 4 Jul 2012 13:47:47 -0400 Date: Thu, 05 Jul 2012 02:47:46 +0900 (JST) Message-Id: <20120705.024746.486687518756828993.yamato@redhat.com> To: bug-gnu-emacs@gnu.org Subject: 24.0.97; Improve imenu expression of sh-script mode to handle "function FOO" From: Masatake YAMATO Organization: Red Hat Japan, Inc. Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is not a bug report. This is a request for reviwing and merging a patch. With this patch foo in following shell script can be captured as an imenu entry. function foo { ... (Even witohut this patch function foo() { ... and foo() { ... can be captured.) 2012-07-04 Masatake YAMATO * progmodes/sh-script.el (sh-imenu-generic-expression): Capture a function with `function' keyword and without parentheses like "function FOO". === modified file 'lisp/progmodes/sh-script.el' --- lisp/progmodes/sh-script.el 2012-05-11 14:24:50 +0000 +++ lisp/progmodes/sh-script.el 2012-07-04 03:57:10 +0000 @@ -327,8 +327,15 @@ (defcustom sh-imenu-generic-expression `((sh . ((nil - "^\\s-*\\(function\\s-+\\)?\\([[:alpha:]_][[:alnum:]_]+\\)\\s-*()" - 2)))) + ;; function FOO + ;; function FOO() + "^\\s-*function\\s-+\\\([[:alpha:]_][[:alnum:]_]+\\)\\s-*\\(?:()\\)?" + 1) + ;; FOO() + (nil + "^\\s-*\\([[:alpha:]_][[:alnum:]_]+\\)\\s-*()" + 1) + ))) "Alist of regular expressions for recognizing shell function definitions. See `sh-feature' and `imenu-generic-expression'." :type '(alist :key-type (symbol :tag "Shell") From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 08 19:30:02 2012 Received: (at 11856) by debbugs.gnu.org; 8 Jul 2012 23:30:02 +0000 Received: from localhost ([127.0.0.1]:57119 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1So0vR-0006Fr-IR for submit@debbugs.gnu.org; Sun, 08 Jul 2012 19:30:02 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53300) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1So0vQ-0006FS-6y for 11856@debbugs.gnu.org; Sun, 08 Jul 2012 19:30:00 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q68NOjWD014889; Sun, 8 Jul 2012 19:24:46 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 39B6DAEC0D; Sun, 8 Jul 2012 19:24:43 -0400 (EDT) From: Stefan Monnier To: Masatake YAMATO Subject: Re: bug#11856: 24.0.97; Improve imenu expression of sh-script mode to handle "function FOO" Message-ID: References: <20120705.024746.486687518756828993.yamato@redhat.com> Date: Sun, 08 Jul 2012 19:24:43 -0400 In-Reply-To: <20120705.024746.486687518756828993.yamato@redhat.com> (Masatake YAMATO's message of "Thu, 05 Jul 2012 02:47:46 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4273=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4273> : streams <781006> : uri <1160259> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 11856 Cc: 11856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > This is not a bug report. This is a request for reviwing and merging a > patch. Looks good, please install, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 11 01:51:08 2012 Received: (at 11856) by debbugs.gnu.org; 11 Jul 2012 05:51:09 +0000 Received: from localhost ([127.0.0.1]:32922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SoppM-0004hI-BE for submit@debbugs.gnu.org; Wed, 11 Jul 2012 01:51:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15845) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SoppJ-0004h8-6D for 11856@debbugs.gnu.org; Wed, 11 Jul 2012 01:51:06 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6B5jdtW025561 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 11 Jul 2012 01:45:39 -0400 Received: from localhost (dhcp-193-19.nrt.redhat.com [10.64.193.19]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6B5jbHq016731; Wed, 11 Jul 2012 01:45:37 -0400 Date: Wed, 11 Jul 2012 14:45:36 +0900 (JST) Message-Id: <20120711.144536.433618201521258508.yamato@redhat.com> To: monnier@iro.umontreal.ca Subject: Re: bug#11856: 24.0.97; Improve imenu expression of sh-script mode to handle "function FOO" From: Masatake YAMATO In-Reply-To: References: <20120705.024746.486687518756828993.yamato@redhat.com> Organization: Red Hat Japan, Inc. Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11856 Cc: 11856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) >> This is not a bug report. This is a request for reviwing and merging a >> patch. > > Looks good, please install, > > > Stefan I'm sorry but could you install the patch? I deleted my self from 'emacs commiters' when my hard disk was broken and my domain (gyve.org) was lost simultaneously. Masatake YAMATO From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 09:48:22 2012 Received: (at 11856) by debbugs.gnu.org; 18 Jul 2012 13:48:22 +0000 Received: from localhost ([127.0.0.1]:47798 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrUc1-0002Xr-T4 for submit@debbugs.gnu.org; Wed, 18 Jul 2012 09:48:22 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:57993) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrUc0-0002Xk-9C for 11856@debbugs.gnu.org; Wed, 18 Jul 2012 09:48:20 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q6IDgC5R005903; Wed, 18 Jul 2012 09:42:13 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 6434DAECAF; Wed, 18 Jul 2012 09:42:10 -0400 (EDT) From: Stefan Monnier To: Masatake YAMATO Subject: Re: bug#11856: 24.0.97; Improve imenu expression of sh-script mode to handle "function FOO" Message-ID: References: <20120705.024746.486687518756828993.yamato@redhat.com> <20120711.144536.433618201521258508.yamato@redhat.com> Date: Wed, 18 Jul 2012 09:42:10 -0400 In-Reply-To: <20120711.144536.433618201521258508.yamato@redhat.com> (Masatake YAMATO's message of "Wed, 11 Jul 2012 14:45:36 +0900 (JST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4282=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4282> : streams <786707> : uri <1168486> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 11856 Cc: 11856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >>> This is not a bug report. This is a request for reviwing and merging a >>> patch. >> Looks good, please install, > I'm sorry but could you install the patch? Of course, done. > I deleted my self from 'emacs commiters' when my hard disk was > broken and my domain (gyve.org) was lost simultaneously. Feel free to re-request memership from your savannah account, so I can re-add you there. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 18 10:13:17 2012 Received: (at control) by debbugs.gnu.org; 18 Jul 2012 14:13:17 +0000 Received: from localhost ([127.0.0.1]:48565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrV09-0003IZ-1c for submit@debbugs.gnu.org; Wed, 18 Jul 2012 10:13:17 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:54121) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SrV06-0003IS-Ui for control@debbugs.gnu.org; Wed, 18 Jul 2012 10:13:15 -0400 Received: by pbcwy7 with SMTP id wy7so2562307pbc.3 for ; Wed, 18 Jul 2012 07:07:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:date:message-id:mime-version:content-type; bh=488c+jem5DVJWk6TkCg9luYHbNmgQeNH4O5+ZfwEpfo=; b=Ge3oWv+nmN1BJocjCclf8ry8ATyKXChy0SffMcJB5sbF+r/NKPDplETOh7IRhWjffr ZE5vgWSTlbnoSkKEp7NbtcSfdtrUejfGAbRaIrVQx17WwRokWLZdldWdLi6L8z3QBwCj dSju3UrSVOOYWuN6BuWPUtc321h6912cxmo43d+GZbNQtP3OUGcl4j7OZQHSlwZoXRo1 cVsMt8ylSVJielexBr//h6KG/qUaLOgCbAK74kpsGshN2wkJsCumM25M+d5aKpWLDYjl pnB4pzQFwVLQsJTxYCUH+hh3Aup9aDwp/X5/MuGxF7gVIGIsMG+m6/cvRTSvg7fcxYe6 quNw== Received: by 10.68.231.39 with SMTP id td7mr8196256pbc.3.1342620428018; Wed, 18 Jul 2012 07:07:08 -0700 (PDT) Received: from ulysses (cm162.gamma80.maxonline.com.sg. [202.156.80.162]) by mx.google.com with ESMTPS id op10sm16261963pbc.75.2012.07.18.07.07.05 (version=SSLv3 cipher=OTHER); Wed, 18 Jul 2012 07:07:07 -0700 (PDT) From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11856 Date: Wed, 18 Jul 2012 22:07:02 +0800 Message-ID: <87vchlp3i1.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) close 11856 thanks From unknown Sat Jun 21 05:17:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 16 Aug 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator