GNU bug report logs - #11817
24.1.50; Useless code in `kmacro-call-macro'

Previous Next

Package: emacs;

Reported by: Damien Cassou <damien.cassou <at> gmail.com>

Date: Fri, 29 Jun 2012 17:04:02 UTC

Severity: minor

Found in version 24.1.50

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11817 in the body.
You can then email your comments to 11817 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#11817; Package emacs. (Fri, 29 Jun 2012 17:04:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Damien Cassou <damien.cassou <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 29 Jun 2012 17:04:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Damien Cassou <damien.cassou <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; Useless code in `kmacro-call-macro'
Date: Fri, 29 Jun 2012 18:58:21 +0200

Hi,

In `kmacro-call-macro', the variable `repeat-key-str' is defined and
then set but never used.

In GNU Emacs 24.1.50.1 (i686-pc-linux-gnu, GTK+ Version 3.4.2)
 of 2012-06-28 on iridium, modified by Debian
 (emacs-snapshot package, version 2:20120628-1~ppa1~precise1)
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11817; Package emacs. (Fri, 06 Jul 2012 02:11:01 GMT) Full text and rfc822 format available.

Message #8 received at 11817 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Damien Cassou <damien.cassou <at> gmail.com>
Cc: 11817 <at> debbugs.gnu.org, Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#11817: 24.1.50; Useless code in `kmacro-call-macro'
Date: Thu, 05 Jul 2012 22:05:14 -0400

Damien Cassou wrote:

> In `kmacro-call-macro', the variable `repeat-key-str' is defined and
> then set but never used.

It's unused since 2012-05-05.
There used to be a "(Type e to repeat macro)" message after running a
macro. Now there isn't. I wonder why, since it has nothing to do with
the use of set-temporary-overlay-map AFAICS.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11817; Package emacs. (Fri, 06 Jul 2012 21:29:02 GMT) Full text and rfc822 format available.

Message #11 received at 11817 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 11817 <at> debbugs.gnu.org, Damien Cassou <damien.cassou <at> gmail.com>
Subject: Re: bug#11817: 24.1.50; Useless code in `kmacro-call-macro'
Date: Fri, 06 Jul 2012 17:20:29 -0400

>> In `kmacro-call-macro', the variable `repeat-key-str' is defined and
>> then set but never used.
> It's unused since 2012-05-05.
> There used to be a "(Type e to repeat macro)" message after running a
> macro. Now there isn't. I wonder why, since it has nothing to do with
> the use of set-temporary-overlay-map AFAICS.

An oversight on my part, it seems, feel free to re-add it,


        Stefan
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Fri, 06 Jul 2012 21:41:02 GMT) Full text and rfc822 format available.
Notification sent to Damien Cassou <damien.cassou <at> gmail.com>:
bug acknowledged by developer. (Fri, 06 Jul 2012 21:41:02 GMT) Full text and rfc822 format available.

Message #16 received at 11817-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 11817-done <at> debbugs.gnu.org
Subject: Re: bug#11817: 24.1.50; Useless code in `kmacro-call-macro'
Date: Fri, 06 Jul 2012 17:35:46 -0400

Stefan Monnier wrote:

>> There used to be a "(Type e to repeat macro)" message after running a
>> macro. Now there isn't. I wonder why, since it has nothing to do with
>> the use of set-temporary-overlay-map AFAICS.
>
> An oversight on my part, it seems, feel free to re-add it,

Done.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 04 Aug 2012 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 12 years and 318 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.