GNU bug report logs - #11806
(setq load-path ..) of elisp-comp

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Makoto Fujiwara <makoto <at> ki.nu>
Subject: bug#11806: closed (Re: bug#11806: (setq load-path ..) of elisp-comp)
Date: Fri, 06 Jul 2012 19:45:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#11806: (setq load-path ..) of elisp-comp

which was filed against the automake package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 11806 <at> debbugs.gnu.org.

-- 
11806: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11806
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Jack Kelly <jack <at> jackkelly.name>
Cc: 11806-done <at> debbugs.gnu.org, Makoto Fujiwara <makoto <at> ki.nu>,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#11806: (setq load-path ..) of elisp-comp
Date: Fri, 06 Jul 2012 21:39:15 +0200

On 07/06/2012 10:34 AM, Stefano Lattarini wrote:
>
> Thanks.  I'll push the patch by this evening or afternoon if nobody
> else speaks out.
> 
Pushed now.  I'm thus closing this bug report.

Regards,
  Stefano

[Message part 3 (message/rfc822, inline)]

From: Makoto Fujiwara <makoto <at> ki.nu>
To: bug-automake <at> gnu.org
Subject: (setq load-path ..) of elisp-comp
Date: Thu, 28 Jun 2012 13:47:17 +0900

We have following line in automake-1.12.1/lib/elisp-comp.

    73  mkdir $tempdir
    74  cp "$@" $tempdir
    75  
    76  (
    77    cd $tempdir
    78    echo "(setq load-path (cons nil load-path))" > script
    79    $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $?
    80    mv *.elc ..
    81  ) || exit $?
    82  
    83  (exit 0); exit 0

 It seems to me the intention of line 78 is to set load-path
to add default directory on top of existing load-path.

 This 'script' is OK if the file to compile is only one in the
directory.

  But if some files are in the directory there and we will
compile file by file on the same directory, there may be a
possibility that some files load another file in the same
directory. In that case this 'script' fails to read such ones.

I do have problem compiling *.el files with tc-2.3.1 (svn version) 

Following patch fixes this type of problem, thanks a lot.

By the way, the same patch was once proposed as
  http://osdir.com/ml/sysutils.automake.patches/2003-01/msg00004.html
and fix seems to have made, but real line was dropped with
unknown reason.

--- lib/elisp-comp.orig	2012-06-01 22:47:10.000000000 +0900
+++ lib/elisp-comp	2012-06-28 13:28:44.000000000 +0900
@@ -75,7 +75,7 @@
 
 (
   cd $tempdir
-  echo "(setq load-path (cons nil load-path))" > script
+  echo "(setq load-path (cons \"../\" (cons nil load-path)))" > script
   $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $?
   mv *.elc ..
 ) || exit $?


Thanks again, 
---
Makoto Fujiwara, 
Chiba, Japan, Narita Airport and Disneyland prefecture.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.