From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 00:51:56 2012 Received: (at submit) by debbugs.gnu.org; 28 Jun 2012 04:51:56 +0000 Received: from localhost ([127.0.0.1]:33325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sk6hw-0005GH-C5 for submit@debbugs.gnu.org; Thu, 28 Jun 2012 00:51:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55623) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sk6ht-0005GA-RW for submit@debbugs.gnu.org; Thu, 28 Jun 2012 00:51:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sk6dp-0000gd-Gv for submit@debbugs.gnu.org; Thu, 28 Jun 2012 00:47:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:49945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sk6dp-0000gT-DW for submit@debbugs.gnu.org; Thu, 28 Jun 2012 00:47:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59763) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sk6dn-0004xz-OB for bug-automake@gnu.org; Thu, 28 Jun 2012 00:47:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sk6dl-0000et-KB for bug-automake@gnu.org; Thu, 28 Jun 2012 00:47:39 -0400 Received: from gw.ki.nu ([218.44.234.233]:29472 helo=mail.ki.nu) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sk6dl-0000by-3V for bug-automake@gnu.org; Thu, 28 Jun 2012 00:47:37 -0400 Received: from modena.i.ki.nu.ki.nu (modena.ipv6.ki.nu [IPv6:2001:218:463:1::232]) by mail.ki.nu (8.14.2/8.14.2) with ESMTP id q5S4grNm023306; Thu, 28 Jun 2012 13:42:53 +0900 (JST) Date: Thu, 28 Jun 2012 13:47:17 +0900 Message-ID: From: Makoto Fujiwara To: bug-automake@gnu.org Subject: (setq load-path ..) of elisp-comp User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/24.0.94 (x86_64--netbsd) MULE/6.0 (=?ISO-2022-JP?B?GyRCMlY7Nk4kGyhC?=) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-detected-operating-system: by eggs.gnu.org: NetBSD 3.0 (DF) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) We have following line in automake-1.12.1/lib/elisp-comp. 73 mkdir $tempdir 74 cp "$@" $tempdir 75 76 ( 77 cd $tempdir 78 echo "(setq load-path (cons nil load-path))" > script 79 $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? 80 mv *.elc .. 81 ) || exit $? 82 83 (exit 0); exit 0 It seems to me the intention of line 78 is to set load-path to add default directory on top of existing load-path. This 'script' is OK if the file to compile is only one in the directory. But if some files are in the directory there and we will compile file by file on the same directory, there may be a possibility that some files load another file in the same directory. In that case this 'script' fails to read such ones. I do have problem compiling *.el files with tc-2.3.1 (svn version) Following patch fixes this type of problem, thanks a lot. By the way, the same patch was once proposed as http://osdir.com/ml/sysutils.automake.patches/2003-01/msg00004.html and fix seems to have made, but real line was dropped with unknown reason. --- lib/elisp-comp.orig 2012-06-01 22:47:10.000000000 +0900 +++ lib/elisp-comp 2012-06-28 13:28:44.000000000 +0900 @@ -75,7 +75,7 @@ ( cd $tempdir - echo "(setq load-path (cons nil load-path))" > script + echo "(setq load-path (cons \"../\" (cons nil load-path)))" > script $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? mv *.elc .. ) || exit $? Thanks again, --- Makoto Fujiwara, Chiba, Japan, Narita Airport and Disneyland prefecture. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 06:54:12 2012 Received: (at 11806) by debbugs.gnu.org; 28 Jun 2012 10:54:12 +0000 Received: from localhost ([127.0.0.1]:34451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkCMV-0007tj-K0 for submit@debbugs.gnu.org; Thu, 28 Jun 2012 06:54:11 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:36924) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkCMS-0007tb-TW for 11806@debbugs.gnu.org; Thu, 28 Jun 2012 06:54:09 -0400 Received: by bkty8 with SMTP id y8so1772134bkt.3 for <11806@debbugs.gnu.org>; Thu, 28 Jun 2012 03:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=LhMukqrf9+Hj+K3wFanmc8R2rPqe3TbVXHviLEgMyuk=; b=Kjd37JARcO0G1C1jaFawUo2TSDlwrvpu3NVOaVoHY7NqwiIWZ+0aScz6zDjtlAHA4U 9CIWLd3XLO6SivPXSqTMqMUaUVfFJvrFiTe8iiCq6+c4+CDn8/cI4v2TX0c1PeZ5iH4x rVrwksXWEfwxvplBbqqmB4zY/kIzn87s+cPmWa6p8RjfzU2sVIot2vK/53rlUOYth0h/ 5bL1lm0dkYdH0MMDFpS7eYG9u805hHCczmR+/b/rH+kKSVlkufeUZSTwZIeQBp4d1bat ZqvUPS6KrhqtobEH+CnkvC3J97NxnzI8LhFaWRmhFRiXBGXE0oIUS8uYvRFh51tmEX5W NxEA== Received: by 10.204.154.74 with SMTP id n10mr224652bkw.60.1340880596361; Thu, 28 Jun 2012 03:49:56 -0700 (PDT) Received: from [87.5.99.184] (host184-99-dynamic.5-87-r.retail.telecomitalia.it. [87.5.99.184]) by mx.google.com with ESMTPS id hg13sm1791651bkc.7.2012.06.28.03.49.54 (version=SSLv3 cipher=OTHER); Thu, 28 Jun 2012 03:49:55 -0700 (PDT) Message-ID: <4FEC36C9.2040008@gmail.com> Date: Thu, 28 Jun 2012 12:49:45 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Makoto Fujiwara Subject: Re: bug#11806: (setq load-path ..) of elisp-comp References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806 Cc: 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hi Makoto. Thanks for the report and the patch. On 06/28/2012 06:47 AM, Makoto Fujiwara wrote: > We have following line in automake-1.12.1/lib/elisp-comp. > > 73 mkdir $tempdir > 74 cp "$@" $tempdir > 75 > 76 ( > 77 cd $tempdir > 78 echo "(setq load-path (cons nil load-path))" > script > 79 $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? > 80 mv *.elc .. > 81 ) || exit $? > 82 > 83 (exit 0); exit 0 > > It seems to me the intention of line 78 is to set load-path > to add default directory on top of existing load-path. > > This 'script' is OK if the file to compile is only one in the > directory. > > But if some files are in the directory there and we will > compile file by file on the same directory, there may be a > possibility that some files load another file in the same > directory. In that case this 'script' fails to read such ones. > > I do have problem compiling *.el files with tc-2.3.1 (svn version) > Could you expose such problems in a minimal test case? This way, I could add it to the automake testsuite, to ensure the issue doesn't represent itself in the future. Thanks. > Following patch fixes this type of problem, thanks a lot. > > By the way, the same patch was once proposed as > http://osdir.com/ml/sysutils.automake.patches/2003-01/msg00004.html > and fix seems to have made, but real line was dropped with > unknown reason. > > --- lib/elisp-comp.orig 2012-06-01 22:47:10.000000000 +0900 > +++ lib/elisp-comp 2012-06-28 13:28:44.000000000 +0900 > @@ -75,7 +75,7 @@ > > ( > cd $tempdir > - echo "(setq load-path (cons nil load-path))" > script > + echo "(setq load-path (cons \"../\" (cons nil load-path)))" > script > $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? > mv *.elc .. > ) || exit $? > > The patch seems small and harmless, but unfortunately I know nothing at all about Lisp or Emacs, so I can't judge whether such a change could have unintended consequences. Perchance someone more knowledgeable than me in this area is reading the thread, and can chime in? Otherwise I will go ahead and push the patch in 72 hours. Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 18:36:37 2012 Received: (at 11806) by debbugs.gnu.org; 28 Jun 2012 22:36:37 +0000 Received: from localhost ([127.0.0.1]:35937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkNKG-0007qk-SK for submit@debbugs.gnu.org; Thu, 28 Jun 2012 18:36:37 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:58556) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkNKE-0007qb-1a for 11806@debbugs.gnu.org; Thu, 28 Jun 2012 18:36:36 -0400 Received: by werc1 with SMTP id c1so785124wer.3 for <11806@debbugs.gnu.org>; Thu, 28 Jun 2012 15:32:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=xuDONlCWfFBaF1iDDj8IWFfjBA+zI/AI/NXjLDtdYaQ=; b=uIduJZGJ1ZwpBrQnXV5b7l6PPo2K+Q5OuW44gDHxjrb4BqRQtqxmqd5ke/bzft3hmq 0+s4L736lXt+73k1v1fGawtvKXzwKEe+YgRbJRH6wOylx1ozylsf6UVzDzsqvsT2l/F6 992HzqiNufcnuBMJBsnG2nm7ReQdJMUgpc/FJMJ4YCPgYqLLFrgeTLxcjHG9pUi9YuBX xOqPBX/Y+fnzPaF9a7qOzjxgBMP+IF9yBFybczOS8zQUm7j++hKiIKIXiPMHa9WfohNH 1GYHDv9NoEn0E1tKOWDcZkVZFxttq307+c1GANU2jIG5kvPPjRaeEiEJdgYNmDQl3/Ba G5VA== MIME-Version: 1.0 Received: by 10.216.143.213 with SMTP id l63mr2110989wej.117.1340922738741; Thu, 28 Jun 2012 15:32:18 -0700 (PDT) Received: by 10.194.62.172 with HTTP; Thu, 28 Jun 2012 15:32:18 -0700 (PDT) In-Reply-To: <4FEC36C9.2040008@gmail.com> References: <4FEC36C9.2040008@gmail.com> Date: Fri, 29 Jun 2012 08:32:18 +1000 X-Google-Sender-Auth: Be7MRH6Va7S3BtRUtXCDphCKoXI Message-ID: Subject: Re: bug#11806: (setq load-path ..) of elisp-comp From: Jack Kelly To: Stefano Lattarini Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806 Cc: Makoto Fujiwara , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Thu, Jun 28, 2012 at 8:49 PM, Stefano Lattarini wrote: > On 06/28/2012 06:47 AM, Makoto Fujiwara wrote: >> I do have problem compiling *.el files with tc-2.3.1 (svn version) I think this is the relevant Makefile.am: http://code.google.com/p/tcode/source/browse/trunk/tc/lisp/Makefile.am It confuses me thoroughly. > Could you expose such problems in a minimal test case? =A0This way, I > could add it to the automake testsuite, to ensure the issue doesn't > represent itself in the future. =A0Thanks. > >> Following patch fixes this type of problem, thanks a lot. >> >> By the way, the same patch was once proposed as >> =A0 http://osdir.com/ml/sysutils.automake.patches/2003-01/msg00004.html >> and fix seems to have made, but real line was dropped with >> unknown reason. >> >> --- lib/elisp-comp.orig =A0 =A0 =A0 2012-06-01 22:47:10.000000000 +0900 >> +++ lib/elisp-comp =A0 =A02012-06-28 13:28:44.000000000 +0900 >> @@ -75,7 +75,7 @@ >> >> =A0( >> =A0 =A0cd $tempdir >> - =A0echo "(setq load-path (cons nil load-path))" > script >> + =A0echo "(setq load-path (cons \"../\" (cons nil load-path)))" > scrip= t >> =A0 =A0$EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? >> =A0 =A0mv *.elc .. >> =A0) || exit $? >> >> > The patch seems small and harmless, but unfortunately I know nothing at > all about Lisp or Emacs, so I can't judge whether such a change could > have unintended consequences. =A0Perchance someone more knowledgeable tha= n > me in this area is reading the thread, and can chime in? =A0Otherwise I > will go ahead and push the patch in 72 hours. I'm no elisp master, but here's what I see is happening: * Developer defines something like lisp_LISP =3D foo.el bar.el baz.el * baz.el (say) depends on quux.el, in the same directory but not listed in the primary. * At `make' time, everything in lisp_LISP is copied to a subdirectory and batch-byte-compile is called on all those files. * Because quux.el wasn't copied over, the compile fails. * Adding the parent directory to load-path might fix that, but I wonder if it will still break on VPATH builds? Maybe the correct answer is to add ../$(srcdir) or $(abs_srcdir) insted. * Why (in the .el files) is the developer depending on a file that's not being compiled? will this cause automake to silently do the wrong thing if a new .el file has been listed and Makefile.am doesn't get updated? Now you can go ahead and install an incomplete package. * Should the current directory come before the source directory? There's another (potential) problem. The script that elisp-comp creates is called "script". Does it make sense to allow files without a .el extension to appear in a _LISP primary? Currently, automake lets you get away with it, but it will only compile *.el anyway (even though it copies $@ into the temporary dir). I don't know enough about elisp to say, but if that's fixed, then "script" should be given a better filename (using mktemp or something) so it doesn't clobber a user's script. -- Jack From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 29 21:24:08 2012 Received: (at 11806) by debbugs.gnu.org; 30 Jun 2012 01:24:08 +0000 Received: from localhost ([127.0.0.1]:38075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkmPv-0002QG-LV for submit@debbugs.gnu.org; Fri, 29 Jun 2012 21:24:08 -0400 Received: from gw.ki.nu ([218.44.234.233]:19857 helo=mail.ki.nu) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkmPr-0002Q1-Vy for 11806@debbugs.gnu.org; Fri, 29 Jun 2012 21:24:06 -0400 Received: from modena.i.ki.nu.ki.nu (modena.ipv6.ki.nu [IPv6:2001:218:463:1::232]) by mail.ki.nu (8.14.2/8.14.2) with ESMTP id q5U1ExZE001814; Sat, 30 Jun 2012 10:14:59 +0900 (JST) Date: Sat, 30 Jun 2012 10:19:32 +0900 Message-ID: From: Makoto Fujiwara To: Jack Kelly Subject: Re: bug#11806: (setq load-path ..) of elisp-comp In-Reply-To: References: <4FEC36C9.2040008@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?ISO-2022-JP-2?B?R29qGyQoRCtXGyhC?=) APEL/10.8 Emacs/24.0.94 (x86_64--netbsd) MULE/6.0 (=?ISO-2022-JP?B?GyRCMlY7Nk4kGyhC?=) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11806 Cc: Stefano Lattarini , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) | To: Stefano Lattarini | From: Jack Kelly | Subject: Re: bug#11806: (setq load-path ..) of elisp-comp | Date: Fri, 29 Jun 2012 08:32:18 +1000 | Message-ID: > I'm no elisp master, but here's what I see is happening: > * Developer defines something like lisp_LISP = foo.el bar.el baz.el > * baz.el (say) depends on quux.el, in the same directory but not > listed in the primary. > * At `make' time, everything in lisp_LISP is copied to a subdirectory > and batch-byte-compile is called on all those files. > * Because quux.el wasn't copied over, the compile fails. Thanks for reviewing Makefile.am setup. The reason 'quux.el' (in above example) is not listed, is that it should not be byte-compiled by some reason. It is intentionally excluded from the to-be-compiled list. I didn't get that point. Thanks a lot. I will either adjust Makefile.am or pursue not using automake, or insist to depend automake. With your advice for VPATH issue, I am now using attached patch, thanks a lot, --- Makoto Fujiwara, Chiba, Japan, Narita Airport and Disneyland prefecture. --- lib/elisp-comp.orig 2012-01-31 20:41:18.000000000 +0900 +++ lib/elisp-comp 2012-04-13 22:14:39.000000000 +0900 @@ -62,6 +62,7 @@ fi tempdir=elc.$$ +currdir=`pwd` # Cleanup the temporary directory on exit. trap 'ret=$?; rm -rf "$tempdir" && exit $ret' 0 @@ -72,7 +73,7 @@ ( cd $tempdir - echo "(setq load-path (cons nil load-path))" > script + echo "(setq load-path (cons \"$currdir\" (cons nil load-path)))" > script $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? mv *.elc .. ) || exit $? From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 30 19:08:02 2012 Received: (at 11806) by debbugs.gnu.org; 30 Jun 2012 23:08:02 +0000 Received: from localhost ([127.0.0.1]:39603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sl6lm-0005XW-Fg for submit@debbugs.gnu.org; Sat, 30 Jun 2012 19:08:02 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:64885) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sl6lj-0005X6-Us for 11806@debbugs.gnu.org; Sat, 30 Jun 2012 19:08:01 -0400 Received: by wibhm6 with SMTP id hm6so1824589wib.15 for <11806@debbugs.gnu.org>; Sat, 30 Jun 2012 16:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=2wc6CenfN2jEbqmXoE582k463flkeujFqRE8taDI8bI=; b=zBWQwpaB4sLNaxDueV4mPrrnDDH7HGtkSu3dU6JIed0qT2ZNIetUpxTCtbp804/qZ/ ImE5asWex9GuCQ4sUk2cKsPhLrt/OFBHKOPpFYah/dqmbIHvu4nds6W7TCz9CY96oTaV dcLULpv7aXsMGwRYOaNuZ/iNPkYP6MKVSRZ0wTrr8p/JPjC2Y6SjGSOpWBxYGeRo6R1q tIgkamYL39WowJUivQf8q//E9KNV9tRQlVGIXvjz6QxIO2NfVlgYIKDQwGnAUKz/4APL f4rYTq3YvZ6Sk6FPUxKs7x8yaPNFD1aLs8/MrZMhTN4nx5Vg5a8PIKyX5GZAt1vTQlqU I5wA== MIME-Version: 1.0 Received: by 10.180.82.42 with SMTP id f10mr7149144wiy.22.1341097412950; Sat, 30 Jun 2012 16:03:32 -0700 (PDT) Received: by 10.194.62.172 with HTTP; Sat, 30 Jun 2012 16:03:32 -0700 (PDT) In-Reply-To: References: <4FEC36C9.2040008@gmail.com> Date: Sun, 1 Jul 2012 09:03:32 +1000 X-Google-Sender-Auth: hOEeKyMmtOo1DtPdQUnfxbWQyaI Message-ID: Subject: Re: bug#11806: (setq load-path ..) of elisp-comp From: Jack Kelly To: Makoto Fujiwara Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806 Cc: Stefano Lattarini , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sat, Jun 30, 2012 at 11:19 AM, Makoto Fujiwara wrote: > With your advice for VPATH issue, I am now using attached patch, > thanks a lot, > --- lib/elisp-comp.orig 2012-01-31 20:41:18.000000000 +0900 > +++ lib/elisp-comp 2012-04-13 22:14:39.000000000 +0900 > @@ -62,6 +62,7 @@ > fi > > tempdir=elc.$$ > +currdir=`pwd` > > # Cleanup the temporary directory on exit. > trap 'ret=$?; rm -rf "$tempdir" && exit $ret' 0 > @@ -72,7 +73,7 @@ > > ( > cd $tempdir > - echo "(setq load-path (cons nil load-path))" > script > + echo "(setq load-path (cons \"$currdir\" (cons nil load-path)))" > script > $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? > mv *.elc .. > ) || exit $? Hi, Unfortunately your patch doesn't quite work, because in a VPATH build the build dir is not the sourcedir, so when you set $currdir, you are setting the wrong path. I'm not sure of the best way to fix this. The rules for calling elisp-comp could be updated so that $(abs_srcdir) is passed along: abs_srcdir="$(abs_srcdir)" EMACS="$(EMACS)" $(SHELL) $(elisp_comp) "$$@" || exit 1; \ , which is then added to load-path. elisp-comp would still need a patch, but that's ok. As to providing test cases, something like this should work: configure.ac: AC_INIT([foo], [bar], [baz@quux.net]) AM_INIT_AUTOMAKE([foreign]) AM_PATH_LISPDIR AC_CONFIG_FILES([Makefile]) AC_OUTPUT Makefile.am: lisp_LISP = foo.el lisp_DATA = bar.el foo.el: (require 'bar) bar.el: (provide 'bar) Once elisp-comp (and whatever else) is fixed, this setup should survive a ./configure && make in both a normal and VPATH build. (Aside: my copyright paperwork should still be in order. Email me off-list if it is not.) -- Jack From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 05 14:01:06 2012 Received: (at 11806) by debbugs.gnu.org; 5 Jul 2012 18:01:07 +0000 Received: from localhost ([127.0.0.1]:50919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmqMS-0006s4-6L for submit@debbugs.gnu.org; Thu, 05 Jul 2012 14:01:05 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:39718) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmqMO-0006rb-RZ; Thu, 05 Jul 2012 14:01:02 -0400 Received: by bkty7 with SMTP id y7so620392bkt.3 for ; Thu, 05 Jul 2012 10:56:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type; bh=i01DvJgZNAgt2sfyxq99n2tgBDYZ1NZdcbygKHZ5gNw=; b=eXsjam06AqxvtqB03hxI6v3/E+Zcajl4QH/wBRodTH7VheQp8vgEM3wyVsQHy30IJG a+yrPZ9BZHdCfc6uQvferMKrAe5Knk8Mf22wvyBjXVgQLqprCYGt447ak1AZ4WxTRNt2 Qjh/NEF9lgD3ywZTnbstWOZhT3l6KDirxizd8I2LoJLnmn+4g09ueazwh3EwlmBKY96Z Ml0wL7Tx0ahBQMlmkO1JceG23YRxohWtIboq4TA7kuFuImmJ7phynegn+hUA8hm23I/Z xhOcj8B2KNL0g/iXSROYeyk91KjTwe4IghrVv1dlMjwBC0Y+kK94Rnz3PR1/NeTgLMh+ ZieQ== Received: by 10.204.154.74 with SMTP id n10mr14088598bkw.60.1341510966138; Thu, 05 Jul 2012 10:56:06 -0700 (PDT) Received: from [87.8.100.250] (host250-100-dynamic.8-87-r.retail.telecomitalia.it. [87.8.100.250]) by mx.google.com with ESMTPS id gq2sm14961355bkc.13.2012.07.05.10.56.03 (version=SSLv3 cipher=OTHER); Thu, 05 Jul 2012 10:56:05 -0700 (PDT) Message-ID: <4FF5D532.3010905@gmail.com> Date: Thu, 05 Jul 2012 19:56:02 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Jack Kelly Subject: Re: bug#11806: (setq load-path ..) of elisp-comp References: <4FEC36C9.2040008@gmail.com> In-Reply-To: Content-Type: multipart/mixed; boundary="------------050708010803040405020303" X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 11806 Cc: "automake-patches@gnu.org" , Makoto Fujiwara , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.9 (/) This is a multi-part message in MIME format. --------------050708010803040405020303 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit tags 11806 + patch thanks On 07/01/2012 01:03 AM, Jack Kelly wrote: > On Sat, Jun 30, 2012 at 11:19 AM, Makoto Fujiwara wrote: >> With your advice for VPATH issue, I am now using attached patch, >> thanks a lot, >> --- lib/elisp-comp.orig 2012-01-31 20:41:18.000000000 +0900 >> +++ lib/elisp-comp 2012-04-13 22:14:39.000000000 +0900 >> @@ -62,6 +62,7 @@ >> fi >> >> tempdir=elc.$$ >> +currdir=`pwd` >> >> # Cleanup the temporary directory on exit. >> trap 'ret=$?; rm -rf "$tempdir" && exit $ret' 0 >> @@ -72,7 +73,7 @@ >> >> ( >> cd $tempdir >> - echo "(setq load-path (cons nil load-path))" > script >> + echo "(setq load-path (cons \"$currdir\" (cons nil load-path)))" > script >> $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? >> mv *.elc .. >> ) || exit $? > > Hi, > > Unfortunately your patch doesn't quite work, because in a VPATH build > the build dir is not the sourcedir, so when you set $currdir, you are > setting the wrong path. > > I'm not sure of the best way to fix this. The rules for calling > elisp-comp could be updated so that $(abs_srcdir) is passed along: > > abs_srcdir="$(abs_srcdir)" EMACS="$(EMACS)" $(SHELL) > $(elisp_comp) "$$@" || exit 1; \ > > , which is then added to load-path. elisp-comp would still need a > patch, but that's ok. > > As to providing test cases, something like this should work: > > configure.ac: > > AC_INIT([foo], [bar], [baz@quux.net]) > AM_INIT_AUTOMAKE([foreign]) > AM_PATH_LISPDIR > AC_CONFIG_FILES([Makefile]) > AC_OUTPUT > > Makefile.am: > > lisp_LISP = foo.el > lisp_DATA = bar.el > > foo.el: > > (require 'bar) > > bar.el: > > (provide 'bar) > > Once elisp-comp (and whatever else) is fixed, this setup should > survive a ./configure && make in both a normal and VPATH build. > Thanks. I've condensed a patch from you explanation (see attachment). I will push it shortly if there are no objections. > (Aside: my copyright paperwork should still be in order. Email me > off-list if it is not.) > I don't have an account on fencepost, so I can't check this, sorry. Since your part of the changes are short enough to be classified as "tiny change", I've just added a 'Copyright-paperwork-exempt' field to the patch to get the easiest way out. > -- Jack Thanks, Stefano --------------050708010803040405020303 Content-Type: text/x-diff; name="0001-lisp-better-support-of-VPATH-builds.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-lisp-better-support-of-VPATH-builds.patch" >From 5c94d97d90aa5b731a11c538f8b835e57bf39fee Mon Sep 17 00:00:00 2001 Message-Id: <5c94d97d90aa5b731a11c538f8b835e57bf39fee.1341510886.git.stefano.lattarini@gmail.com> From: Jack Kelly Date: Thu, 5 Jul 2012 18:50:37 +0200 Subject: [PATCH] lisp: better support of VPATH builds Fixes automake bug#11806. * lib/am/lisp.am: Pass the value of '$(abs_srcdir)' to the elisp-compile script in the environment. * lib/elisp-comp: Add the vale of '$abs_srcdir' to the emacs load-path. * t/lisp-pr11806.sh: New test. * t/list-of-tests.mk: Add it. Copyright-paperwork-exempt: yes Co-authored-by: Stefano Lattarini Reported-by: Makoto Fujiwara Signed-off-by: Stefano Lattarini --- lib/am/lisp.am | 3 ++- lib/elisp-comp | 4 ++-- t/lisp-pr11806.sh | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++ t/list-of-tests.mk | 1 + 4 files changed, 56 insertions(+), 3 deletions(-) create mode 100755 t/lisp-pr11806.sh diff --git a/lib/am/lisp.am b/lib/am/lisp.am index ba5c92a..050d7dc 100644 --- a/lib/am/lisp.am +++ b/lib/am/lisp.am @@ -36,7 +36,8 @@ elc-stamp: $(LISP) done; \ ## Finally call elisp-comp for all files. shift; \ - EMACS="$(EMACS)" $(SHELL) $(elisp_comp) "$$@" || exit 1; \ + abs_srcdir="$(abs_srcdir)" EMACS="$(EMACS)" $(SHELL) \ + $(elisp_comp) "$$@" || exit 1; \ else : ; fi @mv -f elc-temp $@ diff --git a/lib/elisp-comp b/lib/elisp-comp index 7766db4..b646640 100755 --- a/lib/elisp-comp +++ b/lib/elisp-comp @@ -1,7 +1,7 @@ #!/bin/sh # Copyright (C) 1995-2012 Free Software Foundation, Inc. -scriptversion=2010-02-06.18; # UTC +scriptversion=2012-07-05.17; # UTC # Franc,ois Pinard , 1995. # @@ -75,7 +75,7 @@ cp "$@" $tempdir ( cd $tempdir - echo "(setq load-path (cons nil load-path))" > script + echo "(setq load-path (cons \"$abs_srcdir\" (cons nil load-path)))" > script $EMACS -batch -q -l script -f batch-byte-compile *.el || exit $? mv *.elc .. ) || exit $? diff --git a/t/lisp-pr11806.sh b/t/lisp-pr11806.sh new file mode 100755 index 0000000..c372ea5 --- /dev/null +++ b/t/lisp-pr11806.sh @@ -0,0 +1,51 @@ +#! /bin/sh +# Copyright (C) 2012 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Compiling .el files that requires each other in a VPATH build. +# See automake bug#11806. + +required=emacs +. ./defs || exit 1 + +cat >> configure.ac << 'END' +AM_PATH_LISPDIR +AC_OUTPUT +END + +cat > Makefile.am << 'END' +lisp_LISP = foo.el +lisp_DATA = bar.el +END + +echo "(require 'bar)" > foo.el +echo "(provide 'bar)" > bar.el + +$ACLOCAL +$AUTOCONF +$AUTOMAKE -a + +mkdir build +cd build +../configure +$MAKE +test -f foo.elc +cd .. + +./configure +$MAKE +test -f foo.elc + +: diff --git a/t/list-of-tests.mk b/t/list-of-tests.mk index 852b87a..dd88819 100644 --- a/t/list-of-tests.mk +++ b/t/list-of-tests.mk @@ -640,6 +640,7 @@ t/lisp6.sh \ t/lisp7.sh \ t/lisp8.sh \ t/lispdry.sh \ +t/lisp-pr11806.sh \ t/listval.sh \ t/location.sh \ t/longline.sh \ -- 1.7.9.5 --------------050708010803040405020303-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 05 18:02:20 2012 Received: (at 11806) by debbugs.gnu.org; 5 Jul 2012 22:02:20 +0000 Received: from localhost ([127.0.0.1]:51103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Smu7v-00079F-Uq for submit@debbugs.gnu.org; Thu, 05 Jul 2012 18:02:20 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:36746) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Smu7t-000796-Md for 11806@debbugs.gnu.org; Thu, 05 Jul 2012 18:02:18 -0400 Received: by bkty7 with SMTP id y7so772825bkt.3 for <11806@debbugs.gnu.org>; Thu, 05 Jul 2012 14:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=WxBdJhpmrho8y69LQTeeTkNI0QZsAxHjd6HyYDn5wFQ=; b=RFAi7gcJ/A7bBSViTKAAi8cWJXzZc2thMiEGKe8xlno0xYPGRVh4oTSHa0HHDkV0dh xL9EOBRJ6Wb+wxsgezQh6yMvJgkqqnRsNZBit87QfpydAm590DGWDoMr2kxI9x8yiMta zb0oAn0GyR+vt/Ch8vhqaZa2x8POsYkivhfWpz7WTiHBDM0Ig90KSfRW8G/6zhUuB7VP HSNcJlDfpeP8Jk3WEW1nQEFDj16GUoNDn/uZsFcPVAf2q0B8rT85q7LDyRzl10Pyw/3V htP3uZbnbY2V6CNrLc7YKmcA1Olutrg4zAQ7tDB1PUd9qvh7XnHFA6A4ox3UXsFYmaTU iJFQ== Received: by 10.205.127.77 with SMTP id gz13mr9846284bkc.17.1341525442183; Thu, 05 Jul 2012 14:57:22 -0700 (PDT) Received: from [95.244.95.248] (host248-95-dynamic.244-95-r.retail.telecomitalia.it. [95.244.95.248]) by mx.google.com with ESMTPS id u8sm21298626bks.0.2012.07.05.14.57.20 (version=SSLv3 cipher=OTHER); Thu, 05 Jul 2012 14:57:21 -0700 (PDT) Message-ID: <4FF60DB7.2040504@gmail.com> Date: Thu, 05 Jul 2012 23:57:11 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Jack Kelly Subject: Re: bug#11806: (setq load-path ..) of elisp-comp References: <4FEC36C9.2040008@gmail.com> <4FF5D532.3010905@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806 Cc: Makoto Fujiwara , "automake-patches@gnu.org" , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hi Jack, thanks for the feedback. On 07/05/2012 11:33 PM, Jack Kelly wrote: > On Fri, Jul 6, 2012 at 3:56 AM, Stefano Lattarini > wrote: >> On 07/01/2012 01:03 AM, Jack Kelly wrote: >> Thanks. I've condensed a patch from you explanation (see attachment). >> I will push it shortly if there are no objections. > > Though I doubt it makes any practical difference, the only thing I > would suggest is to cons the load-path so the current directory is > before $abs_srcdir: echo "(setq load-path (cons nil (cons > \"$abs_srcdir\" load-path)))" > script > > That way, the build directory (where all the .el files being compiled > actually are), then the src directory, then everywhere else will be > searched. > Usually I'd agree, and in fact I had done as you're suggesting in a previous attempt; but that caused the test 'lisp3.sh' to fail :-/ With the patch I've posted, the testsuite remains clean at least. So I say we commit my patch: albeit suboptimal, and somewhat reeking of cargo-cult programming, it solves the OP issue. If someone then wants to venture in refactoring, fixing and cleaning up the elisp support in Automake -- be him my guest! As for more, I'm not knowledgeable nor motivated enough to venture in something like that at the moment. Sorry. > Another thing I noticed from `man emacs': There's a --eval command > like argument, so generating that subscript is technically > unnecessary. Try something like: > > $EMACS -batch -q --eval "(setq load-path (cons nil (cons > \"$abs_srcdir\" load-path)))" -f batch-byte-compile *.el || exit $? > > Since elisp-comp doesn't handle stamps but only a temporary directory, > I think you might even be able to call it directly from make using > something like: > > $(EMACS) -batch -q --eval "(setq load-path (cons \"$(srcdir)\" > load-path))" -f batch-byte-compile $(LISP) || exit 1 > I'm not sure how this would interact with $(LISP) containing '.el' files in a subdirectory ... But then, I guess all the current implementation of byte-compilation for elisp sources is probably brittle and buggy in such a setup anyway, I guess, so my misgivings might be unjustified: Anyway, I'd rather not touch the existing code, for fear of introducing regressions. But patches would be mostly welcome (if coming with proper testsuite enhancement). Thanks, Stefano From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 05 20:47:07 2012 Received: (at 11806) by debbugs.gnu.org; 6 Jul 2012 00:47:07 +0000 Received: from localhost ([127.0.0.1]:51153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmwhO-0002Lm-Vj for submit@debbugs.gnu.org; Thu, 05 Jul 2012 20:47:07 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:45362) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SmwhL-0002LZ-Sz for 11806@debbugs.gnu.org; Thu, 05 Jul 2012 20:47:05 -0400 Received: by wibhr14 with SMTP id hr14so198789wib.15 for <11806@debbugs.gnu.org>; Thu, 05 Jul 2012 17:42:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=D3GfcmXD+WULrbGOXsJv6BNVECtJmjiWqcA3w3KsFlk=; b=I9uhANsJpdBs1TAh3SLhGjGMAw0X9b412lDjNY/NdSPDvz9GiGAwUM318S3qBFX7qI wF7W6gmG3kTq4YsrABRZw+w60o8SP9ogjTDwBN2FPbDWh6oAJX+mng/ZAqPgotsceyBO 1gwhhEDSHr8j4TXFGB2WBYSmDKc+gup7Q7NrPwHfYBSUZyvZxcgWS0KvMTiJ6w3gCUSJ ExORJCNUmfTudVUyJH0TllrsSwQ4H5TnkDfeeYNgSQRkcG5uKWmgPmwmk5MAuOcabKh1 h0fv0yzz4YreQD5jSKL2aTGFs1tBeRDw12c3bwI/P0GRzAbvkXiKaTukNAzwPGp5er5O /71g== MIME-Version: 1.0 Received: by 10.216.59.130 with SMTP id s2mr6315700wec.25.1341535325256; Thu, 05 Jul 2012 17:42:05 -0700 (PDT) Received: by 10.194.62.172 with HTTP; Thu, 5 Jul 2012 17:42:05 -0700 (PDT) In-Reply-To: <4FF60DB7.2040504@gmail.com> References: <4FEC36C9.2040008@gmail.com> <4FF5D532.3010905@gmail.com> <4FF60DB7.2040504@gmail.com> Date: Fri, 6 Jul 2012 10:42:05 +1000 X-Google-Sender-Auth: uRRF93wds7JZjw8zUrtGlPhsW4w Message-ID: Subject: Re: bug#11806: (setq load-path ..) of elisp-comp From: Jack Kelly To: Stefano Lattarini Content-Type: text/plain; charset=ISO-8859-1 X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806 Cc: Makoto Fujiwara , "automake-patches@gnu.org" , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Fri, Jul 6, 2012 at 7:57 AM, Stefano Lattarini wrote: > Usually I'd agree, and in fact I had done as you're suggesting in a > previous attempt; but that caused the test 'lisp3.sh' to fail :-/ > With the patch I've posted, the testsuite remains clean at least. > > So I say we commit my patch: albeit suboptimal, and somewhat reeking > of cargo-cult programming, it solves the OP issue. I would like to have a crack at rewriting some of the elisp stuff, but I can make no promises as to when that will actually happen. Therefore I agree with you: commit the patch and we'll deal with the refactoring if/when it arrives. -- Jack From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 04:39:43 2012 Received: (at 11806) by debbugs.gnu.org; 6 Jul 2012 08:39:44 +0000 Received: from localhost ([127.0.0.1]:51410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sn44l-0005FT-Nb for submit@debbugs.gnu.org; Fri, 06 Jul 2012 04:39:43 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:50588) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sn44j-0005FJ-8d for 11806@debbugs.gnu.org; Fri, 06 Jul 2012 04:39:42 -0400 Received: by bkty7 with SMTP id y7so994283bkt.3 for <11806@debbugs.gnu.org>; Fri, 06 Jul 2012 01:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=j4W7wDWau8hR4taz2g+CKSJJew4SaZjtW8QB9qacXvo=; b=TfY8Fv5F+rttoGbyXXir9nMNrS1XabTJUMK0N7g5eT7MVbZuId5l5KgZSL+abSVwZl +S1zxU+hHKylamZSocrSA3WrHe+O4q+CIlL6/cVRaeipObTTZ4OmQqtC4YDQhBAcCV1O iIPtgImh0FP/NXwS85N0odv8XzqkxrjDlolqv0EQBYMnghzTC3ME+jA7k3+kAfuOMyfr DwCJI+12Fkc/stJBIeoUkqxRwIJP9e06KnJ3eKMkWtmvgvAmdwF2Q2Ft8yfIfbEkGjMk GCf0B2RKTmz2nyZEJvqXWzL0BHE0I9ckSaDtJI0JQzsWbdbgD2a5yC2DcnMfNO/G9AKl oNWw== Received: by 10.205.117.3 with SMTP id fk3mr15411411bkc.136.1341563683114; Fri, 06 Jul 2012 01:34:43 -0700 (PDT) Received: from [87.4.96.201] (host201-96-dynamic.4-87-r.retail.telecomitalia.it. [87.4.96.201]) by mx.google.com with ESMTPS id o4sm21745184bkv.15.2012.07.06.01.34.40 (version=SSLv3 cipher=OTHER); Fri, 06 Jul 2012 01:34:41 -0700 (PDT) Message-ID: <4FF6A31E.8040604@gmail.com> Date: Fri, 06 Jul 2012 10:34:38 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Jack Kelly Subject: Re: bug#11806: (setq load-path ..) of elisp-comp References: <4FEC36C9.2040008@gmail.com> <4FF5D532.3010905@gmail.com> <4FF60DB7.2040504@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806 Cc: Makoto Fujiwara , "automake-patches@gnu.org" , 11806@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 07/06/2012 02:42 AM, Jack Kelly wrote: > On Fri, Jul 6, 2012 at 7:57 AM, Stefano Lattarini > wrote: >> Usually I'd agree, and in fact I had done as you're suggesting in a >> previous attempt; but that caused the test 'lisp3.sh' to fail :-/ >> With the patch I've posted, the testsuite remains clean at least. >> >> So I say we commit my patch: albeit suboptimal, and somewhat reeking >> of cargo-cult programming, it solves the OP issue. > > I would like to have a crack at rewriting some of the elisp stuff, but > I can make no promises as to when that will actually happen. > No need to make any such promise. Just know that if you find time for such a rewrite, I'd be happy to help out and try my best to have it integrated. > Therefore I agree with you: commit the patch and we'll deal with the > refactoring if/when it arrives. > Thanks. I'll push the patch by this evening or afternooon if nobody else speaks out. Best regards, Stefano From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 06 15:44:25 2012 Received: (at 11806-done) by debbugs.gnu.org; 6 Jul 2012 19:44:25 +0000 Received: from localhost ([127.0.0.1]:53207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnES1-000656-71 for submit@debbugs.gnu.org; Fri, 06 Jul 2012 15:44:25 -0400 Received: from mail-bk0-f44.google.com ([209.85.214.44]:39045) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnERz-00064z-P8 for 11806-done@debbugs.gnu.org; Fri, 06 Jul 2012 15:44:24 -0400 Received: by bkty7 with SMTP id y7so1502186bkt.3 for <11806-done@debbugs.gnu.org>; Fri, 06 Jul 2012 12:39:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:mime-version:to:cc:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=OBtDJ3Br8UcxB8pNLEgxgYrjQU9F9tfQggb2SBCYbTQ=; b=1HhoeOt29HSjhSH0AalH314CexfL3C49gXol+FdHr7WoCbhplfzCsR7pZqqUYSdbCG rw5SQ7GcIZINMWyVG6nM2J4+Gcru/K2+8VG/Hf21wsEjqTjDXoG3DkTlhJt0bhKMRzV8 1zoRmf5FAEwK74BveVVCdZkCaNJyEr27p2wecjVn+jvVIeRhRTPoRzyyBDbmASfacsiw KMoMb7HZnvywI9ZdVdDP71qlhp6TBGRsgKjnHlfYHdcMkLoxnkaIdkylil5AHKYSBxaK XZaqzaBWRdV4Pxrk5uWMnEyAsr56ZvytPwWByPXVzjKRw2tjgapku/8lHbxO+MiU1kAX mFAw== Received: by 10.204.129.8 with SMTP id m8mr7340607bks.62.1341603563128; Fri, 06 Jul 2012 12:39:23 -0700 (PDT) Received: from [87.4.96.201] (host201-96-dynamic.4-87-r.retail.telecomitalia.it. [87.4.96.201]) by mx.google.com with ESMTPS id 25sm2541322bkx.9.2012.07.06.12.39.20 (version=SSLv3 cipher=OTHER); Fri, 06 Jul 2012 12:39:21 -0700 (PDT) Message-ID: <4FF73EE3.3010905@gmail.com> Date: Fri, 06 Jul 2012 21:39:15 +0200 From: Stefano Lattarini MIME-Version: 1.0 To: Jack Kelly Subject: Re: bug#11806: (setq load-path ..) of elisp-comp References: <4FEC36C9.2040008@gmail.com> <4FF5D532.3010905@gmail.com> <4FF60DB7.2040504@gmail.com> <4FF6A31E.8040604@gmail.com> In-Reply-To: <4FF6A31E.8040604@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11806-done Cc: 11806-done@debbugs.gnu.org, Makoto Fujiwara , "automake-patches@gnu.org" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 07/06/2012 10:34 AM, Stefano Lattarini wrote: > > Thanks. I'll push the patch by this evening or afternoon if nobody > else speaks out. > Pushed now. I'm thus closing this bug report. Regards, Stefano From unknown Sun Aug 17 22:10:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 04 Aug 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator