GNU bug report logs - #11761
Slight bug in split :-)

Previous Next

Full log

Message #19 received at 11761-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: François Pinard <pinard <at> iro.umontreal.ca>,
	11761-done <at> debbugs.gnu.org
Subject: Re: bug#11761: Slight bug in split :-)
Date: Fri, 22 Jun 2012 12:05:40 +0200

Pádraig Brady wrote:
...
>> Thanks.
>> That looks fine and passes "make check syntax-check" (no surprise).
>> Please move the declaration of "fd" down to the point of initialization.
>
> OK I'll move the stat declaration down too.
>
>> That would induce a line-split, but perhaps this is a good excuse to
>> factor out these:  (maybe name it something like MODE_RW_UGO)
>>
>>     $ git grep -l 'S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH'
>>     src/dd.c
>>     src/mkfifo.c
>>     src/mknod.c
>>     src/split.c
>>     src/touch.c
>>     src/truncate.c
>
> OK I'll do that first.

Thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.