GNU bug report logs - #11757
24.1.50; vc-git calls `process-file' too many times

Previous Next

Full log

View this message in rfc822 format

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 11757 <at> debbugs.gnu.org
Subject: bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times)
Date: Sat, 30 Jun 2012 21:42:31 +0400

On 30.06.2012 17:19, Michael Albinus wrote:
> Dmitry Gutov <dgutov <at> yandex.ru> writes:
>
>> Here's what I had in mind:
>
> Well, I've committed both your and my patch. Can we close the ticket now?

Uh, probably not. This was not enough to fully fix the scenario of 
writing to a file that was removed from Git externally.

This way, `vc-before-save' clears 'vc-backend property too and 
(vc-backend file) retuns nil in `vc-after-save', and the mode-line isn't 
getting updated.

I'm not sure what we should do. Call (vc-mode-line) anyway? That would work.

Clearing only some properties in `vc-before-save' wouldn't be very sane, 
since 'git-registered is backend-specific.

There's a major inconsistency in `vc-backend' logic: we have a way to 
display mode-line, refresh state, etc, for a file that's been registered 
in VC but then was removed, as long as the buffer wasn't killed, but 
kill it and open the file again - now (vc-backend) returns nil.

-- Dmitry

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.