GNU bug report logs - #11749
24.1; C-mode indentation gives wrong-type-argument error.

Previous Next

Packages: emacs, cc-mode;

Reported by: storm <at> cua.dk (Kim F. Storm)

Date: Tue, 19 Jun 2012 20:50:02 UTC

Severity: normal

Merged with 9957, 13385

Found in versions 24.0.90, 24.1

Done: Alan Mackenzie <acm <at> muc.de>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: Alan Mackenzie <acm <at> muc.de>
Cc: Michael Welsh Duggan <mwd <at> md5i.com>, "11749 <at> debbugs.gnu.org" <11749 <at> debbugs.gnu.org>, Michael Welsh Duggan <mwd <at> cert.org>, Kim Storm <storm <at> cua.dk>
Subject: bug#11749: Acknowledgement (24.1; C-mode indentation gives wrong-type-argument error.)
Date: Tue, 08 Jan 2013 14:10:58 -0500

If you'd like to see this in the next pretest, please install this in
emacs-24 as soon as possible.

FWIW, here is some sanity checking from someone who knows nothing about
cc-mode (other than the terror that it brings). Just ignore any of these
comments if they are obviously wrong.

Alan Mackenzie wrote:

> + (defvar c-state-old-cpp-beg-marker)

I guess you wanted to give that an actual value, ie

(defvar c-state-old-cpp-beg-marker nil)

> + (defvar c-state-old-cpp-end-marker)

Likewise.

> + (defmacro c-state-maybe-marker (place marker)
> +   ;; If PLACE is non-nil, return a marker marking it, otherwise nil.
> +   ;; We (re)use MARKER.
> +   `(and ,place
> + 	(or ,marker (setq ,marker (make-marker)))
> + 	(set-marker ,marker ,place)))
> + 
[...]
> !       (setq c-state-old-cpp-beg (and here-cpp-beg (copy-marker here-cpp-beg t))
> ! 	    c-state-old-cpp-end (and here-cpp-end (copy-marker here-cpp-end t)))
> !       )))
>   
>   ;; Debug tool to catch cache inconsistencies.  This is called from
>   ;; 000tests.el.
> --- 3372,3381 ----
>   	      (c-parse-state-1))
>   	   (c-with-cpps-commented-out
>   	    (c-parse-state-1))))
> !       (setq c-state-old-cpp-beg
> ! 	    (c-state-maybe-marker here-cpp-beg c-state-old-cpp-beg-marker)
> ! 	    c-state-old-cpp-end
> ! 	    (c-state-maybe-marker here-cpp-end c-state-old-cpp-end-marker)))))

Looks like the marker insertion type has changed?
This bug report was last modified 12 years and 107 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.