From unknown Sat Aug 09 18:38:40 2025 X-Loop: don@donarmstrong.com Subject: bug#1173: gnus/imap.el should quote quotes in password Reply-To: "Aaron D. Ball" , 1173@debbugs.gnu.org Resent-From: "Aaron D. Ball" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 15 Oct 2008 18:20:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1173 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122409431211114 (code B ref -1); Wed, 15 Oct 2008 18:20:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=BAYES_00,MURPHY_DRUGS_REL8, RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 15 Oct 2008 18:11:52 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9FIBnSt011108 for ; Wed, 15 Oct 2008 11:11:50 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqAqa-00046i-El for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:48 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqAqX-00044L-3L for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:47 -0400 Received: from [199.232.76.173] (port=33891 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqAqX-00044G-0q for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:45 -0400 Received: from lysine.broad.mit.edu ([18.103.8.101]:59898) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqAqW-0002nK-OE for bug-gnu-emacs@gnu.org; Wed, 15 Oct 2008 14:11:44 -0400 Received: from localhost (phenylalanine.broad.mit.edu [18.103.34.14]) by lysine.broad.mit.edu (Postfix) with ESMTP id 2BB56180FF for ; Wed, 15 Oct 2008 14:11:44 -0400 (EDT) X-Virus-Scanned: amavisd-new at broad.mit.edu Received: from lysine.broad.mit.edu ([18.103.8.101]) by localhost (phenylalanine.broad.mit.edu [18.103.34.14]) (amavisd-new, port 10024) with LMTP id yOU2TBpvOkR4 for ; Wed, 15 Oct 2008 14:11:43 -0400 (EDT) Received: from gm518-ea5.broad.mit.edu (gm518-ea5.broad.mit.edu [18.103.27.84]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: adb@broad.mit.edu) by lysine.broad.mit.edu (Postfix) with ESMTP id 5BAD8180EA for ; Wed, 15 Oct 2008 14:11:43 -0400 (EDT) Message-ID: <48F6325F.5010107@broad.mit.edu> Date: Wed, 15 Oct 2008 14:11:43 -0400 From: "Aaron D. Ball" Organization: Broad Institute of MIT and Harvard User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081010 Shredder/3.0b1pre MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 When sending a LOGIN command, the imap-login-auth function in imap.el does not quote double quotes in the password string, so passwords containing double quotes result in an error. I'm using stock Emacs 22.3, compiled by our sysadmin team here: GNU Emacs 22.3.2 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-09-26 on node106 Below is the patch I am using, which fixed the problem for me: --- lisp/gnus/imap.el~ 2008-01-06 20:22:42.000000000 -0500 +++ lisp/gnus/imap.el 2008-10-15 13:58:06.124586000 -0400 @@ -922,7 +922,7 @@ (lambda (user passwd) (imap-ok-p (imap-send-command-wait (concat "LOGIN \"" user "\" \"" - passwd "\"")))))) + (replace-regexp-in-string "\"" "\\\"" passwd) "\"")))))) (defun imap-anonymous-p (buffer) t) -- Aaron D. Ball Senior Systems Analyst Broad Institute of MIT and Harvard From unknown Sat Aug 09 18:38:40 2025 X-Loop: don@donarmstrong.com Subject: bug#1173: Acknowledgement (gnus/imap.el should quote quotes in password) Reply-To: "Aaron D. Ball" , 1173@debbugs.gnu.org Resent-From: "Aaron D. Ball" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 15 Oct 2008 18:50:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1173 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1173-submit@emacsbugs.donarmstrong.com id=B1173.122409618918348 (code B ref 1173); Wed, 15 Oct 2008 18:50:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.4 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1173) by emacsbugs.donarmstrong.com; 15 Oct 2008 18:43:09 +0000 Received: from lysine.broad.mit.edu (lysine.broad.mit.edu [18.103.8.101]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9FIh65N018342 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 11:43:07 -0700 Received: from localhost (methionine.broad.mit.edu [18.103.34.13]) by lysine.broad.mit.edu (Postfix) with ESMTP id F340C18386 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 14:43:05 -0400 (EDT) X-Virus-Scanned: amavisd-new at broad.mit.edu Received: from lysine.broad.mit.edu ([18.103.8.101]) by localhost (methionine.broad.mit.edu [18.103.34.13]) (amavisd-new, port 10024) with LMTP id ZUQmy3pa2NMO for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 14:43:05 -0400 (EDT) Received: from gm518-ea5.broad.mit.edu (gm518-ea5.broad.mit.edu [18.103.27.84]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: adb@broad.mit.edu) by lysine.broad.mit.edu (Postfix) with ESMTP id 20E6018385 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 14:43:05 -0400 (EDT) Message-ID: <48F639B9.2020101@broad.mit.edu> Date: Wed, 15 Oct 2008 14:43:05 -0400 From: "Aaron D. Ball" Organization: Broad Institute of MIT and Harvard User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081010 Shredder/3.0b1pre MIME-Version: 1.0 To: 1173@debbugs.gnu.org References: <48F6325F.5010107@broad.mit.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I was mistaken about that patch fixing the problem. It had a syntax error, so I didn't get the IMAP server error message, just an Emacs error message that went by fast enough that I missed it. If someone can provide a patch that (unlike mine) actually works, I'd appreciate that. In the meantime I'll see if I can figure out elisp string replacement again---it's been a while. -- Aaron D. Ball Senior Systems Analyst Broad Institute of MIT and Harvard From unknown Sat Aug 09 18:38:40 2025 X-Loop: don@donarmstrong.com Subject: bug#1173: Acknowledgement (gnus/imap.el should quote quotes in password) Reply-To: "Aaron D. Ball" , 1173@debbugs.gnu.org Resent-From: "Aaron D. Ball" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 15 Oct 2008 19:10:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1173 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1173-submit@emacsbugs.donarmstrong.com id=B1173.122409722622628 (code B ref 1173); Wed, 15 Oct 2008 19:10:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.2 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1173) by emacsbugs.donarmstrong.com; 15 Oct 2008 19:00:26 +0000 Received: from lysine.broad.mit.edu (lysine.broad.mit.edu [18.103.8.101]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9FJ0NdP022547 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 12:00:24 -0700 Received: from localhost (asparagine.broad.mit.edu [18.103.34.3]) by lysine.broad.mit.edu (Postfix) with ESMTP id 7FA3818386 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 15:00:23 -0400 (EDT) X-Virus-Scanned: amavisd-new at broad.mit.edu Received: from lysine.broad.mit.edu ([18.103.8.101]) by localhost (asparagine.broad.mit.edu [18.103.34.3]) (amavisd-new, port 10024) with LMTP id 05+hrPW0JVw2 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 15:00:22 -0400 (EDT) Received: from gm518-ea5.broad.mit.edu (gm518-ea5.broad.mit.edu [18.103.27.84]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: adb@broad.mit.edu) by lysine.broad.mit.edu (Postfix) with ESMTP id BD2E718364 for <1173@emacsbugs.donarmstrong.com>; Wed, 15 Oct 2008 15:00:22 -0400 (EDT) Message-ID: <48F63DC6.4020109@broad.mit.edu> Date: Wed, 15 Oct 2008 15:00:22 -0400 From: "Aaron D. Ball" Organization: Broad Institute of MIT and Harvard User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081010 Shredder/3.0b1pre MIME-Version: 1.0 To: 1173@debbugs.gnu.org References: <48F6325F.5010107@broad.mit.edu> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Looks like all I needed was to specify that the replacement is literal. This patch let me read my mail for real. --- lisp/gnus/imap.el~ 2008-01-06 20:22:42.000000000 -0500 +++ lisp/gnus/imap.el 2008-10-15 14:58:40.890800000 -0400 @@ -922,7 +922,7 @@ (lambda (user passwd) (imap-ok-p (imap-send-command-wait (concat "LOGIN \"" user "\" \"" - passwd "\"")))))) + (replace-regexp-in-string "\"" "\\\"" passwd t t) "\"")))))) (defun imap-anonymous-p (buffer) t) -- Aaron D. Ball Senior Systems Analyst Broad Institute of MIT and Harvard From unknown Sat Aug 09 18:38:40 2025 X-Loop: don@donarmstrong.com Subject: bug#1173: Acknowledgement (gnus/imap.el should quote quotes in password) Reply-To: Ted Zlatanov , 1173@debbugs.gnu.org Resent-From: Ted Zlatanov Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 16 Oct 2008 17:35:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1173 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1173-submit@emacsbugs.donarmstrong.com id=B1173.12241779971880 (code B ref 1173); Thu, 16 Oct 2008 17:35:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-10.8 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1173) by emacsbugs.donarmstrong.com; 16 Oct 2008 17:26:37 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9GHQYqo001874 for <1173@emacsbugs.donarmstrong.com>; Thu, 16 Oct 2008 10:26:35 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KqWZs-0003fe-Gu for 1173@emacsbugs.donarmstrong.com; Thu, 16 Oct 2008 13:24:00 -0400 Resent-To: 1173@debbugs.gnu.org Resent-From: Glenn Morris Resent-Date: Thu, 16 Oct 2008 13:24:00 -0400 Resent-Message-ID: Resent-User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-From-Line: bug-gnu-emacs-bounces+rgm=gnu.org@gnu.org Thu Oct 16 12:37:44 2008 Received: from mx10.gnu.org ([199.232.76.166]:34265) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KqVr6-00020f-JQ for rgm@gnu.org; Thu, 16 Oct 2008 12:37:44 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KqVtZ-00062x-HI for rgm@gnu.org; Thu, 16 Oct 2008 12:40:17 -0400 Received: from lists.gnu.org ([199.232.76.165]:59616) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KqVtZ-00062q-Aj for rgm@gnu.org; Thu, 16 Oct 2008 12:40:17 -0400 Received: from localhost ([127.0.0.1]:60349 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqVtZ-00008N-AL for rgm@gnu.org; Thu, 16 Oct 2008 12:40:17 -0400 Path: news.stanford.edu!newsfeed.stanford.edu!news.tele.dk!news.tele.dk!small.news.tele.dk!newsgate.cistron.nl!xs4all!news2.euro.net!newsfeed.freenet.de!news.albasani.net!not-for-mail From: Ted Zlatanov Newsgroups: gnu.emacs.bug Date: Thu, 16 Oct 2008 11:16:00 -0500 Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos Message-ID: <864p3cecsf.fsf@lifelogs.com> References: <48F6325F.5010107@broad.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: news.albasani.net 2eGdxpbZqRIXK0GMtfd9AtqeyTAKOYsYXIjxEr+wbHcsXxARMDHbQ1xFtMBKWbwM+vr6l3wfldOAk4ISE9jjOqujhcwTdcLcDpm9JDzLrqbjGH1nhrCPp6df1+KWDSbV X-Complaints-To: abuse@albasani.net NNTP-Posting-Date: Thu, 16 Oct 2008 16:16:02 +0000 (UTC) X-User-ID: 4vmQeI4Mjy3eFcDQZZXrCTiKU6f7hehAYwLu7xRhA6M= X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Cancel-Lock: sha1:7NscWjg5DsEUBXZL693htG7qmgk= sha1:CRLKOb44zBmlUOWXPOd+vkImL8s= X-NNTP-Posting-Host: p5Z7oAsqlabrgh50eqEMqf/iEvBrK6wLdweW0I1gkCQ= To: bug-gnu-emacs@gnu.org X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+rgm=gnu.org@gnu.org X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Lines: 40 User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) Posted-To: gnu.emacs.bug Resent-Date: Thu, 16 Oct 2008 13:24:00 -0400 The following message is a courtesy copy of an article that has been posted to gnu.emacs.bug as well. On Wed, 15 Oct 2008 15:00:22 -0400 "Aaron D. Ball" wrote: ADB> Looks like all I needed was to specify that the replacement is ADB> literal. This patch let me read my mail for real. ADB> --- lisp/gnus/imap.el~ 2008-01-06 20:22:42.000000000 -0500 ADB> +++ lisp/gnus/imap.el 2008-10-15 14:58:40.890800000 -0400 ADB> @@ -922,7 +922,7 @@ ADB> (lambda (user passwd) ADB> (imap-ok-p (imap-send-command-wait ADB> (concat "LOGIN \"" user "\" \"" ADB> - passwd "\"")))))) ADB> + (replace-regexp-in-string "\"" "\\\"" passwd t t) "\"")))))) ADB> (defun imap-anonymous-p (buffer) ADB> t) Aaron, the latest CVS Gnus and Emacs have: (defun imap-quote-specials (string) (with-temp-buffer (insert string) (goto-char (point-min)) (while (re-search-forward "[\\\"]" nil t) (forward-char -1) (insert "\\") (forward-char 1)) (buffer-string))) (it gets called for user name, password, etc. and escapes backslash as well) I think that will solve your problem, if you can use a more recent Emacs or Gnus. Thanks Ted