From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 16 19:11:13 2012 Received: (at submit) by debbugs.gnu.org; 16 Jun 2012 23:11:13 +0000 Received: from localhost ([127.0.0.1]:45243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sg29A-0000aW-Di for submit@debbugs.gnu.org; Sat, 16 Jun 2012 19:11:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48000) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sg297-0000aO-NW for submit@debbugs.gnu.org; Sat, 16 Jun 2012 19:11:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sg263-0006Us-VR for submit@debbugs.gnu.org; Sat, 16 Jun 2012 19:08:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,GAPPY_SUBJECT, RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42604) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sg263-0006Uk-SQ for submit@debbugs.gnu.org; Sat, 16 Jun 2012 19:07:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sg262-0006xK-Cv for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2012 19:07:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sg260-0006UF-LO for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2012 19:07:57 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:19736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sg260-0006To-FA for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2012 19:07:56 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q5GN7pc0028471 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 16 Jun 2012 23:07:51 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q5GN7ojO012660 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sat, 16 Jun 2012 23:07:51 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q5GN7ogU015418 for ; Sat, 16 Jun 2012 18:07:50 -0500 Received: from dradamslap1 (/10.159.188.149) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 16 Jun 2012 16:07:50 -0700 From: "Drew Adams" To: Subject: 24.1; `C-x C-q' should say that the buffer is now read only or writable Date: Sat, 16 Jun 2012 16:07:42 -0700 Message-ID: <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac1MFNUIkJE2x9niTZG8sZL/uCz1kw== X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) Subject line says it all. Yes, the mode line tells you the new status, but it is common courtesy for a mode toggle to announce the new state with a message. Newbies, in particular, can benefit from such a message, not necessarily noticing or understanding the mode-line symbol change. In GNU Emacs 24.1.1 (i386-mingw-nt5.1.2600) of 2012-06-10 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 10:17:24 2012 Received: (at 11726-done) by debbugs.gnu.org; 22 Jun 2012 14:17:24 +0000 Received: from localhost ([127.0.0.1]:53035 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Si4fs-0008LA-0F for submit@debbugs.gnu.org; Fri, 22 Jun 2012 10:17:24 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:43366) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Si4fq-0008L3-KA for 11726-done@debbugs.gnu.org; Fri, 22 Jun 2012 10:17:23 -0400 Received: by wgbdq10 with SMTP id dq10so1637042wgb.15 for <11726-done@debbugs.gnu.org>; Fri, 22 Jun 2012 07:13:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:date:message-id:mime-version:content-type; bh=QQPbf2Ym89fWRrxheGTWb8kJdZzuoIR0qih59631Z1o=; b=uTk8Mnpe3VHoCtHOLXkPCVSq9T1T6W1uG3I6vvMGrY+eVm4UXSwumcpfQDVsRFhZRf ZYgrWfob45Jqk0SdkeK7MzZG1Gs9dMlKX/7+fvz6pC4o+xUu/99EgbN8RGuOiGMQ6leQ 0ST1EAzn7IBQ9EgTcUMNBFKDqJt1BA+JMd0ZBtYGbfIO7kpgExi77kxbPc8If6yeXrCO A1aRe2YxwuDYCACLHVxpyrXkQOasbsCC2P6bB+Jj7uv0XL7A1pOiNh0iXCLhMnIRW31y vJ3v7UdE8PrXxH6mH3p7+DSfrI7ux1PSEPoKXUL/e7n+H5O2OYMrQ+jGbWIdjGbUbazj a9KA== Received: by 10.216.50.80 with SMTP id y58mr1217384web.106.1340374423203; Fri, 22 Jun 2012 07:13:43 -0700 (PDT) Received: from myhost.localdomain (81-64-183-34.rev.numericable.fr. [81.64.183.34]) by mx.google.com with ESMTPS id k8sm100748492wia.6.2012.06.22.07.13.42 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jun 2012 07:13:42 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 5369F86BF; Fri, 22 Jun 2012 16:14:32 +0200 (CEST) From: Bastien To: "Drew Adams" Subject: Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable In-Reply-To: <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> (Drew Adams's message of "Sat, 16 Jun 2012 16:07:42 -0700") Organization: GNU References: <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Date: Fri, 22 Jun 2012 16:14:32 +0200 Message-ID: <87a9zvcu2f.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 11726-done Cc: 11726-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.6 (/) Hi Drew, "Drew Adams" writes: > Subject line says it all. Yes, the mode line tells you the new status, > but it is common courtesy for a mode toggle to announce the new state > with a message. Newbies, in particular, can benefit from such a > message, not necessarily noticing or understanding the mode-line symbol > change. I added a message after `C-x C-q' -- thanks. -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 02:55:09 2012 Received: (at 11726) by debbugs.gnu.org; 27 Jun 2012 06:55:09 +0000 Received: from localhost ([127.0.0.1]:59418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sjm9c-0004WL-GC for submit@debbugs.gnu.org; Wed, 27 Jun 2012 02:55:08 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59720) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sjm9Z-0004WD-B3 for 11726@debbugs.gnu.org; Wed, 27 Jun 2012 02:55:06 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sjm5a-00058d-HN; Wed, 27 Jun 2012 02:50:58 -0400 From: Glenn Morris To: 11726@debbugs.gnu.org Subject: Re: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) References: <87a9zvcu2f.fsf@gnu.org> <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> X-Spook: sweep Majic cypherpunk Leuken-Baden SDI warfare X-Ran: SsT3NK&+B(jKNIwJ0Z<#);UdK$!,$KuH5hp;9(zeY\9*>:L9d2mO#sCDDWhz7;vDV2#K8$ X-Hue: white X-Attribution: GM Date: Wed, 27 Jun 2012 02:50:58 -0400 In-Reply-To: (GNU bug Tracking System's message of "Fri, 22 Jun 2012 14:18:03 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 11726 Cc: Bastien Guerry X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) > I added a message after `C-x C-q' -- thanks. This is an annoyance. emacs -Q M-x custom TAB -> "Read-only enabled for this buffer" in the echo area From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 04:40:10 2012 Received: (at 11726) by debbugs.gnu.org; 27 Jun 2012 08:40:10 +0000 Received: from localhost ([127.0.0.1]:59478 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjnnF-0006qo-NX for submit@debbugs.gnu.org; Wed, 27 Jun 2012 04:40:09 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:35260) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjnnD-0006qf-TB for 11726@debbugs.gnu.org; Wed, 27 Jun 2012 04:40:08 -0400 Received: by wibhm6 with SMTP id hm6so671869wib.15 for <11726@debbugs.gnu.org>; Wed, 27 Jun 2012 01:36:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=Q5IKHSX4LdlrshsIRDPkWozqwquk3tMu7EzPyAwBOG4=; b=XATfILE5WrIYDqdBN20JvGT6wmMoFxAlIfydAw1zaRT8al2H7Cc5TslN1wTa/gBtmZ 5gY10sNvYAF7hyQ3eSTf+aKauXdMVMXU5JUAHj4ohNWAuDGLYJN2C3Rpb7LNxMNTswRL xayJFzc3NX7kcrvtHKcvCsru5DjBDb/FguV92bvKQYeeilZVrbaHFYIIYcIYg8rkaE9L yUamzwEJCF3F1IKwfqzfBXuvWEGwFykpkC8ubmZfM/aK9A2gE/FC3u3lVCuVg0zafBAf DxZJPL2/sRYVVNQCbd08db7rTiT0Ex8bZj8Mz+tIBeSJt5+YcWKj+u/Q+nm6G8zLPkuZ dtzQ== Received: by 10.180.107.70 with SMTP id ha6mr2791513wib.10.1340786158030; Wed, 27 Jun 2012 01:35:58 -0700 (PDT) Received: from myhost.localdomain (135.6.7.109.rev.sfr.net. [109.7.6.135]) by mx.google.com with ESMTPS id db7sm9214661wib.6.2012.06.27.01.35.56 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 27 Jun 2012 01:35:56 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 6F2568778; Wed, 27 Jun 2012 10:36:40 +0200 (CEST) From: Bastien To: Glenn Morris Subject: Re: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) In-Reply-To: (Glenn Morris's message of "Wed, 27 Jun 2012 02:50:58 -0400") References: <87a9zvcu2f.fsf@gnu.org> <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Date: Wed, 27 Jun 2012 10:36:39 +0200 Message-ID: <87r4t16tig.fsf@altern.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 11726 Cc: 11726@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.6 (/) Glenn Morris writes: >> I added a message after `C-x C-q' -- thanks. > > This is an annoyance. Is this an annoyance for toggle-* commands in general or just for this one? -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 05:31:18 2012 Received: (at 11726) by debbugs.gnu.org; 27 Jun 2012 09:31:19 +0000 Received: from localhost ([127.0.0.1]:59495 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sjoak-00081N-D8 for submit@debbugs.gnu.org; Wed, 27 Jun 2012 05:31:18 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:32869) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sjoah-00081E-Qk for 11726@debbugs.gnu.org; Wed, 27 Jun 2012 05:31:16 -0400 Received: from frontend4.mail.m-online.net (unknown [192.168.8.183]) by mail-out.m-online.net (Postfix) with ESMTP id 3WMf0N3Gllz3hj9s; Wed, 27 Jun 2012 11:27:15 +0200 (CEST) Received: from igel.home (ppp-88-217-99-69.dynamic.mnet-online.de [88.217.99.69]) by mail.mnet-online.de (Postfix) with ESMTPA id 3WMf0C72HLzbc0x; Wed, 27 Jun 2012 11:27:07 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 4F798CA2A2; Wed, 27 Jun 2012 11:27:06 +0200 (CEST) From: Andreas Schwab To: Glenn Morris Subject: Re: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) References: <87a9zvcu2f.fsf@gnu.org> <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> X-Yow: My EARS are GONE!! Date: Wed, 27 Jun 2012 11:27:06 +0200 In-Reply-To: (Glenn Morris's message of "Wed, 27 Jun 2012 02:50:58 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 11726 Cc: Bastien Guerry , 11726@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.1 (/) Glenn Morris writes: >> I added a message after `C-x C-q' -- thanks. > > This is an annoyance. > > emacs -Q > M-x custom TAB > -> "Read-only enabled for this buffer" in the echo area I think the uses of toggle-read-only in help-mode-finish and completion-list-mode-finish should be eliminated. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 09:37:11 2012 Received: (at 11726) by debbugs.gnu.org; 27 Jun 2012 13:37:11 +0000 Received: from localhost ([127.0.0.1]:59841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjsQh-0006qE-Es for submit@debbugs.gnu.org; Wed, 27 Jun 2012 09:37:11 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:18704) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjsQf-0006q7-IN for 11726@debbugs.gnu.org; Wed, 27 Jun 2012 09:37:10 -0400 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q5RDX160029913 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 27 Jun 2012 13:33:01 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q5RDWx81019916 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 27 Jun 2012 13:33:00 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q5RDWwb1011875; Wed, 27 Jun 2012 08:32:58 -0500 Received: from dradamslap1 (/10.159.171.205) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 27 Jun 2012 06:32:58 -0700 From: "Drew Adams" To: "'Andreas Schwab'" , "'Glenn Morris'" References: <87a9zvcu2f.fsf@gnu.org><4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> Subject: RE: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) Date: Wed, 27 Jun 2012 06:32:50 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-reply-to: Thread-Index: Ac1URy0edynK60RwSNed/Nc5CTTkoAAIcbVQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 11726 Cc: 'Bastien Guerry' , 11726@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) > I think the uses of toggle-read-only in help-mode-finish and > completion-list-mode-finish should be eliminated. I think I'm OK with that. Probably if there is some programmatic double toggling we should suppress the messages. But the message should definitely be there for interactive toggling. In between (programmatic, only off or only on), it is more of a judgment call, and maybe should be handled case by case. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 27 10:11:02 2012 Received: (at 11726) by debbugs.gnu.org; 27 Jun 2012 14:11:02 +0000 Received: from localhost ([127.0.0.1]:60421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjsxS-0007j0-13 for submit@debbugs.gnu.org; Wed, 27 Jun 2012 10:11:02 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:42844) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SjsxQ-0007ic-7C for 11726@debbugs.gnu.org; Wed, 27 Jun 2012 10:11:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlAQAG6Zu09sr+Nd/2dsb2JhbABEgieuIYNJgQiCFQEBBAEnLyMQCw4mBwsUGA0kiBwFugmQRAOjM4FYgwWBOho X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="192189739" Received: from 108-175-227-93.dsl.teksavvy.com (HELO pastel.home) ([108.175.227.93]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 27 Jun 2012 10:06:52 -0400 Received: by pastel.home (Postfix, from userid 20848) id C4C1852030; Wed, 27 Jun 2012 10:06:51 -0400 (EDT) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) Message-ID: References: <87a9zvcu2f.fsf@gnu.org> <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> Date: Wed, 27 Jun 2012 10:06:51 -0400 In-Reply-To: (Glenn Morris's message of "Wed, 27 Jun 2012 02:50:58 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 11726 Cc: Bastien Guerry , 11726@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.0 (/) >> I added a message after `C-x C-q' -- thanks. > This is an annoyance. > emacs -Q > M-x custom TAB > -> "Read-only enabled for this buffer" in the echo area define-minor-mode only outputs such messages when the function is called interactively, so we should do the same for toggle-read-only. Or rather we should probably use something like the patch below. But it's also the case that toggle-read-only should not be called from Elisp, so another bug is to call toggle-read-only rather than to set buffer-read-only. Stefan === modified file 'lisp/files.el' --- lisp/files.el 2012-06-26 16:23:01 +0000 +++ lisp/files.el 2012-06-27 14:02:59 +0000 @@ -4842,7 +4842,7 @@ "Modification-flag cleared")) (set-buffer-modified-p arg)) -(defun toggle-read-only (&optional arg) +(define-minor-mode toggle-read-only "Change whether this buffer is read-only. With prefix argument ARG, make the buffer read-only if ARG is positive, otherwise make it writable. If buffer is read-only @@ -4855,27 +4855,17 @@ set `buffer-read-only'. To ignore read-only status (whether due to text properties or buffer state) and make changes, temporarily bind `inhibit-read-only'." - (interactive "P") - (if (and arg - (if (> (prefix-numeric-value arg) 0) buffer-read-only - (not buffer-read-only))) ; If buffer-read-only is set correctly, - nil ; do nothing. - ;; Toggle. - (progn + :variable buffer-read-only (cond - ((and buffer-read-only view-mode) + ((and (not buffer-read-only) view-mode) (View-exit-and-edit) (make-local-variable 'view-read-only) (setq view-read-only t)) ; Must leave view mode. - ((and (not buffer-read-only) view-read-only + ((and buffer-read-only view-read-only ;; If view-mode is already active, `view-mode-enter' is a nop. (not view-mode) (not (eq (get major-mode 'mode-class) 'special))) - (view-mode-enter)) - (t (setq buffer-read-only (not buffer-read-only)) - (force-mode-line-update)))) - (message "Read-only %s for this buffer" - (if buffer-read-only "enabled" "disabled")))) + (view-mode-enter)))) (defun insert-file (filename) "Insert contents of file FILENAME into buffer after point. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 04:44:45 2012 Received: (at 11726) by debbugs.gnu.org; 28 Jun 2012 08:44:45 +0000 Received: from localhost ([127.0.0.1]:33564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkALE-00031T-P7 for submit@debbugs.gnu.org; Thu, 28 Jun 2012 04:44:45 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:63366) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkALA-00031J-5L for 11726@debbugs.gnu.org; Thu, 28 Jun 2012 04:44:40 -0400 Received: by wibhq12 with SMTP id hq12so5377258wib.3 for <11726@debbugs.gnu.org>; Thu, 28 Jun 2012 01:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:date:message-id:mime-version:content-type; bh=LT0lT4VqntSYc50SBbMUkxk2OapdJTS7JMgVGC8z8Hs=; b=YBdrB1i6j8vwQNz2VqWHiTcJv1d77oSEro8rQiqwyRj8MgO4fafFsws+3QWBu1E9EI wZLLAl10Wp3B0qnvk0QAmFJTq9dRDVKTfKi+Ku99S4C5UM34ww6oKkn2sXg1y39Ct9Zb zX+Bb1+7N3MVl9FuRPu15v+xhinGaQDVsH5dy1Xupmgc4RKYdMFraUhlOjg035I/WHPp 08J4yst/6Xi1QUMpOXKYoxl1E07fa3Uhvg6/nxwr6luOY2/sj5H8FcZPxLDJrOJftkmA UHNXiHEnMfkWTnmhX0pLBRxSAyzP7/vPams/vRWU/rnBh8q6Io7RO867OY78WNzHq4Fm QxRw== Received: by 10.216.226.101 with SMTP id a79mr600443weq.151.1340872828337; Thu, 28 Jun 2012 01:40:28 -0700 (PDT) Received: from myhost.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPS id fw4sm15454462wib.0.2012.06.28.01.40.26 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 28 Jun 2012 01:40:27 -0700 (PDT) Received: by myhost.localdomain (Postfix, from userid 1000) id 8BED08778; Thu, 28 Jun 2012 10:41:12 +0200 (CEST) From: Bastien To: Stefan Monnier Subject: Re: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) In-Reply-To: (Stefan Monnier's message of "Wed, 27 Jun 2012 10:06:51 -0400") Organization: GNU References: <87a9zvcu2f.fsf@gnu.org> <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Date: Thu, 28 Jun 2012 10:41:12 +0200 Message-ID: <877gur4ymv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 11726 Cc: Glenn Morris , 11726@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.6 (/) Hi Stefan, Stefan Monnier writes: > === modified file 'lisp/files.el' This patch has not been applied to the trunk, right? Sorry for closing the bug too hastily with a half-backed solution. Best, -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 28 11:20:01 2012 Received: (at 11726) by debbugs.gnu.org; 28 Jun 2012 15:20:01 +0000 Received: from localhost ([127.0.0.1]:35286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkGVl-0006PC-8e for submit@debbugs.gnu.org; Thu, 28 Jun 2012 11:20:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:43329) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkGVj-0006P5-Px for 11726@debbugs.gnu.org; Thu, 28 Jun 2012 11:20:00 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ar4PAG6Zu09soXbe/2dsb2JhbABEgiexaoEIghYBBVYjEAs0BwsUGA0kiCG6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="192281629" Received: from 108-161-118-222.dsl.teksavvy.com (HELO pastel.home) ([108.161.118.222]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 Jun 2012 11:15:46 -0400 Received: by pastel.home (Postfix, from userid 20848) id 0CCF359375; Thu, 28 Jun 2012 11:15:45 -0400 (EDT) From: Stefan Monnier To: Bastien Subject: Re: bug#11726: closed (Re: bug#11726: 24.1; `C-x C-q' should say that the buffer is now read only or writable) Message-ID: References: <87a9zvcu2f.fsf@gnu.org> <4AD2AA78BD354EB6B48381EC0C0B3CD0@us.oracle.com> <877gur4ymv.fsf@gnu.org> Date: Thu, 28 Jun 2012 11:15:45 -0400 In-Reply-To: <877gur4ymv.fsf@gnu.org> (Bastien's message of "Thu, 28 Jun 2012 10:41:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 11726 Cc: Glenn Morris , 11726@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.0 (/) >> === modified file 'lisp/files.el' > This patch has not been applied to the trunk, right? No. Stefan From unknown Sat Jun 14 19:09:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Jul 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator