GNU bug report logs - #11725
24.1; confirm-nonexistent-file-or-buffer with after-completion value

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11725: closed (24.1; confirm-nonexistent-file-or-buffer with
 after-completion value)
Date: Sat, 23 Jun 2012 04:54:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 23 Jun 2012 00:50:14 -0400
with message-id <jwvtxy2pr9g.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#11725: 24.1; confirm-nonexistent-file-or-buffer with after-completion value
has caused the debbugs.gnu.org bug report #11725,
regarding 24.1; confirm-nonexistent-file-or-buffer with after-completion value
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11725: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11725
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Szunti <szunti <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1; confirm-nonexistent-file-or-buffer with after-completion value
Date: Sat, 16 Jun 2012 19:14:18 +0200

Using the default value of "after-completion" of the variable
"confirm-nonexistent-file-or-buffer" never asks for confirmation.

I made a git bisect, the first bad commit is:

    commit 064b509639208159ca7c619bccf319aef7950146
    Author: Stefan Monnier <monnier <at> iro.umontreal.ca>
    Date: Mon Mar 12 00:10:59 2012 -0400

        * lisp/minibuffer.el (minibuffer-complete): Don't get confused 
when the
        function is run twice via different commands.
        (complete-with-action): Fix docstring.

Steps to reproduce after bad commit:

1) made two files in bash:
$ cd /tmp
$ touch almafa almacsutka

2) open emacs
C-x C-f /tmp/al[TAB][RET]

[TAB] completes to /tmp/alma, then after pressing [RET], a new file
called alma is open, instead of asking for confirmation.

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Szunti <szunti <at> gmail.com>
Cc: 11725-done <at> debbugs.gnu.org
Subject: Re: bug#11725: 24.1;
	confirm-nonexistent-file-or-buffer with after-completion value
Date: Sat, 23 Jun 2012 00:50:14 -0400

Version: 24.2

> 1) made two files in bash:
> $ cd /tmp
> $ touch almafa almacsutka
> 2) open emacs
> C-x C-f /tmp/al[TAB][RET]
> [TAB] completes to /tmp/alma, then after pressing [RET], a new file
> called alma is open, instead of asking for confirmation.

Thanks, I've installed the patch below on the emacs-24 branch, which
should fix the problem.


        Stefan


--- lisp/minibuffer.el	2012-04-07 08:12:04 +0000
+++ lisp/minibuffer.el	2012-06-23 04:47:36 +0000
@@ -892,7 +892,8 @@
         (completion--cache-all-sorted-completions (cdr all)))))))
 
 (defvar minibuffer-confirm-exit-commands
-  '(minibuffer-complete minibuffer-complete-word PC-complete PC-complete-word)
+  '(completion-at-point minibuffer-complete
+    minibuffer-complete-word PC-complete PC-complete-word)
   "A list of commands which cause an immediately following
 `minibuffer-complete-and-exit' to ask for extra confirmation.")
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.