From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 16 13:38:44 2012 Received: (at submit) by debbugs.gnu.org; 16 Jun 2012 17:38:44 +0000 Received: from localhost ([127.0.0.1]:45104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SfwxQ-0001gj-Ac for submit@debbugs.gnu.org; Sat, 16 Jun 2012 13:38:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45781) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sfwcy-0001EK-5T for submit@debbugs.gnu.org; Sat, 16 Jun 2012 13:17:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfwZx-0004w1-5z for submit@debbugs.gnu.org; Sat, 16 Jun 2012 13:14:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43770) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfwZx-0004vw-0D for submit@debbugs.gnu.org; Sat, 16 Jun 2012 13:14:29 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33938) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfwZv-0002Ts-E9 for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2012 13:14:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfwZt-0004vf-EY for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2012 13:14:26 -0400 Received: from mail-bk0-f41.google.com ([209.85.214.41]:43244) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfwZt-0004vX-4e for bug-gnu-emacs@gnu.org; Sat, 16 Jun 2012 13:14:25 -0400 Received: by bkcjm19 with SMTP id jm19so3698183bkc.0 for ; Sat, 16 Jun 2012 10:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=QsMCqQVkmD7iiSJ5sZDpKKl6s4PXUWE6i3Gdvn5vSvs=; b=qOzJFB5N8+d+hJLUuHcniEQPKEMs7xsHWr7d4HztK71iVr1r4KjBZngrW5m9VFPC1U Gklhp+CHui0z7Dvra8QP0CrvfLWyYG87dqRlIE8cufvzApZTTOHdDz239R36aB6OgI6F fe9GgoWdsPqWu8QF5qxFY7LVGs3LfEsLNJqwvv745sE0ShzdlCGOdSSjY6iLDJM3sz97 TYxoKC2x0pJqGjbwE2dMnJVp6IlUE37Q7p4jXIhcuZx2m+AIvEtKDXepQD9+3y6iFW+s nnUyj1pP5zrgCZhKjnxeKIx14+51kxJc+DF+Dp8ZVckm5xjwf6+HNaSrUkAK39mw0/77 ZH5Q== Received: by 10.204.156.217 with SMTP id y25mr4300913bkw.65.1339866861838; Sat, 16 Jun 2012 10:14:21 -0700 (PDT) Received: from [192.168.1.101] (5403BC44.catv.pool.telekom.hu. [84.3.188.68]) by mx.google.com with ESMTPS id gm18sm13343905bkc.7.2012.06.16.10.14.19 (version=SSLv3 cipher=OTHER); Sat, 16 Jun 2012 10:14:20 -0700 (PDT) Message-ID: <4FDCBEEA.7040101@gmail.com> Date: Sat, 16 Jun 2012 19:14:18 +0200 From: Szunti User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120616 Thunderbird/13.0.1 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 24.1; confirm-nonexistent-file-or-buffer with after-completion value Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 16 Jun 2012 13:38:43 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Using the default value of "after-completion" of the variable "confirm-nonexistent-file-or-buffer" never asks for confirmation. I made a git bisect, the first bad commit is: commit 064b509639208159ca7c619bccf319aef7950146 Author: Stefan Monnier Date: Mon Mar 12 00:10:59 2012 -0400 * lisp/minibuffer.el (minibuffer-complete): Don't get confused when the function is run twice via different commands. (complete-with-action): Fix docstring. Steps to reproduce after bad commit: 1) made two files in bash: $ cd /tmp $ touch almafa almacsutka 2) open emacs C-x C-f /tmp/al[TAB][RET] [TAB] completes to /tmp/alma, then after pressing [RET], a new file called alma is open, instead of asking for confirmation. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 23 00:53:59 2012 Received: (at 11725-done) by debbugs.gnu.org; 23 Jun 2012 04:53:59 +0000 Received: from localhost ([127.0.0.1]:53448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SiIMB-00067u-9O for submit@debbugs.gnu.org; Sat, 23 Jun 2012 00:53:59 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:1923) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SiIM9-00067k-4d for 11725-done@debbugs.gnu.org; Sat, 23 Jun 2012 00:53:57 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09MCrYj/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCws0EhQYDSSIHAW6CZBEA6MzgViDBQ X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="191968648" Received: from 76-10-182-35.dsl.teksavvy.com (HELO ceviche.home) ([76.10.182.35]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 23 Jun 2012 00:50:14 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 4CF8E660C9; Sat, 23 Jun 2012 00:50:14 -0400 (EDT) From: Stefan Monnier To: Szunti Subject: Re: bug#11725: 24.1; confirm-nonexistent-file-or-buffer with after-completion value Message-ID: References: <4FDCBEEA.7040101@gmail.com> Date: Sat, 23 Jun 2012 00:50:14 -0400 In-Reply-To: <4FDCBEEA.7040101@gmail.com> (szunti@gmail.com's message of "Sat, 16 Jun 2012 19:14:18 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11725-done Cc: 11725-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Version: 24.2 > 1) made two files in bash: > $ cd /tmp > $ touch almafa almacsutka > 2) open emacs > C-x C-f /tmp/al[TAB][RET] > [TAB] completes to /tmp/alma, then after pressing [RET], a new file > called alma is open, instead of asking for confirmation. Thanks, I've installed the patch below on the emacs-24 branch, which should fix the problem. Stefan --- lisp/minibuffer.el 2012-04-07 08:12:04 +0000 +++ lisp/minibuffer.el 2012-06-23 04:47:36 +0000 @@ -892,7 +892,8 @@ (completion--cache-all-sorted-completions (cdr all))))))) (defvar minibuffer-confirm-exit-commands - '(minibuffer-complete minibuffer-complete-word PC-complete PC-complete-word) + '(completion-at-point minibuffer-complete + minibuffer-complete-word PC-complete PC-complete-word) "A list of commands which cause an immediately following `minibuffer-complete-and-exit' to ask for extra confirmation.") From unknown Wed Jun 18 23:13:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 21 Jul 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator