GNU bug report logs - #11706
24.1.50; Wrong behavior of move-end-of-line in ERC

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#11706: closed (24.1.50; Wrong behavior of move-end-of-line in
 ERC)
Date: Sun, 07 Oct 2012 01:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 06 Oct 2012 21:41:30 -0400
with message-id <kvk3v36otx.fsf <at> fencepost.gnu.org>
and subject line Re: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC
has caused the debbugs.gnu.org bug report #11706,
regarding 24.1.50; Wrong behavior of move-end-of-line in ERC
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
11706: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11706
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Antoine Levitt <antoine.levitt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1.50; Wrong behavior of move-end-of-line in ERC
Date: Thu, 14 Jun 2012 09:48:20 +0200

Hi,

(setq erc-timestamp-only-if-changed-flag nil
      erc-hide-timestamps t
      erc-insert-timestamp-function 'erc-insert-timestamp-left)

Join IRC, type a few line, then go back in the text and type C-e. Point
will stop one character before EOL. It's annoying.

My quick fix is
diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el
index 5831233..b43b2b3 100644
--- a/lisp/erc/erc-stamp.el
+++ b/lisp/erc/erc-stamp.el
@@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil."
 			       'isearch-open-invisible 'timestamp ts)
 	;; N.B. Later use categories instead of this harmless, but
 	;; inelegant, hack. -- BPT
-	(when erc-timestamp-intangible
+	(when (and erc-timestamp-intangible (not erc-hide-timestamps))
 	  (erc-put-text-property 0 (length ts) 'intangible t ts))
 	ts)
     ""))

I think it's fine to install in trunk and certainly unlikely to cause
any further bugs (there's not much point in setting something invisible
as intangible), but I don't know very well how the code works, so I'd
appreciate it if someone could review it and fix the whole thing
consistently.

Antoine

[Message part 3 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 11706-done <at> debbugs.gnu.org
Subject: Re: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC
Date: Sat, 06 Oct 2012 21:41:30 -0400

Version: 24.3

Thanks; applied to trunk.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.