From unknown Tue Aug 19 23:13:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC Resent-From: Antoine Levitt Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2012 07:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11706 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11706@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13396602998390 (code B ref -1); Thu, 14 Jun 2012 07:52:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jun 2012 07:51:39 +0000 Received: from localhost ([127.0.0.1]:41774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf4qB-0002BH-Eh for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:51:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52666) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf4qA-0002BB-Fu for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:51:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4nJ-00081S-TG for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:48:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nJ-00081L-NR for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:48:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nD-0006OH-HC for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4n5-0007za-EY for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:34 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:64845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4n5-0007zB-6F for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:27 -0400 Received: by wgbds1 with SMTP id ds1so5910644wgb.0 for ; Thu, 14 Jun 2012 00:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=1GlJJi9MvG2Qne5ILq7+G751ewOjUwBE20aGNY66WlY=; b=Ro3jhnZKcdKP3Dym6Az2J00LWxc0FYca+5LIT/NPZk/g97Wp5njwPjxr2vhju3VtTW X7lRRDebEZcwAtEKoUJwhfD2stsTPWwd4msory7kM50DsTak54LRthKbeobBDcYWwnWE UIcIT5i+mYWdf0MSGGc2P6i8WJxsWjhkRjEwgKBkj9ustwyontDnl9zvGj0Voi7kUpzP irZlCzxzhYVTlwdJ4PfcrTo17teuo60ue8Qu4nLzUq8F3uPgJshCosbS9P33xKpwuJ3i RgfeHGO69k0u9DNn0NUhG8vstDSdh9gJHeR44P8DHH+okaTkoZlAdVRTTRp2efBQqjpE 4SVA== Received: by 10.216.215.153 with SMTP id e25mr410067wep.189.1339660103241; Thu, 14 Jun 2012 00:48:23 -0700 (PDT) Received: from lambda (portable48.ceremade.dauphine.fr. [193.48.71.48]) by mx.google.com with ESMTPS id fo7sm17298061wib.9.2012.06.14.00.48.21 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jun 2012 00:48:22 -0700 (PDT) From: Antoine Levitt Date: Thu, 14 Jun 2012 09:48:20 +0200 Message-ID: <874nqe1ghn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi, (setq erc-timestamp-only-if-changed-flag nil erc-hide-timestamps t erc-insert-timestamp-function 'erc-insert-timestamp-left) Join IRC, type a few line, then go back in the text and type C-e. Point will stop one character before EOL. It's annoying. My quick fix is diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el index 5831233..b43b2b3 100644 --- a/lisp/erc/erc-stamp.el +++ b/lisp/erc/erc-stamp.el @@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil." 'isearch-open-invisible 'timestamp ts) ;; N.B. Later use categories instead of this harmless, but ;; inelegant, hack. -- BPT - (when erc-timestamp-intangible + (when (and erc-timestamp-intangible (not erc-hide-timestamps)) (erc-put-text-property 0 (length ts) 'intangible t ts)) ts) "")) I think it's fine to install in trunk and certainly unlikely to cause any further bugs (there's not much point in setting something invisible as intangible), but I don't know very well how the code works, so I'd appreciate it if someone could review it and fix the whole thing consistently. Antoine From unknown Tue Aug 19 23:13:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Antoine Levitt Subject: bug#11706: closed (Re: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC) Message-ID: References: <874nqe1ghn.fsf@gmail.com> X-Gnu-PR-Message: they-closed 11706 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 11706@debbugs.gnu.org Date: Sun, 07 Oct 2012 01:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1349574122-23172-1" This is a multi-part message in MIME format... ------------=_1349574122-23172-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11706: 24.1.50; Wrong behavior of move-end-of-line in ERC which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11706@debbugs.gnu.org. --=20 11706: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11706 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1349574122-23172-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11706-done) by debbugs.gnu.org; 7 Oct 2012 01:41:53 +0000 Received: from localhost ([127.0.0.1]:58795 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKfsP-00061Q-1p for submit@debbugs.gnu.org; Sat, 06 Oct 2012 21:41:53 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:39193 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TKfsM-00061J-Eo for 11706-done@debbugs.gnu.org; Sat, 06 Oct 2012 21:41:51 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1TKfs2-0005z2-EI; Sat, 06 Oct 2012 21:41:30 -0400 From: Glenn Morris To: 11706-done@debbugs.gnu.org Subject: Re: bug#11706: 24.1.50; Wrong behavior of move-end-of-line in ERC References: <874nqe1ghn.fsf@gmail.com> X-Spook: USDOJ Firewalls cybercash blackjack Iran Arnett counter X-Ran: 0MI,N#K8|rQm3\(fyMm:[H[H}?FWe(N&#l,/Cm8WQf$RSWHK0=@$#`'P/PW{]-1Qp\:sPV X-Hue: magenta X-Attribution: GM Date: Sat, 06 Oct 2012 21:41:30 -0400 In-Reply-To: <874nqe1ghn.fsf@gmail.com> (Antoine Levitt's message of "Thu, 14 Jun 2012 09:48:20 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.3 (------) X-Debbugs-Envelope-To: 11706-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.3 (------) Version: 24.3 Thanks; applied to trunk. ------------=_1349574122-23172-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jun 2012 07:51:39 +0000 Received: from localhost ([127.0.0.1]:41774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf4qB-0002BH-Eh for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:51:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52666) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf4qA-0002BB-Fu for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:51:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4nJ-00081S-TG for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:48:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nJ-00081L-NR for submit@debbugs.gnu.org; Thu, 14 Jun 2012 03:48:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44335) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4nD-0006OH-HC for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sf4n5-0007za-EY for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:34 -0400 Received: from mail-wg0-f41.google.com ([74.125.82.41]:64845) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sf4n5-0007zB-6F for bug-gnu-emacs@gnu.org; Thu, 14 Jun 2012 03:48:27 -0400 Received: by wgbds1 with SMTP id ds1so5910644wgb.0 for ; Thu, 14 Jun 2012 00:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:user-agent:mime-version :content-type; bh=1GlJJi9MvG2Qne5ILq7+G751ewOjUwBE20aGNY66WlY=; b=Ro3jhnZKcdKP3Dym6Az2J00LWxc0FYca+5LIT/NPZk/g97Wp5njwPjxr2vhju3VtTW X7lRRDebEZcwAtEKoUJwhfD2stsTPWwd4msory7kM50DsTak54LRthKbeobBDcYWwnWE UIcIT5i+mYWdf0MSGGc2P6i8WJxsWjhkRjEwgKBkj9ustwyontDnl9zvGj0Voi7kUpzP irZlCzxzhYVTlwdJ4PfcrTo17teuo60ue8Qu4nLzUq8F3uPgJshCosbS9P33xKpwuJ3i RgfeHGO69k0u9DNn0NUhG8vstDSdh9gJHeR44P8DHH+okaTkoZlAdVRTTRp2efBQqjpE 4SVA== Received: by 10.216.215.153 with SMTP id e25mr410067wep.189.1339660103241; Thu, 14 Jun 2012 00:48:23 -0700 (PDT) Received: from lambda (portable48.ceremade.dauphine.fr. [193.48.71.48]) by mx.google.com with ESMTPS id fo7sm17298061wib.9.2012.06.14.00.48.21 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jun 2012 00:48:22 -0700 (PDT) From: Antoine Levitt To: bug-gnu-emacs@gnu.org Subject: 24.1.50; Wrong behavior of move-end-of-line in ERC Date: Thu, 14 Jun 2012 09:48:20 +0200 Message-ID: <874nqe1ghn.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hi, (setq erc-timestamp-only-if-changed-flag nil erc-hide-timestamps t erc-insert-timestamp-function 'erc-insert-timestamp-left) Join IRC, type a few line, then go back in the text and type C-e. Point will stop one character before EOL. It's annoying. My quick fix is diff --git a/lisp/erc/erc-stamp.el b/lisp/erc/erc-stamp.el index 5831233..b43b2b3 100644 --- a/lisp/erc/erc-stamp.el +++ b/lisp/erc/erc-stamp.el @@ -352,7 +352,7 @@ Return the empty string if FORMAT is nil." 'isearch-open-invisible 'timestamp ts) ;; N.B. Later use categories instead of this harmless, but ;; inelegant, hack. -- BPT - (when erc-timestamp-intangible + (when (and erc-timestamp-intangible (not erc-hide-timestamps)) (erc-put-text-property 0 (length ts) 'intangible t ts)) ts) "")) I think it's fine to install in trunk and certainly unlikely to cause any further bugs (there's not much point in setting something invisible as intangible), but I don't know very well how the code works, so I'd appreciate it if someone could review it and fix the whole thing consistently. Antoine ------------=_1349574122-23172-1--