From unknown Mon Aug 18 11:21:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Resent-From: Masatake YAMATO Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jun 2012 17:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 11698@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133960909928740 (code B ref -1); Wed, 13 Jun 2012 17:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Jun 2012 17:38:19 +0000 Received: from localhost ([127.0.0.1]:41193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SerWL-0007TT-Dg for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:38:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38763) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SerWH-0007TK-2u for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:38:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SerTX-00025i-3V for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:35:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SerTX-00025c-00 for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:35:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SerTV-0001Iw-3C for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 13:35:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SerTQ-00024T-6v for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 13:35:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SerTP-000247-VT for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 13:35:16 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5DHZD9O015828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Jun 2012 13:35:13 -0400 Received: from localhost (vpn-232-223.phx2.redhat.com [10.3.232.223]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5DHZCYg018915 for ; Wed, 13 Jun 2012 13:35:13 -0400 Date: Thu, 14 Jun 2012 02:35:11 +0900 (JST) Message-Id: <20120614.023511.637296055128807025.yamato@redhat.com> From: Masatake YAMATO Organization: Red Hat Japan, Inc. Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is not a bug report. This is a request for merging the attached patch to the emacs official source tree. See the patch. The original code is written in 2004. I implemented mouse-face on mode-line in 2005-06-07:) 2012-06-13 Masatake YAMATO * progmodes/which-func.el (which-func-format): Enable mouse-face. === modified file 'lisp/progmodes/which-func.el' *** lisp/progmodes/which-func.el 2012-06-03 11:10:44 +0000 --- lisp/progmodes/which-func.el 2012-06-13 17:20:38 +0000 *************** *** 144,150 **** (:propertize which-func-current local-map ,which-func-keymap face which-func ! ;;mouse-face highlight ; currently not evaluated :-( help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") --- 144,150 ---- (:propertize which-func-current local-map ,which-func-keymap face which-func ! mouse-face highlight help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") From unknown Mon Aug 18 11:21:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Resent-From: Glenn Morris Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jun 2012 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Masatake YAMATO Cc: 11698@debbugs.gnu.org Received: via spool by 11698-submit@debbugs.gnu.org id=B11698.133961864510100 (code B ref 11698); Wed, 13 Jun 2012 20:18:02 +0000 Received: (at 11698) by debbugs.gnu.org; 13 Jun 2012 20:17:25 +0000 Received: from localhost ([127.0.0.1]:41271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Seu0K-0002cq-Nm for submit@debbugs.gnu.org; Wed, 13 Jun 2012 16:17:25 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:58320) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Seu0I-0002cj-0R for 11698@debbugs.gnu.org; Wed, 13 Jun 2012 16:17:22 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SetxX-0003h7-O1; Wed, 13 Jun 2012 16:14:31 -0400 From: Glenn Morris References: <20120614.023511.637296055128807025.yamato@redhat.com> X-Spook: NWO CESID Semtex counter terrorism Treasury AIMSX kibo X-Ran: Gmt1LanrDtYzs (Masatake YAMATO's message of "Thu, 14 Jun 2012 02:35:11 +0900 (JST)") Message-ID: <2ny5nrc6l4.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Masatake YAMATO wrote: > ! mouse-face highlight Is this really desirable? Many other parts of the mode line can be clicked on, but do not have a mouse-face. Isn't the change in cursor sufficient? From unknown Mon Aug 18 11:21:44 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func Resent-From: Masatake YAMATO Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Jun 2012 03:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11698 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: rgm@gnu.org Cc: 11698@debbugs.gnu.org Received: via spool by 11698-submit@debbugs.gnu.org id=B11698.133964306016171 (code B ref 11698); Thu, 14 Jun 2012 03:05:01 +0000 Received: (at 11698) by debbugs.gnu.org; 14 Jun 2012 03:04:20 +0000 Received: from localhost ([127.0.0.1]:41550 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf0M7-0004Ck-0T for submit@debbugs.gnu.org; Wed, 13 Jun 2012 23:04:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49280) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sf0M4-0004Cc-7Y for 11698@debbugs.gnu.org; Wed, 13 Jun 2012 23:04:18 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5E31Nh3025992 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jun 2012 23:01:23 -0400 Received: from localhost (vpn-232-169.phx2.redhat.com [10.3.232.169]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q5E31MDF005049; Wed, 13 Jun 2012 23:01:22 -0400 Date: Thu, 14 Jun 2012 12:01:21 +0900 (JST) Message-Id: <20120614.120121.1235549761581179800.yamato@redhat.com> From: Masatake YAMATO In-Reply-To: <2ny5nrc6l4.fsf@fencepost.gnu.org> References: <20120614.023511.637296055128807025.yamato@redhat.com> <2ny5nrc6l4.fsf@fencepost.gnu.org> Organization: Red Hat Japan, Inc. Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Glenn Morris wrote: > Masatake YAMATO wrote: > >> ! mouse-face highlight > > Is this really desirable? Many other parts of the mode line can be > clicked on, but do not have a mouse-face. Isn't the change in cursor > sufficient? It seems that mode-line-highlight is used for mouse-face. How do you think to use it in which-func for keeping consistency between other area on the mode line? I think sometimes cursor is not sufficient. It doesn't tells just the pixel under the cursor is something clickable. The feed-back with mouse-face can tell the area under the cursor is something clickable. Sometimes it is obvious that the area even without mouse face. However, it may be a bit difficult to recognize one-character area like area for buffer-coding system. === modified file 'lisp/progmodes/which-func.el' *** lisp/progmodes/which-func.el 2012-06-03 11:10:44 +0000 --- lisp/progmodes/which-func.el 2012-06-14 02:55:51 +0000 *************** *** 144,150 **** (:propertize which-func-current local-map ,which-func-keymap face which-func ! ;;mouse-face highlight ; currently not evaluated :-( help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") --- 144,150 ---- (:propertize which-func-current local-map ,which-func-keymap face which-func ! mouse-face mode-line-highlight help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") From unknown Mon Aug 18 11:21:44 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Masatake YAMATO Subject: bug#11698: closed (Re: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func) Message-ID: References: <67k3yv50fq.fsf@fencepost.gnu.org> <20120614.023511.637296055128807025.yamato@redhat.com> X-Gnu-PR-Message: they-closed 11698 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 11698@debbugs.gnu.org Date: Mon, 25 Jun 2012 07:18:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1340608682-32436-1" This is a multi-part message in MIME format... ------------=_1340608682-32436-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11698: [PATCH] Enable mouse-face on the mode-line area of which-func=20 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11698@debbugs.gnu.org. --=20 11698: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11698 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1340608682-32436-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11698-done) by debbugs.gnu.org; 25 Jun 2012 07:17:12 +0000 Received: from localhost ([127.0.0.1]:56017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sj3Xr-0008Q0-QT for submit@debbugs.gnu.org; Mon, 25 Jun 2012 03:17:12 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:58658) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sj3Xp-0008Pt-KP for 11698-done@debbugs.gnu.org; Mon, 25 Jun 2012 03:17:10 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Sj3U1-0002BY-VX; Mon, 25 Jun 2012 03:13:14 -0400 From: Glenn Morris To: 11698-done@debbugs.gnu.org Subject: Re: bug#11698: [PATCH] Enable mouse-face on the mode-line area of which-func References: <20120614.023511.637296055128807025.yamato@redhat.com> <2ny5nrc6l4.fsf@fencepost.gnu.org> <20120614.120121.1235549761581179800.yamato@redhat.com> X-Spook: FIPS140 explosion M-14 ASO Venezuela weapons of mass X-Ran: <1"#tDWVDq{t339U,ho!LF`u*MF:?CO.`fb7-4YrqidpP[/Z`@*S4&pP9z?""nH~jMu,hu X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 25 Jun 2012 03:13:13 -0400 In-Reply-To: <20120614.120121.1235549761581179800.yamato@redhat.com> (Masatake YAMATO's message of "Thu, 14 Jun 2012 12:01:21 +0900 (JST)") Message-ID: <67k3yv50fq.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11698-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Version: 24.2 Masatake YAMATO wrote: > ! mouse-face mode-line-highlight Applied to emacs-24 branch, thanks. (I hadn't appreciated that mode-line-highlight is already used all over the place in the mode-line.) ------------=_1340608682-32436-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Jun 2012 17:38:19 +0000 Received: from localhost ([127.0.0.1]:41193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SerWL-0007TT-Dg for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:38:18 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38763) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SerWH-0007TK-2u for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:38:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SerTX-00025i-3V for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:35:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:59618) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SerTX-00025c-00 for submit@debbugs.gnu.org; Wed, 13 Jun 2012 13:35:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SerTV-0001Iw-3C for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 13:35:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SerTQ-00024T-6v for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 13:35:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59929) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SerTP-000247-VT for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 13:35:16 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5DHZD9O015828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 13 Jun 2012 13:35:13 -0400 Received: from localhost (vpn-232-223.phx2.redhat.com [10.3.232.223]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5DHZCYg018915 for ; Wed, 13 Jun 2012 13:35:13 -0400 Date: Thu, 14 Jun 2012 02:35:11 +0900 (JST) Message-Id: <20120614.023511.637296055128807025.yamato@redhat.com> To: bug-gnu-emacs@gnu.org Subject: [PATCH] Enable mouse-face on the mode-line area of which-func From: Masatake YAMATO Organization: Red Hat Japan, Inc. Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is not a bug report. This is a request for merging the attached patch to the emacs official source tree. See the patch. The original code is written in 2004. I implemented mouse-face on mode-line in 2005-06-07:) 2012-06-13 Masatake YAMATO * progmodes/which-func.el (which-func-format): Enable mouse-face. === modified file 'lisp/progmodes/which-func.el' *** lisp/progmodes/which-func.el 2012-06-03 11:10:44 +0000 --- lisp/progmodes/which-func.el 2012-06-13 17:20:38 +0000 *************** *** 144,150 **** (:propertize which-func-current local-map ,which-func-keymap face which-func ! ;;mouse-face highlight ; currently not evaluated :-( help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") --- 144,150 ---- (:propertize which-func-current local-map ,which-func-keymap face which-func ! mouse-face highlight help-echo "mouse-1: go to beginning\n\ mouse-2: toggle rest visibility\n\ mouse-3: go to end") ------------=_1340608682-32436-1--