From drew.adams@oracle.com Tue Oct 14 15:45:55 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2008 22:45:55 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9EMjqf3010834 for ; Tue, 14 Oct 2008 15:45:53 -0700 Received: from mx10.gnu.org ([199.232.76.166]:58167) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kpsbo-0000JP-2M for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 18:43:20 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KpseE-00047e-Nq for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 18:45:51 -0400 Received: from rgminet01.oracle.com ([148.87.113.118]:50923) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KpseE-00047W-CH for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 18:45:50 -0400 Received: from agmgw1.us.oracle.com (agmgw1.us.oracle.com [152.68.180.212]) by rgminet01.oracle.com (Switch-3.2.4/Switch-3.1.6) with ESMTP id m9EMjkHn006355 for ; Tue, 14 Oct 2008 16:45:47 -0600 Received: from acsmt702.oracle.com (acsmt702.oracle.com [141.146.40.80]) by agmgw1.us.oracle.com (Switch-3.2.0/Switch-3.2.0) with ESMTP id m9EMjklL015573 for ; Tue, 14 Oct 2008 16:45:46 -0600 Received: from dradamslap1 (/24.23.165.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 14 Oct 2008 15:45:45 -0700 From: "Drew Adams" To: Subject: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Tue, 14 Oct 2008 15:45:50 -0700 Message-ID: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AckuTpsgvY0R6QxhShecU+qx3n/vIw== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 emacs -Q (substitute-command-keys "\\{minibuffer-local-map}") ; or another map The returned string ends in \n\n. It should end in just \n. If text is added after the returned string, then it should be up to that text to start with a \n if it wants a blank separator line. If, for example, it starts instead with ^L, then the current code includes an extra blank line before the form feed. It should be up to the calling function to decide whether it wants a blank line at the end - only the calling function knows the context and whether such a line is appropriate. In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-03 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From rgm@gnu.org Mon Dec 1 13:49:16 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.8 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 1 Dec 2008 21:49:16 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mB1LnDMM000518 for ; Mon, 1 Dec 2008 13:49:14 -0800 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1L7GdM-0008SN-6S; Mon, 01 Dec 2008 16:48:48 -0500 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18740.23488.148163.871830@fencepost.gnu.org> Date: Mon, 1 Dec 2008 16:48:48 -0500 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: blue X-Ran: dHutS;PvtLT>]=Iut:H^~-r8Z3Uy7H*m]h8"Bg2|dzaL.X45OvG}(}e'-dvg') id 1QesGT-0006Jh-0L for submit@debbugs.gnu.org; Thu, 07 Jul 2011 13:21:25 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QesGQ-0006JU-Oh for 1169@debbugs.gnu.org; Thu, 07 Jul 2011 13:21:23 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QesGF-0006PS-53; Thu, 07 Jul 2011 19:21:11 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline In-Reply-To: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> (Drew Adams's message of "Tue, 14 Oct 2008 15:45:50 -0700") Date: Thu, 07 Jul 2011 19:21:06 +0200 Message-ID: References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: The Smiths's _The Queen Is Dead_: "I Know It's Over" X-Hashcash: 1:23:110707:drew.adams@oracle.com::8cj/6/v2/dAL2ZVm:000000000000000000000000000000000000000019QK X-Hashcash: 1:23:110707:1169@debbugs.gnu.org::Q6aZLEmhVvtds9W9:000000000000000000000000000000000000000006sQs MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QesGF-0006PS-53 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310664071.75271@dMgfx2QJWp4rMrzCaGyOxg X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 1169 Cc: 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: > (substitute-command-keys "\\{minibuffer-local-map}") ; or another map > > The returned string ends in \n\n. It should end in just \n. > > If text is added after the returned string, then it should be up to > that text to start with a \n if it wants a blank separator line. If, > for example, it starts instead with ^L, then the current code includes > an extra blank line before the form feed. > > It should be up to the calling function to decide whether it wants a > blank line at the end - only the calling function knows the context > and whether such a line is appropriate. I've now made the change, but I haven't totally replicated the look of `C-h b' and the like. It used to have ... stuff ... ^L ... more stuff ... With the change, it now says: ... stuff ... ^L ... more stuff ... I can add back the newlines if people want. I'd rather get rid of the ^L characters, though. Do they have any purpose any more? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 13:25:45 2011 Received: (at 1169) by debbugs.gnu.org; 7 Jul 2011 17:25:46 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QesKe-0006Rh-Ui for submit@debbugs.gnu.org; Thu, 07 Jul 2011 13:25:45 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QesKd-0006RS-RD for 1169@debbugs.gnu.org; Thu, 07 Jul 2011 13:25:44 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p67HPZGS003052 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2011 17:25:37 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p67HPZxG018034 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 7 Jul 2011 17:25:35 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p67HPTfb012745; Thu, 7 Jul 2011 12:25:30 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 07 Jul 2011 10:25:29 -0700 From: "Drew Adams" To: "'Lars Magne Ingebrigtsen'" References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> Subject: RE: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Thu, 7 Jul 2011 10:25:30 -0700 Message-ID: <51B66F0CCAE145448298FC161B6BA8BE@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Acw8yk2bsql7mcHRT4akbbBkI73ZJQAAELLg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4E15EC11.01E6:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: 1169 Cc: 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) > I'd rather get rid of the ^L characters, though. > Do they have any purpose any more? No, no, no. Yes, of course they serve a purpose - more than one purpose. See `(emacs) Pages', to start with. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 13:33:12 2011 Received: (at 1169) by debbugs.gnu.org; 7 Jul 2011 17:33:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QesRs-0007U9-7I for submit@debbugs.gnu.org; Thu, 07 Jul 2011 13:33:12 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QesRq-0007Tw-Pi for 1169@debbugs.gnu.org; Thu, 07 Jul 2011 13:33:11 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QesRf-0006eQ-HO; Thu, 07 Jul 2011 19:32:59 +0200 From: Lars Magne Ingebrigtsen To: "Drew Adams" Subject: Re: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline In-Reply-To: <51B66F0CCAE145448298FC161B6BA8BE@us.oracle.com> (Drew Adams's message of "Thu, 7 Jul 2011 10:25:30 -0700") Date: Thu, 07 Jul 2011 19:32:56 +0200 Message-ID: References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <51B66F0CCAE145448298FC161B6BA8BE@us.oracle.com> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEUGIAEDGwBaaksQKwYA FAAKJQPWB9ewAAACRklEQVQ4jWVUy5LjIAwU63BHCb5PmZq7bYr7MOYD8DD8/69sSziZfVCJK1bT 3ZJAodRbbPH/Rck5Zra9/oPSyt4XfoQdL/sewvIENl+wHmFZdnzlcwFV4iWHHYElvIcQWksCGGXM f+krwCwE5kaxjr0xdWWo1Gwi5OOuDn2HE53siy+OSMvRnBEHUFWL6Y8yFwVAKdlnir1diAgtkciW GI8lbGzx+0VI5G5HCKK6OiZHtgmAoqiUfXmTjOrKszE2fl1ALiACqMaRcbalhpybFHiECqmwosct TMt7lwp7I/8ZVnHohne1fbbk9rkceDc39vl+ATG1RuYIn7BGu8qHMGJYK6TQq/x2X0ItaMCXAjHW iuMmLvMU+IS1GxYtdQXQ3bYWzp5/yf7ekq1dAV+Obz1EIeAoUkNc0i3XUgK5Ltv1BK+4EOLpqF4X iXhQxCEkZrJItVukS0YPnSSjjQ1Bv/cEczSm5EyscbmSai1ArMWzecDBDCVI9QHc0A+0KQFwYpGE BSCeMwsgDEsKRGXga2bxBoEGAxcPQHKjumCe2epNjHH7LnwPWgUQiSLdBADp+hnn07kMd8m3ow6D 90m6IAC0kp46rXTLxkxQqBfQAIBRMTqcOzqD1qgHcmoRgDXFf1QeSy3GqNmEnZNhowCu6KgwUjtz zk2UpCNVvZtWbpwv6H4lco6eowCgQ+CxOmsIq/9MD3YyH8SYH9Z5e01tbLR1Jl3W/vxvEMrfTk2I jGi9AHlIW3H7ehoxvdckT8zmhCyf1gr8BnTqy9HLLEOlAAAAAElFTkSuQmCC X-Now-Playing: The Smiths's _The Queen Is Dead_: "Bigmouth Strikes Again" X-Hashcash: 1:23:110707:1169@debbugs.gnu.org::hLX2OSguzhG4zIie:000000000000000000000000000000000000000000jaW X-Hashcash: 1:23:110707:drew.adams@oracle.com::aBSIIxHyFepu4Fdy:000000000000000000000000000000000000000081hr MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QesRf-0006eQ-HO X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1310664779.6908@PmgHL/629Wm1MpwI8wx8ig X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 1169 Cc: 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) "Drew Adams" writes: >> I'd rather get rid of the ^L characters, though. >> Do they have any purpose any more? > > No, no, no. > Yes, of course they serve a purpose - more than one purpose. > See `(emacs) Pages', to start with. I know what they do, but is there any point in actually inserting something as visually distracting as ^L into the buffer people are looking at? If one, for instance, just made the ^L invisible, it'd look nicer, and there would be minimal code change. A better solution would probably to get rid of it altogether and instead insert a `form-feed' text property that the `C-x [' (and friends) command would use instead. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 13:50:38 2011 Received: (at 1169) by debbugs.gnu.org; 7 Jul 2011 17:50:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qesik-0000HK-5O for submit@debbugs.gnu.org; Thu, 07 Jul 2011 13:50:38 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qesii-0000H8-6O for 1169@debbugs.gnu.org; Thu, 07 Jul 2011 13:50:37 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p67HoSuA013613 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 7 Jul 2011 17:50:29 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p67HoRi1009229 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 7 Jul 2011 17:50:27 GMT Received: from abhmt104.oracle.com (abhmt104.oracle.com [141.146.116.56]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p67HoMfx011527; Thu, 7 Jul 2011 12:50:22 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 07 Jul 2011 10:50:22 -0700 From: "Drew Adams" To: "'Lars Magne Ingebrigtsen'" References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com><51B66F0CCAE145448298FC161B6BA8BE@us.oracle.com> Subject: RE: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Thu, 7 Jul 2011 10:50:22 -0700 Message-ID: <3F0F6108342A491D8097ADC015A4D2E9@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Acw8y/Ob71Oz+RbNRMy7LOHFIV6QlAAAKRtg X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090203.4E15F1E6.000A:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.4 (----) X-Debbugs-Envelope-To: 1169 Cc: 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.4 (----) > >> I'd rather get rid of the ^L characters, though. > >> Do they have any purpose any more? > > > > No, no, no. > > Yes, of course they serve a purpose - more than one purpose. > > See `(emacs) Pages', to start with. > > I know what they do, but is there any point in actually inserting > something as visually distracting as ^L into the buffer people are > looking at? > > If one, for instance, just made the ^L invisible, it'd look nicer, and > there would be minimal code change. > > A better solution would probably to get rid of it altogether and > instead insert a `form-feed' text property that the `C-x [' (and friends) > command would use instead. 1. If you want to propose an Emacs design change, then please propose it to emacs-devel, for discussion. This is not the place. 2. The presence and purpose of ^L are one thing. The appearance is something else. Wrt #2, I use (and I proposed to Emacs Dev) pp-c-l.el, which lets users customize the appearance of a page break to virtually anything they like. http://www.emacswiki.org/emacs/download/pp-c-l.el - code http://www.emacswiki.org/emacs/PrettyControlL - description From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 07 16:07:24 2011 Received: (at 1169) by debbugs.gnu.org; 7 Jul 2011 20:07:24 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qeur5-0008Vu-No for submit@debbugs.gnu.org; Thu, 07 Jul 2011 16:07:24 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qeur4-0008Vf-FU for 1169@debbugs.gnu.org; Thu, 07 Jul 2011 16:07:23 -0400 Received: by pzk5 with SMTP id 5so1102595pzk.3 for <1169@debbugs.gnu.org>; Thu, 07 Jul 2011 13:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=nUyWn4GLoFghvOagx7gvJDGtIx6p8qWG3p0ti++6JPw=; b=jP/ySdwF44NQQwbbRtWGbqheUIfplzCWMOhtaZl1IARIEem6bVdTuRjdOOhsZrtKee nOLvJOIXewq+Cg92R0FP/qiad82XGn6fOYPQEZIkBBjWIvArNV0C586Ct/FjSJhcOP2I 1r1yP1NA/vSFh32DFUQdbru2xliXKrfokfOxs= Received: by 10.143.91.16 with SMTP id t16mr579752wfl.366.1310069236224; Thu, 07 Jul 2011 13:07:16 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.144.4 with HTTP; Thu, 7 Jul 2011 13:06:35 -0700 (PDT) In-Reply-To: References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <51B66F0CCAE145448298FC161B6BA8BE@us.oracle.com> From: Juanma Barranquero Date: Thu, 7 Jul 2011 22:06:35 +0200 Message-ID: Subject: Re: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline To: Lars Magne Ingebrigtsen Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: 1169 Cc: Drew Adams , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.3 (---) On Thu, Jul 7, 2011 at 19:32, Lars Magne Ingebrigtsen wrot= e: > I know what they do, but is there any point in actually inserting > something as visually distracting as ^L into the buffer people are > looking at? > > If one, for instance, just made the ^L invisible, it'd look nicer, and > there would be minimal code change. (defface page-break '((t :strike-through t)) "Face to make page breaks more visible.") (define-minor-mode page-break-mode "Toggle Page Break mode. This is a global minor mode: all buffers which don't have an overriding window or buffer display-table will be affected." :init-value nil :global t (aset (or standard-display-table (setq standard-display-table (make-display-table))) ?\^L (and page-break-mode (or (get 'page-break-mode :glyph-vector) (put 'page-break-mode :glyph-vector (make-vector 78 (make-glyph-code ?\s 'page-break)))))= )) =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 12 04:49:59 2011 Received: (at control) by debbugs.gnu.org; 12 Jul 2011 08:49:59 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgYfG-0001lY-BS for submit@debbugs.gnu.org; Tue, 12 Jul 2011 04:49:59 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QgYfD-0001lI-VH for control@debbugs.gnu.org; Tue, 12 Jul 2011 04:49:56 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QgYf1-0001kh-Nl for control@debbugs.gnu.org; Tue, 12 Jul 2011 10:49:43 +0200 Date: Tue, 12 Jul 2011 10:49:43 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #1169 X-MailScanner-ID: 1QgYf1-0001kh-Nl X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311065383.83697@Fo+6JJGYMpINbke2uZoWbA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 1169 fixed close 1169 24.1 From unknown Sat Aug 16 20:01:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 09 Aug 2011 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue May 29 13:36:02 2012 Received: (at control) by debbugs.gnu.org; 29 May 2012 17:36:02 +0000 Received: from localhost ([127.0.0.1]:48678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZQKw-0002iH-8W for submit@debbugs.gnu.org; Tue, 29 May 2012 13:36:02 -0400 Received: from smtprelay-h11.telenor.se ([62.127.194.4]:52792) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZQKc-0002hU-Gd for control@debbugs.gnu.org; Tue, 29 May 2012 13:36:01 -0400 Received: from ipb5.telenor.se (ipb5.telenor.se [195.54.127.168]) by smtprelay-h11.telenor.se (Postfix) with ESMTP id 6ABF248A9E for ; Tue, 29 May 2012 19:23:32 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.229.0.223] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah7kABwFxU9V5QDfPGdsb2JhbABEgm4JSYYrgw2nGwOBHxkBAQEBNzSCEyQ9gTABDAqFdgiCIxuXY6EUi2GBPYMWA6dq X-Suspected-Spam: Yes X-IronPort-AV: E=Sophos;i="4.75,679,1330902000"; d="scan'208";a="125186635" Received: from c-df00e555.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.229.0.223]) by ipb5.telenor.se with ESMTP; 29 May 2012 19:23:32 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 617024841A7; Tue, 29 May 2012 19:23:31 +0200 (CEST) From: Johan Bockgard To: control@debbugs.gnu.org Subject: unarchiving 1169 Date: Tue, 29 May 2012 19:23:23 +0200 User-Agent: devscripts bts/2.11.6ubuntu1.2 Message-ID: <1338312203-2356-bts-bojohan@gnu.org> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) unarchive 1169 thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 29 13:47:11 2012 Received: (at 1169) by debbugs.gnu.org; 29 May 2012 17:47:11 +0000 Received: from localhost ([127.0.0.1]:48683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZQVj-0003kk-CW for submit@debbugs.gnu.org; Tue, 29 May 2012 13:47:11 -0400 Received: from smtprelay-b12.telenor.se ([62.127.194.21]:48065) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZQVM-0003jp-EJ for 1169@debbugs.gnu.org; Tue, 29 May 2012 13:47:09 -0400 Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id 692F4EABE1 for <1169@debbugs.gnu.org>; Tue, 29 May 2012 19:45:18 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.229.0.223] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvWKAPkKxU9V5QDfPGdsb2JhbABFiWuqKAOBHxkBAQEBNzSCFwEBBAEnLyMFCwshJQ8BBBgBDAoaE4gGCbkAi2GEUwOnag X-IronPort-AV: E=Sophos;i="4.75,679,1330902000"; d="scan'208";a="348239336" Received: from c-df00e555.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.229.0.223]) by ipb1.telenor.se with ESMTP; 29 May 2012 19:44:59 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 884584841A7; Tue, 29 May 2012 19:44:58 +0200 (CEST) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: Lars Magne Ingebrigtsen Subject: Re: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> Mail-Copies-To: never Date: Tue, 29 May 2012 19:44:58 +0200 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Thu, 07 Jul 2011 19:21:06 +0200") Message-ID: <87ehq251b9.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 1169 Cc: cyd@gnu.org, Drew Adams , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) Lars Magne Ingebrigtsen writes: > "Drew Adams" writes: > >> (substitute-command-keys "\\{minibuffer-local-map}") ; or another map >> >> The returned string ends in \n\n. It should end in just \n. [...] > I've now made the change, This change breaks the highlighting code in `help-make-xrefs' which assumes that a list of key bindings produced by substitute-command-keys (in `documentation') ends with an extra blank line: (while (re-search-forward "^key +binding\n\\(-+ +\\)-+\n\n" nil t) (let ((col (- (match-end 1) (match-beginning 1)))) (while (and (not (eobp)) ;; Stop at a pair of blank lines. (not (looking-at "\n\\s-*\n"))) Example: emacs -Q C-h m C-x o M-> Note the highlighted "or"s in the last two paragraphs. From debbugs-submit-bounces@debbugs.gnu.org Tue May 29 15:08:42 2012 Received: (at 1169) by debbugs.gnu.org; 29 May 2012 19:08:42 +0000 Received: from localhost ([127.0.0.1]:48735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZRmb-0006Qg-6Z for submit@debbugs.gnu.org; Tue, 29 May 2012 15:08:41 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:19816) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZRmY-0006QU-PC for 1169@debbugs.gnu.org; Tue, 29 May 2012 15:08:39 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4TJ77Jk011784 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 May 2012 19:07:07 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4TJ76JG008773 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 29 May 2012 19:07:06 GMT Received: from abhmt113.oracle.com (abhmt113.oracle.com [141.146.116.65]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4TJ75uH009890; Tue, 29 May 2012 14:07:05 -0500 Received: from dradamslap1 (/10.159.177.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 29 May 2012 12:07:05 -0700 From: "Drew Adams" To: "=?iso-8859-1?Q?'Johan_Bockg=E5rd'?=" , "'Lars Magne Ingebrigtsen'" References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org> Subject: RE: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Tue, 29 May 2012 12:06:48 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehq251b9.fsf@gnu.org> Thread-Index: Ac09wtKbCr0DveHCSUK8Z7FK5IC+pQACTEGw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 1169 Cc: cyd@gnu.org, 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > This change breaks the highlighting code in `help-make-xrefs' which > assumes that a list of key bindings produced by > substitute-command-keys > (in `documentation') ends with an extra blank line: > > (while (re-search-forward "^key +binding\n\\(-+ +\\)-+\n\n" > nil t) > (let ((col (- (match-end 1) (match-beginning 1)))) > (while > (and (not (eobp)) > ;; Stop at a pair of blank lines. > (not (looking-at "\n\\s-*\n"))) > > Example: > emacs -Q > C-h m > C-x o > M-> > > Note the highlighted "or"s in the last two paragraphs. So maybe a different fix is needed. Some fix for 1169 is needed, in any case. But the visual change I see from a build from 2011-07-11 and a build from 2011-07-18 (and later builds) is that function names are now links (which is generally a good thing). Isn't that a separate thing (feature) from the fix for bug #1169? That function-name highlighting can sometimes be "off" - highlighting the word `or' as if it was intended as the function `or', seems a separate problem from `substitute-command-keys' adding an extra newline char. No? From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 10:12:02 2012 Received: (at 1169) by debbugs.gnu.org; 30 May 2012 14:12:02 +0000 Received: from localhost ([127.0.0.1]:50328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZjd4-00014s-Fo for submit@debbugs.gnu.org; Wed, 30 May 2012 10:12:02 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56354 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZjd3-00014V-4W for 1169@debbugs.gnu.org; Wed, 30 May 2012 10:12:01 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:42455 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZjbZ-00046o-LC; Wed, 30 May 2012 10:10:30 -0400 From: Chong Yidong To: Lars Magne Ingebrigtsen Subject: Re: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org> Date: Wed, 30 May 2012 22:10:22 +0800 In-Reply-To: <87ehq251b9.fsf@gnu.org> ("Johan \=\?utf-8\?Q\?Bockg\=C3\=A5rd\=22's\?\= message of "Tue, 29 May 2012 19:44:58 +0200") Message-ID: <8762bdyd2p.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 1169 Cc: Drew Adams , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Johan Bockg=C3=A5rd writes: >> I've now made the change, > > This change breaks the highlighting code in `help-make-xrefs' which > assumes that a list of key bindings produced by substitute-command-keys > (in `documentation') ends with an extra blank line Thanks. I've reverted the change in the emacs-24 branch, and added a note to the docstring of substitute-command-keys that the two newlines are needed by `help-make-xrefs'. From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 10:46:16 2012 Received: (at 1169) by debbugs.gnu.org; 30 May 2012 14:46:16 +0000 Received: from localhost ([127.0.0.1]:50381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZkAB-0002gO-O1 for submit@debbugs.gnu.org; Wed, 30 May 2012 10:46:15 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:17350) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZkA9-0002gD-SM for 1169@debbugs.gnu.org; Wed, 30 May 2012 10:46:14 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4UEibO1017022 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 May 2012 14:44:37 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4UEiaMY002959 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 May 2012 14:44:36 GMT Received: from abhmt101.oracle.com (abhmt101.oracle.com [141.146.116.53]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4UEiZJa028957; Wed, 30 May 2012 09:44:35 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 May 2012 07:44:35 -0700 From: "Drew Adams" To: "'Chong Yidong'" , "'Lars Magne Ingebrigtsen'" References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org> <8762bdyd2p.fsf@gnu.org> Subject: RE: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Wed, 30 May 2012 07:44:34 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <8762bdyd2p.fsf@gnu.org> Thread-Index: Ac0+bfss8lBYjA7jRPCnUrKup3SLEQAAo7TA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 1169 Cc: 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > >> I've now made the change, > > > > This change breaks the highlighting code in `help-make-xrefs' which > > assumes that a list of key bindings produced by > > substitute-command-keys (in `documentation') ends with an extra blank line > > Thanks. I've reverted the change in the emacs-24 branch, and added a > note to the docstring of substitute-command-keys that the two newlines > are needed by `help-make-xrefs'. Huh? Two newlines is the wrong thing. It is the point of this bug report. If some other fix is needed than the one that you made, fine. Just DTRT. Sounds like `help-make-xrefs' needs to be fixed - dunno. In any case, the extra newline still needs to be removed. It is simply wrong - doesn't belong in `substitute-command-keys' - is not part of its mission. And you added your note to the _doc string_? Of `substitute-command-keys'? If you need to make a note that this bug still needs to be fixed then that should be done elsewhere than a doc string. There is absolutely nothing in the purpose of `substitute-command-keys' that constrains it or invites it to add an extra newline. Quite the contrary. `substitute-command-keys' is a very general utility function. It is not some helper routine for `help-make-xrefs'. Bending it to fix inadequate code in `help-make-xrefs' is _way_ wrong. And putting that kind of note into its doc string is doubly wrong. To repeat, from the bug report: > If text is added after the returned string, then it should be up > to *that* text to start with a \n if it wants a blank separator line. > If, for example, it starts instead with ^L, then the current code > includes an extra blank line before the form feed. > > It should be up to the *calling* function to decide whether it wants > a blank line at the end - *only* the calling function knows the > context and whether such a line is appropriate. From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 12:42:40 2012 Received: (at 1169) by debbugs.gnu.org; 30 May 2012 16:42:41 +0000 Received: from localhost ([127.0.0.1]:50528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZlyq-0005Jl-HJ for submit@debbugs.gnu.org; Wed, 30 May 2012 12:42:40 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:32804 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZlym-0005Jb-Sh for 1169@debbugs.gnu.org; Wed, 30 May 2012 12:42:37 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:43230 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZlxI-0001pY-QP; Wed, 30 May 2012 12:41:05 -0400 From: Chong Yidong To: "Drew Adams" Subject: Re: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org> <8762bdyd2p.fsf@gnu.org> Date: Thu, 31 May 2012 00:40:57 +0800 In-Reply-To: (Drew Adams's message of "Wed, 30 May 2012 07:44:34 -0700") Message-ID: <878vg9tyee.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 1169 Cc: 'Lars Magne Ingebrigtsen' , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) "Drew Adams" writes: > Huh? Two newlines is the wrong thing. It is the point of this bug > report. > > If some other fix is needed than the one that you made, fine. Just > DTRT. Sounds like `help-make-xrefs' needs to be fixed - dunno. Two newlines does not seem obviously wrong to me. It is a way of denoting the end of the key summary, just like the "key" and "binding" column headers that are also inserted to denote the start. We could probably do something fancy like using a text property to mark the extent of the key summary, but that seems like overengineering, and anyway it might break third-party code that relies on the old behavior. Feel free to submit a patch for consideration, if you care a lot about replacing those two newlines, though. From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 13:38:16 2012 Received: (at 1169) by debbugs.gnu.org; 30 May 2012 17:38:16 +0000 Received: from localhost ([127.0.0.1]:50666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZmqe-0006bp-2k for submit@debbugs.gnu.org; Wed, 30 May 2012 13:38:16 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:35269) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZmqJ-0006b3-Cw for 1169@debbugs.gnu.org; Wed, 30 May 2012 13:38:14 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4UHaHtk013124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 May 2012 17:36:18 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4UHaGPr000925 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 May 2012 17:36:16 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4UHaG7B027094; Wed, 30 May 2012 12:36:16 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 May 2012 10:36:15 -0700 From: "Drew Adams" To: "'Chong Yidong'" References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org><8762bdyd2p.fsf@gnu.org> <878vg9tyee.fsf@gnu.org> Subject: RE: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Wed, 30 May 2012 10:36:15 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <878vg9tyee.fsf@gnu.org> Thread-Index: Ac0+gwR0Q/8tOls5R3q7i9FMUh0c+wAADsHA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 1169 Cc: 'Lars Magne Ingebrigtsen' , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > Huh? Two newlines is the wrong thing. It is the point of this bug > > report. > > > > If some other fix is needed than the one that you made, fine. Just > > DTRT. Sounds like `help-make-xrefs' needs to be fixed - dunno. > > Two newlines does not seem obviously wrong to me. It is a way of > denoting the end of the key summary, just like the "key" and "binding" > column headers that are also inserted to denote the start. The `}' character "denotes the end", perfectly. The code that calls `s-c-k' has no need to guess where the substituted text ends: it ends where the code uses `}' in the string argument. Everything depends on what the calling code wants to do with the returned string. You are assuming that it always wants an extra separator line (extra newline) at the end, because you are thinking of a particular calling context. I reported the bug because I use this utility string function in other contexts, some of which do not want an extra newline. I gave a good example: ^L following \{...}. Isn't that reasonable, that some code might want to end a page with a key listing? Why impose an extra newline char at the page end? Calling code can always add an extra newline whenever it wants it - it can add 15 newlines if it likes. That's the point. By shoving this extra newline into the `s-c-k' substitution systematically, you make it impossible NOT to have the extra newline. This should be a no-brainer. Nothing prevents a caller from writing (s-c-k "foo \\{barmap}\ntoto") instead of (s-c-k "foo\\{barmap}toto"). > We could probably do something fancy like using a text property to mark the > extent of the key summary, Huh? Why do you need to "mark" it? It is "marked" by the delimiters \\{...}. Whatever comes after the `}' is the first char after the key listing - no question about it. If nothing comes after the `}' then the end of the key listing is the end of the resulting string. > but that seems like overengineering, and anyway it might break third-party > code that relies on the old behavior. Give me a break, please. Any code that expects the extra newline can add "\n". And the change due to the fix will be obvious, if it is important. `s-c-k' is a general-purpose string manipulation function. It simply substitutes key and keymap descriptions for placeholders (\[], \{}, and \<>). There is zero need to "denote the end" of the substituted text - it is indicated in the source string by `}'. > Feel free to submit a patch for consideration, if you care a lot about > replacing those two newlines, though. I do care a lot about it, but you know that I will not be submitting a C patch. If it were coded in Lisp then I would submit a patch. It is obvious that the (trivial) fix is to (a) not insert an extra newline in `s-c-k' and (b) insert such a newline in the particular caller that expects the newline in this case. From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 16:04:04 2012 Received: (at 1169) by debbugs.gnu.org; 30 May 2012 20:04:04 +0000 Received: from localhost ([127.0.0.1]:50763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZp7k-0003r2-A2 for submit@debbugs.gnu.org; Wed, 30 May 2012 16:04:04 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:37520) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZp7h-0003qb-A5 for 1169@debbugs.gnu.org; Wed, 30 May 2012 16:04:02 -0400 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3W2jQF3pdSz3hhWN; Wed, 30 May 2012 22:02:28 +0200 (CEST) Received: from igel.home (ppp-93-104-155-151.dynamic.mnet-online.de [93.104.155.151]) by mail.mnet-online.de (Postfix) with ESMTPA id 3W2jQC23wyz4KK2m; Wed, 30 May 2012 22:02:27 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id 850E6CA2A2; Wed, 30 May 2012 22:02:26 +0200 (CEST) From: Andreas Schwab To: "Drew Adams" Subject: Re: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org> <8762bdyd2p.fsf@gnu.org> <878vg9tyee.fsf@gnu.org> X-Yow: YUGGA-HUGGA-BUGGA-TUGGA!! HEY-HEY!! A TRAIN STATION!! No, a POST OFFICE!! An OCEAN LINER!! No, I think it's a CAFETERIA!!! Date: Wed, 30 May 2012 22:02:26 +0200 In-Reply-To: (Drew Adams's message of "Wed, 30 May 2012 10:36:15 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 1169 Cc: 'Lars Magne Ingebrigtsen' , 'Chong Yidong' , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) "Drew Adams" writes: >> > Huh? Two newlines is the wrong thing. It is the point of this bug >> > report. >> > >> > If some other fix is needed than the one that you made, fine. Just >> > DTRT. Sounds like `help-make-xrefs' needs to be fixed - dunno. >> >> Two newlines does not seem obviously wrong to me. It is a way of >> denoting the end of the key summary, just like the "key" and "binding" >> column headers that are also inserted to denote the start. > > The `}' character "denotes the end", perfectly. Which '}' character? Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 16:23:40 2012 Received: (at 1169) by debbugs.gnu.org; 30 May 2012 20:23:40 +0000 Received: from localhost ([127.0.0.1]:50777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZpQi-0004HF-1v for submit@debbugs.gnu.org; Wed, 30 May 2012 16:23:40 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:44822) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZpQO-0004Gh-4Q for 1169@debbugs.gnu.org; Wed, 30 May 2012 16:23:39 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4UKLgJE002847 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 30 May 2012 20:21:43 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4UKLfqS004843 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 30 May 2012 20:21:42 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4UKLeBC018296; Wed, 30 May 2012 15:21:40 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 30 May 2012 13:21:40 -0700 From: "Drew Adams" To: "'Andreas Schwab'" References: <004801c92e4e$9b8018c0$0200a8c0@us.oracle.com> <87ehq251b9.fsf@gnu.org><8762bdyd2p.fsf@gnu.org><878vg9tyee.fsf@gnu.org> Subject: RE: bug#1169: 23.0.60; (substitute-command-keys "\\{...}") adds extra newline Date: Wed, 30 May 2012 13:21:39 -0700 Message-ID: <47A49711AAFF4AAE90177B12D628AB5B@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac0+nyjeqgjkGJKmSd6fWMFBkI6A0AAAdM4w X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 1169 Cc: 'Lars Magne Ingebrigtsen' , 'Chong Yidong' , 1169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) > > The `}' character "denotes the end", perfectly. > > Which '}' character? Which double-newline? There is a lot less (zero?) ambiguity in finding the `}' that corresponds to a given `\{' than there is to trying to parse the _resulting_, substituted text for \n\n to determine the end of the text that was substituted for `}'. Try (substiture-command-keys "\\{global-map}") and see how many \n\n there are. Why rely on the content of the _resulting_ string, after substitution? From unknown Sat Aug 16 20:01:09 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 28 Jun 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator