From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 12 17:01:15 2012 Received: (at submit) by debbugs.gnu.org; 12 Jun 2012 21:01:15 +0000 Received: from localhost ([127.0.0.1]:39813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SeYDD-0001Vm-Ff for submit@debbugs.gnu.org; Tue, 12 Jun 2012 17:01:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56378) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SeYDB-0001Vf-9J for submit@debbugs.gnu.org; Tue, 12 Jun 2012 17:01:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeYAW-0005sb-5V for submit@debbugs.gnu.org; Tue, 12 Jun 2012 16:58:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeYAW-0005sX-1w for submit@debbugs.gnu.org; Tue, 12 Jun 2012 16:58:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeYAU-0001Qc-Kl for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2012 16:58:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeYAT-0005sI-1e for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2012 16:58:26 -0400 Received: from smtprelay-b21.telenor.se ([195.54.99.212]:36910) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeYAS-0005sC-RB for bug-gnu-emacs@gnu.org; Tue, 12 Jun 2012 16:58:24 -0400 Received: from ipb4.telenor.se (ipb4.telenor.se [195.54.127.167]) by smtprelay-b21.telenor.se (Postfix) with ESMTP id 22C49248DB for ; Tue, 12 Jun 2012 22:58:23 +0200 (CEST) X-SMTPAUTH-B2: [bocjoh] X-SENDER-IP: [85.229.0.223] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtTCAHys109V5QDfPGdsb2JhbABFgndKhlGDHKZXA4EtGQEBAQE3NIIUYV80AQQYAQwKhXYIgiMbmByhJIwMghGDGwOnfA X-IronPort-AV: E=Sophos;i="4.77,399,1336341600"; d="scan'208";a="60832925" Received: from c-df00e555.04-211-6c6b701.cust.bredbandsbolaget.se (HELO muon.localdomain) ([85.229.0.223]) by ipb4.telenor.se with ESMTP; 12 Jun 2012 22:58:22 +0200 Received: by muon.localdomain (Postfix, from userid 1000) id 65C49484262; Tue, 12 Jun 2012 22:58:21 +0200 (CEST) From: =?utf-8?Q?Johan_Bockg=C3=A5rd?= To: bug-gnu-emacs@gnu.org Subject: 24.1.50; defun should return name Date: Tue, 12 Jun 2012 22:58:20 +0200 Message-ID: <87ipewb637.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) With current trunk, (defun NAME ()) => (lambda nil nil) expected => NAME Ditto for defmacro. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 13 05:16:32 2012 Received: (at submit) by debbugs.gnu.org; 13 Jun 2012 09:16:32 +0000 Received: from localhost ([127.0.0.1]:40459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sejgl-0001Dh-Tt for submit@debbugs.gnu.org; Wed, 13 Jun 2012 05:16:32 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32864) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sejgi-0001DZ-Pf for submit@debbugs.gnu.org; Wed, 13 Jun 2012 05:16:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sejdx-0008JM-A4 for submit@debbugs.gnu.org; Wed, 13 Jun 2012 05:13:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sejdx-0008JI-6j for submit@debbugs.gnu.org; Wed, 13 Jun 2012 05:13:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sejdr-0007Yf-3e for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 05:13:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sejdp-0008IZ-BO for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 05:13:30 -0400 Received: from plane.gmane.org ([80.91.229.3]:55127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sejdp-0008IU-4Z for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 05:13:29 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Sejdj-0002rK-C9 for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 11:13:23 +0200 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jun 2012 11:13:23 +0200 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jun 2012 11:13:23 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Lawrence Mitchell Subject: Re: bug#11686: 24.1.50; defun should return name Date: Wed, 13 Jun 2012 10:13:10 +0100 Lines: 55 Message-ID: <87mx47h8wp.fsf@gmx.li> References: <87ipewb637.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: e4300lm.epcc.ed.ac.uk User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Cancel-Lock: sha1:noBDboJYfeIbD8xkCBvnYpkrmXY= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Johan Bockgård wrote: > With current trunk, > (defun NAME ()) => (lambda nil nil) > expected => NAME > Ditto for defmacro. Here's a patch, think this is right: Return NAME, not definition from defun and defmacro * lisp/emacs-lisp/byte-run.el (defun, defmacro): Return newly created definition's name, not its definition. diff --git a/lisp/emacs-lisp/byte-run.el b/lisp/emacs-lisp/byte-run.el index 635eef9..fb86b2a 100644 --- a/lisp/emacs-lisp/byte-run.el +++ b/lisp/emacs-lisp/byte-run.el @@ -135,9 +135,11 @@ interpreted according to `macro-declarations-alist'." (if docstring (setq body (cons docstring body))) ;; Can't use backquote because it's not defined yet! (let* ((fun (list 'function (cons 'lambda (cons arglist body)))) - (def (list 'defalias - (list 'quote name) - (list 'cons ''macro fun))) + (def (cons 'prog1 + (list (list 'quote name) + (list 'defalias + (list 'quote name) + (list 'cons ''macro fun))))) (declarations (mapcar #'(lambda (x) @@ -190,11 +192,13 @@ interpreted according to `defun-declarations-alist'. (t (message "Warning: Unknown defun property %S in %S" (car x) name))))) decls)) - (def (list 'defalias - (list 'quote name) - (list 'function - (cons 'lambda - (cons arglist body)))))) + (def (cons 'prog1 + (list (list 'quote name) + (list 'defalias + (list 'quote name) + (list 'function + (cons 'lambda + (cons arglist body)))))))) (if declarations (cons 'prog1 (cons def declarations)) def)))) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 13 08:30:08 2012 Received: (at 11686) by debbugs.gnu.org; 13 Jun 2012 12:30:08 +0000 Received: from localhost ([127.0.0.1]:40576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Semi7-0006OU-Fe for submit@debbugs.gnu.org; Wed, 13 Jun 2012 08:30:07 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14605) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Semi3-0006Ny-VU for 11686@debbugs.gnu.org; Wed, 13 Jun 2012 08:30:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu09FxIKb/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCwsOJhIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="191277632" Received: from 69-196-130-155.dsl.teksavvy.com (HELO pastel.home) ([69.196.130.155]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 13 Jun 2012 08:27:15 -0400 Received: by pastel.home (Postfix, from userid 20848) id 5169258E8D; Wed, 13 Jun 2012 08:27:08 -0400 (EDT) From: Stefan Monnier To: Lawrence Mitchell Subject: Re: bug#11686: 24.1.50; defun should return name Message-ID: References: <87ipewb637.fsf@gnu.org> <87mx47h8wp.fsf@gmx.li> Date: Wed, 13 Jun 2012 08:27:08 -0400 In-Reply-To: <87mx47h8wp.fsf@gmx.li> (Lawrence Mitchell's message of "Wed, 13 Jun 2012 10:13:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11686 Cc: 11686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Here's a patch, think this is right: > Return NAME, not definition from defun and defmacro > * lisp/emacs-lisp/byte-run.el (defun, defmacro): Return newly created > definition's name, not its definition. I wonder what is the impact on the generated byte-code. Maybe a simpler way is to change defalias to return the name rather than the value. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 13 10:37:36 2012 Received: (at submit) by debbugs.gnu.org; 13 Jun 2012 14:37:36 +0000 Received: from localhost ([127.0.0.1]:40988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SeohU-0000tH-C6 for submit@debbugs.gnu.org; Wed, 13 Jun 2012 10:37:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52964) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SeohS-0000t8-Ig for submit@debbugs.gnu.org; Wed, 13 Jun 2012 10:37:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Seoef-0001GI-VC for submit@debbugs.gnu.org; Wed, 13 Jun 2012 10:34:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:46440) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Seoef-0001G9-Ra for submit@debbugs.gnu.org; Wed, 13 Jun 2012 10:34:41 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeoeZ-00046D-GA for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 10:34:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SeoeQ-0001Dz-S9 for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 10:34:34 -0400 Received: from plane.gmane.org ([80.91.229.3]:37893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SeoeQ-0001Dh-Kg for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 10:34:26 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1SeoeM-0000Uh-4D for bug-gnu-emacs@gnu.org; Wed, 13 Jun 2012 16:34:22 +0200 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jun 2012 16:34:21 +0200 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 13 Jun 2012 16:34:21 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Lawrence Mitchell Subject: Re: bug#11686: 24.1.50; defun should return name Date: Wed, 13 Jun 2012 15:34:09 +0100 Lines: 41 Message-ID: <874nqfl1r2.fsf@gmx.li> References: <87ipewb637.fsf@gnu.org> <87mx47h8wp.fsf@gmx.li> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: e4300lm.epcc.ed.ac.uk User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Cancel-Lock: sha1:vt8mPF9w4TJgjPHslw0dfugBmbg= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier wrote: >> Here's a patch, think this is right: >> Return NAME, not definition from defun and defmacro >> * lisp/emacs-lisp/byte-run.el (defun, defmacro): Return newly created >> definition's name, not its definition. > I wonder what is the impact on the generated byte-code. If the name is thrown away, there's no impact afaict. If you assign the name to something there's a small increase. Here's an example before and after for (defvar foo (defun foo (&rest x) x)) Before: (defvar foo (defalias 'foo #[(&rest x) "^H\207" [x] 1])) After: (defvar foo (byte-code "\300\301\300\302\"\210\207" [foo defalias #[(&rest x) "^H\207" [x] 1]] 4)) > Maybe a simpler way is to change defalias to return the name rather than > the value. But defalias says: | (defalias SYMBOL DEFINITION &optional DOCSTRING) | Set SYMBOL's function definition to DEFINITION, and return DEFINITION. So you'll probably then get a bug report about that instead. Cheers, Lawrence -- Lawrence Mitchell From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 18 15:08:51 2012 Received: (at 11686) by debbugs.gnu.org; 18 Jun 2012 19:08:51 +0000 Received: from localhost ([127.0.0.1]:47016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SghJj-0002h8-DC for submit@debbugs.gnu.org; Mon, 18 Jun 2012 15:08:51 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:43323) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SghJh-0002h1-JR for 11686@debbugs.gnu.org; Mon, 18 Jun 2012 15:08:50 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q5IJ5VJ0009425; Mon, 18 Jun 2012 15:05:31 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 6DE5EB4253; Mon, 18 Jun 2012 11:58:09 -0400 (EDT) From: Stefan Monnier To: Lawrence Mitchell Subject: Re: bug#11686: 24.1.50; defun should return name Message-ID: References: <87ipewb637.fsf@gnu.org> <87mx47h8wp.fsf@gmx.li> <874nqfl1r2.fsf@gmx.li> Date: Mon, 18 Jun 2012 11:58:09 -0400 In-Reply-To: <874nqfl1r2.fsf@gmx.li> (Lawrence Mitchell's message of "Wed, 13 Jun 2012 15:34:09 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4254=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4254> : streams <769858> : uri <1142754> X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 11686 Cc: 11686@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.0 (--) >> Maybe a simpler way is to change defalias to return the name rather than >> the value. > But defalias says: > | (defalias SYMBOL DEFINITION &optional DOCSTRING) > | Set SYMBOL's function definition to DEFINITION, and return DEFINITION. > So you'll probably then get a bug report about that instead. We'll see, I just installed a patch that does that. I don't know of any use-case where the return value of `defalias' is used, whereas I do know of one use case where the return value of `defun' is used (it's in (add-hook 'foo-hook (defun bar () ...))). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 22 09:42:55 2012 Received: (at submit) by debbugs.gnu.org; 22 Jun 2012 13:42:55 +0000 Received: from localhost ([127.0.0.1]:52731 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Si48U-0007Vh-G6 for submit@debbugs.gnu.org; Fri, 22 Jun 2012 09:42:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37845) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Si48R-0007VZ-QS for submit@debbugs.gnu.org; Fri, 22 Jun 2012 09:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Si44l-00042f-KN for submit@debbugs.gnu.org; Fri, 22 Jun 2012 09:39:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Si44l-00042Y-H5 for submit@debbugs.gnu.org; Fri, 22 Jun 2012 09:39:03 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Si44f-0000zu-SP for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2012 09:39:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Si44Z-000418-2Q for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2012 09:38:57 -0400 Received: from plane.gmane.org ([80.91.229.3]:34889) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Si44Y-00040g-RT for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2012 09:38:50 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1Si44S-00082R-QC for bug-gnu-emacs@gnu.org; Fri, 22 Jun 2012 15:38:44 +0200 Received: from e4300lm.epcc.ed.ac.uk ([129.215.63.156]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 22 Jun 2012 15:38:44 +0200 Received: from wence by e4300lm.epcc.ed.ac.uk with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 22 Jun 2012 15:38:44 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Lawrence Mitchell Subject: Re: bug#11686: 24.1.50; defun should return name Date: Fri, 22 Jun 2012 14:38:30 +0100 Lines: 44 Message-ID: <87d34r4gbt.fsf@gmx.li> References: <87ipewb637.fsf@gnu.org> <87mx47h8wp.fsf@gmx.li> <874nqfl1r2.fsf@gmx.li> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: e4300lm.epcc.ed.ac.uk User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) Cancel-Lock: sha1:a0dwKz425JnL2c0Evrb/Px3yrPI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier wrote: >>> Maybe a simpler way is to change defalias to return the name rather than >>> the value. >> But defalias says: >> | (defalias SYMBOL DEFINITION &optional DOCSTRING) >> | Set SYMBOL's function definition to DEFINITION, and return DEFINITION. >> So you'll probably then get a bug report about that instead. > We'll see, I just installed a patch that does that. I think the following (NEWS) patch should be applied on top. This is an incompatible change to defalias. So it should go in the appropriate part of NEWS. Additionally, we should mention defmacro and defun. diff --git a/etc/NEWS b/etc/NEWS index 3cd4d21..65f4269 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -418,6 +418,12 @@ Only variables defined using `defcustom' are considered user options. The function `user-variable-p' is now an obsolete alias for `custom-variable-p'. ++++ +** The return values of `defalias', `defun' and `defmacro' have changed, +and are now undefined. For backwards compatibility, defun and +defmacro currently return the name of the newly defined function/macro +but this should not be relied upon. + ** `face-spec-set' no longer sets frame-specific attributes when the third argument is a frame (that usage was obsolete since Emacs 22.2). @@ -434,8 +440,6 @@ still be supported for Emacs 24.x. * Lisp changes in Emacs 24.2 -** The return value of `defalias' has changed and is now undefined. - ** `defun' also accepts a (declare DECLS) form, like `defmacro'. The interpretation of the DECLS is determined by `defun-declarations-alist'. -- Lawrence Mitchell From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 24 13:11:56 2012 Received: (at 11686-done) by debbugs.gnu.org; 24 Jun 2012 17:11:56 +0000 Received: from localhost ([127.0.0.1]:55348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SiqLs-0002Ex-5e for submit@debbugs.gnu.org; Sun, 24 Jun 2012 13:11:56 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59839) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SiqLp-0002Ep-UV for 11686-done@debbugs.gnu.org; Sun, 24 Jun 2012 13:11:54 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ai0FAG6Zu0/O+L+Q/2dsb2JhbABEsEiDSYEIghUBAQQBViMFCwsOJhIUGA0kLYdvBboJkEQDozOBWIMF X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="192015648" Received: from 206-248-191-144.dsl.teksavvy.com (HELO pastel.home) ([206.248.191.144]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Jun 2012 13:08:02 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8D5F04E151; Sun, 24 Jun 2012 13:08:02 -0400 (EDT) From: Stefan Monnier To: Lawrence Mitchell Subject: Re: bug#11686: 24.1.50; defun should return name Message-ID: References: <87ipewb637.fsf@gnu.org> <87mx47h8wp.fsf@gmx.li> <874nqfl1r2.fsf@gmx.li> <87d34r4gbt.fsf@gmx.li> Date: Sun, 24 Jun 2012 13:08:02 -0400 In-Reply-To: <87d34r4gbt.fsf@gmx.li> (Lawrence Mitchell's message of "Fri, 22 Jun 2012 14:38:30 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11686-done Cc: 11686-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I think the following (NEWS) patch should be applied on top. > This is an incompatible change to defalias. So it should go in > the appropriate part of NEWS. Additionally, we should mention > defmacro and defun. Thanks, installed, Stefan From unknown Tue Aug 19 21:03:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 23 Jul 2012 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator