GNU bug report logs - #11680
flyspell should use mouse-3 instead of mouse-2

Previous Next

Package: emacs;

Reported by: Le Wang <l26wang <at> gmail.com>

Date: Tue, 12 Jun 2012 12:28:01 UTC

Severity: minor

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log


Message #23 received at 11680 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: l26wang <at> gmail.com, 11680 <at> debbugs.gnu.org
Subject: Re: bug#11680: flyspell should use mouse-3 instead of mouse-2
Date: Thu, 16 Jan 2020 16:46:45 +0200
> From: Stefan Kangas <stefan <at> marxist.se>
> Cc: 11680 <at> debbugs.gnu.org,  l26wang <at> gmail.com
> Date: Thu, 16 Jan 2020 02:50:19 +0100
> 
> > Fine with me, but that button is already bound to
> > mouse-save-then-kill.  I never use it, but what will those who do say?
> 
> Since this key binding is only in flyspell-mouse-map, it will only be
> rebound when the mouse pointer is over a misspelled word.  Note that
> mouse-2 is normally bound to mouse-yank-primary.

I don't see how this resolves the backward-compatibility issue, sorry.

> I therefore don't think it will be a big problem in practice.  On the
> contrary, I believe that having the context menu on the right mouse
> button will feel more natural and be more discoverable to users.

Once again, we are not talking about adding a new feature from
scratch, we are talking about changing a very old behavior.  So
whether it's more natural or not is of secondary importance for this
decision.

I'm okay with making this conditional on some user option, but I
object to an unconditional change.

> I have attached an updated patch below.  If there are no objections to
> it, would this change be safe for the release branch, or should it go
> to master?

In any case, we don't add new features on the release branch, we only
fix bugs there.

Thanks.




This bug report was last modified 4 years and 332 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.