From drew.adams@oracle.com Tue Oct 14 10:43:10 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.0 required=4.0 tests=AWL,BAYES_00, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2008 17:43:10 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9EHh7nj032009 for ; Tue, 14 Oct 2008 10:43:08 -0700 Received: from mx10.gnu.org ([199.232.76.166]:59672) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kpnsp-0006n6-Hy for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 13:40:35 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KpnvF-0006kY-2I for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 13:43:05 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:50253) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KpnvE-0006gy-7W for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 13:43:04 -0400 Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id m9EHgllh016871 for ; Tue, 14 Oct 2008 12:42:48 -0500 Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id m9EHgkOn024850 for ; Tue, 14 Oct 2008 11:42:46 -0600 Received: from dradamslap1 (/24.23.165.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 14 Oct 2008 10:42:45 -0700 From: "Drew Adams" To: Subject: 23.0.60; doc of make-frame-command Date: Tue, 14 Oct 2008 10:42:43 -0700 Message-ID: <001601c92e24$45515bf0$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: AckuJELgv07kl3SfSXK1kMtTzS3x4g== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 The doc string of `make-frame-command' (`C-x 5 2') says: "Make a new frame, and select it if the terminal displays only one frame." The Emacs manual says: "Create a new frame" (node Creating Frames) "Use `C-x 5 2' to create a new frame and switch to it" (node Non-Window Terminals) The code does this: (if (and window-system (not (eq window-system 'pc))) (make-frame) (select-frame (make-frame))) 1. Why the difference for `pc'? 2. What does the doc string mean by "terminal" and "if the terminal displays only one frame"? If "terminal" refers only to emacs -nw, then nothing is said about the window-manager case. If "terminal" refers to both -nw and window mgr cases, then it seems false for the latter - whether the new frame is selected has nothing to do with whether there is only one frame. 3. Node Creating Frames of the manual should say also that the frame is selected for a non-window system. 4. Somewhere, we should say that the current buffer is what is displayed (alone) in the new frame. 5. However, we should also mention this apparent exception to #4: If the current frame is a standalone minibuffer frame, then the buffer displayed in the new frame is *scratch*. Are there other exceptions? In GNU Emacs 23.0.60.1 (i386-mingw-nt5.1.2600) of 2008-10-03 on LENNART-69DE564 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/g/include -fno-crossjumping' From eliz@gnu.org Tue Oct 14 12:46:39 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,RCVD_IN_NIX1 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2008 19:46:40 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9EJka4M030913 for ; Tue, 14 Oct 2008 12:46:37 -0700 Received: from mx10.gnu.org ([199.232.76.166]:47066) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KppoK-0008Vy-OG for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 15:44:04 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kppqk-0000CX-KH for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 15:46:35 -0400 Received: from mtaout7.012.net.il ([84.95.2.19]:64539) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kppqk-0000CN-5D; Tue, 14 Oct 2008 15:46:34 -0400 Received: from HOME-C4E4A596F7 ([77.127.24.3]) by i-mtaout7.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0K8Q00IRMUXN6VJ0@i-mtaout7.012.net.il>; Tue, 14 Oct 2008 21:46:36 +0200 (IST) Date: Tue, 14 Oct 2008 21:45:19 +0200 From: Eli Zaretskii Subject: Re: bug#1165: 23.0.60; doc of make-frame-command In-reply-to: <001601c92e24$45515bf0$0200a8c0@us.oracle.com> X-012-Sender: halo1@inter.net.il To: Drew Adams , 1165@debbugs.gnu.org Cc: emacs-pretest-bug@gnu.org, bug-gnu-emacs@gnu.org Reply-to: Eli Zaretskii Message-id: References: <001601c92e24$45515bf0$0200a8c0@us.oracle.com> X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (1203?) > From: "Drew Adams" > Date: Tue, 14 Oct 2008 10:42:43 -0700 > Cc: > > (if (and window-system (not (eq window-system 'pc))) > (make-frame) > (select-frame (make-frame))) > > 1. Why the difference for `pc'? `pc' is the value of window-system for the MS-DOS build of Emacs. The MS-DOS build behaves like a text terminal, but its window-system has a non-nil value; thus the difference. Although correct, that code should actually be rewritten using display-graphic-p to become cleaner. > 2. What does the doc string mean by "terminal" and "if the terminal > displays only one frame"? It means the text-only terminals, which can only display one frame at a time. > If "terminal" refers only to emacs -nw, then nothing is said about > the window-manager case. Well, I think it does say something about the windowed terminals: it says that on those terminals, a new frame is created, but it is not selected. From eliz@gnu.org Tue Oct 14 13:06:32 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.0 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,RCVD_IN_NIX1 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2008 20:06:32 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9EK6TWS004001 for ; Tue, 14 Oct 2008 13:06:30 -0700 Received: from mail.gnu.org ([199.232.76.166]:48628 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Kpq7Z-0005ho-OJ for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 16:03:57 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Kpq9z-0003ys-Mc for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 16:06:28 -0400 Received: from mtaout4.012.net.il ([84.95.2.10]:62214) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Kpq9z-0003yW-4P; Tue, 14 Oct 2008 16:06:27 -0400 Received: from HOME-C4E4A596F7 ([77.127.24.3]) by i_mtaout4.012.net.il (HyperSendmail v2004.12) with ESMTPA id <0K8Q00578VV91RL2@i_mtaout4.012.net.il>; Tue, 14 Oct 2008 22:06:46 +0200 (IST) Date: Tue, 14 Oct 2008 22:05:29 +0200 From: Eli Zaretskii Subject: Re: bug#1165: 23.0.60; doc of make-frame-command In-reply-to: <001601c92e24$45515bf0$0200a8c0@us.oracle.com> X-012-Sender: halo1@inter.net.il To: Drew Adams , 1165@debbugs.gnu.org Cc: emacs-pretest-bug@gnu.org, bug-gnu-emacs@gnu.org Reply-to: Eli Zaretskii Message-id: References: <001601c92e24$45515bf0$0200a8c0@us.oracle.com> X-detected-operating-system: by monty-python.gnu.org: Solaris 9.1 > From: "Drew Adams" > Date: Tue, 14 Oct 2008 10:42:43 -0700 > Cc: > > 2. What does the doc string mean by "terminal" and "if the terminal > displays only one frame"? Sorry, what I wrote originally was probably unclear. Here's a better version: "Terminal" is any terminal, whether graphics (a.k.a. windowed) or text-only. A terminal "that can only display one frame" is a text-only terminal. From drew.adams@oracle.com Tue Oct 14 13:15:36 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.5 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER, RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Oct 2008 20:15:36 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9EKFXbr006410 for ; Tue, 14 Oct 2008 13:15:34 -0700 Received: from mail.gnu.org ([199.232.76.166]:49270 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KpqGL-0008Ov-NS for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 16:13:01 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KpqIl-0005zY-PC for emacs-pretest-bug@gnu.org; Tue, 14 Oct 2008 16:15:32 -0400 Received: from agminet01.oracle.com ([141.146.126.228]:10486) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KpqIl-0005zK-7h; Tue, 14 Oct 2008 16:15:31 -0400 Received: from rgmgw1.us.oracle.com (rgmgw1.us.oracle.com [138.1.186.110]) by agminet01.oracle.com (Switch-3.2.4/Switch-3.1.7) with ESMTP id m9EKFHIb002669; Tue, 14 Oct 2008 15:15:18 -0500 Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by rgmgw1.us.oracle.com (Switch-3.2.4/Switch-3.2.4) with ESMTP id m9EKFHHB005857; Tue, 14 Oct 2008 14:15:17 -0600 Received: from dradamslap1 (/24.23.165.218) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 14 Oct 2008 13:15:16 -0700 From: "Drew Adams" To: "'Eli Zaretskii'" , <1165@debbugs.gnu.org> Cc: , References: <001601c92e24$45515bf0$0200a8c0@us.oracle.com> Subject: RE: bug#1165: 23.0.60; doc of make-frame-command Date: Tue, 14 Oct 2008 13:15:18 -0700 Message-ID: <002e01c92e39$94347850$0200a8c0@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AckuNb8JxSI+4ES1Tt+qfP3mQBFvAgAAvv0A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-CrossAssassin-Score: 2 > > (if (and window-system (not (eq window-system 'pc))) > > (make-frame) > > (select-frame (make-frame))) > > > > 1. Why the difference for `pc'? > > `pc' is the value of window-system for the MS-DOS build of Emacs. The > MS-DOS build behaves like a text terminal, but its window-system has a > non-nil value; thus the difference. > > Although correct, that code should actually be rewritten using > display-graphic-p to become cleaner. > > > 2. What does the doc string mean by "terminal" and "if the terminal > > displays only one frame"? > > It means the text-only terminals, which can only display one frame at > a time. In that case, that's what it should say. There is a difference between (1) a terminal that _can only_ display one frame at a time and (2) a terminal that is currently displaying only one frame. The way it is written, it sounds as if that occurs whenever Emacs (even with a window manager) shows only one frame. > > If "terminal" refers only to emacs -nw, then nothing is said about > > the window-manager case. > > Well, I think it does say something about the windowed terminals: it > says that on those terminals, a new frame is created, but it is not > selected. Unless only one frame is displayed. That's what it seems to say. If the distinction in behavior is really due to emacs -nw versus emacs with a window manager, then that's what should be said. Saying "if the terminal displays only one frame" is misleading or, at best, not clear, IMO. And the manual should be at least as specific about this distinction as the doc string. In node Creating Frames it says nothing about it. From cyd@stupidchicken.com Wed Oct 22 14:11:31 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-5.4 required=4.0 tests=AWL,BAYES_00,HAS_BUG_NUMBER autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1165-done) by emacsbugs.donarmstrong.com; 22 Oct 2008 21:11:32 +0000 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9MLBPwO010248 for <1165-done@emacsbugs.donarmstrong.com>; Wed, 22 Oct 2008 14:11:26 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id 8282F57E04B; Wed, 22 Oct 2008 17:11:27 -0400 (EDT) From: Chong Yidong To: Eli Zaretskii , Drew Adams Cc: 1165-done@debbugs.gnu.org Subject: Re: bug#1165: 23.0.60; doc of make-frame-command Date: Wed, 22 Oct 2008 17:11:27 -0400 Message-ID: <87iqrkbaio.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > > (if (and window-system (not (eq window-system 'pc))) > > (make-frame) > > (select-frame (make-frame))) > > > > 1. Why the difference for `pc'? > > `pc' is the value of window-system for the MS-DOS build of Emacs. The > MS-DOS build behaves like a text terminal, but its window-system has a > non-nil value; thus the difference. > > Although correct, that code should actually be rewritten using > display-graphic-p to become cleaner. Indeed. I've changed it to use display-graphic-p. > > 2. What does the doc string mean by "terminal" and "if the terminal > > displays only one frame"? > > It means the text-only terminals, which can only display one frame at > a time. I tweaked the doc-string to make this clearer. From unknown Sat Jun 14 19:08:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Nov 2008 15:24:04 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator