GNU bug report logs - #11647
24.1; Document return value of load-source-file-function

Previous Next

Package: emacs;

Reported by: Christopher Schmidt <christopher <at> ch.ristopher.com>

Date: Fri, 8 Jun 2012 02:00:02 UTC

Severity: minor

Found in version 24.1

Done: Chong Yidong <cyd <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11647 in the body.
You can then email your comments to 11647 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#11647; Package emacs. (Fri, 08 Jun 2012 02:00:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Christopher Schmidt <christopher <at> ch.ristopher.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Fri, 08 Jun 2012 02:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.1; Document return value of load-source-file-function
Date: Fri,  8 Jun 2012 02:57:05 +0100 (BST)
[load-source-file-function.diff (text/x-diff, inline)]
=== modified file 'src/ChangeLog'
--- src/ChangeLog	2012-06-07 05:11:51 +0000
+++ src/ChangeLog	2012-06-08 01:42:27 +0000
@@ -1,3 +1,8 @@
+2012-06-08  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* lread.c (syms_of_lread): Document return value of
+	load-source-file-function.
+
 2012-06-07  Paul Eggert  <eggert <at> cs.ucla.edu>
 
 	* doprnt.c (doprnt): Truncate multibyte char correctly.

=== modified file 'src/lread.c'
--- src/lread.c	2012-05-30 03:59:42 +0000
+++ src/lread.c	2012-06-08 01:53:34 +0000
@@ -4508,7 +4508,8 @@
 
   DEFVAR_LISP ("load-source-file-function", Vload_source_file_function,
 	       doc: /* Function called in `load' for loading an Emacs Lisp source file.
-This function is for doing code conversion before reading the source file.
+This function is for doing code conversion before reading the source
+file.  It should return t if the file exists and loads successfully.
 If nil, loading is done without any code conversion.
 Arguments are FULLNAME, FILE, NOERROR, NOMESSAGE, where
  FULLNAME is the full name of FILE.

[Message part 2 (text/plain, inline)]
Unfortunately I cannot get the trunk to build so the patch is untested.
It's just a doc fix, though.

        Christopher

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#11647; Package emacs. (Sun, 24 Jun 2012 15:30:02 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Schmidt <christopher <at> ch.ristopher.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#11647: 24.1;
	Document return value of load-source-file-function
Date: Sun, 24 Jun 2012 16:25:31 +0100 (BST)
[load-source-file-function.diff (text/x-diff, inline)]
=== modified file 'src/ChangeLog'
--- src/ChangeLog	2012-06-24 04:11:19 +0000
+++ src/ChangeLog	2012-06-24 15:24:00 +0000
@@ -1,3 +1,7 @@
+2012-06-24  Christopher Schmidt  <christopher <at> ch.ristopher.com>
+
+	* lread.c (syms_of_lread): Doc fix (Bug#11647).
+
 2012-06-24  Paul Eggert  <eggert <at> cs.ucla.edu>
 
 	Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).

=== modified file 'src/lread.c'
--- src/lread.c	2012-06-22 21:17:42 +0000
+++ src/lread.c	2012-06-24 15:22:30 +0000
@@ -4501,11 +4501,11 @@
 
   DEFVAR_LISP ("load-source-file-function", Vload_source_file_function,
 	       doc: /* Function called in `load' for loading an Emacs Lisp source file.
-This function is for doing code conversion before reading the source file.
-If nil, loading is done without any code conversion.
-Arguments are FULLNAME, FILE, NOERROR, NOMESSAGE, where
- FULLNAME is the full name of FILE.
-See `load' for the meaning of the remaining arguments.  */);
+This function is for doing code conversion before reading the source
+file.  It should return t if the file exists and loads successfully.
+If nil, loading is done without any code conversion.  Arguments are
+FULLNAME, FILE, NOERROR, NOMESSAGE, where FULLNAME is the full name of
+FILE.  See `load' for the meaning of the remaining arguments.  */);
   Vload_source_file_function = Qnil;
 
   DEFVAR_BOOL ("load-force-doc-strings", load_force_doc_strings,

[Message part 2 (text/plain, inline)]
OK to commit?

        Christopher

Reply sent to Chong Yidong <cyd <at> gnu.org>:
You have taken responsibility. (Sat, 08 Dec 2012 03:18:02 GMT) Full text and rfc822 format available.

Notification sent to Christopher Schmidt <christopher <at> ch.ristopher.com>:
bug acknowledged by developer. (Sat, 08 Dec 2012 03:18:02 GMT) Full text and rfc822 format available.

Message #13 received at 11647-done <at> debbugs.gnu.org (full text, mbox):

From: Chong Yidong <cyd <at> gnu.org>
To: 11647-done <at> debbugs.gnu.org
Subject: Re: bug#11647: 24.1;
	Document return value of load-source-file-function
Date: Sat, 08 Dec 2012 11:16:40 +0800
> +2012-06-24  Christopher Schmidt  <christopher <at> ch.ristopher.com>
> +
> +	* lread.c (syms_of_lread): Doc fix (Bug#11647).
> +

Sorry for the delay.  I've now committed a tweaked version of this
patch.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 05 Jan 2013 12:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 12 years and 246 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.