GNU bug report logs - #11606
24.1; Get rid of buffer local hook variables in find-file.el

Previous Next

Package: emacs;

Reported by: Leo <sdl.web <at> gmail.com>

Date: Sat, 2 Jun 2012 04:48:02 UTC

Severity: minor

Tags: notabug, wontfix

Found in version 24.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo <sdl.web <at> gmail.com>
Cc: 11606 <at> debbugs.gnu.org
Subject: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el
Date: Sun, 03 Jun 2012 11:18:23 -0400

>> I also like removing those, but I still don't know why you think these
>> can be removed safely.
> I was thinking that add-hook supports adding local hooks which might be
> better than making those hooks buffer-local.

That's generally true, but (add-hook 'foo 'bar) operates on the local
part if the var is `make-variable-buffer-local', so the removal you
suggest would break code that relies on this detail.

> What are your concerns about their safety?

My concern is that I know nothing about these variables, so I have no
way to judge whether removing those things is safe.


        Stefan
This bug report was last modified 11 years and 114 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.