From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 02 00:47:14 2012 Received: (at submit) by debbugs.gnu.org; 2 Jun 2012 04:47:14 +0000 Received: from localhost ([127.0.0.1]:53730 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SagF7-00073t-WF for submit@debbugs.gnu.org; Sat, 02 Jun 2012 00:47:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47364) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SagF5-00073g-Fb for submit@debbugs.gnu.org; Sat, 02 Jun 2012 00:47:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SagDJ-0004eJ-Ht for submit@debbugs.gnu.org; Sat, 02 Jun 2012 00:45:22 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SagDJ-0004e8-C4 for submit@debbugs.gnu.org; Sat, 02 Jun 2012 00:45:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53265) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SagDI-0008OL-0i for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 00:45:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SagDG-0004dm-Hv for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 00:45:19 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:35899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SagDG-0004dZ-8i for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2012 00:45:18 -0400 Received: by pbbrp2 with SMTP id rp2so4011314pbb.0 for ; Fri, 01 Jun 2012 21:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=tE2UYzZh6tOrgSaK9PAFAFg64ze/kI5zUCq1nt+SQgo=; b=0LKwyyrZ8uM5hPWdnUoDr4YCkLEhIeEBY5bhJ1hZ0qufnF8QaX7/zcQYN9KAok3oDM LIpLaa2dRr6o9ztAk1JNAUeYFGHcGLbue9lxyNUuNSkenrfaZezTwyUWTVCT5pcLUIBz 5n6Xn8iWKY2vne++j9J9zktxqoIhoPS0v1p1gK1cIzciISTtY0SznbvTVxqylcs20Yse 3BdP4hYiMlJOz89cRe7+UkvjI9rgN6mnpRUBy1BcqDEbF+fbRRfcaQu+itn1ypscUMRb IjrIb73NO6EtspHW8TSqNzzDROngXYiv/Xb/vXoiwp+BMVM1TIFCUTxGeKfT5pIoKxkx susg== Received: by 10.68.222.163 with SMTP id qn3mr16588299pbc.135.1338612313278; Fri, 01 Jun 2012 21:45:13 -0700 (PDT) Received: from localhost ([114.249.198.72]) by mx.google.com with ESMTPS id ms1sm5032892pbb.63.2012.06.01.21.45.09 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 01 Jun 2012 21:45:12 -0700 (PDT) From: Leo To: bug-gnu-emacs@gnu.org Subject: 24.1; Get rid of buffer local hook variables in find-file.el Date: Sat, 02 Jun 2012 12:44:54 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) ff-pre-find-hook ff-pre-load-hook ff-post-load-hook ff-not-found-hook ff-file-created-hook From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 02 13:59:32 2012 Received: (at 11606) by debbugs.gnu.org; 2 Jun 2012 17:59:32 +0000 Received: from localhost ([127.0.0.1]:54824 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sasbs-00012u-JM for submit@debbugs.gnu.org; Sat, 02 Jun 2012 13:59:32 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:33627) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SasbY-00012P-Fr for 11606@debbugs.gnu.org; Sat, 02 Jun 2012 13:59:30 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+UI/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="187005029" Received: from 108-175-229-8.dsl.teksavvy.com (HELO pastel.home) ([108.175.229.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jun 2012 13:57:19 -0400 Received: by pastel.home (Postfix, from userid 20848) id 34DAF59655; Sat, 2 Jun 2012 13:57:18 -0400 (EDT) From: Stefan Monnier To: Leo Subject: Re: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Message-ID: References: Date: Sat, 02 Jun 2012 13:57:18 -0400 In-Reply-To: (Leo's message of "Sat, 02 Jun 2012 12:44:54 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11606 Cc: 11606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > ff-pre-find-hook > ff-pre-load-hook > ff-post-load-hook > ff-not-found-hook > ff-file-created-hook I like removing things, but could you expand on why you think we should remove these? Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 02 22:09:39 2012 Received: (at 11606) by debbugs.gnu.org; 3 Jun 2012 02:09:39 +0000 Received: from localhost ([127.0.0.1]:55123 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb0GB-0005uM-37 for submit@debbugs.gnu.org; Sat, 02 Jun 2012 22:09:39 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:53449) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb0G8-0005u9-Uz for 11606@debbugs.gnu.org; Sat, 02 Jun 2012 22:09:37 -0400 Received: by pbcwy7 with SMTP id wy7so4188443pbc.3 for <11606@debbugs.gnu.org>; Sat, 02 Jun 2012 19:07:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=jT4KjjTyjpg8OsX6harwMH2dcD28KVDuYCggOpJLEl8=; b=ZcKHlApwlFI6Z8lscjzhGL/t3vx11iHiOCtoGAL40wmVi5sHiEtJGq7TZPEXwyndV5 JFldytPpVn4Qt7vwIKJ8TDcNTEJfdd5USXZXFRoU8rNHsD8yDCeZzcnyJHIHaWF6PKCe bUP1ehBGvU5Xi3Dak2Xq4MmmQWu3dGARUq+IGUj45XRo+o2lPIeBmu1RmMjb1di+J/in 4l0s/mkImJMqofItmewJw3erjc0YuQCU8iheOIRiVFgeO7mqiutfHNL+Gb+aRyfSKSu7 itD47etZlVTo3CAIT+ySxBPB3r1ErINH4XmkI6+2gasDKexLcZ2ydfem6QvLSxKzQSYz A0Lw== Received: by 10.68.232.38 with SMTP id tl6mr23528366pbc.89.1338689262524; Sat, 02 Jun 2012 19:07:42 -0700 (PDT) Received: from localhost ([221.219.113.118]) by mx.google.com with ESMTPS id wn3sm8071830pbc.74.2012.06.02.19.07.37 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 02 Jun 2012 19:07:41 -0700 (PDT) From: Leo To: Stefan Monnier Subject: Re: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Sun, 03 Jun 2012 10:07:28 +0800 In-Reply-To: (Stefan Monnier's message of "Sat, 02 Jun 2012 13:57:18 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (Mac OS X 10.6.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11606 Cc: 11606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-06-03 01:57 +0800, Stefan Monnier wrote: > I like removing things, but could you expand on why you think we should > remove these? Not removing the hooks themselves but the buffer-local bits, i.e. === modified file 'lisp/find-file.el' --- lisp/find-file.el 2012-05-04 05:14:14 +0000 +++ lisp/find-file.el 2012-06-03 02:06:57 +0000 @@ -284,11 +284,6 @@ ;; No user definable variables beyond this point! ;; ============================================== -(make-variable-buffer-local 'ff-pre-find-hook) -(make-variable-buffer-local 'ff-pre-load-hook) -(make-variable-buffer-local 'ff-post-load-hook) -(make-variable-buffer-local 'ff-not-found-hook) -(make-variable-buffer-local 'ff-file-created-hook) (make-variable-buffer-local 'ff-case-fold-search) (make-variable-buffer-local 'ff-always-in-other-window) (make-variable-buffer-local 'ff-ignore-include) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 02 23:20:13 2012 Received: (at 11606) by debbugs.gnu.org; 3 Jun 2012 03:20:13 +0000 Received: from localhost ([127.0.0.1]:55148 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb1MS-0007Tw-Qs for submit@debbugs.gnu.org; Sat, 02 Jun 2012 23:20:13 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:56846) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb1MQ-0007Th-VY for 11606@debbugs.gnu.org; Sat, 02 Jun 2012 23:20:11 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+UI/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="187344369" Received: from 108-175-229-8.dsl.teksavvy.com (HELO pastel.home) ([108.175.229.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jun 2012 23:18:16 -0400 Received: by pastel.home (Postfix, from userid 20848) id 7B48F59607; Sat, 2 Jun 2012 23:18:15 -0400 (EDT) From: Stefan Monnier To: Leo Subject: Re: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Message-ID: References: Date: Sat, 02 Jun 2012 23:18:15 -0400 In-Reply-To: (Leo's message of "Sun, 03 Jun 2012 10:07:28 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11606 Cc: 11606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> I like removing things, but could you expand on why you think we should >> remove these? > Not removing the hooks themselves but the buffer-local bits, i.e. I also like removing those, but I still don't know why you think these can be removed safely. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 03 00:08:05 2012 Received: (at 11606) by debbugs.gnu.org; 3 Jun 2012 04:08:05 +0000 Received: from localhost ([127.0.0.1]:55161 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb26m-00005a-Cs for submit@debbugs.gnu.org; Sun, 03 Jun 2012 00:08:04 -0400 Received: from mail-pb0-f44.google.com ([209.85.160.44]:49249) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb26l-000056-FI for 11606@debbugs.gnu.org; Sun, 03 Jun 2012 00:08:04 -0400 Received: by pbcwy7 with SMTP id wy7so4239461pbc.3 for <11606@debbugs.gnu.org>; Sat, 02 Jun 2012 21:06:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=SdEc8hQiPwEKS9smMELnxZIQrKos8lp8TnI5t7brXxM=; b=CMqrMuJjEdcZ69bOydahw2botZ5pCQbn3MU6y3R7fxAcBi30IlzoYCED+xIersUVkw HKd87D0fPCWA3jATwSpjRTjapqLW0RkNHhfvyN8tE7kOw9+nmSK3d+to1lPZb3RjbqBY OqFb3WRugmcBtGlm0SYfTMoT1MlFZMSZ9yl2keiEoGe0zRdQ4miFwobqDh6AYPRJx1Xw r362U6UBuJ9/64p4gFaCmXFOb0f5hbHgK4l+53c3bLC8RdkVwwY9huTDtNpeLrNbJL1k aFX1vMphNvprb7e5/YunYDPa3By9RsLRuie39x7R2AEsiu5mR/CwTxwyVdad7H0iBCO6 fxXw== Received: by 10.68.201.9 with SMTP id jw9mr17667308pbc.28.1338696368570; Sat, 02 Jun 2012 21:06:08 -0700 (PDT) Received: from localhost ([221.219.116.142]) by mx.google.com with ESMTPS id ip5sm8402007pbc.3.2012.06.02.21.06.04 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 02 Jun 2012 21:06:08 -0700 (PDT) From: Leo To: Stefan Monnier Subject: Re: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Sun, 03 Jun 2012 12:05:56 +0800 In-Reply-To: (Stefan Monnier's message of "Sat, 02 Jun 2012 23:18:15 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (Mac OS X 10.6.8) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11606 Cc: 11606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2012-06-03 11:18 +0800, Stefan Monnier wrote: > I also like removing those, but I still don't know why you think these > can be removed safely. I was thinking that add-hook supports adding local hooks which might be better than making those hooks buffer-local. What are your concerns about their safety? Leo From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 03 11:20:40 2012 Received: (at 11606) by debbugs.gnu.org; 3 Jun 2012 15:20:40 +0000 Received: from localhost ([127.0.0.1]:55916 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbCbg-0003FK-Kr for submit@debbugs.gnu.org; Sun, 03 Jun 2012 11:20:40 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:19064) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbCbN-0003En-1J for 11606@debbugs.gnu.org; Sun, 03 Jun 2012 11:20:39 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAG6Zu09sr+UI/2dsb2JhbABEtBGBCIIVAQEEAVYjBQsLNBIUGA0kiBwFugmQRAOjM4FYgwU X-IronPort-AV: E=Sophos;i="4.75,637,1330923600"; d="scan'208";a="187797018" Received: from 108-175-229-8.dsl.teksavvy.com (HELO pastel.home) ([108.175.229.8]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jun 2012 11:18:23 -0400 Received: by pastel.home (Postfix, from userid 20848) id 3673259607; Sun, 3 Jun 2012 11:18:23 -0400 (EDT) From: Stefan Monnier To: Leo Subject: Re: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el Message-ID: References: Date: Sun, 03 Jun 2012 11:18:23 -0400 In-Reply-To: (Leo's message of "Sun, 03 Jun 2012 12:05:56 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11606 Cc: 11606@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> I also like removing those, but I still don't know why you think these >> can be removed safely. > I was thinking that add-hook supports adding local hooks which might be > better than making those hooks buffer-local. That's generally true, but (add-hook 'foo 'bar) operates on the local part if the var is `make-variable-buffer-local', so the removal you suggest would break code that relies on this detail. > What are your concerns about their safety? My concern is that I know nothing about these variables, so I have no way to judge whether removing those things is safe. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 03 19:34:03 2012 Received: (at control) by debbugs.gnu.org; 3 Jun 2012 23:34:04 +0000 Received: from localhost ([127.0.0.1]:56195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbKJ9-0007Px-K5 for submit@debbugs.gnu.org; Sun, 03 Jun 2012 19:34:03 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:38497 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbKJ7-0007Pe-OX for control@debbugs.gnu.org; Sun, 03 Jun 2012 19:34:01 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SbKHH-0005X2-Jt for control@debbugs.gnu.org; Sun, 03 Jun 2012 19:32:07 -0400 Date: Sun, 03 Jun 2012 19:32:07 -0400 Message-Id: Subject: control message for bug 11606 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) tag 11606 notabug wontfix From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 05 12:17:24 2012 Received: (at 11606) by debbugs.gnu.org; 5 Jun 2012 16:17:24 +0000 Received: from localhost ([127.0.0.1]:58493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbwRf-0007jo-UN for submit@debbugs.gnu.org; Tue, 05 Jun 2012 12:17:24 -0400 Received: from mail-pz0-f44.google.com ([209.85.210.44]:32829) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SbwRK-0007ix-Vp for 11606@debbugs.gnu.org; Tue, 05 Jun 2012 12:17:22 -0400 Received: by dacx6 with SMTP id x6so6937386dac.3 for <11606@debbugs.gnu.org>; Tue, 05 Jun 2012 09:14:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=Bzosi1pjP5x9WlJi6KmIEIuDgHLJsWJuxwNKJOEKM/A=; b=ILjtoMul7EvcCE4brKgUEIlSh+FBWvaS9s/LK/fXU669EeZJT/KXXzr6kjMHlCmlj8 SatAIcmc8+x/+Kfi5tuBRAqBKZZExNLrL2mUktIUmgMI2Xp87KR5LcQS8Vyv06g10Ojd 8hwTPDS8KXsPg61PZvfMWsQqEGtjmZCZ0mR+iBOgydIToBMCGojghhs2adpg8aNOSOmb aoVTvtWJ8Nn8X/33zfCRxbHnyurqcihvkjfQUeYG/doYjbhdKcmnwExdN3WiMARS7RjR aZftOBKZbQj014qZWCNj2Yj17Z8NDD/qS7k+R1lG4ZTipHuU6ePizyYshUBf0Z0MtCci opVQ== Received: by 10.68.190.10 with SMTP id gm10mr2501459pbc.163.1338912893556; Tue, 05 Jun 2012 09:14:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.142.164.7 with HTTP; Tue, 5 Jun 2012 09:14:13 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Tue, 5 Jun 2012 18:14:13 +0200 Message-ID: Subject: Re: bug#11606: 24.1; Get rid of buffer local hook variables in find-file.el To: Leo Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 11606 Cc: 11606@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On Sun, Jun 3, 2012 at 6:05 AM, Leo wrote: > I was thinking that add-hook supports adding local hooks which might be > better than making those hooks buffer-local. Most hooks and hook-like variables can be useful as either global or buffer-local, and for these (add-hook X Y Z t) or (set (make-local-variable X) Y) is the way to go. But there are some hooks that make no sense as global variables, or are never used that way. For these, being automatically buffer-local is, in fact, less error prone. A notable example is revert-buffer-function, which strangely we have not made automatically-buffer local even when the 31 packages in lisp/** that assign it do convert it to buffer-local first... =C2=A0 =C2=A0 Juanma From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 01 03:08:45 2014 Received: (at control) by debbugs.gnu.org; 1 Feb 2014 08:08:45 +0000 Received: from localhost ([127.0.0.1]:43842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W9Vd6-0006tq-Ha for submit@debbugs.gnu.org; Sat, 01 Feb 2014 03:08:45 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:44000) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W9Vd3-0006ti-Ky for control@debbugs.gnu.org; Sat, 01 Feb 2014 03:08:42 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1W9Vco-0002Ze-DV for control@debbugs.gnu.org; Sat, 01 Feb 2014 09:08:26 +0100 Date: Sat, 01 Feb 2014 00:07:34 -0800 Message-Id: <874n4jntmh.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #11606 X-MailScanner-ID: 1W9Vco-0002Ze-DV X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1391846908.67083@nKDX0kxxVbBVazCAUFurxA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 11606 From unknown Sat Aug 16 12:45:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 01 Mar 2014 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator