From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 06:30:43 2012 Received: (at submit) by debbugs.gnu.org; 30 May 2012 10:30:43 +0000 Received: from localhost ([127.0.0.1]:49527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZgAt-0003by-1r for submit@debbugs.gnu.org; Wed, 30 May 2012 06:30:43 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54243) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZgAX-0003bN-Eq for submit@debbugs.gnu.org; Wed, 30 May 2012 06:30:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg90-00023F-ML for submit@debbugs.gnu.org; Wed, 30 May 2012 06:28:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:41656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg90-00023A-IS for submit@debbugs.gnu.org; Wed, 30 May 2012 06:28:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51482) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg8u-0004wG-BQ for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:28:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg8p-00022J-CQ for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:28:39 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:42515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg8p-00022E-94 for bug-gnu-emacs@gnu.org; Wed, 30 May 2012 06:28:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36638) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1SZg8o-000745-LW for bug-emacs@gnu.org; Wed, 30 May 2012 06:28:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZg8l-00021f-LX for bug-emacs@gnu.org; Wed, 30 May 2012 06:28:33 -0400 Received: from mx.meyering.net ([88.168.87.75]:35632) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZg8l-00021L-EQ for bug-emacs@gnu.org; Wed, 30 May 2012 06:28:31 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id 517376009D for ; Wed, 30 May 2012 12:28:29 +0200 (CEST) From: Jim Meyering To: bug-emacs@gnu.org Subject: mkstemp failure diagnostic lacks directory name Date: Wed, 30 May 2012 12:28:29 +0200 Message-ID: <87d35mt12q.fsf@rho.meyering.net> Lines: 61 MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) In emacs I tried to filter a section of an input file through a pipe and got this diagnostic: byte-code: Failed to open temporary file: No such file or directory, emacsXXXXXX Knowing it's due to mkstemp failure, most would suspect that /tmp is missing. But I set TMPDIR to a different private directory for each shell, and for me it means that the parent shell's temporary directory had been removed. Oops. It should be easy to work around simply by recreating that directory, but the diagnostic doesn't include the directory name. Sure, I was able to work around it by inspecting emacs's view of $TMPDIR, but I shouldn't have had to do that. With the tiny patch below, I now get a diagnostic like this: byte-code: Failed to open temporary file: No such file or directory, /t/jt-toGrGn/emacs3gdoKc >From a389e755b74e048a34628b4f5ccad9f244e99cc3 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 30 May 2012 12:25:58 +0200 Subject: [PATCH] diagnose mkstemp failure with full file name * callproc.c (Fcall_process_region): Diagnose mkstemp failure using the full, expanded name, including the directory part, not just the basename template. --- src/ChangeLog | 6 ++++++ src/callproc.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/ChangeLog b/src/ChangeLog index edf68a5..5d9e86e 100644 --- a/src/ChangeLog +++ b/src/ChangeLog @@ -1,3 +1,9 @@ +2012-05-30 Jim Meyering + + * callproc.c (Fcall_process_region): Diagnose mkstemp failure using + the full, expanded name, including the directory part, not just + the basename template. + 2012-05-30 Paul Eggert * alloc.c, lisp.h (make_pure_vector): Now static. diff --git a/src/callproc.c b/src/callproc.c index f7c9971..976d306 100644 --- a/src/callproc.c +++ b/src/callproc.c @@ -1015,7 +1015,7 @@ usage: (call-process-region START END PROGRAM &optional DELETE BUFFER DISPLAY &r UNBLOCK_INPUT; if (fd == -1) report_file_error ("Failed to open temporary file", - Fcons (Vtemp_file_name_pattern, Qnil)); + Fcons (build_string (tempfile), Qnil)); else close (fd); } -- 1.7.10.2.605.gbefc5ed From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 10:22:41 2012 Received: (at 11586) by debbugs.gnu.org; 30 May 2012 14:22:41 +0000 Received: from localhost ([127.0.0.1]:50352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZjnM-0001Jw-RW for submit@debbugs.gnu.org; Wed, 30 May 2012 10:22:41 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56600 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZjnJ-0001Jm-C6 for 11586@debbugs.gnu.org; Wed, 30 May 2012 10:22:39 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:42474 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZjlq-0007Cf-Qu; Wed, 30 May 2012 10:21:07 -0400 From: Chong Yidong To: Jim Meyering Subject: Re: bug#11586: mkstemp failure diagnostic lacks directory name References: <87d35mt12q.fsf@rho.meyering.net> Date: Wed, 30 May 2012 22:21:01 +0800 In-Reply-To: <87d35mt12q.fsf@rho.meyering.net> (Jim Meyering's message of "Wed, 30 May 2012 12:28:29 +0200") Message-ID: <87sjehwy0i.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11586 Cc: 11586@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Jim Meyering writes: > With the tiny patch below, I now get a diagnostic like this: > > byte-code: Failed to open temporary file: No such file or directory, /t/jt-toGrGn/emacs3gdoKc > > From a389e755b74e048a34628b4f5ccad9f244e99cc3 Mon Sep 17 00:00:00 2001 > From: Jim Meyering > Date: Wed, 30 May 2012 12:25:58 +0200 > Subject: [PATCH] diagnose mkstemp failure with full file name Looks good; committed to trunk. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed May 30 10:23:00 2012 Received: (at control) by debbugs.gnu.org; 30 May 2012 14:23:00 +0000 Received: from localhost ([127.0.0.1]:50355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZjng-0001KP-71 for submit@debbugs.gnu.org; Wed, 30 May 2012 10:23:00 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56606 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZjne-0001KI-Ck for control@debbugs.gnu.org; Wed, 30 May 2012 10:22:58 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:42476 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZjmC-0007DG-8y for control@debbugs.gnu.org; Wed, 30 May 2012 10:21:28 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11586 Date: Wed, 30 May 2012 22:21:24 +0800 Message-ID: <87pq9lwxzv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 11586 thanks From unknown Thu Aug 14 22:24:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 28 Jun 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator