From unknown Thu Jun 19 13:55:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#11571 <11571@debbugs.gnu.org> To: bug#11571 <11571@debbugs.gnu.org> Subject: Status: 24.0.97; doc string of `dired-get-subdir-min' Reply-To: bug#11571 <11571@debbugs.gnu.org> Date: Thu, 19 Jun 2025 20:55:25 +0000 retitle 11571 24.0.97; doc string of `dired-get-subdir-min' reassign 11571 emacs submitter 11571 "Drew Adams" severity 11571 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sun May 27 17:39:36 2012 Received: (at submit) by debbugs.gnu.org; 27 May 2012 21:39:36 +0000 Received: from localhost ([127.0.0.1]:45838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYlBX-0008HS-LL for submit@debbugs.gnu.org; Sun, 27 May 2012 17:39:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50621) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYlBD-0008Gz-Ka for submit@debbugs.gnu.org; Sun, 27 May 2012 17:39:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYl9u-00006D-S1 for submit@debbugs.gnu.org; Sun, 27 May 2012 17:37:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:35540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYl9u-000066-PO for submit@debbugs.gnu.org; Sun, 27 May 2012 17:37:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51748) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYl9t-0003xL-4F for bug-gnu-emacs@gnu.org; Sun, 27 May 2012 17:37:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SYl9r-00004y-7C for bug-gnu-emacs@gnu.org; Sun, 27 May 2012 17:37:52 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:22563) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SYl9r-0008W8-0Z for bug-gnu-emacs@gnu.org; Sun, 27 May 2012 17:37:51 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4RLbldq014180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 27 May 2012 21:37:48 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4RLblQg008059 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Sun, 27 May 2012 21:37:47 GMT Received: from abhmt107.oracle.com (abhmt107.oracle.com [141.146.116.59]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4RLbkaA002355 for ; Sun, 27 May 2012 16:37:47 -0500 Received: from dradamslap1 (/10.159.190.91) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 27 May 2012 14:37:46 -0700 From: "Drew Adams" To: Subject: 24.0.97; doc string of `dired-get-subdir-min' Date: Sun, 27 May 2012 14:37:35 -0700 Message-ID: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac08UO46pSuTtze/TVWh9YP/o0w5uA== X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) These parts have nothing to do with this function per se, and should be removed: "... If arg is nil, return nil. Error if arg is not nil and not a cons cell. See also `cdr-safe'." This is not the place to teach about cdr - this is misplaced zeal. Just say that the function returns the cdr of LIST. If you want to add something useful, say what that is, in terms of directories etc. But do not teach cdr and cons cells here. See Info node `(elisp)Cons Cells' for a discussion of related basic Lisp concepts such as cdr, car, cons cell and list. In GNU Emacs 24.0.97.1 (i386-mingw-nt5.1.2600) of 2012-05-16 on MARVIN Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include' From debbugs-submit-bounces@debbugs.gnu.org Sun May 27 17:43:26 2012 Received: (at 11571) by debbugs.gnu.org; 27 May 2012 21:43:26 +0000 Received: from localhost ([127.0.0.1]:45845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYlFF-0008N7-NA for submit@debbugs.gnu.org; Sun, 27 May 2012 17:43:26 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:38222) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SYlFD-0008Mv-Rd for 11571@debbugs.gnu.org; Sun, 27 May 2012 17:43:24 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4RLg3xq015885 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <11571@debbugs.gnu.org>; Sun, 27 May 2012 21:42:04 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4RLg3TL010386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <11571@debbugs.gnu.org>; Sun, 27 May 2012 21:42:03 GMT Received: from abhmt120.oracle.com (abhmt120.oracle.com [141.146.116.72]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4RLg30s032303 for <11571@debbugs.gnu.org>; Sun, 27 May 2012 16:42:03 -0500 Received: from dradamslap1 (/10.159.190.91) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 27 May 2012 14:42:02 -0700 From: "Drew Adams" To: <11571@debbugs.gnu.org> References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> Subject: RE: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' Date: Sun, 27 May 2012 14:41:52 -0700 Message-ID: <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac08UO46pSuTtze/TVWh9YP/o0w5uAAAEXxw In-Reply-To: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11571 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Actually, the real bug is that `dired-get-subdir-min' has no doc string, so the doc string of `cdr' is used in its stead. The whole point of defining and using a separate function for this, instead of just coding with `cdr', is to enable readers of the code - and a fortiori the doc - to think in terms of the data structure of directories and not just abstract cons cells. There should be doc at the proper level of abstraction here. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 16 19:51:01 2012 Received: (at 11571) by debbugs.gnu.org; 16 Sep 2012 23:51:01 +0000 Received: from localhost ([127.0.0.1]:37788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOc8-0005tf-1C for submit@debbugs.gnu.org; Sun, 16 Sep 2012 19:51:01 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]:21088) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TDOc6-0005tY-9f for 11571@debbugs.gnu.org; Sun, 16 Sep 2012 19:50:58 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q8GNnjpW026256 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <11571@debbugs.gnu.org>; Sun, 16 Sep 2012 23:49:45 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q8GNniH7022207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <11571@debbugs.gnu.org>; Sun, 16 Sep 2012 23:49:44 GMT Received: from abhmt108.oracle.com (abhmt108.oracle.com [141.146.116.60]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q8GNni6i005777 for <11571@debbugs.gnu.org>; Sun, 16 Sep 2012 18:49:44 -0500 Received: from dradamslap1 (/10.159.170.142) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 16 Sep 2012 16:49:44 -0700 From: "Drew Adams" To: <11571@debbugs.gnu.org> References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> Subject: RE: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' Date: Sun, 16 Sep 2012 16:49:33 -0700 Message-ID: <2BB8D54F9F074FDFB74334E2C2CF6652@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> Thread-Index: Ac08UO46pSuTtze/TVWh9YP/o0w5uAAAEXxwFgUs01A= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -7.4 (-------) X-Debbugs-Envelope-To: 11571 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -7.4 (-------) ping From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 23:00:50 2014 Received: (at 11571) by debbugs.gnu.org; 9 Feb 2014 04:00:50 +0000 Received: from localhost ([127.0.0.1]:58742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLZZ-0007cO-LX for submit@debbugs.gnu.org; Sat, 08 Feb 2014 23:00:50 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:32996) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLZW-0007YS-0L for 11571@debbugs.gnu.org; Sat, 08 Feb 2014 23:00:46 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCLZH-0004xu-Bh; Sun, 09 Feb 2014 05:00:31 +0100 From: Lars Ingebrigtsen To: "Drew Adams" Subject: Re: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> Date: Sat, 08 Feb 2014 19:59:19 -0800 In-Reply-To: <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> (Drew Adams's message of "Sun, 27 May 2012 14:41:52 -0700") Message-ID: <871tzdgcmg.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WCLZH-0004xu-Bh X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392523232.00777@4/f6eGKnCURwLCzGKi9mzA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 11571 Cc: 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) "Drew Adams" writes: > Actually, the real bug is that `dired-get-subdir-min' has no doc string, so the > doc string of `cdr' is used in its stead. The whole point of defining and using > a separate function for this, instead of just coding with `cdr', is to enable > readers of the code - and a fortiori the doc - to think in terms of the data > structure of directories and not just abstract cons cells. There should be doc > at the proper level of abstraction here. Help says: --- dired-get-subdir-min is an alias for `cdr' in `dired.el'. (dired-get-subdir-min LIST) Return the cdr of LIST. If arg is nil, return nil. Error if arg is not nil and not a cons cell. See also `cdr-safe'. --- I think that's fine. However: ;; can't use macro, must be redefinable for other alist format in dired-nstd. (defalias 'dired-get-subdir-min 'cdr) Which is kinda er. I don't know what nstd is, and the function doesn't seem to be redefined anywhere, so is this just legacy gunk? Should `dired-get-subdir-min' just be replaced by `cdr' in all the calling sites? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 17:25:37 2014 Received: (at 11571) by debbugs.gnu.org; 9 Feb 2014 22:25:37 +0000 Received: from localhost ([127.0.0.1]:60912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCcoh-00054J-Ua for submit@debbugs.gnu.org; Sun, 09 Feb 2014 17:25:36 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:16828) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCcoe-000545-SP for 11571@debbugs.gnu.org; Sun, 09 Feb 2014 17:25:33 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s19MPUuA003952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 9 Feb 2014 22:25:31 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s19MPTwd001024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 9 Feb 2014 22:25:30 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s19MPTOQ001019; Sun, 9 Feb 2014 22:25:29 GMT MIME-Version: 1.0 Message-ID: <7806d41c-d4e6-45f6-bbca-4abbf0a8ba9e@default> Date: Sun, 9 Feb 2014 14:25:27 -0800 (PST) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> In-Reply-To: <871tzdgcmg.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 11571 Cc: 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > Actually, the real bug is that `dired-get-subdir-min' has no doc > > string, so the doc string of `cdr' is used in its stead. The > > whole point of defining and using a separate function for this, > > instead of just coding with `cdr', is to enable readers of the > > code - and a fortiori the doc - to think in terms of the data > > structure of directories and not just abstract cons cells. There > > should be doc at the proper level of abstraction here. >=20 > Help says: >=20 > --- > dired-get-subdir-min is an alias for `cdr' in `dired.el'. > (dired-get-subdir-min LIST) > Return the cdr of LIST. If arg is nil, return nil. > Error if arg is not nil and not a cons cell. See also `cdr-safe'. > --- >=20 > I think that's fine. No, it is not fine. That doc is 100% unrelated to "dired", "getting" something, "subdir", and "minimum". If it were fine, then it would be even finer to get rid of this function, with its supposedly descriptive name, and use just cdr. If that is the fix you make, fine with me. If you keep the function then users deserve its doc to explain what it is about. Clearly, it is not just "about" returning the cdr. The function is named, presumably, to suggest what it is for: its purpose or behavior WRT DIRED AND SUBDIRS. Hard to believe that when someone goes to the trouble of spelling out in the bug report why better doc is needed here you cannot read and understand that. > However: >=20 > ;; can't use macro, must be redefinable for other alist format in > dired-nstd. > (defalias 'dired-get-subdir-min 'cdr) >=20 > Which is kinda er. >=20 > I don't know what nstd is, and the function doesn't seem to be > redefined anywhere, so is this just legacy gunk? Should > `dired-get-subdir-min' just be replaced by `cdr' in all the > calling sites? Yes, that can be the first question, if you want to get into it. If you do not want to file a separate (code) bug for that, fine. But if this function is kept then please document it properly. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 14:44:34 2019 Received: (at 11571) by debbugs.gnu.org; 1 Nov 2019 18:44:35 +0000 Received: from localhost ([127.0.0.1]:57133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQbuU-0002oi-DU for submit@debbugs.gnu.org; Fri, 01 Nov 2019 14:44:34 -0400 Received: from host.gofardesign.uk ([208.79.239.190]:53543) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQbuR-0002oR-Rf for 11571@debbugs.gnu.org; Fri, 01 Nov 2019 14:44:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ikv9JJGjep8EGez/3tpMPKqiL9XViNuC2ZmeRtzkZrU=; b=sUwBB2fz4iRWdMJ8ryDgI7GKr3 y5rJ1mrJY2/jshhTzV5EME3GR20FMfsLHuLGiX8gkqmp3TR6haWpOTWBnLpWJD4X5Nwyt9OEeUUIR 8q4bdfs9LkgxqHNjjdA15czvEqJVqOhBwKvGBTEtfTQ9qpp5mbxyHN7PWjLss2FNZvT4=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:48292 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iQbuL-0004nW-Nm; Fri, 01 Nov 2019 13:44:26 -0500 From: Stefan Kangas To: Lars Ingebrigtsen Subject: Re: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' In-Reply-To: <871tzdgcmg.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Sat, 08 Feb 2014 19:59:19 -0800") References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Fri, 01 Nov 2019 19:44:24 +0100 Message-ID: <878sozighj.fsf@skangas.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 11571 Cc: 11571@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: > "Drew Adams" writes: > >> Actually, the real bug is that `dired-get-subdir-min' has no doc string, so the >> doc string of `cdr' is used in its stead. The whole point of defining and using >> a separate function for this, instead of just coding with `cdr', is to enable >> readers of the code - and a fortiori the doc - to think in terms of the data >> structure of directories and not just abstract cons cells. There should be doc >> at the proper level of abstraction here. [...] > ;; can't use macro, must be redefinable for other alist format in dired-nstd. > (defalias 'dired-get-subdir-min 'cdr) > > Which is kinda er. > > I don't know what nstd is, and the function doesn't seem to be redefined > anywhere, so is this just legacy gunk? Should `dired-get-subdir-min' > just be replaced by `cdr' in all the calling sites? >From searching the web, I think dired-nstd is "dired nested", which indeed seems to be some old, now non-existent stuff from Emacs 19 or older. See this for example: https://www.cs.cmu.edu/cgi-bin/info2www?(dired.info)Dired%20Known%20Problems I therefore think it's safe to obsolete this function, like in the below patch. Comments? Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-dired-get-subdir-min-obsolete.patch >From 1a6c799863380e5986f26a9c8fd9d3fc98241bb1 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Thu, 31 Oct 2019 02:39:20 +0100 Subject: [PATCH] Make dired-get-subdir-min obsolete * lisp/dired.el (dired-get-subdir-min): Redefine as obsolete function alias for 'cdr'. (Bug#11571) (dired-get-subdir, dired-get-subdir-max, dired-clear-alist) (dired-next-subdir, dired-current-directory): * lisp/dired-aux.el (dired-rename-subdir-2) (dired-alist-sort, dired-insert-subdir-del) (dired-insert-subdir-doupdate, dired-goto-subdir) (dired-hide-subdir, dired-hide-all): Use 'cdr' instead of the above obsolete function. --- lisp/dired-aux.el | 18 +++++++++--------- lisp/dired.el | 13 ++++++------- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index b1521ecf01..7f690e7e72 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1713,7 +1713,7 @@ dired-rename-subdir-2 (let ((regexp (regexp-quote (directory-file-name dir))) (newtext (directory-file-name to)) buffer-read-only) - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) ;; Update subdir headerline in buffer (if (not (looking-at dired-subdir-regexp)) (error "%s not found where expected - dired-subdir-alist broken?" @@ -2476,8 +2476,8 @@ dired-alist-sort (setq dired-subdir-alist (sort dired-subdir-alist (lambda (elt1 elt2) - (> (dired-get-subdir-min elt1) - (dired-get-subdir-min elt2)))))) + (> (cdr elt1) + (cdr elt2)))))) (defun dired-kill-tree (dirname &optional remember-marks kill-root) "Kill all proper subdirs of DIRNAME, excluding DIRNAME itself. @@ -2520,7 +2520,7 @@ dired-insert-subdir-newpos (defun dired-insert-subdir-del (element) ;; Erase an already present subdir (given by ELEMENT) from buffer. ;; Move to that buffer position. Return a mark-alist. - (let ((begin-marker (dired-get-subdir-min element))) + (let ((begin-marker (cdr element))) (goto-char begin-marker) ;; Are at beginning of subdir (and inside it!). Now determine its end: (goto-char (dired-subdir-max)) @@ -2551,7 +2551,7 @@ dired-insert-subdir-doupdate ;; BEG-END is the subdir-region (as list of begin and end). (if elt ; subdir was already present ;; update its position (should actually be unchanged) - (set-marker (dired-get-subdir-min elt) (point-marker)) + (set-marker (cdr elt) (point-marker)) (dired-alist-add dirname (point-marker))) ;; The hook may depend on the subdir-alist containing the just ;; inserted subdir, so run it after dired-alist-add: @@ -2665,7 +2665,7 @@ dired-goto-subdir (setq dir (file-name-as-directory dir)) (let ((elt (assoc dir dired-subdir-alist))) (and elt - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) ;; dired-subdir-hidden-p and dired-add-entry depend on point being ;; at \n after this function succeeds. (progn (end-of-line) @@ -2763,7 +2763,7 @@ dired-hide-subdir (end-pos (1- (dired-get-subdir-max elt))) buffer-read-only) ;; keep header line visible, hide rest - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) (end-of-line) (if hidden-p (dired--unhide (point) end-pos) @@ -2782,14 +2782,14 @@ dired-hide-all ;; hide (let ((pos (point-max))) ; pos of end of last directory (dolist (subdir dired-subdir-alist) - (let ((start (dired-get-subdir-min subdir)) ; pos of prev dir + (let ((start (cdr subdir)) ; pos of prev dir (end (save-excursion (goto-char pos) ; current dir ;; we're somewhere on current dir's line (forward-line -1) (point)))) (dired--hide start end)) - (setq pos (dired-get-subdir-min subdir))))))) ; prev dir gets current dir + (setq pos (cdr subdir))))))) ; prev dir gets current dir ;;;###end dired-ins.el diff --git a/lisp/dired.el b/lisp/dired.el index 05789a3516..a94bf528c2 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -2857,21 +2857,20 @@ dired-get-subdir (let ((cur-dir (dired-current-directory))) (beginning-of-line) ; alist stores b-o-l positions (and (zerop (- (point) - (dired-get-subdir-min (assoc cur-dir + (cdr (assoc cur-dir dired-subdir-alist)))) cur-dir)))) -;; can't use macro, must be redefinable for other alist format in dired-nstd. -(defalias 'dired-get-subdir-min 'cdr) +(define-obsolete-function-alias 'dired-get-subdir-min 'cdr "27.1") (defun dired-get-subdir-max (elt) (save-excursion - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) (dired-subdir-max))) (defun dired-clear-alist () (while dired-subdir-alist - (set-marker (dired-get-subdir-min (car dired-subdir-alist)) nil) + (set-marker (cdr (car dired-subdir-alist)) nil) (setq dired-subdir-alist (cdr dired-subdir-alist)))) (defun dired-subdir-index (dir) @@ -2895,7 +2894,7 @@ dired-next-subdir ;; nth with negative arg does not return nil but the first element (setq index (- (dired-subdir-index this-dir) arg)) (setq pos (if (>= index 0) - (dired-get-subdir-min (nth index dired-subdir-alist)))) + (cdr (nth index dired-subdir-alist)))) (if pos (progn (goto-char pos) @@ -3116,7 +3115,7 @@ dired-current-directory (setq elt (car alist) dir (car elt) ;; use `<=' (not `<') as subdir line is part of subdir - alist (if (<= (dired-get-subdir-min elt) here) + alist (if (<= (cdr elt) here) nil ; found (cdr alist)))) (if localp -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 01 16:57:09 2019 Received: (at 11571) by debbugs.gnu.org; 1 Nov 2019 20:57:09 +0000 Received: from localhost ([127.0.0.1]:57344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQdym-0008MW-E2 for submit@debbugs.gnu.org; Fri, 01 Nov 2019 16:57:08 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:40094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQdyj-0008Ls-Jp for 11571@debbugs.gnu.org; Fri, 01 Nov 2019 16:57:07 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA1KsVRp070140; Fri, 1 Nov 2019 20:56:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=IIbUK5ZEC8wRKbyvTUQqjWmSrKslxL+Lc2y9bLKIIlc=; b=Wm3eI8G3eIVGWYc699O9xk8UgORDPl4cM1L/ubEU+d8PaUET6KbX0Q5IfsJxyYbSdzXh g+9NZ/PzPZQarFX0LfUTQ3xKAGW9fNgQTHTzy7jCFc8/irtaWEEGB4y8j5wUT4NmFKAS LOFZGnHuULzSc3J4XcCL/Xw53xuy/xUnFFJpNM258KUZgwyFBdFwvfJQEeuUnsQGaUmx qgFJkp9ty7KGioNpWNQbAQui3ap8lGntyf/lW08rrhj+/eaIPibMyguHOA0O4JOzMysK yvkVFw/VRHa1zQ31hFDpoyB6FCK6LROwjd0NVIKKxPBI7/4dQfN+0x/mx0fYzh3B4n5n jw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2vxwhfv4wx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Nov 2019 20:56:59 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA1KmHxp074022; Fri, 1 Nov 2019 20:54:58 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2w0qcrqbh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 01 Nov 2019 20:54:58 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA1Ksus5001856; Fri, 1 Nov 2019 20:54:57 GMT MIME-Version: 1.0 Message-ID: <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> Date: Fri, 1 Nov 2019 13:54:55 -0700 (PDT) From: Drew Adams To: Stefan Kangas , Lars Ingebrigtsen Subject: RE: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> In-Reply-To: <878sozighj.fsf@skangas.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9428 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=938 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911010193 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9428 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911010194 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 11571 Cc: 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I therefore think it's safe to obsolete this function, like in the > below patch. Comments? It's OK by me. Thx. ___ The use of cdr is clear enough, as long as you understand what `dired-subdir-alist' is. But that could be clearer.=20 `C-h v dired-subdir-alist' says: Association list of subdirectories and their buffer positions. Each subdirectory has an element: (DIRNAME . STARTMARKER). ... Directories don't have buffer positions. It would be clearer to say "listed subdirectories". It's not about subdirectories. It's about those subdirs that are listed in the Dired buffer, and STARTMARKER is the buffer position where such a _listing_ starts. The buffer position of a subdirectory isn't clear. The buffer position of a subdirectory listing is clear. From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 02 10:51:44 2019 Received: (at 11571) by debbugs.gnu.org; 2 Nov 2019 14:51:44 +0000 Received: from localhost ([127.0.0.1]:32823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQuki-00089X-6T for submit@debbugs.gnu.org; Sat, 02 Nov 2019 10:51:44 -0400 Received: from quimby.gnus.org ([80.91.231.51]:56180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iQukK-00088w-DN for 11571@debbugs.gnu.org; Sat, 02 Nov 2019 10:51:42 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iQukG-0003bM-Kn; Sat, 02 Nov 2019 15:51:18 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> Date: Sat, 02 Nov 2019 15:51:16 +0100 In-Reply-To: <878sozighj.fsf@skangas.se> (Stefan Kangas's message of "Fri, 01 Nov 2019 19:44:24 +0100") Message-ID: <87a79efi1n.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I therefore think it's safe to obsolete this function, like in the below > patch. Comments? Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 11571 Cc: 11571@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I therefore think it's safe to obsolete this function, like in the below > patch. Comments? Looks good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 10:09:45 2019 Received: (at 11571) by debbugs.gnu.org; 5 Nov 2019 15:09:46 +0000 Received: from localhost ([127.0.0.1]:38945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iS0Sn-00007b-KN for submit@debbugs.gnu.org; Tue, 05 Nov 2019 10:09:45 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:39392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iS0Sl-00007I-3n for 11571@debbugs.gnu.org; Tue, 05 Nov 2019 10:09:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ahp/NZaJ+0Z1DKOo5ZTAf80YKcYSyz52UIpT+crrxf4=; b=A41bVmEQj/ORqwA2vrujGPxiZh Xwi5tuiQlDLqEs2ufEBSNAG3up1t5l101L9yzGeX+H50YLS2Z5BO53TLD9OOGILw6vEMcoxjbgCz/ ZL0TjYRLqB6pBO8PeSuJdBsA5crojBc8ROJ58uqpQqVC8I8nBNozgGsKwE2KJzvHaw5A=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:59880 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iS0Sc-0007N1-NV; Tue, 05 Nov 2019 09:09:35 -0600 From: Stefan Kangas To: Drew Adams Subject: Re: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' In-Reply-To: <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> (Drew Adams's message of "Fri, 1 Nov 2019 13:54:55 -0700 (PDT)") References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Tue, 05 Nov 2019 16:09:32 +0100 Message-ID: <871rum742b.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 11571 Cc: Lars Ingebrigtsen , 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > The use of cdr is clear enough, as long as you > understand what `dired-subdir-alist' is. > > But that could be clearer. > > `C-h v dired-subdir-alist' says: > > Association list of subdirectories and their buffer positions. > Each subdirectory has an element: (DIRNAME . STARTMARKER). > ... > > Directories don't have buffer positions. > > It would be clearer to say "listed subdirectories". > It's not about subdirectories. It's about those > subdirs that are listed in the Dired buffer, and > STARTMARKER is the buffer position where such a > _listing_ starts. > > The buffer position of a subdirectory isn't clear. > The buffer position of a subdirectory listing is > clear. FWIW, I think it's already clear enough, given that the value after dired-maybe-insert-subdir will be something like: (("/home/skangas/wip/emacs/etc/" . #) ("/home/skangas/wip/emacs/" . #)) I'm not against trying to make it even clearer though. Do you have a suggestion for how to rewrite this text without going over the recommended 67 character limit? Association list of subdirectories and their buffer positions. The best I could come up with is this (exactly 67 characters): Alist of subdirectories and the buffer positions of their listings. Best regards, Stefan Kangas From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 05 11:21:50 2019 Received: (at 11571) by debbugs.gnu.org; 5 Nov 2019 16:21:50 +0000 Received: from localhost ([127.0.0.1]:39000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iS1aY-00024u-9E for submit@debbugs.gnu.org; Tue, 05 Nov 2019 11:21:50 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:43430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iS1aW-00024d-KG for 11571@debbugs.gnu.org; Tue, 05 Nov 2019 11:21:49 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA5GESns091653; Tue, 5 Nov 2019 16:21:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=VNdEMnZGHpaFMs7T7/XJsZlPchkcCUYBk6FGjJihYw0=; b=BNxvLLfCVxydfFZDB/E8Rqn+MuO1gOHS9svzXIRDzqjXUH5VPgfr7lxY3K/RofErLZGE 2aP4BpYX/UF8d/5dIHWNvCSVSehpi3CUB8NdOFY5lM4PRAiMT5uki9wLWL9kFKPByw9F rU/VV2uiU1y1iBvMenOU0xtXUEhtLPM5VPRy4EOHamJWAYgAibPR5NHnlhquh/7Wucwl txXoD5T4ZeWmau9hvJsFTVCGzB6qsrhkxHFnjLiPaenI1//GDMjbXFQaG+wdoDgXddXV m6Ahl2ADXDxrRo0c4qRwX5mEK/t1GseMahfcZLZOxY2CZ3JnljdAIIuQ/P/xalnvF0JE bw== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2w117tyqen-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Nov 2019 16:21:42 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA5GJYWH019954; Tue, 5 Nov 2019 16:21:42 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 2w2wck75da-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 05 Nov 2019 16:21:41 +0000 Received: from abhmp0017.oracle.com (abhmp0017.oracle.com [141.146.116.23]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id xA5GLeA4006699; Tue, 5 Nov 2019 16:21:40 GMT MIME-Version: 1.0 Message-ID: Date: Tue, 5 Nov 2019 08:21:39 -0800 (PST) From: Drew Adams To: Stefan Kangas Subject: RE: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> <871rum742b.fsf@marxist.se> In-Reply-To: <871rum742b.fsf@marxist.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9432 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050134 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9432 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1908290000 definitions=main-1911050134 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 11571 Cc: Lars Ingebrigtsen , 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > > It would be clearer to say "listed subdirectories". > > It's not about subdirectories. It's about those > > subdirs that are listed in the Dired buffer, and > > STARTMARKER is the buffer position where such a > > _listing_ starts. > =20 > Do you have a suggestion for how to rewrite this text without going > over the recommended 67 character limit? > Association list of subdirectories and their buffer positions. > The best I could come up with is this (exactly 67 characters): > Alist of subdirectories and the buffer positions of their listings. I already suggested it, at the beginning: "listed subdirectories" instead of just "subdirectories". To be even more precise, as it's not the listed subdirs that are used in the alist, but their names: Alist of listed subdirectory names and their buffer positions. However, the alist contains not only elements for the listed subdirs but also an element for the listed main dir. The doc string is unclear about that. This is clear, I think. And the lines are all less than 60 chars wide: Alist of listed directory names and their buffer positions. Alist elements have the form (DIRNAME . STARTMARKER), where DIRNAME is the listed absolute name of the directory and STARTMARKER is a marker at the beginning of DIRNAME. The elements are in reverse order of the listing. If no subdirectories are listed then the alist contains only one element, for the listed directory. That also makes clear that DIRNAME is an absolute file name, and it is what is shown in the listing. And it makes clear what the "one element" is when there are no subdir listings.=20 From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 08:31:14 2019 Received: (at 11571) by debbugs.gnu.org; 8 Nov 2019 13:31:15 +0000 Received: from localhost ([127.0.0.1]:44974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iT4M6-0007t9-AI for submit@debbugs.gnu.org; Fri, 08 Nov 2019 08:31:14 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:56340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iT4M5-0007sx-4j for 11571@debbugs.gnu.org; Fri, 08 Nov 2019 08:31:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ipgFzfnOUm0iiZY0DXRCMCz77pD3hRnbsAanDBqYXUk=; b=RAuNrcSUhTG8dbJWTqBqaE5QVo logLbDmYYZ90qAVWgqi/08AYF5DuLxyzR9lKbfB+CiC1BWs2zTWSjaywu9/czmxEm3GrKIGUVX69f Rd3DcpKx3NaAmXIV40BribB/P/M8Fo25/RPcvg5KBcsJGG1Xk3S+yrpz6Qyeq4eb2ctI=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:53670 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iT4Lt-0000od-Q3; Fri, 08 Nov 2019 07:31:06 -0600 From: Stefan Kangas To: Drew Adams Subject: Re: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' In-Reply-To: (Drew Adams's message of "Tue, 5 Nov 2019 08:21:39 -0800 (PST)") References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> <871rum742b.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Fri, 08 Nov 2019 14:30:59 +0100 Message-ID: <87bltmtrzg.fsf@marxist.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 11571 Cc: Lars Ingebrigtsen , 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Drew Adams writes: >> Do you have a suggestion for how to rewrite this text without going >> over the recommended 67 character limit? >> Association list of subdirectories and their buffer positions. >> The best I could come up with is this (exactly 67 characters): >> Alist of subdirectories and the buffer positions of their listings. [...] > However, the alist contains not only elements for the > listed subdirs but also an element for the listed main > dir. The doc string is unclear about that. > > This is clear, I think. And the lines are all less than > 60 chars wide: > > Alist of listed directory names and their buffer positions. > Alist elements have the form (DIRNAME . STARTMARKER), where > DIRNAME is the listed absolute name of the directory and > STARTMARKER is a marker at the beginning of DIRNAME. > > The elements are in reverse order of the listing. If no > subdirectories are listed then the alist contains only one > element, for the listed directory. > > That also makes clear that DIRNAME is an absolute file name, > and it is what is shown in the listing. And it makes clear > what the "one element" is when there are no subdir listings. Thanks, that's much better. I've attached an updated patch with a slightly different wording. If there are no further comments or objections, I intend to push this in a couple of days. Best regards, Stefan Kangas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Make-dired-get-subdir-min-obsolete.patch >From 181fea4507be10c80981ff7fd650f7d6b82de039 Mon Sep 17 00:00:00 2001 From: Stefan Kangas Date: Thu, 31 Oct 2019 02:39:20 +0100 Subject: [PATCH] Make dired-get-subdir-min obsolete * lisp/dired.el (dired-get-subdir-min): Redefine as obsolete function alias for 'cdr'. (Bug#11571) (dired-get-subdir, dired-get-subdir-max, dired-clear-alist) (dired-next-subdir, dired-current-directory): * lisp/dired-aux.el (dired-rename-subdir-2) (dired-alist-sort, dired-insert-subdir-del) (dired-insert-subdir-doupdate, dired-goto-subdir) (dired-hide-subdir, dired-hide-all): Use 'cdr' instead of the above obsolete function. (dired-subdir-alist): Doc fix. --- lisp/dired-aux.el | 18 +++++++++--------- lisp/dired.el | 20 +++++++++++--------- 2 files changed, 20 insertions(+), 18 deletions(-) diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el index 722d036e3f..184b507e1d 100644 --- a/lisp/dired-aux.el +++ b/lisp/dired-aux.el @@ -1728,7 +1728,7 @@ dired-rename-subdir-2 (let ((regexp (regexp-quote (directory-file-name dir))) (newtext (directory-file-name to)) buffer-read-only) - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) ;; Update subdir headerline in buffer (if (not (looking-at dired-subdir-regexp)) (error "%s not found where expected - dired-subdir-alist broken?" @@ -2491,8 +2491,8 @@ dired-alist-sort (setq dired-subdir-alist (sort dired-subdir-alist (lambda (elt1 elt2) - (> (dired-get-subdir-min elt1) - (dired-get-subdir-min elt2)))))) + (> (cdr elt1) + (cdr elt2)))))) (defun dired-kill-tree (dirname &optional remember-marks kill-root) "Kill all proper subdirs of DIRNAME, excluding DIRNAME itself. @@ -2535,7 +2535,7 @@ dired-insert-subdir-newpos (defun dired-insert-subdir-del (element) ;; Erase an already present subdir (given by ELEMENT) from buffer. ;; Move to that buffer position. Return a mark-alist. - (let ((begin-marker (dired-get-subdir-min element))) + (let ((begin-marker (cdr element))) (goto-char begin-marker) ;; Are at beginning of subdir (and inside it!). Now determine its end: (goto-char (dired-subdir-max)) @@ -2566,7 +2566,7 @@ dired-insert-subdir-doupdate ;; BEG-END is the subdir-region (as list of begin and end). (if elt ; subdir was already present ;; update its position (should actually be unchanged) - (set-marker (dired-get-subdir-min elt) (point-marker)) + (set-marker (cdr elt) (point-marker)) (dired-alist-add dirname (point-marker))) ;; The hook may depend on the subdir-alist containing the just ;; inserted subdir, so run it after dired-alist-add: @@ -2680,7 +2680,7 @@ dired-goto-subdir (setq dir (file-name-as-directory dir)) (let ((elt (assoc dir dired-subdir-alist))) (and elt - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) ;; dired-subdir-hidden-p and dired-add-entry depend on point being ;; at \n after this function succeeds. (progn (end-of-line) @@ -2778,7 +2778,7 @@ dired-hide-subdir (end-pos (1- (dired-get-subdir-max elt))) buffer-read-only) ;; keep header line visible, hide rest - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) (end-of-line) (if hidden-p (dired--unhide (point) end-pos) @@ -2797,14 +2797,14 @@ dired-hide-all ;; hide (let ((pos (point-max))) ; pos of end of last directory (dolist (subdir dired-subdir-alist) - (let ((start (dired-get-subdir-min subdir)) ; pos of prev dir + (let ((start (cdr subdir)) ; pos of prev dir (end (save-excursion (goto-char pos) ; current dir ;; we're somewhere on current dir's line (forward-line -1) (point)))) (dired--hide start end)) - (setq pos (dired-get-subdir-min subdir))))))) ; prev dir gets current dir + (setq pos (cdr subdir))))))) ; prev dir gets current dir ;;;###end dired-ins.el diff --git a/lisp/dired.el b/lisp/dired.el index 05789a3516..8939ea2d88 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -354,8 +354,11 @@ dired-re-dot ;; The subdirectory names in the next two lists are expanded. (defvar dired-subdir-alist nil - "Association list of subdirectories and their buffer positions. -Each subdirectory has an element: (DIRNAME . STARTMARKER). + "Alist of listed subdirectories and their buffer positions. +Alist elements have the form (DIRNAME . STARTMARKER), where +DIRNAME is the absolute name of the directory and STARTMARKER is +a marker at the beginning of DIRNAME. + The order of elements is the reverse of the order in the buffer. In simple cases, this list contains one element.") @@ -2857,21 +2860,20 @@ dired-get-subdir (let ((cur-dir (dired-current-directory))) (beginning-of-line) ; alist stores b-o-l positions (and (zerop (- (point) - (dired-get-subdir-min (assoc cur-dir + (cdr (assoc cur-dir dired-subdir-alist)))) cur-dir)))) -;; can't use macro, must be redefinable for other alist format in dired-nstd. -(defalias 'dired-get-subdir-min 'cdr) +(define-obsolete-function-alias 'dired-get-subdir-min 'cdr "27.1") (defun dired-get-subdir-max (elt) (save-excursion - (goto-char (dired-get-subdir-min elt)) + (goto-char (cdr elt)) (dired-subdir-max))) (defun dired-clear-alist () (while dired-subdir-alist - (set-marker (dired-get-subdir-min (car dired-subdir-alist)) nil) + (set-marker (cdr (car dired-subdir-alist)) nil) (setq dired-subdir-alist (cdr dired-subdir-alist)))) (defun dired-subdir-index (dir) @@ -2895,7 +2897,7 @@ dired-next-subdir ;; nth with negative arg does not return nil but the first element (setq index (- (dired-subdir-index this-dir) arg)) (setq pos (if (>= index 0) - (dired-get-subdir-min (nth index dired-subdir-alist)))) + (cdr (nth index dired-subdir-alist)))) (if pos (progn (goto-char pos) @@ -3116,7 +3118,7 @@ dired-current-directory (setq elt (car alist) dir (car elt) ;; use `<=' (not `<') as subdir line is part of subdir - alist (if (<= (dired-get-subdir-min elt) here) + alist (if (<= (cdr elt) here) nil ; found (cdr alist)))) (if localp -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 08 13:07:07 2019 Received: (at 11571) by debbugs.gnu.org; 8 Nov 2019 18:07:07 +0000 Received: from localhost ([127.0.0.1]:47568 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iT8f2-0004cK-Md for submit@debbugs.gnu.org; Fri, 08 Nov 2019 13:07:07 -0500 Received: from userp2130.oracle.com ([156.151.31.86]:37338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iT8f0-0004bm-Bi for 11571@debbugs.gnu.org; Fri, 08 Nov 2019 13:07:02 -0500 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA8I47In045272; Fri, 8 Nov 2019 18:06:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=NlPLidm+OtpF3cbNL9t4pM6gB+mRdUS/5r1I9ymzAPk=; b=lT6JoZxS0LUI9+byGodHWazuf/wB7TVOR+FxxznuBuLX5WKTPIh39eOTLIkO8+Juhqiu nco7zKWFA2biM9D2LjnvoxtJoSj3/+r404kVwn0BARV+XAUuhLYLHeE08Sd6F9NfofNv KO3V/oIPe9fVvf+7Nzf+E2m0HlVTKGWqYDTt6j5hG/JsVeUsWqaEiawXc3XnJAuxDfh8 jmeYKOl4snCmxYtu8150dkSAPi+KTD+jn8eTTkle69AFS1qoEmw9EytHbcbTBW6nyRuT TAyVJv2jI7rNYn10pirqB8I983EtnG31nG0bklTCATJbjKrXsEvDmwR555lQX4wZZgED VQ== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 2w41w1ex7t-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2019 18:06:56 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xA8I4LBR027814; Fri, 8 Nov 2019 18:04:55 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 2w5cxk1rj6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 08 Nov 2019 18:04:51 +0000 Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xA8I41VO016149; Fri, 8 Nov 2019 18:04:02 GMT MIME-Version: 1.0 Message-ID: <0fb5b6cb-018d-48cb-8b69-4259d9f99689@default> Date: Fri, 8 Nov 2019 18:04:01 +0000 (UTC) From: Drew Adams To: Stefan Kangas Subject: RE: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> <871rum742b.fsf@marxist.se> <87bltmtrzg.fsf@marxist.se> In-Reply-To: <87bltmtrzg.fsf@marxist.se> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4900.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9435 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=707 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080177 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9435 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=805 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1910280000 definitions=main-1911080177 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 11571 Cc: Lars Ingebrigtsen , 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Thanks, that's much better. I've attached an updated patch with a > slightly different wording. If there are no further comments or > objections, I intend to push this in a couple of days. OK by me. Thx. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 10 16:17:44 2019 Received: (at 11571) by debbugs.gnu.org; 10 Nov 2019 21:17:44 +0000 Received: from localhost ([127.0.0.1]:52686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTuae-0003wv-HD for submit@debbugs.gnu.org; Sun, 10 Nov 2019 16:17:44 -0500 Received: from host.gofardesign.uk ([208.79.239.190]:38959) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iTuad-0003wg-Cs; Sun, 10 Nov 2019 16:17:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=marxist.se; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=SO2r/cyXd/Pefqt0tHHIch667wnklBLjtLTd9c3myJo=; b=q9csNpraDjuLafyYwsPqUxaJhL Sk5IDoZy+6rs6W0jrBv33OoeA2aNXAGFZlb6uZMyWVVS5HK8s+0QtGoD2cHuKBICJrFrzcZQ+532k VvwAtK4ihTo7Zdaiae910LSNBA8+ExTg7aPsuN6LCxkPCo20G/XAbqtuUottY4RxJF9s=; Received: from h-70-69.a785.priv.bahnhof.se ([155.4.70.69]:52354 helo=localhost) by host.gofardesign.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1iTuaX-0006G7-CM; Sun, 10 Nov 2019 15:17:37 -0600 From: Stefan Kangas To: Drew Adams Subject: Re: bug#11571: 24.0.97; doc string of `dired-get-subdir-min' In-Reply-To: <87bltmtrzg.fsf@marxist.se> (Stefan Kangas's message of "Fri, 08 Nov 2019 14:30:59 +0100") References: <144EDF3C01664A2180447B02D1A6EB09@us.oracle.com> <484EACDE2A4A4185B158B84473AB1710@us.oracle.com> <871tzdgcmg.fsf@building.gnus.org> <878sozighj.fsf@skangas.se> <7374f5d9-6d88-4351-bd63-b526ea0d3486@default> <871rum742b.fsf@marxist.se> <87bltmtrzg.fsf@marxist.se> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Date: Sun, 10 Nov 2019 22:17:35 +0100 Message-ID: <87v9rrsa6o.fsf@marxist.se> MIME-Version: 1.0 Content-Type: text/plain X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host.gofardesign.uk X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - marxist.se X-Get-Message-Sender-Via: host.gofardesign.uk: authenticated_id: stefan@marxist.se X-Authenticated-Sender: host.gofardesign.uk: stefan@marxist.se X-Source: X-Source-Args: X-Source-Dir: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 11571 Cc: Lars Ingebrigtsen , 11571@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 11571 27.1 thanks Stefan Kangas writes: > If there are no further comments or objections, I intend to push > this in a couple of days. Now pushed to master as commit 0154e41b18. Closing. Best regards, Stefan Kangas From unknown Thu Jun 19 13:55:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 09 Dec 2019 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator