GNU bug report logs - #11567
24.0.97; WTF? ROFL! (hilarious bug)

Previous Next

Full log

Message #17 received at 11567 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Tobias Bading <tbading <at> web.de>, Troels Nielsen <bn.troels <at> gmail.com>,
	11567 <at> debbugs.gnu.org
Subject: Re: bug#11567: 24.0.97; WTF? ROFL! (hilarious bug)
Date: Mon, 28 May 2012 20:19:14 +0200

[Message part 1 (text/plain, inline)]

>> Why can't we use `window--delete' instead of `iconify-frame' here?
>
> Probably no reason.

Then maybe we should use `quit-window' in the first place.  Attached
find a patch for those who would give it a try (I hardly ever see the
completions buffer).

martin

[simple.diff (text/plain, inline)]

*** lisp/simple.el	2012-05-04 23:16:47 +0000
--- lisp/simple.el	2012-05-28 17:54:25 +0000
***************
*** 6212,6227 ****
  
        (unless (buffer-live-p buffer)
          (error "Destination buffer is dead"))
!       (select-window (posn-window (event-start event)))
!       (if (and (one-window-p t 'selected-frame)
! 	       (window-dedicated-p (selected-window)))
! 	  ;; This is a special buffer's frame
! 	  (iconify-frame (selected-frame))
! 	(or (window-dedicated-p (selected-window))
! 	    (bury-buffer)))
!       (select-window
!        (or (get-buffer-window buffer 0)
!            owindow))
  
        (with-current-buffer buffer
          (choose-completion-string
--- 6212,6218 ----
  
        (unless (buffer-live-p buffer)
          (error "Destination buffer is dead"))
!       (quit-window nil (posn-window (event-start event)))
  
        (with-current-buffer buffer
          (choose-completion-string

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.