From unknown Wed Sep 10 02:44:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11552: 23.4; woman.el bold \e Resent-From: Kevin Ryde Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 May 2012 01:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11552@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133782356418361 (code B ref -1); Thu, 24 May 2012 01:40:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 May 2012 01:39:24 +0000 Received: from localhost ([127.0.0.1]:41206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXN1Q-0004m6-8K for submit@debbugs.gnu.org; Wed, 23 May 2012 21:39:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46536) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SXN1O-0004lt-19 for submit@debbugs.gnu.org; Wed, 23 May 2012 21:39:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXN0R-0006x7-92 for submit@debbugs.gnu.org; Wed, 23 May 2012 21:38:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SUBJ_OBFU_PUNCT_FEW, T_TVD_MIME_NO_HEADERS autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:50927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXN0R-0006x2-5i for submit@debbugs.gnu.org; Wed, 23 May 2012 21:38:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXN0P-00081O-9p for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 21:38:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SXN0N-0006wJ-8V for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 21:38:20 -0400 Received: from mailout1-11.pacific.net.au ([125.255.80.130]:48834 helo=mailout3-syd3.pacific.net.au) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SXN0M-0006w5-Lp for bug-gnu-emacs@gnu.org; Wed, 23 May 2012 21:38:19 -0400 Received: from mailproxy4-syd3.pacific.net.au (mailproxy4-syd3.pacific.net.au [61.8.2.162]) by mailout3-syd3.pacific.net.au (Postfix) with ESMTP id 8E14F4F97E4 for ; Thu, 24 May 2012 11:38:12 +1000 (EST) Received: from blah.blah (unknown [203.26.175.125]) by mailproxy4-syd3.pacific.net.au (Postfix) with ESMTP id 57D0B2C075 for ; Thu, 24 May 2012 11:38:11 +1000 (EST) Received: from gg by blah.blah with local (Exim 4.72) (envelope-from ) id 1SXMv8-0000at-UC for bug-gnu-emacs@gnu.org; Thu, 24 May 2012 11:32:54 +1000 From: Kevin Ryde Date: Thu, 24 May 2012 11:32:54 +1000 Message-ID: <87y5oi4b3t.fsf@blah.blah> User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.4 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= With the esc-face.1 below, (woman-find-file "esc-face.1") produces bold \ backslash with the "\" not in bold, where I expected it would be (man-db+groff makes it bold). I think woman.el.esc-face.diff below could correct this. 2012-05-24 Kevin Ryde * woman.el (woman-decode-region): Replace escaped-escapes using `subst-char-in-region' so bold or underline on \e is preserved. I struck this in some perl pod2man output. It uses \e for backslashes in "verbatim" output paragraphs (bits of sample code usually). Those parts are in ".ft CW" font, which comes out of woman.el as woman-unknown face (which is red). But the face wasn't on the backslashes. --=-=-= Content-Disposition: inline; filename=esc-face.1 .TH FOO 1 .SH NAME .B bold \e backslash --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=woman.el.esc-face.diff --- woman.el.orig 2012-05-19 12:08:35.000000000 +1000 +++ woman.el 2012-05-24 07:09:48.000000000 +1000 @@ -2394,17 +2394,20 @@ (woman-negative-vertical-space from)) (if woman-preserve-ascii - ;; Re-instate escaped escapes to just `\' and unpaddable - ;; spaces to just `space', without inheriting any text - ;; properties. This is not necessary, UNLESS the buffer is to - ;; be saved as ASCII. + ;; Re-instate escaped escapes to just `\' and unpaddable spaces to + ;; just `space'. This is not necessary for display since there's + ;; display table entries for the escaped chars, but it is necessary + ;; if the buffer might be saved as ASCII. + ;; + ;; `subst-char-in-region' preserves text properties on the + ;; characters, which is necessary for bold, underline, etc on \e. + ;; There's usually no face on spaces, but if there is then it's good + ;; to keep that too. (progn - (goto-char from) - (while (search-forward woman-escaped-escape-string nil t) - (delete-char -1) (insert ?\\)) - (goto-char from) - (while (search-forward woman-unpadded-space-string nil t) - (delete-char -1) (insert ?\ )))) + (subst-char-in-region from (point-max) + woman-escaped-escape-char ?\\) + (subst-char-in-region from (point-max) + woman-unpadded-space-char ?\ ))) ;; Must return the new end of file if used in format-alist. (point-max))) --=-=-= In GNU Emacs 23.4.1 (i486-pc-linux-gnu, GTK+ Version 2.24.10) of 2012-04-08 on biber, modified by Debian Windowing system distributor `The X.Org Foundation', version 11.0.10707000 configured using `configure '--build' 'i486-linux-gnu' '--build' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var/lib' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs23:/etc/emacs:/usr/local/share/emacs/23.4/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.4/site-lisp:/usr/share/emacs/site-lisp' '--with-crt-dir=/usr/lib/i386-linux-gnu' '--with-x=yes' '--with-x-toolkit=gtk' '--with-toolkit-scroll-bars' 'build_alias=i486-linux-gnu' 'CFLAGS=-g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Wformat-security -Werror=format-security -Wall -DDEBIAN -O2' 'CPPFLAGS=-D_FORTIFY_SOURCE=2'' --=-=-=-- From unknown Wed Sep 10 02:44:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11552: 23.4; woman.el bold \e Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jul 2012 10:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11552 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kevin Ryde Cc: 11552@debbugs.gnu.org Received: via spool by 11552-submit@debbugs.gnu.org id=B11552.134165596817053 (code B ref 11552); Sat, 07 Jul 2012 10:13:02 +0000 Received: (at 11552) by debbugs.gnu.org; 7 Jul 2012 10:12:48 +0000 Received: from localhost ([127.0.0.1]:53972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnS0N-0004Qz-Dk for submit@debbugs.gnu.org; Sat, 07 Jul 2012 06:12:48 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:47049) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnS0L-0004Qs-PN for 11552@debbugs.gnu.org; Sat, 07 Jul 2012 06:12:46 -0400 Received: from [155.69.186.151] (port=33346 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SnRvR-00031Y-2L; Sat, 07 Jul 2012 06:07:42 -0400 From: Chong Yidong References: <87y5oi4b3t.fsf@blah.blah> Date: Sat, 07 Jul 2012 18:07:36 +0800 In-Reply-To: <87y5oi4b3t.fsf@blah.blah> (Kevin Ryde's message of "Thu, 24 May 2012 11:32:54 +1000") Message-ID: <877gufsx3r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Kevin Ryde writes: > With the esc-face.1 below, > > (woman-find-file "esc-face.1") > > produces > > bold \ backslash > > with the "\" not in bold, where I expected it would be (man-db+groff > makes it bold). > > I think woman.el.esc-face.diff below could correct this. Committed, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 07 06:12:59 2012 Received: (at control) by debbugs.gnu.org; 7 Jul 2012 10:12:59 +0000 Received: from localhost ([127.0.0.1]:53975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnS0Z-0004RL-4K for submit@debbugs.gnu.org; Sat, 07 Jul 2012 06:12:59 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:47054) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SnS0X-0004RE-Af for control@debbugs.gnu.org; Sat, 07 Jul 2012 06:12:57 -0400 Received: from [155.69.186.151] (port=33347 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SnRvd-00031q-A8 for control@debbugs.gnu.org; Sat, 07 Jul 2012 06:07:53 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11552 Date: Sat, 07 Jul 2012 18:07:49 +0800 Message-ID: <87mx3bg9ze.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 11552 thanks