GNU bug report logs - #11541
24.0.97; Crash when visiting file on OS X 10.7.3

Previous Next

Packages: emacs, ns;

Reported by: Florian Ebeling <florian.ebeling <at> gmail.com>

Date: Tue, 22 May 2012 16:20:02 UTC

Severity: important

Merged with 11684, 11792, 11801

Found in versions 24.0.97, 24.1.50, 24.1

Done: Jan Djärv <jan.h.d <at> swipnet.se>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Chong Yidong <cyd <at> gnu.org>
To: Florian Ebeling <florian.ebeling <at> gmail.com>
Cc: 11541 <at> debbugs.gnu.org
Subject: bug#11541: 24.0.97; Crash when visiting file on OS X 10.7.3
Date: Thu, 31 May 2012 14:52:12 +0800

Florian Ebeling <florian.ebeling <at> gmail.com> writes:

> It still stops at the same location, which is 531 after the patch.
>
> 524	    if (!FONT_SPEC_P (font_spec))
> 525	      abort ();
> 526	
> 527 fkeys = [NSMutableSet setWithArray: [[fdesc fontAttributes]
> allKeys]];
> 528	    if (isMatch)
> 529		[fkeys removeObject: NSFontFamilyAttribute];
> 530	
> 531 matchingDescs = [fdesc matchingFontDescriptorsWithMandatoryKeys:
> fkeys];
> (gdb) p font_spec
> $1 = 140734799760960
> (gdb) xtype
> Lisp_Int0

Does the following patch fix the crash?

=== modified file 'src/nsfont.m'
*** src/nsfont.m	2012-02-10 18:58:48 +0000
--- src/nsfont.m	2012-05-31 06:51:00 +0000
***************
*** 157,164 ****
  	fdesc = [fdesc fontDescriptorWithFamily: family];
        }
  
-     [fdAttrs release];
-     [tdict release];
      return fdesc;
  }
  
--- 157,162 ----
This bug report was last modified 12 years and 255 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.