From unknown Sat Sep 20 08:01:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#1154 <1154@debbugs.gnu.org> To: bug#1154 <1154@debbugs.gnu.org> Subject: Status: C-x 4 a in struct [] diff does not work anymore Reply-To: bug#1154 <1154@debbugs.gnu.org> Date: Sat, 20 Sep 2025 15:01:41 +0000 retitle 1154 C-x 4 a in struct [] diff does not work anymore reassign 1154 emacs,cc-mode submitter 1154 Dan Nicolaescu severity 1154 normal thanks From dann@mothra.ics.uci.edu Sun Oct 12 19:39:16 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.1 required=4.0 tests=AWL,BAYES_00,FOURLA, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 13 Oct 2008 02:39:16 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9D2dBkH030974 for ; Sun, 12 Oct 2008 19:39:13 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KpDKw-0003wv-Nx for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:10 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KpDKu-0003vu-2q for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:10 -0400 Received: from [199.232.76.173] (port=36104 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KpDKt-0003vr-St for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:07 -0400 Received: from sallyv2.ics.uci.edu ([128.195.1.120]:39372) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1KpDKt-0000fJ-D1 for bug-gnu-emacs@gnu.org; Sun, 12 Oct 2008 22:39:08 -0400 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by sallyv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9D2cvkU006146 for ; Sun, 12 Oct 2008 19:38:57 -0700 (PDT) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9D2cut9000668; Sun, 12 Oct 2008 19:38:56 -0700 (PDT) Date: Sun, 12 Oct 2008 19:38:56 -0700 (PDT) Message-Id: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs@gnu.org Subject: C-x 4 a in struct [] diff does not work anymore X-Debbugs-No-Ack: yes Lines: 36 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9D2cvkU006146 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) For the patch below, with the point on the first + line, C-x 4 a adds an entry called: * emacsclient.c (]): emacs-22.2 added the correct entry: * emacsclient.c (longopts): Also, for the second hunk C-x 4 a cannot find the function name. Index: emacsclient.c =================================================================== RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v retrieving revision 1.132 diff -u -3 -p -u -p -r1.132 emacsclient.c --- emacsclient.c 19 Sep 2008 16:45:12 -0000 1.132 +++ emacsclient.c 13 Oct 2008 01:34:25 -0000 @@ -156,6 +156,7 @@ struct option longopts[] = { "help", no_argument, NULL, 'H' }, { "version", no_argument, NULL, 'V' }, { "tty", no_argument, NULL, 't' }, + { "nw", no_argument, NULL, 't' }, { "create-frame", no_argument, NULL, 'c' }, { "alternate-editor", required_argument, NULL, 'a' }, #ifndef NO_SOCKETS_IN_FILE_SYSTEM @@ -474,7 +475,7 @@ decode_options (argc, argv) while (1) { - int opt = getopt_long (argc, argv, + int opt = getopt_long_only (argc, argv, #ifndef NO_SOCKETS_IN_FILE_SYSTEM "VHnea:s:f:d:tc", #else From rgm@gnu.org Mon Oct 13 13:01:04 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-9.6 required=4.0 tests=AWL,BAYES_00,MISSING_SUBJECT, NOSUBJECT,RCVD_IN_DNSWL_MED,VALID_BTS_CONTROL,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at control) by emacsbugs.donarmstrong.com; 13 Oct 2008 20:01:04 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9DK11YV031536 for ; Mon, 13 Oct 2008 13:01:03 -0700 Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1KpTYl-0005HD-K1; Mon, 13 Oct 2008 15:58:31 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <18675.43111.536125.792122@fencepost.gnu.org> Date: Mon, 13 Oct 2008 15:58:31 -0400 From: Glenn Morris To: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: green X-Ran: \~"6_B * progmodes/cc-cmds.el (c-defun-name, c-cpp-define-name): New optimised functions to get the name of the current defun/macro. * add-log.el (add-log-current-defun): Move the functionality which gets the current function name for C like modes to cc-cmds.el, thus optimising for speed. From acm@muc.de Fri Oct 17 14:09:00 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.7 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 17 Oct 2008 21:09:00 +0000 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9HL8voP027611 for ; Fri, 17 Oct 2008 14:08:58 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KqwZ6-0005nf-NY for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:56 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KqwZ5-0005mU-9n for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:55 -0400 Received: from [199.232.76.173] (port=47259 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KqwZ4-0005mM-Vt for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:54 -0400 Received: from colin.muc.de ([193.149.48.1]:1106 helo=mail.muc.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KqwZ4-00022c-Em for bug-gnu-emacs@gnu.org; Fri, 17 Oct 2008 17:08:54 -0400 Received: (qmail 78186 invoked by uid 3782); 17 Oct 2008 21:08:49 -0000 Received: from acm.muc.de (pD9E53977.dip.t-dialin.net [217.229.57.119]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Fri, 17 Oct 2008 23:08:47 +0200 Received: (qmail 5531 invoked by uid 1000); 17 Oct 2008 21:17:50 -0000 Date: Fri, 17 Oct 2008 21:17:50 +0000 To: Dan Nicolaescu , 1154@debbugs.gnu.org Cc: bug-gnu-emacs@gnu.org Subject: Re: bug#1154: C-x 4 a in struct [] diff does not work anymore Message-ID: <20081017211750.GA2157@muc.de> References: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-detected-operating-system: by monty-python.gnu.org: FreeBSD 4.6-4.9 X-CrossAssassin-Score: 2 Hi, Dan: I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes the first bug (longopts). I can't reproduce the second bug (C-x 4 a can't find the name for the second hunk). Could you let me know whether or not it's still a problem. Thanks! On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote: > For the patch below, with the point on the first + line, C-x 4 a > adds an entry called: > > * emacsclient.c (]): > > emacs-22.2 added the correct entry: > > * emacsclient.c (longopts): > > Also, for the second hunk C-x 4 a cannot find the function name. > > > Index: emacsclient.c > =================================================================== > RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v > retrieving revision 1.132 > diff -u -3 -p -u -p -r1.132 emacsclient.c > --- emacsclient.c 19 Sep 2008 16:45:12 -0000 1.132 > +++ emacsclient.c 13 Oct 2008 01:34:25 -0000 > @@ -156,6 +156,7 @@ struct option longopts[] = > { "help", no_argument, NULL, 'H' }, > { "version", no_argument, NULL, 'V' }, > { "tty", no_argument, NULL, 't' }, > + { "nw", no_argument, NULL, 't' }, > { "create-frame", no_argument, NULL, 'c' }, > { "alternate-editor", required_argument, NULL, 'a' }, > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > @@ -474,7 +475,7 @@ decode_options (argc, argv) > > while (1) > { > - int opt = getopt_long (argc, argv, > + int opt = getopt_long_only (argc, argv, > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > "VHnea:s:f:d:tc", > #else > -- Alan Mackenzie (Nuremberg, Germany). From dann@mothra.ics.uci.edu Sat Oct 18 00:53:40 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-8.7 required=4.0 tests=AWL,BAYES_00,FOURLA, HAS_BUG_NUMBER,MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1154-done) by emacsbugs.donarmstrong.com; 18 Oct 2008 07:53:40 +0000 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m9I7rbna024968 for <1154-done@emacsbugs.donarmstrong.com>; Sat, 18 Oct 2008 00:53:38 -0700 Received: from mothra.ics.uci.edu (mothra.ics.uci.edu [128.195.6.93]) by barrelv2.ics.uci.edu (8.13.7+Sun/8.13.7) with ESMTP id m9I7rPs5014342; Sat, 18 Oct 2008 00:53:25 -0700 (PDT) Received: (from dann@localhost) by mothra.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id m9I7rPsu017038; Sat, 18 Oct 2008 00:53:25 -0700 (PDT) Date: Sat, 18 Oct 2008 00:53:25 -0700 (PDT) Message-Id: <200810180753.m9I7rPsu017038@mothra.ics.uci.edu> From: Dan Nicolaescu To: Alan Mackenzie Cc: 1154-done@debbugs.gnu.org Subject: Re: bug#1154: C-x 4 a in struct [] diff does not work anymore References: <200810130238.m9D2cut9000668@mothra.ics.uci.edu> <20081017211750.GA2157@muc.de> X-Debbugs-No-Ack: yes In-Reply-To: <20081017211750.GA2157@muc.de> (Alan Mackenzie's message of "Fri, 17 Oct 2008 21:17:50 +0000") Lines: 58 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: m9I7rPs5014342 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@mothra.ics.uci.edu Alan Mackenzie writes: > Hi, Dan: > > I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes > the first bug (longopts). > > I can't reproduce the second bug (C-x 4 a can't find the name for the > second hunk). Could you let me know whether or not it's still a > problem. Thanks! All the issues seem fixed. Closing the bug. Thanks! > On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote: > > For the patch below, with the point on the first + line, C-x 4 a > > adds an entry called: > > > > * emacsclient.c (]): > > > > emacs-22.2 added the correct entry: > > > > * emacsclient.c (longopts): > > > > Also, for the second hunk C-x 4 a cannot find the function name. > > > > > > Index: emacsclient.c > > =================================================================== > > RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v > > retrieving revision 1.132 > > diff -u -3 -p -u -p -r1.132 emacsclient.c > > --- emacsclient.c 19 Sep 2008 16:45:12 -0000 1.132 > > +++ emacsclient.c 13 Oct 2008 01:34:25 -0000 > > @@ -156,6 +156,7 @@ struct option longopts[] = > > { "help", no_argument, NULL, 'H' }, > > { "version", no_argument, NULL, 'V' }, > > { "tty", no_argument, NULL, 't' }, > > + { "nw", no_argument, NULL, 't' }, > > { "create-frame", no_argument, NULL, 'c' }, > > { "alternate-editor", required_argument, NULL, 'a' }, > > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > > @@ -474,7 +475,7 @@ decode_options (argc, argv) > > > > while (1) > > { > > - int opt = getopt_long (argc, argv, > > + int opt = getopt_long_only (argc, argv, > > #ifndef NO_SOCKETS_IN_FILE_SYSTEM > > "VHnea:s:f:d:tc", > > #else > > > > -- > Alan Mackenzie (Nuremberg, Germany). From unknown Sat Sep 20 08:01:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sat, 15 Nov 2008 15:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator