GNU bug report logs - #1154
C-x 4 a in struct [] diff does not work anymore

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 1154 in the body.
You can then email your comments to 1154 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <at> gnu.org
Subject: C-x 4 a in struct [] diff does not work anymore
Date: Sun, 12 Oct 2008 19:38:56 -0700 (PDT)

For the patch below, with the point on the first + line, C-x 4 a
adds an entry called:

     * emacsclient.c (]):

emacs-22.2 added the correct entry:

     * emacsclient.c (longopts): 

Also, for the second hunk C-x 4 a cannot find the function name.


Index: emacsclient.c
===================================================================
RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
retrieving revision 1.132
diff -u -3 -p -u -p -r1.132 emacsclient.c
--- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
+++ emacsclient.c	13 Oct 2008 01:34:25 -0000
@@ -156,6 +156,7 @@ struct option longopts[] =
   { "help",	no_argument,	   NULL, 'H' },
   { "version",	no_argument,	   NULL, 'V' },
   { "tty",	no_argument,       NULL, 't' },
+  { "nw",	no_argument,       NULL, 't' },
   { "create-frame", no_argument,   NULL, 'c' },
   { "alternate-editor", required_argument, NULL, 'a' },
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
@@ -474,7 +475,7 @@ decode_options (argc, argv)
 
   while (1)
     {
-      int opt = getopt_long (argc, argv,
+      int opt = getopt_long_only (argc, argv,
 #ifndef NO_SOCKETS_IN_FILE_SYSTEM
 			     "VHnea:s:f:d:tc",
 #else

Message #10 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Dan Nicolaescu <dann <at> ics.uci.edu>, 1154 <at> debbugs.gnu.org
Cc: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#1154: C-x 4 a in struct [] diff does not work anymore
Date: Fri, 17 Oct 2008 21:17:50 +0000

Hi, Dan:

I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes
the first bug (longopts).

I can't reproduce the second bug (C-x 4 a can't find the name for the
second hunk).  Could you let me know whether or not it's still a
problem.  Thanks!

On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote:
> For the patch below, with the point on the first + line, C-x 4 a
> adds an entry called:
> 
>      * emacsclient.c (]):
> 
> emacs-22.2 added the correct entry:
> 
>      * emacsclient.c (longopts): 
> 
> Also, for the second hunk C-x 4 a cannot find the function name.
> 
> 
> Index: emacsclient.c
> ===================================================================
> RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
> retrieving revision 1.132
> diff -u -3 -p -u -p -r1.132 emacsclient.c
> --- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
> +++ emacsclient.c	13 Oct 2008 01:34:25 -0000
> @@ -156,6 +156,7 @@ struct option longopts[] =
>    { "help",	no_argument,	   NULL, 'H' },
>    { "version",	no_argument,	   NULL, 'V' },
>    { "tty",	no_argument,       NULL, 't' },
> +  { "nw",	no_argument,       NULL, 't' },
>    { "create-frame", no_argument,   NULL, 'c' },
>    { "alternate-editor", required_argument, NULL, 'a' },
>  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
> @@ -474,7 +475,7 @@ decode_options (argc, argv)
>  
>    while (1)
>      {
> -      int opt = getopt_long (argc, argv,
> +      int opt = getopt_long_only (argc, argv,
>  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
>  			     "VHnea:s:f:d:tc",
>  #else
> 

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #20 received at 1154-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 1154-done <at> debbugs.gnu.org
Subject: Re: bug#1154: C-x 4 a in struct [] diff does not work anymore
Date: Sat, 18 Oct 2008 00:53:25 -0700 (PDT)

Alan Mackenzie <acm <at> muc.de> writes:

  > Hi, Dan:
  > 
  > I've just commited a fix to ..../lisp/progmodes/cc-cmds.el which fixes
  > the first bug (longopts).
  > 
  > I can't reproduce the second bug (C-x 4 a can't find the name for the
  > second hunk).  Could you let me know whether or not it's still a
  > problem.  Thanks!

All the issues seem fixed.  Closing the bug.

Thanks!



  > On Sun, Oct 12, 2008 at 07:38:56PM -0700, Dan Nicolaescu wrote:
  > > For the patch below, with the point on the first + line, C-x 4 a
  > > adds an entry called:
  > > 
  > >      * emacsclient.c (]):
  > > 
  > > emacs-22.2 added the correct entry:
  > > 
  > >      * emacsclient.c (longopts): 
  > > 
  > > Also, for the second hunk C-x 4 a cannot find the function name.
  > > 
  > > 
  > > Index: emacsclient.c
  > > ===================================================================
  > > RCS file: /cvsroot/emacs/emacs/lib-src/emacsclient.c,v
  > > retrieving revision 1.132
  > > diff -u -3 -p -u -p -r1.132 emacsclient.c
  > > --- emacsclient.c	19 Sep 2008 16:45:12 -0000	1.132
  > > +++ emacsclient.c	13 Oct 2008 01:34:25 -0000
  > > @@ -156,6 +156,7 @@ struct option longopts[] =
  > >    { "help",	no_argument,	   NULL, 'H' },
  > >    { "version",	no_argument,	   NULL, 'V' },
  > >    { "tty",	no_argument,       NULL, 't' },
  > > +  { "nw",	no_argument,       NULL, 't' },
  > >    { "create-frame", no_argument,   NULL, 'c' },
  > >    { "alternate-editor", required_argument, NULL, 'a' },
  > >  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
  > > @@ -474,7 +475,7 @@ decode_options (argc, argv)
  > >  
  > >    while (1)
  > >      {
  > > -      int opt = getopt_long (argc, argv,
  > > +      int opt = getopt_long_only (argc, argv,
  > >  #ifndef NO_SOCKETS_IN_FILE_SYSTEM
  > >  			     "VHnea:s:f:d:tc",
  > >  #else
  > > 
  > 
  > -- 
  > Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.