From unknown Tue Sep 09 05:12:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11518: 24.1.50; install-etc target installs emacs.png outside of $DESTDIR Resent-From: Ulrich Mueller Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 May 2012 08:10:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11518 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11518@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133741497912487 (code B ref -1); Sat, 19 May 2012 08:10:01 +0000 Received: (at submit) by debbugs.gnu.org; 19 May 2012 08:09:39 +0000 Received: from localhost ([127.0.0.1]:33605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVejL-0003FM-Ei for submit@debbugs.gnu.org; Sat, 19 May 2012 04:09:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49574) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVej0-0003Ep-QK for submit@debbugs.gnu.org; Sat, 19 May 2012 04:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVeiU-0002Zi-KN for submit@debbugs.gnu.org; Sat, 19 May 2012 04:08:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVeiU-0002Ze-H8 for submit@debbugs.gnu.org; Sat, 19 May 2012 04:08:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVeiS-0008Kn-GP for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 04:08:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVeiQ-0002ZQ-CT for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 04:08:43 -0400 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:55968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVeiQ-0002YV-32 for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 04:08:42 -0400 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.4/8.13.4) with ESMTP id q4J88S1R012043 for ; Sat, 19 May 2012 10:08:28 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.5/8.14.2) with ESMTP id q4J88S5u027930; Sat, 19 May 2012 10:08:28 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.5/8.14.5/Submit) id q4J88S35027927; Sat, 19 May 2012 10:08:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Message-ID: <20407.21756.214998.135845@a1i15.kph.uni-mainz.de> Date: Sat, 19 May 2012 10:08:28 +0200 X-Mailer: VM 8.2.0b under 23.4.2 (x86_64-pc-linux-gnu) From: Ulrich Mueller Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by a1iwww1.kph.uni-mainz.de id q4J88S1R012043 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Forwarding downstream bug . When installing Emacs from BZR trunk as of today, the "install-etc" target in the top-level Makefile tries to install files outside of $DESTDIR. In Gentoo's sandboxed environment this leads to an access violation. Here is the relevant part of the build log: umask 022; /bin/mkdir -p /var/tmp/portage/app-editors/emacs-vcs-24.1.9999= /image//usr/share/applications /usr/bin/install -c -m 644 /var/tmp/portage/app-editors/emacs-vcs-24.1.99= 99/work/emacs-vcs-24.1.9999/etc/emacs.desktop \ /var/tmp/portage/app-editors/emacs-vcs-24.1.9999/image//usr/share/appli= cations/emacs.desktop thisdir=3D`/bin/pwd`; \ cd /var/tmp/portage/app-editors/emacs-vcs-24.1.9999/work/emacs-vcs-24.1.9= 999/etc/images/icons || exit 1; umask 022 ; \ for dir in */*/apps */*/mimetypes; do \ [ -d ${dir} ] || continue ; \ ( cd ${thisdir}; /bin/mkdir -p /usr/share/icons/${dir} ) ; \ for icon in ${dir}/*.*; do \ [ -r ${icon} ] || continue ; \ ( cd ${thisdir}; \ /usr/bin/install -c -m 644 /var/tmp/portage/app-editors/emacs-vcs-2= 4.1.9999/work/emacs-vcs-24.1.9999/etc/images/icons/${icon} /usr/share/ico= ns/${icon} ) \ || exit 1; \ done ; \ done ACCESS DENIED unlink: /usr/share/icons/hicolor/128x128/apps/emacs.= png /usr/bin/install: cannot remove =E2=80=98/usr/share/icons/hicolor/128x128= /apps/emacs.png=E2=80=99: Permission denied make: *** [install-etc] Error 1 * ERROR: app-editors/emacs-vcs-24.1.9999 failed (install phase): * emake failed The breakage was introduced by this commit: ------------------------------------------------------------ revno: 108266 committer: Glenn Morris branch nick: trunk timestamp: Thu 2012-05-17 15:13:02 -0400 message: Simplify install-etc rule =20 * Makefile.in (install-etc, mkdir): Make relevant directories in install-etc rather than mkdir. ------------------------------------------------------------ The following patch should fix it: 2012-05-19 Ulrich M=C3=BCller * Makefile.in (install-etc): Install icons inside of DESTDIR. --- emacs-orig/Makefile.in +++ emacs/Makefile.in @@ -626,11 +626,11 @@ cd ${iconsrcdir} || exit 1; umask 022 ; \ for dir in */*/apps */*/mimetypes; do \ [ -d $${dir} ] || continue ; \ - ( cd $${thisdir}; ${MKDIR_P} ${icondir}/$${dir} ) ; \ + ( cd $${thisdir}; ${MKDIR_P} $(DESTDIR)${icondir}/$${dir} ) ; \ for icon in $${dir}/*.*; do \ [ -r $${icon} ] || continue ; \ ( cd $${thisdir}; \ - ${INSTALL_DATA} ${iconsrcdir}/$${icon} ${icondir}/$${icon} ) \ + ${INSTALL_DATA} ${iconsrcdir}/$${icon} $(DESTDIR)${icondir}/$${ic= on} ) \ || exit 1; \ done ; \ done From unknown Tue Sep 09 05:12:51 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ulrich Mueller Subject: bug#11518: closed (Re: bug#11518: 24.1.50; install-etc target installs emacs.png outside of $DESTDIR) Message-ID: References: <20407.21756.214998.135845@a1i15.kph.uni-mainz.de> X-Gnu-PR-Message: they-closed 11518 X-Gnu-PR-Package: emacs Reply-To: 11518@debbugs.gnu.org Date: Sat, 19 May 2012 18:58:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1337453882-8635-1" This is a multi-part message in MIME format... ------------=_1337453882-8635-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #11518: 24.1.50; install-etc target installs emacs.png outside of $DESTDIR which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 11518@debbugs.gnu.org. --=20 11518: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D11518 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1337453882-8635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 11518-done) by debbugs.gnu.org; 19 May 2012 18:58:00 +0000 Received: from localhost ([127.0.0.1]:34668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVoql-0002F5-RT for submit@debbugs.gnu.org; Sat, 19 May 2012 14:58:00 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:59089 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVoqj-0002Ey-Ik for 11518-done@debbugs.gnu.org; Sat, 19 May 2012 14:57:58 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1SVoqG-0000T9-Qn; Sat, 19 May 2012 14:57:28 -0400 From: Glenn Morris To: 11518-done@debbugs.gnu.org Subject: Re: bug#11518: 24.1.50; install-etc target installs emacs.png outside of $DESTDIR References: <20407.21756.214998.135845@a1i15.kph.uni-mainz.de> X-Spook: militia credit card ASDIC Zachawi SHA Firewalls passwd X-Ran: .Rz+;u>w[D}K5?8LJ,EU6;$Li@+WW]g5*WX0YB]=_1I,`orZFL@l'V}-QJ'y?0n0{4851# X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 19 May 2012 14:57:28 -0400 In-Reply-To: <20407.21756.214998.135845@a1i15.kph.uni-mainz.de> (Ulrich Mueller's message of "Sat, 19 May 2012 10:08:28 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11518-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Thanks. ------------=_1337453882-8635-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 19 May 2012 08:09:39 +0000 Received: from localhost ([127.0.0.1]:33605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVejL-0003FM-Ei for submit@debbugs.gnu.org; Sat, 19 May 2012 04:09:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49574) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SVej0-0003Ep-QK for submit@debbugs.gnu.org; Sat, 19 May 2012 04:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVeiU-0002Zi-KN for submit@debbugs.gnu.org; Sat, 19 May 2012 04:08:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:43683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVeiU-0002Ze-H8 for submit@debbugs.gnu.org; Sat, 19 May 2012 04:08:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45555) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVeiS-0008Kn-GP for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 04:08:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SVeiQ-0002ZQ-CT for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 04:08:43 -0400 Received: from a1iwww1.kph.uni-mainz.de ([134.93.134.1]:55968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SVeiQ-0002YV-32 for bug-gnu-emacs@gnu.org; Sat, 19 May 2012 04:08:42 -0400 Received: from a1i15.kph.uni-mainz.de (a1i15.kph.uni-mainz.de [134.93.134.92]) by a1iwww1.kph.uni-mainz.de (8.14.4/8.13.4) with ESMTP id q4J88S1R012043 for ; Sat, 19 May 2012 10:08:28 +0200 Received: from a1i15.kph.uni-mainz.de (localhost [127.0.0.1]) by a1i15.kph.uni-mainz.de (8.14.5/8.14.2) with ESMTP id q4J88S5u027930; Sat, 19 May 2012 10:08:28 +0200 Received: (from ulm@localhost) by a1i15.kph.uni-mainz.de (8.14.5/8.14.5/Submit) id q4J88S35027927; Sat, 19 May 2012 10:08:28 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Message-ID: <20407.21756.214998.135845@a1i15.kph.uni-mainz.de> Date: Sat, 19 May 2012 10:08:28 +0200 To: bug-gnu-emacs@gnu.org Subject: 24.1.50; install-etc target installs emacs.png outside of $DESTDIR X-Mailer: VM 8.2.0b under 23.4.2 (x86_64-pc-linux-gnu) From: Ulrich Mueller Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by a1iwww1.kph.uni-mainz.de id q4J88S1R012043 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Forwarding downstream bug . When installing Emacs from BZR trunk as of today, the "install-etc" target in the top-level Makefile tries to install files outside of $DESTDIR. In Gentoo's sandboxed environment this leads to an access violation. Here is the relevant part of the build log: umask 022; /bin/mkdir -p /var/tmp/portage/app-editors/emacs-vcs-24.1.9999= /image//usr/share/applications /usr/bin/install -c -m 644 /var/tmp/portage/app-editors/emacs-vcs-24.1.99= 99/work/emacs-vcs-24.1.9999/etc/emacs.desktop \ /var/tmp/portage/app-editors/emacs-vcs-24.1.9999/image//usr/share/appli= cations/emacs.desktop thisdir=3D`/bin/pwd`; \ cd /var/tmp/portage/app-editors/emacs-vcs-24.1.9999/work/emacs-vcs-24.1.9= 999/etc/images/icons || exit 1; umask 022 ; \ for dir in */*/apps */*/mimetypes; do \ [ -d ${dir} ] || continue ; \ ( cd ${thisdir}; /bin/mkdir -p /usr/share/icons/${dir} ) ; \ for icon in ${dir}/*.*; do \ [ -r ${icon} ] || continue ; \ ( cd ${thisdir}; \ /usr/bin/install -c -m 644 /var/tmp/portage/app-editors/emacs-vcs-2= 4.1.9999/work/emacs-vcs-24.1.9999/etc/images/icons/${icon} /usr/share/ico= ns/${icon} ) \ || exit 1; \ done ; \ done ACCESS DENIED unlink: /usr/share/icons/hicolor/128x128/apps/emacs.= png /usr/bin/install: cannot remove =E2=80=98/usr/share/icons/hicolor/128x128= /apps/emacs.png=E2=80=99: Permission denied make: *** [install-etc] Error 1 * ERROR: app-editors/emacs-vcs-24.1.9999 failed (install phase): * emake failed The breakage was introduced by this commit: ------------------------------------------------------------ revno: 108266 committer: Glenn Morris branch nick: trunk timestamp: Thu 2012-05-17 15:13:02 -0400 message: Simplify install-etc rule =20 * Makefile.in (install-etc, mkdir): Make relevant directories in install-etc rather than mkdir. ------------------------------------------------------------ The following patch should fix it: 2012-05-19 Ulrich M=C3=BCller * Makefile.in (install-etc): Install icons inside of DESTDIR. --- emacs-orig/Makefile.in +++ emacs/Makefile.in @@ -626,11 +626,11 @@ cd ${iconsrcdir} || exit 1; umask 022 ; \ for dir in */*/apps */*/mimetypes; do \ [ -d $${dir} ] || continue ; \ - ( cd $${thisdir}; ${MKDIR_P} ${icondir}/$${dir} ) ; \ + ( cd $${thisdir}; ${MKDIR_P} $(DESTDIR)${icondir}/$${dir} ) ; \ for icon in $${dir}/*.*; do \ [ -r $${icon} ] || continue ; \ ( cd $${thisdir}; \ - ${INSTALL_DATA} ${iconsrcdir}/$${icon} ${icondir}/$${icon} ) \ + ${INSTALL_DATA} ${iconsrcdir}/$${icon} $(DESTDIR)${icondir}/$${ic= on} ) \ || exit 1; \ done ; \ done ------------=_1337453882-8635-1--