Subject: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc

From: Sven Joachim <[email-masked]>
Date: Mon, 21 May 2012 13:46:07 +0200

On 2012-05-18 23:23 +0200, Romain Francoise wrote:

> If you put the following in /tmp/foo.el:
>
> (setq mail-user-agent 'gnus-user-agent
>       gnus-message-archive-group "nnimap+foo:Sent")
>
> then start Emacs with `emacs -Q -l /tmp/foo.el' then do `C-x m', the
> resulting Message buffer doesn't have a Gcc header. In Emacs 23 and
> 24.0.92, the Gcc header was (correctly, I think) added to the buffer.
>
> Note: whether or not Gnus is started beforehand doesn't make a difference.

This seems to have been introduced by the following change in the
emacs-24 branch:

,----
| revno: 107813
| author: Lars Magne Ingebrigtsen <[email-masked]>
| committer: Katsumi Yamaoka <[email-masked]>
| branch nick: emacs-24
| timestamp: Wed 2012-04-11 22:31:16 +0000
| message:
|   gnus-art.el (article-wash-html): Fix non-ASCII characters when washing HTML (bug#7410).
|   gnus-msg.el (gnus-inews-insert-gcc): Protect against when we don't have a group name.
|   gnus-start.el (gnus-read-newsrc-el-file): Protect against broken .newsrc.el files.
`----

The diff for gnus-msg.el is this:

--8<---------------cut here---------------start------------->8---
=== modified file 'lisp/gnus/gnus-msg.el'
--- lisp/gnus/gnus-msg.el	2012-03-14 22:15:04 +0000
+++ lisp/gnus/gnus-msg.el	2012-04-11 22:31:16 +0000
@@ -1670,11 +1670,13 @@ this is a reply."
 			(not
 			 (setq result
 			       (cond
-				((stringp (caar var))
+				((and group
+				      (stringp (caar var)))
 				 ;; Regexp.
 				 (when (string-match (caar var) group)
 				   (cdar var)))
-				((functionp (car var))
+				((and group
+				      (functionp (car var)))
 				 ;; Function.
 				 (funcall (car var) group))
 				(t

--8<---------------cut here---------------end--------------->8---

It corresponds to commit bf5aff3ff7c87 in the no-gnus branch in Gnus
git.

Cheers,
       Sven