GNU bug report logs - #11514
24.0.97; gnus-user-agent no longer sets up Gcc

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 11514 in the body.
You can then email your comments to 11514 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Romain Francoise <romain <at> orebokech.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Fri, 18 May 2012 23:23:36 +0200

If you put the following in /tmp/foo.el:

(setq mail-user-agent 'gnus-user-agent
      gnus-message-archive-group "nnimap+foo:Sent")

then start Emacs with `emacs -Q -l /tmp/foo.el' then do `C-x m', the
resulting Message buffer doesn't have a Gcc header. In Emacs 23 and
24.0.92, the Gcc header was (correctly, I think) added to the buffer.

Note: whether or not Gnus is started beforehand doesn't make a difference.

Message #8 received at 11514 <at> debbugs.gnu.org (full text, mbox):

From: Sven Joachim <svenjoac <at> gmx.de>
To: Romain Francoise <romain <at> orebokech.com>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 11514 <at> debbugs.gnu.org,
	Katsumi Yamaoka <yamaoka <at> jpl.org>
Subject: Re: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Mon, 21 May 2012 13:46:07 +0200

On 2012-05-18 23:23 +0200, Romain Francoise wrote:

> If you put the following in /tmp/foo.el:
>
> (setq mail-user-agent 'gnus-user-agent
>       gnus-message-archive-group "nnimap+foo:Sent")
>
> then start Emacs with `emacs -Q -l /tmp/foo.el' then do `C-x m', the
> resulting Message buffer doesn't have a Gcc header. In Emacs 23 and
> 24.0.92, the Gcc header was (correctly, I think) added to the buffer.
>
> Note: whether or not Gnus is started beforehand doesn't make a difference.

This seems to have been introduced by the following change in the
emacs-24 branch:

,----
| revno: 107813
| author: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
| committer: Katsumi Yamaoka <yamaoka <at> jpl.org>
| branch nick: emacs-24
| timestamp: Wed 2012-04-11 22:31:16 +0000
| message:
|   gnus-art.el (article-wash-html): Fix non-ASCII characters when washing HTML (bug#7410).
|   gnus-msg.el (gnus-inews-insert-gcc): Protect against when we don't have a group name.
|   gnus-start.el (gnus-read-newsrc-el-file): Protect against broken .newsrc.el files.
`----

The diff for gnus-msg.el is this:

--8<---------------cut here---------------start------------->8---
=== modified file 'lisp/gnus/gnus-msg.el'
--- lisp/gnus/gnus-msg.el	2012-03-14 22:15:04 +0000
+++ lisp/gnus/gnus-msg.el	2012-04-11 22:31:16 +0000
@@ -1670,11 +1670,13 @@ this is a reply."
 			(not
 			 (setq result
 			       (cond
-				((stringp (caar var))
+				((and group
+				      (stringp (caar var)))
 				 ;; Regexp.
 				 (when (string-match (caar var) group)
 				   (cdar var)))
-				((functionp (car var))
+				((and group
+				      (functionp (car var)))
 				 ;; Function.
 				 (funcall (car var) group))
 				(t

--8<---------------cut here---------------end--------------->8---

It corresponds to commit bf5aff3ff7c87 in the no-gnus branch in Gnus
git.

Cheers,
       Sven

Message #13 received at 11514-done <at> debbugs.gnu.org (full text, mbox):

From: Katsumi Yamaoka <yamaoka <at> jpl.org>
To: 11514-done <at> debbugs.gnu.org
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>,
	Romain Francoise <romain <at> orebokech.com>, Sven Joachim <svenjoac <at> gmx.de>
Subject: Re: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Tue, 22 May 2012 08:29:09 +0900

Sven Joachim wrote:
> On 2012-05-18 23:23 +0200, Romain Francoise wrote:

>> If you put the following in /tmp/foo.el:
>>
>> (setq mail-user-agent 'gnus-user-agent
>>       gnus-message-archive-group "nnimap+foo:Sent")
>>
>> then start Emacs with `emacs -Q -l /tmp/foo.el' then do `C-x m', the
>> resulting Message buffer doesn't have a Gcc header. In Emacs 23 and
>> 24.0.92, the Gcc header was (correctly, I think) added to the buffer.
>>
>> Note: whether or not Gnus is started beforehand doesn't make a difference.

This is the issue of only a case where Gnus is running, since
Gcc is Gnus' feature and the `gnus-user-agent' agent behaves
like the `message-user-agent' agent now if Gnus is not alive:

2012-02-09  Lars Ingebrigtsen  <larsi <at> gnus.org>

	* gnus-msg.el (gnus-msg-mail): Use `message-mail' if Gnus isn't
	running.

(So, why one uses `C-x m' rather than `m'?  Ok, he mey be in a
non-Gnus window.)

> This seems to have been introduced by the following change in the
> emacs-24 branch:

> ,----
>| revno: 107813
>| author: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
>| committer: Katsumi Yamaoka <yamaoka <at> jpl.org>
>| branch nick: emacs-24
>| timestamp: Wed 2012-04-11 22:31:16 +0000
>| message:
>|   gnus-art.el (article-wash-html): Fix non-ASCII characters when
>| washing HTML (bug#7410).
>|   gnus-msg.el (gnus-inews-insert-gcc): Protect against when we don't
>| have a group name.
>|   gnus-start.el (gnus-read-newsrc-el-file): Protect against broken
>| .newsrc.el files.
> `----

> The diff for gnus-msg.el is this:

> === modified file 'lisp/gnus/gnus-msg.el'
> --- lisp/gnus/gnus-msg.el	2012-03-14 22:15:04 +0000
> +++ lisp/gnus/gnus-msg.el	2012-04-11 22:31:16 +0000
> @@ -1670,11 +1670,13 @@ this is a reply."
>  			(not
>  			 (setq result
>  			       (cond
> -				((stringp (caar var))
> +				((and group
> +				      (stringp (caar var)))
>  				 ;; Regexp.
>  				 (when (string-match (caar var) group)
>  				   (cdar var)))
> -				((functionp (car var))
> +				((and group
> +				      (functionp (car var)))
>  				 ;; Function.
>  				 (funcall (car var) group))
>  				(t

> It corresponds to commit bf5aff3ff7c87 in the no-gnus branch in Gnus
> git.

Reverting this change does not help.  I believe the right fix is
to modify `gnus-msg-mail' so as to bind `gnus-newsgroup-name' to
a string like `gnus-group-mail' does.  Fixed in the emacs-24 branch.

Message #16 received at 11514 <at> debbugs.gnu.org (full text, mbox):

From: Romain Francoise <romain <at> orebokech.com>
To: Katsumi Yamaoka <yamaoka <at> jpl.org>
Cc: Lars Magne Ingebrigtsen <larsi <at> gnus.org>, 11514 <at> debbugs.gnu.org,
	Sven Joachim <svenjoac <at> gmx.de>
Subject: Re: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Tue, 22 May 2012 09:38:58 +0200

Katsumi Yamaoka <yamaoka <at> jpl.org> writes:

> This is the issue of only a case where Gnus is running, since
> Gcc is Gnus' feature and the `gnus-user-agent' agent behaves
> like the `message-user-agent' agent now if Gnus is not alive:
> [...]

Which is rather suboptimal... if the user explicitly configured
`gnus-user-agent' then we should start enough Gnus bits to make Gcc
(and other Gnus features) work. If that's not possible then it should
complain loudly about the downgrade, or refuse to work at all. Losing
outgoing mail isn't nice.

> Reverting this change does not help.  I believe the right fix is
> to modify `gnus-msg-mail' so as to bind `gnus-newsgroup-name' to
> a string like `gnus-group-mail' does.  Fixed in the emacs-24 branch.

Works for me, thanks!

Message #19 received at 11514 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <lars.magne.ingebrigtsen <at> gmail.com>
To: Romain Francoise <romain <at> orebokech.com>
Cc: Katsumi Yamaoka <yamaoka <at> jpl.org>, 11514 <at> debbugs.gnu.org,
	Sven Joachim <svenjoac <at> gmx.de>
Subject: Re: bug#11514: 24.0.97; gnus-user-agent no longer sets up Gcc
Date: Fri, 08 Jun 2012 01:00:30 +0200

Romain Francoise <romain <at> orebokech.com> writes:

> Which is rather suboptimal... if the user explicitly configured
> `gnus-user-agent' then we should start enough Gnus bits to make Gcc
> (and other Gnus features) work. If that's not possible then it should
> complain loudly about the downgrade, or refuse to work at all. Losing
> outgoing mail isn't nice.

No, it's not, but we really kinda have to start all of Gnus to make Gcc
handling work completely.  So if you have `gnus-user-agent', and just
start Emacs to send off a single email, then you'd be sitting there
waiting for Gnus to start.

I've added a warning message to Ma Gnus now, though.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.