GNU bug report logs - #11508
24.1.50; Off-by-one error in xg_select?

Previous Next

Package: emacs;

Reported by: Ken Brown <kbrown <at> cornell.edu>

Date: Fri, 18 May 2012 13:15:01 UTC

Severity: normal

Tags: patch

Found in version 24.1.50

Fixed in version 24.2

Done: Ken Brown <kbrown <at> cornell.edu>

Bug is archived. No further changes may be made.

Full log

Message #20 received at 11508 <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Ken Brown <kbrown <at> cornell.edu>
Cc: "11508 <at> debbugs.gnu.org" <11508 <at> debbugs.gnu.org>,
	Andreas Schwab <schwab <at> linux-m68k.org>
Subject: Re: bug#11508: 24.1.50; Off-by-one error in xg_select?
Date: Mon, 21 May 2012 07:30:06 +0200

Hello. 

Go ahead and make the change.

     Jan D. 

21 maj 2012 kl. 00:44 skrev Ken Brown <kbrown <at> cornell.edu>:

> On 5/19/2012 5:52 AM, Andreas Schwab wrote:
>> Jan Djärv<jan.h.d <at> swipnet.se>  writes:
>> 
>>> So the question is, is it more effective to give select the exact value
>>> (select works fine if nfds has a higher value than strictly neccessary),
>>> or always increment by one in lines 78 and 83?
>> 
>> IMHO it doesn't hurt to be exact, and the patch removes an inconsistency
>> which makes it easier to understand the code.
> 
> So can I go ahead and make this change?  Jan, do you still object?
> 
> Ken
This bug report was last modified 13 years and 87 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.