GNU bug report logs - #11508
24.1.50; Off-by-one error in xg_select?

Previous Next

Package: emacs;

Reported by: Ken Brown <kbrown <at> cornell.edu>

Date: Fri, 18 May 2012 13:15:01 UTC

Severity: normal

Tags: patch

Found in version 24.1.50

Fixed in version 24.2

Done: Ken Brown <kbrown <at> cornell.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 11508 <at> debbugs.gnu.org, Ken Brown <kbrown <at> cornell.edu>
Subject: bug#11508: 24.1.50; Off-by-one error in xg_select?
Date: Sat, 19 May 2012 11:52:50 +0200

Jan Djärv <jan.h.d <at> swipnet.se> writes:

> So the question is, is it more effective to give select the exact value
> (select works fine if nfds has a higher value than strictly neccessary),
> or always increment by one in lines 78 and 83?

IMHO it doesn't hurt to be exact, and the patch removes an inconsistency
which makes it easier to understand the code.

Andreas.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."
This bug report was last modified 13 years and 87 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.