From unknown Mon Jun 23 20:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11493: 24.0.95; regression: comint-output-filter-functions / ansi-color-process-output Resent-From: "Roland Winkler" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 May 2012 22:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11493@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.133720843924561 (code B ref -1); Wed, 16 May 2012 22:48:01 +0000 Received: (at submit) by debbugs.gnu.org; 16 May 2012 22:47:19 +0000 Received: from localhost ([127.0.0.1]:58201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUn03-0006O6-Du for submit@debbugs.gnu.org; Wed, 16 May 2012 18:47:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42627) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUn01-0006Nr-3l for submit@debbugs.gnu.org; Wed, 16 May 2012 18:47:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUmzi-0005sG-Rn for submit@debbugs.gnu.org; Wed, 16 May 2012 18:46:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:57306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUmzi-0005sC-Of for submit@debbugs.gnu.org; Wed, 16 May 2012 18:46:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34881) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUmzh-0001or-31 for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 18:46:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SUmzf-0005ro-5O for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 18:46:56 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:37372) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SUmzf-0005rk-1w for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 18:46:55 -0400 Received: from pchdb00005.uni-regensburg.de ([132.199.129.10]:52287 helo=regnitz) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SUmze-0003Nm-86 for bug-gnu-emacs@gnu.org; Wed, 16 May 2012 18:46:54 -0400 Date: Wed, 16 May 2012 17:46:50 -0500 Message-Id: <87y5orhhgl.fsf@gnu.org> From: "Roland Winkler" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Some not so old code that works fine with Emacs 23 is giving me unexpected trouble with Emacs 24. Essentially, it uses a mode derived from comint-mode. It sends input via comint-simple-send and comint-send-input, but it has its own output filters. In Emacs 24, ansi-color-process-output has been added to the hook comint-output-filter-functions. This hook is also run by comint-send-input. ansi-color-process-output references the variable comint-last-output-start. Upon start-up comint-mode assigns this variable a marker, but it does not give this marker a useful value. (Only comint-output-filter assigns a buffer position to comint-last-output-start.) ansi-color-process-output checks that comint-last-output-start is non-nil. But it does not handle the case that comint-last-output-start holds a marker that does not point anywhere. So this code fails. comint-last-output-start is an undocumented variable and I have not fully understood what it is supposed to do. Yet it appears to me that comint.el and ansi-color.el depend on each other in a too sophisticated way. In GNU Emacs 24.0.95.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2012-04-04 on regnitz Windowing system distributor `The X.Org Foundation', version 11.0.10706000 From unknown Mon Jun 23 20:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11493: 24.0.95; regression: comint-output-filter-functions / ansi-color-process-output Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 May 2012 13:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Roland Winkler" Cc: 11493@debbugs.gnu.org Received: via spool by 11493-submit@debbugs.gnu.org id=B11493.133829933316143 (code B ref 11493); Tue, 29 May 2012 13:49:01 +0000 Received: (at 11493) by debbugs.gnu.org; 29 May 2012 13:48:53 +0000 Received: from localhost ([127.0.0.1]:48031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZMn7-0004CK-GN for submit@debbugs.gnu.org; Tue, 29 May 2012 09:48:53 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50148 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZMmn-0004Bt-Q2 for 11493@debbugs.gnu.org; Tue, 29 May 2012 09:48:52 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:36331 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZMlO-0002Oq-QK; Tue, 29 May 2012 09:47:07 -0400 From: Chong Yidong References: <87y5orhhgl.fsf@gnu.org> Date: Tue, 29 May 2012 21:47:00 +0800 In-Reply-To: <87y5orhhgl.fsf@gnu.org> (Roland Winkler's message of "Wed, 16 May 2012 17:46:50 -0500") Message-ID: <87ipffyu97.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) "Roland Winkler" writes: > In Emacs 24, ansi-color-process-output has been added to the hook > comint-output-filter-functions. Actually, in Emacs 23, ansi-color-process-output is also added to comint-output-filter-functions at top-level in ansi-color.el. > ansi-color-process-output checks that comint-last-output-start is > non-nil. But it does not handle the case that comint-last-output-start > holds a marker that does not point anywhere. So this code fails. This is already fixed in the emacs-24 branch, r107978. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue May 29 09:49:06 2012 Received: (at control) by debbugs.gnu.org; 29 May 2012 13:49:06 +0000 Received: from localhost ([127.0.0.1]:48034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZMnJ-0004D6-MZ for submit@debbugs.gnu.org; Tue, 29 May 2012 09:49:06 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:50150 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZMn0-0004C6-0F for control@debbugs.gnu.org; Tue, 29 May 2012 09:49:04 -0400 Received: from cm162.gamma80.maxonline.com.sg ([202.156.80.162]:36332 helo=ulysses) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1SZMld-0002ix-JH for control@debbugs.gnu.org; Tue, 29 May 2012 09:47:22 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 11493 Date: Tue, 29 May 2012 21:47:17 +0800 Message-ID: <87aa0rf6ai.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) close 11493 thanks