From debbugs-submit-bounces@debbugs.gnu.org Mon May 14 13:51:01 2012 Received: (at submit) by debbugs.gnu.org; 14 May 2012 17:51:01 +0000 Received: from localhost ([127.0.0.1]:53088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STzQD-00050b-8Z for submit@debbugs.gnu.org; Mon, 14 May 2012 13:51:01 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47949) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STzJ7-0004pO-Te for submit@debbugs.gnu.org; Mon, 14 May 2012 13:43:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STzIb-0004qJ-DV for submit@debbugs.gnu.org; Mon, 14 May 2012 13:43:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, RECEIVED_FROM_WINDOWS_HOST autolearn=ham version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42775) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STzIb-0004qF-A4 for submit@debbugs.gnu.org; Mon, 14 May 2012 13:43:09 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56845) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STzIZ-0000vm-IS for bug-coreutils@gnu.org; Mon, 14 May 2012 13:43:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1STzIX-0004pj-Ps for bug-coreutils@gnu.org; Mon, 14 May 2012 13:43:06 -0400 Received: from edge2.elion.ee ([84.50.226.3]:8828) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1STzIX-0004pR-Ig for bug-coreutils@gnu.org; Mon, 14 May 2012 13:43:05 -0400 Received: from EX2010CH2.et.ee (80.235.5.163) by edge2.elion.ee (84.50.226.3) with Microsoft SMTP Server (TLS) id 14.1.355.2; Mon, 14 May 2012 20:22:15 +0300 Received: from EX2010MB1.et.ee ([80.235.5.165]) by EX2010CH2.et.ee ([80.235.5.163]) with mapi id 14.01.0355.002; Mon, 14 May 2012 20:22:20 +0300 From: Toomas Soome To: "bug-coreutils@gnu.org" Subject: bug in 8.17 pot file Thread-Topic: bug in 8.17 pot file Thread-Index: AQHNMfYdjHfJZeFoLkmdwGf6aux26Q== Date: Mon, 14 May 2012 17:22:19 +0000 Message-ID: Accept-Language: en-US, et-EE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [195.250.183.232] Content-Type: text/plain; charset="us-ascii" Content-ID: <3900A42A112DCE41AC9F8368A0BFF061@et.ee> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Brightmail-Tracker: AAAAAQAAAUA= X-detected-operating-system: by eggs.gnu.org: Windows XP/2000 (RFC1323+, w+, tstamp-) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 14 May 2012 13:51:00 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) hi! the entry: #: src/fmt.c:285 #, c-format msgid "" " -t, --tagged-paragraph indentation of first line different from secon= d\n" " -u, --uniform-spacing one space between words, two after sentences\n= " " -w, --width=3DWIDTH maximum line width (default of 75 columns)\n= " " -g, --goal=3DWIDTH goal width (default of 93% of width)\n" has unescaped %. the sequence "% o" will be interpreted by printf and it wo= uld expect an argument... and obviously the msgfmt will choke as well. toomas From debbugs-submit-bounces@debbugs.gnu.org Mon May 14 13:56:37 2012 Received: (at 11470) by debbugs.gnu.org; 14 May 2012 17:56:37 +0000 Received: from localhost ([127.0.0.1]:53093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STzVd-00058l-5H for submit@debbugs.gnu.org; Mon, 14 May 2012 13:56:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20955) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1STzVH-00058A-NM for 11470@debbugs.gnu.org; Mon, 14 May 2012 13:56:36 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4EHtkBL002575 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 May 2012 13:55:46 -0400 Received: from [10.3.113.130] (ovpn-113-130.phx2.redhat.com [10.3.113.130]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4EHtkq3016983; Mon, 14 May 2012 13:55:46 -0400 Message-ID: <4FB14722.5070902@redhat.com> Date: Mon, 14 May 2012 11:55:46 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Toomas Soome Subject: Re: bug#11470: bug in 8.17 pot file References: In-Reply-To: X-Enigmail-Version: 1.4.1 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigD1CA48B22A74FF1B3E481893" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11470 Cc: 11470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD1CA48B22A74FF1B3E481893 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 05/14/2012 11:22 AM, Toomas Soome wrote: >=20 >=20 > hi! >=20 > the entry: >=20 > #: src/fmt.c:285 > #, c-format > msgid "" > " -t, --tagged-paragraph indentation of first line different from s= econd\n" > " -u, --uniform-spacing one space between words, two after sentenc= es\n" > " -w, --width=3DWIDTH maximum line width (default of 75 column= s)\n" > " -g, --goal=3DWIDTH goal width (default of 93% of width)\n" >=20 > has unescaped %. the sequence "% o" will be interpreted by printf and i= t would expect an argument... and obviously the msgfmt will choke as well= =2E Thanks for the report. However, looking at format.c, we are printing this string via fputs(), and not fprintf(), so it is _not_ an unescaped %. Apparently, the '#, c-format' marking in the .pot file is the real bug, and we should figure out why xgettext put it there. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigD1CA48B22A74FF1B3E481893 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPsUciAAoJEKeha0olJ0NqAfIIAJvgn62yIzw4POMpFuPcH+Cu Fx5EKw3OCI3vaM3DYnoh3yYuF1ragKZLC/RVpzRi/W1b1/sT3+IznEjs6VUG0FKN oTFdDdO7AXisyZ9MF03ceAplQPuBOn4w/ekKEwiFl129gnmdXxPibLvv4loVT8Nj eOs5yaLLVeavwycre5lUQBVAGTY7RvTB5k/wjrRWR1wPF6IIncl7ZhnFa9k+2VBV SAJrQ925/8XH9ICr0lygSNzJb5/JPVLuHZbcgPCq6WNFt/zXC336pRBj/wI6eqGs h/K2GIAVqTClKtxmlQyXsoeRu3ZSo8vM7beJMRhb0sbYNHZTpq6KcW3qu7Z56ic= =nO3g -----END PGP SIGNATURE----- --------------enigD1CA48B22A74FF1B3E481893-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 14 14:37:34 2012 Received: (at control) by debbugs.gnu.org; 14 May 2012 18:37:34 +0000 Received: from localhost ([127.0.0.1]:53117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SU08x-00066K-UJ for submit@debbugs.gnu.org; Mon, 14 May 2012 14:37:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44875) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SU08c-00065M-Ic; Mon, 14 May 2012 14:37:14 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4EIaPL5023648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 May 2012 14:36:25 -0400 Received: from [10.3.113.130] (ovpn-113-130.phx2.redhat.com [10.3.113.130]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4EIaOLj012653; Mon, 14 May 2012 14:36:24 -0400 Message-ID: <4FB150A8.1000407@redhat.com> Date: Mon, 14 May 2012 12:36:24 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: =?ISO-8859-1?Q?G=F6ran_Uddeborg?= Subject: Re: bug#11471: Message incorrectly marked as c-format References: <20401.19423.882229.224890@freddi.uddeborg> In-Reply-To: <20401.19423.882229.224890@freddi.uddeborg> X-Enigmail-Version: 1.4.1 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigD44AED593BD9D4A8281C0594" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control Cc: control@debbugs.gnu.org, 11471@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigD44AED593BD9D4A8281C0594 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable merge 11470 11471 thanks On 05/14/2012 12:15 PM, G=F6ran Uddeborg wrote: > This message in the 8.17 message file is written using fputs(), but it > is anyway marked as c-format. This is a problem since the % sign in > the description of --goal is taken as a formatting directive (of an > unsigned int written in octal, with the "space" flag). This causes > problems when translating. The effect of the validation of the > translation complains if the word following the percent sign doesn't > start with an "o", or other letter which is "compatible" in printf's > sense. (And in Swedish I would like it to start with an "a".) >=20 >=20 > #: src/fmt.c:285 > #, c-format > msgid "" > " -t, --tagged-paragraph indentation of first line different from s= econd\n" > " -u, --uniform-spacing one space between words, two after sentenc= es\n" > " -w, --width=3DWIDTH maximum line width (default of 75 column= s)\n" > " -g, --goal=3DWIDTH goal width (default of 93% of width)\n" Yep, you're the second person to report that today. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigD44AED593BD9D4A8281C0594 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPsVCoAAoJEKeha0olJ0NqRIgIALDC/MAp6acnLoVCTg5E3s8h F2ITv69FFGZvo+u7UBdFMrZ4cngLfNhE+5n7YpBEahONxCvtnLptEqK8gPMSHrZR cYfFk0n9OBI/voGIJPj6IOINLA1PwHXFBObwcktLQtBxAWJpk8hvspNrDLSrVFBk yIvNxRjw3rTVVjaRJ0a0XnfHyiKdLIKbIiyvKIJWQK60Ou/+/M/IscTvqH36n84r 0zpjbbk2amyjdkFTZowlBed2rVBglSBHmiymfr9HlZM8NQOBILNZ8+wXG9ADkbfs SbIvb6OWIXXxKt4Y4+FZqSgjCyqVG/wKR2JCz3zKLXZICK0lvOvIA+Ulq4JjAyA= =5nCl -----END PGP SIGNATURE----- --------------enigD44AED593BD9D4A8281C0594-- From debbugs-submit-bounces@debbugs.gnu.org Mon May 14 18:03:19 2012 Received: (at control) by debbugs.gnu.org; 14 May 2012 22:03:19 +0000 Received: from localhost ([127.0.0.1]:54845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SU3ML-00030P-B4 for submit@debbugs.gnu.org; Mon, 14 May 2012 18:03:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14310) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SU3ME-000307-RZ; Mon, 14 May 2012 18:03:13 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4EM38ac014840 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 14 May 2012 18:03:09 -0400 Received: from [10.3.113.130] (ovpn-113-130.phx2.redhat.com [10.3.113.130]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4EM38bQ009365; Mon, 14 May 2012 18:03:08 -0400 Message-ID: <4FB1811C.70209@redhat.com> Date: Mon, 14 May 2012 16:03:08 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: 11472@debbugs.gnu.org Subject: Re: bug#11472: Message src/fmt.c:285 marked as c-formatted string erroneously References: <20120514192742.GB3073@album.bayer.uni.cx> In-Reply-To: <20120514192742.GB3073@album.bayer.uni.cx> X-Enigmail-Version: 1.4.1 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig5075D99EB51E67D8DA88FF97" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5075D99EB51E67D8DA88FF97 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable merge 11470 11472 thanks On 05/14/2012 01:27 PM, Petr Pisar wrote: > The problem is such string does not pass through msgfmt tool while comp= iling > the catalog because the '% ' is not a valid printf sequence. >=20 > Solution is to suppress the auto-detection by adding /*xgettext:no-c-fo= rmat*/ > before the fputs() line in the source code. Thanks. You're the third person to report this today, but the first to provide a potential patch. Are you comfortable submitting that fix in 'git format-patch' form with a proper commit message? If not, we will probably do it on your behalf in the next 24 hours or so. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig5075D99EB51E67D8DA88FF97 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPsYEcAAoJEKeha0olJ0NqoGQH/2/nY75BqP0tG6+3R2kkp5U8 X5KFKWpc7tb7wo1Wo6Nj7m4gqqNd/WjBUd+XGcugKDy67yy1NL7WeBJGWtEg0l1e uKkVJSr6a/SU4qZcUdCMUU9nwGE4c0WhBwCTkkb1l7LqFCKEGT1kZxd6/0oRCCqR Pt7kEapKJKnxehXVDZhO98vu2rJjxjy+rbiRijghdI9IGg290Aj/jVO/kHoBU9v7 6CrGVARWBv4ezN45JhEHgls0/I/DdDAMMH6mN1gN79yzb0fVSpnksd6k1Z9i44hA zv2Iv0ZdMHdinltcfW/+GY/9EYr6ktO+Iw8/JF4+m+7XTJCH4r+KEDGVVAFS73Y= =hu0U -----END PGP SIGNATURE----- --------------enig5075D99EB51E67D8DA88FF97-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 00:17:22 2012 Received: (at control) by debbugs.gnu.org; 16 May 2012 04:17:22 +0000 Received: from localhost ([127.0.0.1]:56902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUVft-0000ZU-SW for submit@debbugs.gnu.org; Wed, 16 May 2012 00:17:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43299) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUVfp-0000Z7-Qd; Wed, 16 May 2012 00:17:19 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4G4H4Mk011565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 May 2012 00:17:04 -0400 Received: from [10.3.113.4] ([10.3.113.4]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4G4H3Ci002968; Wed, 16 May 2012 00:17:03 -0400 Message-ID: <4FB32A3E.5070508@redhat.com> Date: Tue, 15 May 2012 22:17:02 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Chusslove Illich Subject: Re: bug#11483: [Translation-i18n] Problem with translation of coreutils 8.17 References: <201205152314.55942.caslav.ilic@gmx.net> In-Reply-To: <201205152314.55942.caslav.ilic@gmx.net> X-Enigmail-Version: 1.4.1 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig670212B715C4695E30437748" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control Cc: translation-i18n@lists.sourceforge.net, primozz.peterlin@gmail.com, 11483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig670212B715C4695E30437748 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable merge 11470 11483 thanks On 05/15/2012 03:14 PM, Chusslove Illich wrote: >> [: Primoz PETERLIN :] >> Apparently, msgfmt interprets "% o" in the help text of the --goal opt= ion >> as a format specifier. >=20 > When that happens, you add such a comment line just before the problema= tic > gettext call: >=20 > /* xgettext: no-c-format */ > gettext("...93% of width...") >=20 > The extracted message will then have no-c-format flag instead of c-form= at, > thus not triggering format validation. This is documented in section 4.= 6 of > Gettext manual. This is the fourth report of the same issue within 48 hours, and second mention of the solution, but still no one has submitted the solution as an actual patch. We will get the problem fixed, but an actual patch would make it easier. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig670212B715C4695E30437748 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPsyo+AAoJEKeha0olJ0NquyIIAIHJzyzt7CkPAF/cpV6I1doJ GvHbGygPaaoKTADesP+MlOUCSAF0ut/A2Ku84BHC1zqWLJjUZeKN5zulUFlYW4fj Fy+ZRpLcDTN1a5IYytDk46VWYnzVC6bgdvPduwvqVhSwAWFX/O3HyhK3nod8brbG VgKcO9zZhCvIqGaTTPkB4gm/s9x4hW7vr0r3s8ueme6hhDOHYAGXOYOgpsZ//Hcy QR8srEU0bAD8yPMOg6ymygEzKfwccVDyNKadwmJUqdY4oJ8q2Ta9zs5A5PLwZwNZ rEroq/VggRPUJZpY3TSSKcDaiEj0Qb4qZWi85ZOw7I6FYOvEfJyWABqzC/GOyz0= =vsGJ -----END PGP SIGNATURE----- --------------enig670212B715C4695E30437748-- From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 01:33:40 2012 Received: (at 11470-done) by debbugs.gnu.org; 16 May 2012 05:33:40 +0000 Received: from localhost ([127.0.0.1]:56930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUWrg-0003E9-VS for submit@debbugs.gnu.org; Wed, 16 May 2012 01:33:40 -0400 Received: from mx.meyering.net ([88.168.87.75]:52721) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUWrG-0003DP-Bp for 11470-done@debbugs.gnu.org; Wed, 16 May 2012 01:33:35 -0400 Received: from rho.meyering.net (localhost.localdomain [127.0.0.1]) by rho.meyering.net (Acme Bit-Twister) with ESMTP id DF11060090; Wed, 16 May 2012 07:33:00 +0200 (CEST) From: Jim Meyering To: Eric Blake Subject: Re: bug#11472: Message src/fmt.c:285 marked as c-formatted string erroneously In-Reply-To: <4FB1811C.70209@redhat.com> (Eric Blake's message of "Mon, 14 May 2012 16:03:08 -0600") References: <20120514192742.GB3073@album.bayer.uni.cx> <4FB1811C.70209@redhat.com> Date: Wed, 16 May 2012 07:33:00 +0200 Message-ID: <8762bwzo4z.fsf@rho.meyering.net> Lines: 100 MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11470-done Cc: 11470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Eric Blake wrote: > merge 11470 11472 > thanks > > On 05/14/2012 01:27 PM, Petr Pisar wrote: >> The problem is such string does not pass through msgfmt tool while compi= ling >> the catalog because the '% ' is not a valid printf sequence. >> >> Solution is to suppress the auto-detection by adding /*xgettext:no-c-for= mat*/ >> before the fputs() line in the source code. > > Thanks. You're the third person to report this today, but the first to > provide a potential patch. Are you comfortable submitting that fix in > 'git format-patch' form with a proper commit message? If not, we will > probably do it on your behalf in the next 24 hours or so. Thanks for all the replies and for merging those, Eric. I wrote the patch. As expected, it was more work to collect and insert names in THANKS.in than to make the actual change ;-) Note that G=F6ran's name is already in the generated THANKS file, so I didn't add it below. If anyone listed prefers a different spelling of name or email, just let us know. >From 54be50197b47ba9200a1c3e48847fa959d4f5bfd Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Wed, 16 May 2012 07:26:36 +0200 Subject: [PATCH] maint: tell xgettext that fputs arg "93% of..." is not a C format string MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * src/fmt.c (usage): Add a comment to tell xgettext that the "% o" in fputs argument string of "...93% of..." is not a C format string. Reported by Toomas Soome, G=F6ran Uddeborg, Petr Pisar, Primoz PETERLIN and Chusslove Illich via http://bugs.gnu.org/11470 --- THANKS.in | 4 ++++ src/fmt.c | 2 ++ 2 files changed, 6 insertions(+) diff --git a/THANKS.in b/THANKS.in index 5c7dde8..6c826af 100644 --- a/THANKS.in +++ b/THANKS.in @@ -121,6 +121,7 @@ Christian Rose menthos@menthos.com Christian von Roques roques@pond.sub.org Christophe LYON christophe.lyon@st.com Chuck Hedrick hedrick@klinzhai.rutgers.edu +Chusslove Illich caslav.ilic@gmx.net Clark Morgan cmorgan@aracnet.com Clement Wang clem.wang@overture.com Colin Plumb colin@nyx.net @@ -482,6 +483,7 @@ Peter Horst peter@ointment.org Peter Moulder reiter@netspace.net.au Peter Samuelson psamuels@sampo.creighton.edu Peter Seebach seebs@taniemarie.solon.com +Petr Pisar petr.pisar@atlas.cz Petr Uzel petr.uzel@suse.cz Petter Reinholdtsen pere@hungry.com Phelippe Neveu pneveu@pcigeomatics.com @@ -496,6 +498,7 @@ Piotr Gackiewicz gacek@intertele.pl Piotr Kwapulinski kwap@univ.gda.pl Prashant TR tr@eth.net Priit J=F5er=FC=FCt jemm4jemm@yahoo.com +Primoz PETERLIN primozz.peterlin@gmail.com Rainer Orth ro@TechFak.Uni-Bielefeld.DE Ralf W. Stephan stephan@tmt.de Ralph Loader loader@maths.ox.ac.uk @@ -593,6 +596,7 @@ Ton Nijkes ton@murphy.nl Tony Kocurko akocurko@mun.ca Tony Leneis tony@plaza.ds.adp.com Tony Robinson ajr@eng.cam.ac.uk +Toomas Soome Toomas.Soome@Elion.ee Toralf F=F6rster toralf.foerster@gmx.de Torbjorn Granlund tege@nada.kth.se Torbjorn Lindgren tl@funcom.no diff --git a/src/fmt.c b/src/fmt.c index 3da198e..3e93654 100644 --- a/src/fmt.c +++ b/src/fmt.c @@ -281,10 +281,12 @@ Mandatory arguments to long options are mandatory for= short options too.\n\ -p, --prefix=3DSTRING reformat only lines beginning with STRING,\n\ reattaching the prefix to reformatted lines\= n\ -s, --split-only split long lines, but do not refill\n\ "), stdout); + /* Tell xgettext that the "% o" below is not a printf-style + format string: xgettext:no-c-format */ fputs (_("\ -t, --tagged-paragraph indentation of first line different from secon= d\n\ -u, --uniform-spacing one space between words, two after sentences\n\ -w, --width=3DWIDTH maximum line width (default of 75 columns)\n\ -g, --goal=3DWIDTH goal width (default of 93% of width)\n\ -- 1.7.10.2.520.g6a4a482 From debbugs-submit-bounces@debbugs.gnu.org Wed May 16 19:10:32 2012 Received: (at control) by debbugs.gnu.org; 16 May 2012 23:10:32 +0000 Received: from localhost ([127.0.0.1]:58238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUnMW-0006wR-DI for submit@debbugs.gnu.org; Wed, 16 May 2012 19:10:32 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57750) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SUnMR-0006w9-8k; Wed, 16 May 2012 19:10:29 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4GNAEQ7002845 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 16 May 2012 19:10:14 -0400 Received: from [10.3.113.4] ([10.3.113.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q4GNADb4017627; Wed, 16 May 2012 19:10:13 -0400 Message-ID: <4FB433D5.1050604@redhat.com> Date: Wed, 16 May 2012 17:10:13 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 MIME-Version: 1.0 To: Ivan Vilata i Balaguer Subject: Re: bug#11494: Accidental format string prevents translation References: <20120516224837.GA3653@edgar.selidor.net> In-Reply-To: <20120516224837.GA3653@edgar.selidor.net> X-Enigmail-Version: 1.4.1 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig0ABC1521668595FAECBCB6D1" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.25 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control Cc: 11494@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig0ABC1521668595FAECBCB6D1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable forcemerge 11470 11494 thanks On 05/16/2012 04:48 PM, Ivan Vilata i Balaguer wrote: > Hi, in coreutils 8.17 (and in current git), `fmt.c` contains the follow= ing > help line: >=20 > -g, --goal=3DWIDTH goal width (default of 93% of width) >=20 > The percent is interpreted (at least by `msgfmt`) as the start of a `%o= ` > format string, thus translations are forced to have an "o" after `93%` = which > makes things quite difficult. ;) >=20 > Changing `93%` by `93%%` should do the job. Thanks, Thanks for the report; however, you're the fifth person to report this in 48 hours, and it has already been fixed in current git: http://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=3De2bd5cda0a34 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig0ABC1521668595FAECBCB6D1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPtDPVAAoJEKeha0olJ0NqGkUH+gIvN8A5ri7ygL1zLNt1CmA/ nWNZYf30iloHyFwRnX3hC+9Tq+qDpHDLoAi+pMGSD2mRC7dVMp2UUNpf6k9cRbO0 mVNsKkNOEfj6y/cBMmk2FTGMkhyrl1M2tzbr9GaGA309cfC4/bqegWyem/KcU9Wz Mq5VWMlFREmzPh3WRlKvznYI6Y4f+TrYYpOaG5hHXt9XNAY9O7MHKNJ7MrwtZ2Kl rM+uRP+8hEW4KNkhOvImWdyAdZJAmX5yT5rARSe0+XzOqz4JZN/khautGcnKwYav /vFU4/MDIVqKBE7dMSpvMLF0DxbXRJQCiejrQFJdSIO7255gzbEStmBLO4CqIYs= =dfE+ -----END PGP SIGNATURE----- --------------enig0ABC1521668595FAECBCB6D1-- From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 14:08:27 2012 Received: (at 11470) by debbugs.gnu.org; 17 May 2012 18:08:27 +0000 Received: from localhost ([127.0.0.1]:59597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV57j-0005Z7-Hd for submit@debbugs.gnu.org; Thu, 17 May 2012 14:08:27 -0400 Received: from smtprelay-b11.telenor.se ([62.127.194.20]:35524) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV57h-0005Yv-FW for 11470@debbugs.gnu.org; Thu, 17 May 2012 14:08:26 -0400 Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-b11.telenor.se (Postfix) with ESMTP id F170AC494 for <11470@debbugs.gnu.org>; Thu, 17 May 2012 20:08:02 +0200 (CEST) X-SENDER-IP: [83.227.168.100] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhBRADM9tU9T46hkPGdsb2JhbABEg0CGNqYPg0MZAQEBATc0glYcgTEMCog/mlahK4h8hEuDIwOVepMr X-IronPort-AV: E=Sophos;i="4.75,611,1330902000"; d="scan'208";a="340024527" Received: from ua-83-227-168-100.cust.bredbandsbolaget.se (HELO mimmi.uddeborg.se) ([83.227.168.100]) by ipb1.telenor.se with ESMTP; 17 May 2012 20:08:02 +0200 Received: from mimmi.uddeborg (localhost [127.0.0.1]) by mimmi.uddeborg.se (8.14.5/8.14.5) with ESMTP id q4HI80wn016264 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <11470@debbugs.gnu.org>; Thu, 17 May 2012 20:08:00 +0200 Received: (from goeran@localhost) by mimmi.uddeborg (8.14.5/8.14.4/Submit) id q4HI7xJl016263; Thu, 17 May 2012 20:07:59 +0200 From: =?utf-8?Q?G=C3=B6ran_Uddeborg?= MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20405.15998.970833.599404@mimmi.uddeborg> Date: Thu, 17 May 2012 20:07:58 +0200 To: 11470@debbugs.gnu.org Subject: bug in 8.17 pot file X-Mailer: VM 8.1.1 under 24.0.95.1 (x86_64-redhat-linux-gnu) X-Face: "m&!q8; elk)j/GjdH0A1-5euH[VSc"z|=FSJFsZMltGCVh^{K :^Y;hs=IW^!,^]<.Do*c6+Eg2{+(^IjaW<2X,!<6=S\`8s3$0p'*sQ"tm\<(tRW?,CmQ3 X-URL: http://www.uddeborg.se/g%C3%B6ran/ X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11470 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) A possibly more general fix would be to tell xgettext that fputs' argument is not c-format. That would catch all uses of fputs. Something like this: --- po/Makevars~ 2012-05-10 11:05:30.000000000 +0200 +++ po/Makevars 2012-05-17 20:06:13.000000000 +0200 @@ -18,6 +18,7 @@ --flag=asprintf:2:c-format\ --flag=error:3:c-format\ --flag=error_at_line:5:c-format\ + --flag=fputs:1:no-c-format\ --flag=vasnprintf:3:c-format\ --flag=vasprintf:2:c-format\ --flag=verror:3:c-format\ From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 14:22:48 2012 Received: (at 11470) by debbugs.gnu.org; 17 May 2012 18:22:48 +0000 Received: from localhost ([127.0.0.1]:59602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV5Lb-0005sl-OU for submit@debbugs.gnu.org; Thu, 17 May 2012 14:22:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51972) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV5LZ-0005sW-Ds for 11470@debbugs.gnu.org; Thu, 17 May 2012 14:22:46 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q4HIMMWl010838 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 17 May 2012 14:22:23 -0400 Received: from [10.36.116.34] (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q4HIMKbB005100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 May 2012 14:22:22 -0400 Message-ID: <4FB541DC.5060404@draigBrady.com> Date: Thu, 17 May 2012 19:22:20 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?G=F6ran_Uddeborg?= Subject: Re: bug#11470: bug in 8.17 pot file References: <20405.15998.970833.599404@mimmi.uddeborg> In-Reply-To: <20405.15998.970833.599404@mimmi.uddeborg> X-Enigmail-Version: 1.3.2 Content-Type: text/plain; charset=ISO-8859-1 X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by mx1.redhat.com id q4HIMMWl010838 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: 11470 Cc: bug-gnu-gettext@gnu.org, 11470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) On 05/17/2012 07:07 PM, G=F6ran Uddeborg wrote: > A possibly more general fix would be to tell xgettext that fputs' > argument is not c-format. That would catch all uses of fputs. > Something like this: >=20 > --- po/Makevars~ 2012-05-10 11:05:30.000000000 +0200 > +++ po/Makevars 2012-05-17 20:06:13.000000000 +0200 > @@ -18,6 +18,7 @@ > --flag=3Dasprintf:2:c-format\ > --flag=3Derror:3:c-format\ > --flag=3Derror_at_line:5:c-format\ > + --flag=3Dfputs:1:no-c-format\ > --flag=3Dvasnprintf:3:c-format\ > --flag=3Dvasprintf:2:c-format\ > --flag=3Dverror:3:c-format\ Why does xgettext even think fputs takes a printf format? That's the real bug here right? I know we have to deal with the bug in the meantime with something like the above, but I've CC'd the gettext bug list so that we won't have to worry about it going forward. cheers, P=E1draig. From debbugs-submit-bounces@debbugs.gnu.org Thu May 17 14:40:26 2012 Received: (at 11470) by debbugs.gnu.org; 17 May 2012 18:40:26 +0000 Received: from localhost ([127.0.0.1]:59643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV5ca-0006Km-Lt for submit@debbugs.gnu.org; Thu, 17 May 2012 14:40:24 -0400 Received: from smtprelay-b21.telenor.se ([195.54.99.212]:39403) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SV5cV-0006KT-HG for 11470@debbugs.gnu.org; Thu, 17 May 2012 14:40:17 -0400 Received: from ipb1.telenor.se (ipb1.telenor.se [195.54.127.164]) by smtprelay-b21.telenor.se (Postfix) with ESMTP id 1597FD4D9 for <11470@debbugs.gnu.org>; Thu, 17 May 2012 20:39:52 +0200 (CEST) X-SENDER-IP: [83.227.168.100] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AntHAHdFtU9T46hkPGdsb2JhbABEiXapUhkBAQEBNzSCFQEBBAFWIwULC0YtDAoUBogcCbwIiHyHbgOVepMr X-IronPort-AV: E=Sophos;i="4.75,611,1330902000"; d="scan'208";a="340053811" Received: from ua-83-227-168-100.cust.bredbandsbolaget.se (HELO mimmi.uddeborg.se) ([83.227.168.100]) by ipb1.telenor.se with ESMTP; 17 May 2012 20:39:52 +0200 Received: from mimmi.uddeborg (localhost [127.0.0.1]) by mimmi.uddeborg.se (8.14.5/8.14.5) with ESMTP id q4HIdolm017465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 17 May 2012 20:39:50 +0200 Received: (from goeran@localhost) by mimmi.uddeborg (8.14.5/8.14.4/Submit) id q4HIdn0D017464; Thu, 17 May 2012 20:39:49 +0200 From: =?utf-8?Q?G=C3=B6ran_Uddeborg?= MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Message-ID: <20405.17908.601367.896596@mimmi.uddeborg> Date: Thu, 17 May 2012 20:39:48 +0200 To: =?iso-8859-1?Q?P=E1draig?= Brady Subject: Re: bug#11470: bug in 8.17 pot file In-Reply-To: <4FB541DC.5060404@draigBrady.com> References: <20405.15998.970833.599404@mimmi.uddeborg> <4FB541DC.5060404@draigBrady.com> X-Mailer: VM 8.1.1 under 24.0.95.1 (x86_64-redhat-linux-gnu) X-Face: "m&!q8; elk)j/GjdH0A1-5euH[VSc"z|=FSJFsZMltGCVh^{K :^Y;hs=IW^!,^]<.Do*c6+Eg2{+(^IjaW<2X,!<6=S\`8s3$0p'*sQ"tm\<(tRW?,CmQ3 X-URL: http://www.uddeborg.se/g%C3%B6ran/ X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 11470 Cc: bug-gnu-gettext@gnu.org, 11470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) P=E1draig Brady: > Why does xgettext even think fputs takes a printf format=3F I don't think it does. I think it doesn't know anything about fputs at all, so it tries to guess. If there is something that looks like a printf directive in the message, it is guessed to be c-format, otherwise not. In a simple test I found that fputs(=5F("Hello world"), stdout); is not considered c-format, but fputs(=5F("Hello %orld"), stdout); is. If I use printf instead of fputs, it is considered c-format in both cases. xgettext does know by default that printf's first argument is c-format. > I've CC'd > the gettext bug list so that we won't have to > worry about it going forward. :-) I actually also sent a message to that list a little while ago, suggesting they add flags by default for the other stdio functions. (puts, fputs and fwrite came to mind) From unknown Mon Jun 23 20:19:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 15 Jun 2012 11:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 19 10:54:22 2012 Received: (at control) by debbugs.gnu.org; 19 Jun 2012 14:54:22 +0000 Received: from localhost ([127.0.0.1]:48690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sgzoz-0008Ox-9H for submit@debbugs.gnu.org; Tue, 19 Jun 2012 10:54:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2018) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sgzow-0008Oo-4f for control@debbugs.gnu.org; Tue, 19 Jun 2012 10:54:20 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q5JEosHn002436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Jun 2012 10:50:54 -0400 Received: from [10.3.113.98] (ovpn-113-98.phx2.redhat.com [10.3.113.98]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q5JEorYE022697 for ; Tue, 19 Jun 2012 10:50:54 -0400 Message-ID: <4FE091CD.4080507@redhat.com> Date: Tue, 19 Jun 2012 08:50:53 -0600 From: Eric Blake Organization: Red Hat User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 MIME-Version: 1.0 To: control@debbugs.gnu.org Subject: Re: Processed: Re: bug#11740: Message erroneously marked c-format in coreutils.pot from 8.17 References: <4FE08359.9070705@redhat.com> <4FE0851B.8000808@redhat.com> In-Reply-To: <4FE0851B.8000808@redhat.com> X-Enigmail-Version: 1.4.2 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigCFB3E87A2FCDAEFB7C554D62" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigCFB3E87A2FCDAEFB7C554D62 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable unarchive 11470 forcemerge 11470 11740 thanks >=20 > On 06/19/2012 07:53 AM, GNU bug Tracking System wrote: >> Processing commands for control@debbugs.gnu.org: >> >>> forcemerge 11470 11740 >> bug number 11470 not found. (Is it archived?) >> >>> thanks >> Stopping processing here. >> >> Please contact help-debbugs@gnu.org if you need assistance. >> >> GNU bugs database, http://debbugs.gnu.org/ >> >> >=20 --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigCFB3E87A2FCDAEFB7C554D62 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP4JHNAAoJEKeha0olJ0NqdVYH/0+T0Q88+NfHOK51vQiOQNfU Ii4YWC96W8ovY0sO/QsigUAgUnHXmN6qawfHmUjVJBgwd0TYoY0G5VTd3xkkdX9p DowA69CMwjyz8yNh4Ez0/PlZrnBq6uDuAXQN+2mYC671HUc8Q7auodV/6hjMYttE rmI6xBP1IzOnXoxn34ADkj5zjlZ5LLkPLXyJWxm4IhKjIwbldGIYTYzrZkqQFTKb Sbe4kin1vjaN77NuyZUDwO+n80UWVijvwf8Buu47CTJm15JY3xUTyVJvaeGXHxtQ 9MalLJx1jE0Za0yrr281Asvrtnsh8cXVTn4OgcOWd0M8mJ2ju/rQ0FWh9fBko4A= =S04b -----END PGP SIGNATURE----- --------------enigCFB3E87A2FCDAEFB7C554D62-- From unknown Mon Jun 23 20:19:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 18 Jul 2012 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator