GNU bug report logs - #11464
24.1.50; pos-visible-in-window-p returns a false positive with bidi text

Previous Next

Full log

Message #40 received at 11464 <at> debbugs.gnu.org (full text, mbox):

From: Michael Welsh Duggan <mwd <at> cert.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: ari.roponen <at> gmail.com, 11464 <at> debbugs.gnu.org
Subject: Re: bug#11464: 24.1.50;
	pos-visible-in-window-p returns a false positive with bidi text
Date: Thu, 17 May 2012 17:22:36 -0400

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Michael Welsh Duggan <mwd <at> cert.org>
>> Cc: Ari Roponen <ari.roponen <at> gmail.com>, 11464 <at> debbugs.gnu.org
>> Date: Thu, 17 May 2012 13:56:45 -0400
>> 
>>   else if (top_y < it.last_visible_y) ==> if (255 < 256) ==> if (TRUE)
>> 
>> hence, visible_p _would_ be set to 1 by the else if clause.
>
> And will never be reset to zero, because 27 <= 256 => FALSE.  And yet
> Ari said that he needed to change the condition to <=.

But where do you get 27?  The number was 270, I believe.

>> bottom_y = 270
>> it.last_visible_y = 256
>> top_y = 255
>> window_top_y = 0

-- 
Michael Welsh Duggan
(mwd <at> cert.org)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.