From unknown Sat Jun 21 03:27:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11457: 24.1.50; incompatible removal of apropos user options Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 May 2012 23:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 11457 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 11457@debbugs.gnu.org X-Debbugs-Original-To: Received: via spool by submit@debbugs.gnu.org id=B.133677858815433 (code B ref -1); Fri, 11 May 2012 23:24:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 May 2012 23:23:08 +0000 Received: from localhost ([127.0.0.1]:49615 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSzAv-00040o-DL for submit@debbugs.gnu.org; Fri, 11 May 2012 19:23:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60122) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SSzAs-00040L-JD for submit@debbugs.gnu.org; Fri, 11 May 2012 19:23:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSzAe-0004t5-Cg for submit@debbugs.gnu.org; Fri, 11 May 2012 19:22:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:38007) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSzAe-0004sz-9C for submit@debbugs.gnu.org; Fri, 11 May 2012 19:22:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSzAc-0003Ce-Lq for bug-gnu-emacs@gnu.org; Fri, 11 May 2012 19:22:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SSzAa-0004rd-Oi for bug-gnu-emacs@gnu.org; Fri, 11 May 2012 19:22:46 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:37025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SSzAa-0004r2-He for bug-gnu-emacs@gnu.org; Fri, 11 May 2012 19:22:44 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Sentrion-MTA-4.2.2/Sentrion-MTA-4.2.2) with ESMTP id q4BNMeci020296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 11 May 2012 23:22:41 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id q4BNMdX0029037 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 11 May 2012 23:22:40 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id q4BNMdFJ026162 for ; Fri, 11 May 2012 18:22:39 -0500 Received: from dradamslap1 (/10.159.217.132) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 11 May 2012 16:22:39 -0700 From: "Drew Adams" Date: Fri, 11 May 2012 16:22:34 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac0vzPGQ1CL5vUT5SB+ATWx0W3WNDg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) So now you've removed the user options for the apropos faces, `apropos-symbol-face' and so on. With the single exception of `apropos-match-face' (why the exception? why not give it an apropos face, which has as its default attributes those of the face `match'?). However, you made this change in a way that disrespects users. There is no deprecation. Starting immediately, you no longer respect a user's customizations of these options that you've removed. E.g., instead of temporarily using, say, (if (boundp 'apropos-symbol-face) ; Deprecated in 24.1, to be apropos-symbol-face ; desupported in 24.3 'apropos-symbol) You immediately use only the face symbol `apropos-symbol'. While I'm in favor of using faces instead of face options (variables), there is a right way and a wrong way to go about such a change. The way you've done it, you invalidate existing user customizations. Not a big deal, but not the best in user friendliness. At least you mentioned the change in the NEWS - that's good. Better would have been to deprecate but not immediately desupport the user options. In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) of 2012-05-06 on MARVIN Bzr revision: 108144 cyd@gnu.org-20120507053738-5ovifsb71cmamn2f Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.6) --no-opt --enable-checking --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 11:53:14 2014 Received: (at control) by debbugs.gnu.org; 22 Jan 2014 16:53:14 +0000 Received: from localhost ([127.0.0.1]:60860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W613B-0002yc-0g for submit@debbugs.gnu.org; Wed, 22 Jan 2014 11:53:13 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:53897) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6138-0002yR-JL for control@debbugs.gnu.org; Wed, 22 Jan 2014 11:53:11 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W6138-0005K3-37 for control@debbugs.gnu.org; Wed, 22 Jan 2014 11:53:10 -0500 Date: Wed, 22 Jan 2014 11:53:10 -0500 Message-Id: Subject: control message for bug 16516 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) merge 11457 16516 From unknown Sat Jun 21 03:27:25 2025 X-Loop: help-debbugs@gnu.org Subject: bug#11457: bug#16516: 24.3.50; NEWS item about `apropos-*-face' user options and new faces Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 Feb 2014 04:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11457 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Drew Adams Cc: 11457@debbugs.gnu.org, 16516@debbugs.gnu.org Received: via spool by 11457-submit@debbugs.gnu.org id=B11457.13919199575171 (code B ref 11457); Sun, 09 Feb 2014 04:26:01 +0000 Received: (at 11457) by debbugs.gnu.org; 9 Feb 2014 04:25:57 +0000 Received: from localhost ([127.0.0.1]:58797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLxp-0001LG-Ux for submit@debbugs.gnu.org; Sat, 08 Feb 2014 23:25:55 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37972) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLxm-0001L3-4t; Sat, 08 Feb 2014 23:25:51 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCLxX-0005Fb-Ts; Sun, 09 Feb 2014 05:25:36 +0100 From: Lars Ingebrigtsen References: Date: Sat, 08 Feb 2014 20:24:24 -0800 In-Reply-To: (Drew Adams's message of "Tue, 21 Jan 2014 19:06:08 -0800 (PST)") Message-ID: <87y51keww7.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WCLxX-0005Fb-Ts X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392524736.51018@ixqmUQ800zvGA6GFeyq9cw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > It is not enough to say "etc." and "and so on." List the options. By > my checking, I find these: apropos-keybinding-face, apropos-label-face, > apropos-match-face, apropos-property-face, apropos-symbol-face. Is it > so hard to find and state the list, to help users? Fixed on trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 23:26:11 2014 Received: (at control) by debbugs.gnu.org; 9 Feb 2014 04:26:11 +0000 Received: from localhost ([127.0.0.1]:58804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLy5-0001MQ-3x for submit@debbugs.gnu.org; Sat, 08 Feb 2014 23:26:10 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37978) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCLy1-0001MC-TG for control@debbugs.gnu.org; Sat, 08 Feb 2014 23:26:06 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCLxn-0005Fw-Sv for control@debbugs.gnu.org; Sun, 09 Feb 2014 05:25:52 +0100 Date: Sat, 08 Feb 2014 20:24:31 -0800 Message-Id: <87wqh4eww0.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #11457 X-MailScanner-ID: 1WCLxn-0005Fw-Sv X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392524752.89121@qtAaKgYpxregBffLtiU5kg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 11457 fixed close 11457 24.4